Commit graph

9 commits

Author SHA1 Message Date
Krzysztof Kozlowski
5a5ecedc4b dt-bindings: pinctrl: qcom: create common LPASS LPI schema
Just like regular TLMM pin controllers in Qualcomm SoCs, the Low Power
Audio SubSystem (LPASS) Low Power Island (LPI) TLMM blocks share a lot
of properties, so common part can be moved to separate schema to reduce
code duplication and make reviewing easier.

Except the move of common part, this introduces effective changes:
1. To all LPASS LPI bindings: Reference pinmux-node.yaml in each pin
   muxing and configuration node, to bring definition of "function" and
   "pins" properties.

2. qcom,sc7280-lpass-lpi-pinctrl: Reference pinctrl.yaml in top leve.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20231208215534.195854-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2023-12-20 12:09:56 +01:00
Krzysztof Kozlowski
3abe84ea06 dt-bindings: pinctrl: qcom: lpass-lpi: correct description of second reg
The description of second IO address is a bit confusing.  It is supposed
to be the MCC range which contains the slew rate registers, not the slew
rate register base.  The Linux driver then accesses slew rate register
with hard-coded offset (0xa000).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230302155255.857065-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2023-03-09 14:07:15 +01:00
Linus Walleij
1ec033f00c Qualcomm pinctrl Devicetree bindings changes for v6.3, part two
Several minor cleanups and fixes on Qualcomm pin controller Devicetree
 bindings - add missing input-disable, correct GPIO pin name patterns in
 bindings, correct number of GPIOs in gpio-ranges property.
 -----BEGIN PGP SIGNATURE-----
 
 iQJEBAABCgAuFiEE3dJiKD0RGyM7briowTdm5oaLg9cFAmPiiaoQHGtyemtAa2Vy
 bmVsLm9yZwAKCRDBN2bmhouD1+75EACXetz0bN1O8oUhwUv2mbcWoWYvy2QnfJZi
 NbqnAdFjfk66p1uNBPvVV2DxRuSiGaXsH5KJRP6WY805QGF4lfVZVsaaQkl4Dug8
 yjolquoV8kOuxfY2G/TI8VuTp5OK9yHnti21KGB7l0kdYc5OwbjgKkB+DBo8QZ3K
 6kW5EmRjqbGZ8ED0/Ymj6K55YPARCx/IoCA1vedl770IqTEIZsag49n9r+c4IqVg
 Sx7pgAhZm01XyHpQdLAc5pfmvZffGYLRr3cFhBVlA8hwVGgjdDza+AMJMoJ2rJxT
 bL2/2io3FRWr0Fi3iFJObDz2rapNqbnypr4lBeKZXMGl81yQi0hwraaVJWc0+n+x
 3JGD/CHWFWD4XFVO7ZO9KwZzexmuIkupMmr4FV0fgr+M6HsNyaGjpc+BNoFk1NNK
 jM0l0+Lazgao3WbpKLaPyvXnoBVF2/HrG1l++wRp2+LpytHStxFmFtmUGsYP0w25
 YAUmeJF2RkTQ6uZebLpCf3q0kNgfeHqv2M6Qjz4Acb5FfQSjkuHwyeiPhGgS6TUf
 8ZTA26Mp8oPc6pntZUVvwHljZ8jXN5wzh+TheCAHCfAyPKOJoHdOr6+sQQEG0rc7
 5J2Hd1wm4FhK197PH8lmUUYC/hfcl8MyOn8iY/jq9grN0e7lkmLbxl2r86DUNcWu
 Cv1sFd7d1w==
 =VNb/
 -----END PGP SIGNATURE-----

Merge tag 'qcom-pinctrl-6.3-2' of https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-dt into devel

Qualcomm pinctrl Devicetree bindings changes for v6.3, part two

Several minor cleanups and fixes on Qualcomm pin controller Devicetree
bindings - add missing input-disable, correct GPIO pin name patterns in
bindings, correct number of GPIOs in gpio-ranges property.
2023-02-08 16:07:59 +01:00
Krzysztof Kozlowski
315dffb843 dt-bindings: pinctrl: qcom: lpass-lpi: correct GPIO name pattern
Narrow the pattern of possible GPIO names for pin controllers:
 - SC7280 LPASS: GPIOs 0-14
 - SM8250 LPASS: GPIOs 0-13
 - SM8450 LPASS: GPIOs 0-22
 - SC8280XP LPASS: GPIOs 0-18

Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230203164854.390080-1-krzysztof.kozlowski@linaro.org
Link: https://lore.kernel.org/r/20230203164854.390080-2-krzysztof.kozlowski@linaro.org
Link: https://lore.kernel.org/r/20230203164854.390080-3-krzysztof.kozlowski@linaro.org
Link: https://lore.kernel.org/r/20230203164854.390080-4-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
2023-02-06 12:17:55 +01:00
Krzysztof Kozlowski
697550668b dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: add input-enable and bias-bus-hold
Allow bias-bus-hold and input-enable properties (already used in SM8450):

  sm8450-qrd.dtb: pinctrl@3440000: dmic02-default-state: 'oneOf' conditional failed, one must be fixed:
    'pins' is a required property
    'function' is a required property
    'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+'
    'input-enable' does not match any of the regexes: 'pinctrl-[0-9]+'

Compact the properties which are just set to true for readability.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20221222161420.172824-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2023-01-10 09:06:49 +01:00
Krzysztof Kozlowski
fc371f6075 dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: minor style cleanups
Drop "binding" from description (and align it with other Qualcomm
pinctrl bindings), use double quotes consistently and drop redundant
quotes.

Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20221017230012.47878-33-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
2022-10-18 12:17:25 -04:00
Krzysztof Kozlowski
a849cbd18a dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: fix matching pin config
The LPASS pin controller follows generic pin-controller bindings, so
just like TLMM, should have subnodes with '-state' and '-pins'.

Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220927153429.55365-11-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
2022-10-17 12:47:39 -04:00
Krzysztof Kozlowski
2f1aad93a1 dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: fix gpio pattern
Fix double ']' in GPIO pattern to properly match "pins" property.
Otherwise schema for pins state fails.

Fixes: 4faa4e7301 ("dt-bindings: pinctrl: qcom: Add sm8450 lpass lpi pinctrl bindings")
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220927153429.55365-7-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
2022-10-17 12:46:50 -04:00
Srinivas Kandagatla
4faa4e7301 dt-bindings: pinctrl: qcom: Add sm8450 lpass lpi pinctrl bindings
Add device tree binding Documentation details for Qualcomm SM8450
LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220817113833.9625-2-srinivas.kandagatla@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2022-08-25 14:29:56 +02:00