public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

dmaengine: idxd: off by one in cleanup code

Browse source 
The clean up is off by one so this will start at "i" and it should start
with "i - 1" and then it doesn't unregister the zeroeth elements in the
array.

Fixes: c52ca47823 ("dmaengine: idxd: add configuration component of driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/X9nFeojulsNqUSnG@mwanda
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Dan Carpenter 2020-12-16 11:29:46 +03:00 • committed by Vinod Koul
parent 26b614fa44
commit ff58f7dd0c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/dma/idxd/sysfs.c
View file

@ -434,7 +434,7 @@ int idxd_register_driver(void)
return 0; return 0;
drv_fail: drv_fail:
for (; i > 0; i--) while (--i >= 0)
driver_unregister(&idxd_drvs[i]->drv); driver_unregister(&idxd_drvs[i]->drv);
return rc; return rc;
} }
@ -1840,7 +1840,7 @@ int idxd_register_bus_type(void)
return 0; return 0;
bus_err: bus_err:
for (; i > 0; i--) while (--i >= 0)
bus_unregister(idxd_bus_types[i]); bus_unregister(idxd_bus_types[i]);
return rc; return rc;
} }