public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

staging: iio: tsl2583: add error code to sysfs store functions

Browse source 
in_illuminance_input_target_store() and in_illuminance_calibrate_store()
validated the data from userspace, however it would not return an
error code to userspace if an invalid value was passed in. This patch
changes these functions so that they return -EINVAL if invalid data is
passed in.

Signed-off-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Brian Masney 2016-10-28 06:00:20 -04:00 • committed by Jonathan Cameron
parent b2fa81be96
commit f375a49f71
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/staging/iio/light/tsl2583.c
View file

@ -525,11 +525,10 @@ static ssize_t in_illuminance_input_target_store(struct device *dev,
struct tsl2583_chip *chip = iio_priv(indio_dev);
int value;
if (kstrtoint(buf, 0, &value))
if (kstrtoint(buf, 0, &value) || !value)
return -EINVAL;
if (value)
chip->taos_settings.als_cal_target = value;
chip->taos_settings.als_cal_target = value;
return len;
}
@ -541,11 +540,10 @@ static ssize_t in_illuminance_calibrate_store(struct device *dev,
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
int value;
if (kstrtoint(buf, 0, &value))
if (kstrtoint(buf, 0, &value) || value != 1)
return -EINVAL;
if (value == 1)
taos_als_calibrate(indio_dev);
taos_als_calibrate(indio_dev);
return len;
}