public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-04-13 09:59:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

topology/sysfs: rework book and drawer topology ifdefery

Browse source 
Provide default defines for the topology_book_[id|cpumask] and
topology_drawer_[id|cpumask] macros just like for each other topology
level.
This way all topology levels are handled in a similar way. Still the
the book and drawer levels are only used on s390, and also the sysfs
attributes are only created on s390. However other architectures may
opt in if wanted.

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://lore.kernel.org/r/20211129130309.3256168-4-hca@linux.ibm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Heiko Carstens 2021-11-29 14:03:09 +01:00 • committed by Greg Kroah-Hartman
parent e795707703
commit f1045056c7
3 changed files with 39 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
Documentation/admin-guide/cputopology.rst
View file

@ -8,14 +8,9 @@ to /proc/cpuinfo output of some architectures. They reside in
Documentation/ABI/stable/sysfs-devices-system-cpu. Documentation/ABI/stable/sysfs-devices-system-cpu.
Architecture-neutral, drivers/base/topology.c, exports these attributes. Architecture-neutral, drivers/base/topology.c, exports these attributes.
However, the book and drawer related sysfs files will only be created if However the die, cluster, book, and drawer hierarchy related sysfs files will
CONFIG_SCHED_BOOK and CONFIG_SCHED_DRAWER are selected, respectively. only be created if an architecture provides the related macros as described
below.
The die and cluster hierarchy related sysfs files will only be created if an
architecture provides the related macros as described below.
CONFIG_SCHED_BOOK and CONFIG_SCHED_DRAWER are currently only used on s390,
where they reflect the cpu and cache hierarchy.
For an architecture to support this feature, it must define some of For an architecture to support this feature, it must define some of
these macros in include/asm-XXX/topology.h:: these macros in include/asm-XXX/topology.h::
@ -42,19 +37,18 @@ To be consistent on all architectures, include/linux/topology.h
provides default definitions for any of the above macros that are provides default definitions for any of the above macros that are
not defined by include/asm-XXX/topology.h: not defined by include/asm-XXX/topology.h:
1) topology_physical_package_id: -1 1) topology_physical_package_id: -1
2) topology_die_id: -1 2) topology_die_id: -1
3) topology_cluster_id: -1 3) topology_cluster_id: -1
4) topology_core_id: 0 4) topology_core_id: 0
5) topology_sibling_cpumask: just the given CPU 5) topology_book_id: -1
6) topology_core_cpumask: just the given CPU 6) topology_drawer_id: -1
7) topology_cluster_cpumask: just the given CPU 7) topology_sibling_cpumask: just the given CPU
8) topology_die_cpumask: just the given CPU 8) topology_core_cpumask: just the given CPU
9) topology_cluster_cpumask: just the given CPU
For architectures that don't support books (CONFIG_SCHED_BOOK) there are no 10) topology_die_cpumask: just the given CPU
default definitions for topology_book_id() and topology_book_cpumask(). 11) topology_book_cpumask: just the given CPU
For architectures that don't support drawers (CONFIG_SCHED_DRAWER) there are 12) topology_drawer_cpumask: just the given CPU
no default definitions for topology_drawer_id() and topology_drawer_cpumask().
Additionally, CPU topology information is provided under Additionally, CPU topology information is provided under
/sys/devices/system/cpu and includes these files. The internal /sys/devices/system/cpu and includes these files. The internal

12
drivers/base/topology.c
View file

@ -86,7 +86,7 @@ define_siblings_read_func(package_cpus, core_cpumask);
static BIN_ATTR_RO(package_cpus, 0); static BIN_ATTR_RO(package_cpus, 0);
static BIN_ATTR_RO(package_cpus_list, 0); static BIN_ATTR_RO(package_cpus_list, 0);
#ifdef CONFIG_SCHED_BOOK #ifdef TOPOLOGY_BOOK_SYSFS
define_id_show_func(book_id); define_id_show_func(book_id);
static DEVICE_ATTR_RO(book_id); static DEVICE_ATTR_RO(book_id);
define_siblings_read_func(book_siblings, book_cpumask); define_siblings_read_func(book_siblings, book_cpumask);
@ -94,7 +94,7 @@ static BIN_ATTR_RO(book_siblings, 0);
static BIN_ATTR_RO(book_siblings_list, 0); static BIN_ATTR_RO(book_siblings_list, 0);
#endif #endif
#ifdef CONFIG_SCHED_DRAWER #ifdef TOPOLOGY_DRAWER_SYSFS
define_id_show_func(drawer_id); define_id_show_func(drawer_id);
static DEVICE_ATTR_RO(drawer_id); static DEVICE_ATTR_RO(drawer_id);
define_siblings_read_func(drawer_siblings, drawer_cpumask); define_siblings_read_func(drawer_siblings, drawer_cpumask);
@ -119,11 +119,11 @@ static struct bin_attribute *bin_attrs[] = {
#endif #endif
&bin_attr_package_cpus, &bin_attr_package_cpus,
&bin_attr_package_cpus_list, &bin_attr_package_cpus_list,
#ifdef CONFIG_SCHED_BOOK #ifdef TOPOLOGY_BOOK_SYSFS
&bin_attr_book_siblings, &bin_attr_book_siblings,
&bin_attr_book_siblings_list, &bin_attr_book_siblings_list,
#endif #endif
#ifdef CONFIG_SCHED_DRAWER #ifdef TOPOLOGY_DRAWER_SYSFS
&bin_attr_drawer_siblings, &bin_attr_drawer_siblings,
&bin_attr_drawer_siblings_list, &bin_attr_drawer_siblings_list,
#endif #endif
@ -139,10 +139,10 @@ static struct attribute *default_attrs[] = {
&dev_attr_cluster_id.attr, &dev_attr_cluster_id.attr,
#endif #endif
&dev_attr_core_id.attr, &dev_attr_core_id.attr,
#ifdef CONFIG_SCHED_BOOK #ifdef TOPOLOGY_BOOK_SYSFS
&dev_attr_book_id.attr, &dev_attr_book_id.attr,
#endif #endif
#ifdef CONFIG_SCHED_DRAWER #ifdef TOPOLOGY_DRAWER_SYSFS
&dev_attr_drawer_id.attr, &dev_attr_drawer_id.attr,
#endif #endif
NULL NULL

18
include/linux/topology.h
View file

@ -186,6 +186,12 @@ static inline int cpu_to_mem(int cpu)
#if defined(topology_cluster_id) && defined(topology_cluster_cpumask) #if defined(topology_cluster_id) && defined(topology_cluster_cpumask)
#define TOPOLOGY_CLUSTER_SYSFS #define TOPOLOGY_CLUSTER_SYSFS
#endif #endif
#if defined(topology_book_id) && defined(topology_book_cpumask)
#define TOPOLOGY_BOOK_SYSFS
#endif
#if defined(topology_drawer_id) && defined(topology_drawer_cpumask)
#define TOPOLOGY_DRAWER_SYSFS
#endif
#ifndef topology_physical_package_id #ifndef topology_physical_package_id
#define topology_physical_package_id(cpu) ((void)(cpu), -1) #define topology_physical_package_id(cpu) ((void)(cpu), -1)
@ -199,6 +205,12 @@ static inline int cpu_to_mem(int cpu)
#ifndef topology_core_id #ifndef topology_core_id
#define topology_core_id(cpu) ((void)(cpu), 0) #define topology_core_id(cpu) ((void)(cpu), 0)
#endif #endif
#ifndef topology_book_id
#define topology_book_id(cpu) ((void)(cpu), -1)
#endif
#ifndef topology_drawer_id
#define topology_drawer_id(cpu) ((void)(cpu), -1)
#endif
#ifndef topology_sibling_cpumask #ifndef topology_sibling_cpumask
#define topology_sibling_cpumask(cpu) cpumask_of(cpu) #define topology_sibling_cpumask(cpu) cpumask_of(cpu)
#endif #endif
@ -211,6 +223,12 @@ static inline int cpu_to_mem(int cpu)
#ifndef topology_die_cpumask #ifndef topology_die_cpumask
#define topology_die_cpumask(cpu) cpumask_of(cpu) #define topology_die_cpumask(cpu) cpumask_of(cpu)
#endif #endif
#ifndef topology_book_cpumask
#define topology_book_cpumask(cpu) cpumask_of(cpu)
#endif
#ifndef topology_drawer_cpumask
#define topology_drawer_cpumask(cpu) cpumask_of(cpu)
#endif
#if defined(CONFIG_SCHED_SMT) && !defined(cpu_smt_mask) #if defined(CONFIG_SCHED_SMT) && !defined(cpu_smt_mask)
static inline const struct cpumask *cpu_smt_mask(int cpu) static inline const struct cpumask *cpu_smt_mask(int cpu)