public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

vfio: platform: check reset call return code during open

Browse source 
Open call is ignoring the return code from reset call and can
potentially continue even though reset call failed.

If reset_required module parameter is set, this patch is going
to validate the return code and will abort open if reset fails.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Sinan Kaya 2016-07-19 09:01:48 -04:00 • committed by Alex Williamson
parent b5add544d6
commit e99442323f
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/vfio/platform/vfio_platform_common.c
View file

@ -251,6 +251,8 @@ static int vfio_platform_open(void *device_data)
mutex_lock(&driver_lock); mutex_lock(&driver_lock);
if (!vdev->refcnt) { if (!vdev->refcnt) {
const char *extra_dbg = NULL;
ret = vfio_platform_regions_init(vdev); ret = vfio_platform_regions_init(vdev);
if (ret) if (ret)
goto err_reg; goto err_reg;
@ -259,7 +261,12 @@ static int vfio_platform_open(void *device_data)
if (ret) if (ret)
goto err_irq; goto err_irq;
vfio_platform_call_reset(vdev, NULL); ret = vfio_platform_call_reset(vdev, &extra_dbg);
if (ret && vdev->reset_required) {
dev_warn(vdev->device, "reset driver is required and reset call failed in open (%d) %s\n",
ret, extra_dbg ? extra_dbg : "");
goto err_rst;
}
} }
vdev->refcnt++; vdev->refcnt++;
@ -267,6 +274,8 @@ static int vfio_platform_open(void *device_data)
mutex_unlock(&driver_lock); mutex_unlock(&driver_lock);
return 0; return 0;
err_rst:
vfio_platform_irq_cleanup(vdev);
err_irq: err_irq:
vfio_platform_regions_cleanup(vdev); vfio_platform_regions_cleanup(vdev);
err_reg: err_reg: