public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[media] tvp5150: Use i2c_smbus_(read|write)_byte_data

Browse source 
X-Patchwork-Delegate: mchehab@redhat.com
Replace the custom I2C read/write implementation with SMBUS functions to
simplify the driver.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
Laurent Pinchart 2014-05-26 16:31:28 -03:00 • committed by Mauro Carvalho Chehab
parent 385dded806
commit e35ce2e4b2
1 changed files with 10 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
drivers/media/i2c/tvp5150.c
View file

@ -56,38 +56,29 @@ static inline struct v4l2_subdev *to_sd(struct v4l2_ctrl *ctrl)
static int tvp5150_read(struct v4l2_subdev *sd, unsigned char addr) static int tvp5150_read(struct v4l2_subdev *sd, unsigned char addr)
{ {
struct i2c_client *c = v4l2_get_subdevdata(sd); struct i2c_client *c = v4l2_get_subdevdata(sd);
unsigned char buffer[1];
int rc; int rc;
struct i2c_msg msg[] = {
{ .addr = c->addr, .flags = 0,
.buf = &addr, .len = 1 },
{ .addr = c->addr, .flags = I2C_M_RD,
.buf = buffer, .len = 1 }
};
rc = i2c_transfer(c->adapter, msg, 2); rc = i2c_smbus_read_byte_data(c, addr);
if (rc < 0 || rc != 2) { if (rc < 0) {
v4l2_err(sd, "i2c i/o error: rc == %d (should be 2)\n", rc); v4l2_err(sd, "i2c i/o error: rc == %d\n", rc);
return rc < 0 ? rc : -EIO; return rc;
} }
v4l2_dbg(2, debug, sd, "tvp5150: read 0x%02x = 0x%02x\n", addr, buffer[0]); v4l2_dbg(2, debug, sd, "tvp5150: read 0x%02x = 0x%02x\n", addr, rc);
return (buffer[0]); return rc;
} }
static inline void tvp5150_write(struct v4l2_subdev *sd, unsigned char addr, static inline void tvp5150_write(struct v4l2_subdev *sd, unsigned char addr,
unsigned char value) unsigned char value)
{ {
struct i2c_client *c = v4l2_get_subdevdata(sd); struct i2c_client *c = v4l2_get_subdevdata(sd);
unsigned char buffer[2];
int rc; int rc;
buffer[0] = addr; v4l2_dbg(2, debug, sd, "tvp5150: writing 0x%02x 0x%02x\n", addr, value);
buffer[1] = value; rc = i2c_smbus_write_byte_data(c, addr, value);
v4l2_dbg(2, debug, sd, "tvp5150: writing 0x%02x 0x%02x\n", buffer[0], buffer[1]); if (rc < 0)
if (2 != (rc = i2c_master_send(c, buffer, 2))) v4l2_dbg(0, debug, sd, "i2c i/o error: rc == %d\n", rc);
v4l2_dbg(0, debug, sd, "i2c i/o error: rc == %d (should be 2)\n", rc);
} }
static void dump_reg_range(struct v4l2_subdev *sd, char *s, u8 init, static void dump_reg_range(struct v4l2_subdev *sd, char *s, u8 init,