public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-05-24 10:39:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ALSA: bebob: expand sleep just after breaking connections for protocol version 1

Browse source 
As long as I investigated, some devices with BeBoB protocol version 1
can be freezed during several hundreds milliseconds after breaking
connections. When accessing during the freezed time, any transaction
is corrupted. In the worst case, the device is going to reboot.

I can see this issue in:
 * Roland FA-66
 * M-Audio FireWire Solo

This commit expands sleep just after breaking connections to avoid
the freezed time as much as possible. I note that the freeze/reboot
behaviour is similar to below models:
 * Focusrite Saffire Pro 10 I/O
 * Focusrite Saffire Pro 26 I/O

The above models certainly reboot after breaking connections.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191101131323.17300-2-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Sakamoto 2019-11-01 22:13:21 +09:00 • committed by Takashi Iwai
parent 0929249e3b
commit d3eabe939a
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sound/firewire/bebob/bebob_stream.c
View file

@ -415,15 +415,16 @@ static int make_both_connections(struct snd_bebob *bebob)
return 0; return 0;
} }
static void static void break_both_connections(struct snd_bebob *bebob)
break_both_connections(struct snd_bebob *bebob)
{ {
cmp_connection_break(&bebob->in_conn); cmp_connection_break(&bebob->in_conn);
cmp_connection_break(&bebob->out_conn); cmp_connection_break(&bebob->out_conn);
/* These models seems to be in transition state for a longer time. */ // These models seem to be in transition state for a longer time. When
if (bebob->maudio_special_quirk != NULL) // accessing in the state, any transactions is corrupted. In the worst
msleep(200); // case, the device is going to reboot.
if (bebob->version < 2)
msleep(600);
} }
static int static int