public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

RDMA/core: Fix return code when modify_device isn't supported

Browse source 
The proper return code is "-EOPNOTSUPP" when modify_device callback is not
supported.

Link: https://lore.kernel.org/r/20190923104158.5331-2-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Kamal Heib 2019-09-23 13:41:56 +03:00 • committed by Jason Gunthorpe
parent 050dbddf24
commit d0f3ef36bf
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/infiniband/core/device.c
View file

@ -2365,7 +2365,7 @@ int ib_modify_device(struct ib_device *device,
struct ib_device_modify *device_modify) struct ib_device_modify *device_modify)
{ {
if (!device->ops.modify_device) if (!device->ops.modify_device)
return -ENOSYS; return -EOPNOTSUPP;
return device->ops.modify_device(device, device_modify_mask, return device->ops.modify_device(device, device_modify_mask,
device_modify); device_modify);

2
drivers/infiniband/core/sysfs.c
View file

@ -1268,7 +1268,7 @@ static ssize_t node_desc_store(struct device *device,
int ret; int ret;
if (!dev->ops.modify_device) if (!dev->ops.modify_device)
return -EIO; return -EOPNOTSUPP;
memcpy(desc.node_desc, buf, min_t(int, count, IB_DEVICE_NODE_DESC_MAX)); memcpy(desc.node_desc, buf, min_t(int, count, IB_DEVICE_NODE_DESC_MAX));
ret = ib_modify_device(dev, IB_DEVICE_MODIFY_NODE_DESC, &desc); ret = ib_modify_device(dev, IB_DEVICE_MODIFY_NODE_DESC, &desc);