public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-05-24 10:39:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()

Browse source 
After calling of_node_put() on the node variable, it is still being
used, which may result in use-after-free.
Fix this issue by calling of_node_put() after the last usage.

Fixes: a0c426fe14 ("ASoC: simple-card-utils: check "reg" property on asoc_simple_card_get_dai_id()")
Link: https://lore.kernel.org/r/1562743509-30496-5-git-send-email-wen.yang99@zte.com.cn
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Wen Yang 2019-07-10 15:25:09 +08:00 • committed by Mark Brown
parent aa2e362cb6
commit c152f8491a
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sound/soc/generic/audio-graph-card.c
View file

@ -63,6 +63,7 @@ static int graph_get_dai_id(struct device_node *ep)
struct device_node *endpoint; struct device_node *endpoint;
struct of_endpoint info; struct of_endpoint info;
int i, id; int i, id;
u32 *reg;
int ret; int ret;
/* use driver specified DAI ID if exist */ /* use driver specified DAI ID if exist */
@ -83,8 +84,9 @@ static int graph_get_dai_id(struct device_node *ep)
return info.id; return info.id;
node = of_get_parent(ep); node = of_get_parent(ep);
reg = of_get_property(node, "reg", NULL);
of_node_put(node); of_node_put(node);
if (of_get_property(node, "reg", NULL)) if (reg)
return info.port; return info.port;
} }
node = of_graph_get_port_parent(ep); node = of_graph_get_port_parent(ep);