public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

crypto: mxc-scc - signedness bugs in mxc_scc_ablkcipher_req_init()

Browse source 
->src_nents and ->dst_nents are unsigned so they can't be less than
zero.  I fixed this by introducing a temporary "nents" variable.

Fixes: d293b640eb ('crypto: mxc-scc - add basic driver for the MXC SCC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Dan Carpenter 2016-04-22 12:56:31 +03:00 • committed by Herbert Xu
parent 3639ca840d
commit b908bd3d4c
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/crypto/mxc-scc.c
View file

@ -210,18 +210,21 @@ static int mxc_scc_ablkcipher_req_init(struct ablkcipher_request *req,
struct mxc_scc_ctx *ctx) struct mxc_scc_ctx *ctx)
{ {
struct mxc_scc *scc = ctx->scc; struct mxc_scc *scc = ctx->scc;
int nents;
ctx->src_nents = sg_nents_for_len(req->src, req->nbytes); nents = sg_nents_for_len(req->src, req->nbytes);
if (ctx->src_nents < 0) { if (nents < 0) {
dev_err(scc->dev, "Invalid number of src SC"); dev_err(scc->dev, "Invalid number of src SC");
return ctx->src_nents; return nents;
} }
ctx->src_nents = nents;
ctx->dst_nents = sg_nents_for_len(req->dst, req->nbytes); nents = sg_nents_for_len(req->dst, req->nbytes);
if (ctx->dst_nents < 0) { if (nents < 0) {
dev_err(scc->dev, "Invalid number of dst SC"); dev_err(scc->dev, "Invalid number of dst SC");
return ctx->dst_nents; return nents;
} }
ctx->dst_nents = nents;
ctx->size = 0; ctx->size = 0;
ctx->offset = 0; ctx->offset = 0;