public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASoC: mediatek: mt2701-afe-pcm: Convert to platform remove callback returning void

Browse source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-108-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-15 16:06:39 +01:00 • committed by Mark Brown
parent 09f8cf0495
commit b3dff59e57
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
View file

@ -1439,14 +1439,12 @@ err_pm_disable:
return ret; return ret;
} }
static int mt2701_afe_pcm_dev_remove(struct platform_device *pdev) static void mt2701_afe_pcm_dev_remove(struct platform_device *pdev)
{ {
pm_runtime_put_sync(&pdev->dev); pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
if (!pm_runtime_status_suspended(&pdev->dev)) if (!pm_runtime_status_suspended(&pdev->dev))
mt2701_afe_runtime_suspend(&pdev->dev); mt2701_afe_runtime_suspend(&pdev->dev);
return 0;
} }
static const struct mt2701_soc_variants mt2701_soc_v1 = { static const struct mt2701_soc_variants mt2701_soc_v1 = {
@ -1477,7 +1475,7 @@ static struct platform_driver mt2701_afe_pcm_driver = {
.pm = &mt2701_afe_pm_ops, .pm = &mt2701_afe_pm_ops,
}, },
.probe = mt2701_afe_pcm_dev_probe, .probe = mt2701_afe_pcm_dev_probe,
.remove = mt2701_afe_pcm_dev_remove, .remove_new = mt2701_afe_pcm_dev_remove,
}; };
module_platform_driver(mt2701_afe_pcm_driver); module_platform_driver(mt2701_afe_pcm_driver);