public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

soundwire: stream: fix programming slave ports for non-continous port maps

Browse source 
Two bitmasks in 'struct sdw_slave_prop' - 'source_ports' and
'sink_ports' - define which ports to program in
sdw_program_slave_port_params().  The masks are used to get the
appropriate data port properties ('struct sdw_get_slave_dpn_prop') from
an array.

Bitmasks can be non-continuous or can start from index different than 0,
thus when looking for matching port property for given port, we must
iterate over mask bits, not from 0 up to number of ports.

This fixes allocation and programming slave ports, when a source or sink
masks start from further index.

Fixes: f8101c74aa ("soundwire: Add Master and Slave port programming")
Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20240729140157.326450-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Krzysztof Kozlowski 2024-07-29 16:01:57 +02:00 • committed by Vinod Koul
parent 8400291e28
commit ab8d66d132
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/soundwire/stream.c
View file

@ -1291,18 +1291,18 @@ struct sdw_dpn_prop *sdw_get_slave_dpn_prop(struct sdw_slave *slave,
unsigned int port_num) unsigned int port_num)
{ {
struct sdw_dpn_prop *dpn_prop; struct sdw_dpn_prop *dpn_prop;
u8 num_ports; unsigned long mask;
int i; int i;
if (direction == SDW_DATA_DIR_TX) { if (direction == SDW_DATA_DIR_TX) {
num_ports = hweight32(slave->prop.source_ports); mask = slave->prop.source_ports;
dpn_prop = slave->prop.src_dpn_prop; dpn_prop = slave->prop.src_dpn_prop;
} else { } else {
num_ports = hweight32(slave->prop.sink_ports); mask = slave->prop.sink_ports;
dpn_prop = slave->prop.sink_dpn_prop; dpn_prop = slave->prop.sink_dpn_prop;
} }
for (i = 0; i < num_ports; i++) { for_each_set_bit(i, &mask, 32) {
if (dpn_prop[i].num == port_num) if (dpn_prop[i].num == port_num)
return &dpn_prop[i]; return &dpn_prop[i];
} }