public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

usb: ohci-platform: Use devm_of_phy_get_by_index

Browse source 
Getting phys by index instead of phy names so that we do
not have to create a naming scheme when multiple phys are present

Signed-off-by: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
Reviewed-by: Ray Jui <rjui@broadcom.com>
Reviewed-by: Scott Branden <sbranden@broadcom.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
This commit is contained in:
Arun Ramamurthy 2015-04-22 16:04:13 -07:00 • committed by Kishon Vijay Abraham I
parent 216e299269
commit a666f7d097
1 changed files with 24 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

69
drivers/usb/host/ohci-platform.c
View file

@ -57,15 +57,13 @@ static int ohci_platform_power_on(struct platform_device *dev)
} }
for (phy_num = 0; phy_num < priv->num_phys; phy_num++) { for (phy_num = 0; phy_num < priv->num_phys; phy_num++) {
if (priv->phys[phy_num]) { ret = phy_init(priv->phys[phy_num]);
ret = phy_init(priv->phys[phy_num]); if (ret)
if (ret) goto err_exit_phy;
goto err_exit_phy; ret = phy_power_on(priv->phys[phy_num]);
ret = phy_power_on(priv->phys[phy_num]); if (ret) {
if (ret) { phy_exit(priv->phys[phy_num]);
phy_exit(priv->phys[phy_num]); goto err_exit_phy;
goto err_exit_phy;
}
} }
} }
@ -73,10 +71,8 @@ static int ohci_platform_power_on(struct platform_device *dev)
err_exit_phy: err_exit_phy:
while (--phy_num >= 0) { while (--phy_num >= 0) {
if (priv->phys[phy_num]) { phy_power_off(priv->phys[phy_num]);
phy_power_off(priv->phys[phy_num]); phy_exit(priv->phys[phy_num]);
phy_exit(priv->phys[phy_num]);
}
} }
err_disable_clks: err_disable_clks:
while (--clk >= 0) while (--clk >= 0)
@ -92,10 +88,8 @@ static void ohci_platform_power_off(struct platform_device *dev)
int clk, phy_num; int clk, phy_num;
for (phy_num = 0; phy_num < priv->num_phys; phy_num++) { for (phy_num = 0; phy_num < priv->num_phys; phy_num++) {
if (priv->phys[phy_num]) { phy_power_off(priv->phys[phy_num]);
phy_power_off(priv->phys[phy_num]); phy_exit(priv->phys[phy_num]);
phy_exit(priv->phys[phy_num]);
}
} }
for (clk = OHCI_MAX_CLKS - 1; clk >= 0; clk--) for (clk = OHCI_MAX_CLKS - 1; clk >= 0; clk--)
@ -123,7 +117,6 @@ static int ohci_platform_probe(struct platform_device *dev)
struct usb_ohci_pdata *pdata = dev_get_platdata(&dev->dev); struct usb_ohci_pdata *pdata = dev_get_platdata(&dev->dev);
struct ohci_platform_priv *priv; struct ohci_platform_priv *priv;
struct ohci_hcd *ohci; struct ohci_hcd *ohci;
const char *phy_name;
int err, irq, phy_num, clk = 0; int err, irq, phy_num, clk = 0;
if (usb_disabled()) if (usb_disabled())
@ -174,36 +167,22 @@ static int ohci_platform_probe(struct platform_device *dev)
priv->num_phys = of_count_phandle_with_args(dev->dev.of_node, priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
"phys", "#phy-cells"); "phys", "#phy-cells");
priv->num_phys = priv->num_phys > 0 ? priv->num_phys : 1;
priv->phys = devm_kcalloc(&dev->dev, priv->num_phys, if (priv->num_phys > 0) {
sizeof(struct phy *), GFP_KERNEL); priv->phys = devm_kcalloc(&dev->dev, priv->num_phys,
if (!priv->phys) sizeof(struct phy *), GFP_KERNEL);
return -ENOMEM; if (!priv->phys)
return -ENOMEM;
} else
priv->num_phys = 0;
for (phy_num = 0; phy_num < priv->num_phys; phy_num++) { for (phy_num = 0; phy_num < priv->num_phys; phy_num++) {
err = of_property_read_string_index( priv->phys[phy_num] = devm_of_phy_get_by_index(
dev->dev.of_node, &dev->dev, dev->dev.of_node, phy_num);
"phy-names", phy_num, if (IS_ERR(priv->phys[phy_num])) {
&phy_name); err = PTR_ERR(priv->phys[phy_num]);
goto err_put_hcd;
if (err < 0) { }
if (priv->num_phys > 1) {
dev_err(&dev->dev, "phy-names not provided");
goto err_put_hcd;
} else
phy_name = "usb";
}
priv->phys[phy_num] = devm_phy_get(&dev->dev,
phy_name);
if (IS_ERR(priv->phys[phy_num])) {
err = PTR_ERR(priv->phys[phy_num]);
if ((priv->num_phys > 1) ||
(err == -EPROBE_DEFER))
goto err_put_hcd;
priv->phys[phy_num] = NULL;
}
} }
for (clk = 0; clk < OHCI_MAX_CLKS; clk++) { for (clk = 0; clk < OHCI_MAX_CLKS; clk++) {