mirror of
				git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
				synced 2025-10-31 16:54:21 +00:00 
			
		
		
		
	drivers/*: mark variables with uninitialized_var()
Mark variables in drivers/* with uninitialized_var() if such a warning appears, and analysis proves that the var is initialized properly on all paths it is used. Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
		
							parent
							
								
									b1734d2388
								
							
						
					
					
						commit
						a6343afb6e
					
				
					 8 changed files with 25 additions and 11 deletions
				
			
		|  | @ -915,7 +915,7 @@ static int open_tx_first(struct atm_vcc *vcc) | ||||||
| 	unsigned long flags; | 	unsigned long flags; | ||||||
| 	u32 *loop; | 	u32 *loop; | ||||||
| 	unsigned short chan; | 	unsigned short chan; | ||||||
| 	int pcr,unlimited; | 	int unlimited; | ||||||
| 
 | 
 | ||||||
| 	DPRINTK("open_tx_first\n"); | 	DPRINTK("open_tx_first\n"); | ||||||
| 	zatm_dev = ZATM_DEV(vcc->dev); | 	zatm_dev = ZATM_DEV(vcc->dev); | ||||||
|  | @ -936,6 +936,8 @@ static int open_tx_first(struct atm_vcc *vcc) | ||||||
| 	    vcc->qos.txtp.max_pcr >= ATM_OC3_PCR); | 	    vcc->qos.txtp.max_pcr >= ATM_OC3_PCR); | ||||||
| 	if (unlimited && zatm_dev->ubr != -1) zatm_vcc->shaper = zatm_dev->ubr; | 	if (unlimited && zatm_dev->ubr != -1) zatm_vcc->shaper = zatm_dev->ubr; | ||||||
| 	else { | 	else { | ||||||
|  | 		int uninitialized_var(pcr); | ||||||
|  | 
 | ||||||
| 		if (unlimited) vcc->qos.txtp.max_sdu = ATM_MAX_AAL5_PDU; | 		if (unlimited) vcc->qos.txtp.max_sdu = ATM_MAX_AAL5_PDU; | ||||||
| 		if ((zatm_vcc->shaper = alloc_shaper(vcc->dev,&pcr, | 		if ((zatm_vcc->shaper = alloc_shaper(vcc->dev,&pcr, | ||||||
| 		    vcc->qos.txtp.min_pcr,vcc->qos.txtp.max_pcr,unlimited)) | 		    vcc->qos.txtp.min_pcr,vcc->qos.txtp.max_pcr,unlimited)) | ||||||
|  |  | ||||||
|  | @ -4466,10 +4466,10 @@ static void cy_hangup(struct tty_struct *tty) | ||||||
| static int __devinit cy_init_card(struct cyclades_card *cinfo) | static int __devinit cy_init_card(struct cyclades_card *cinfo) | ||||||
| { | { | ||||||
| 	struct cyclades_port *info; | 	struct cyclades_port *info; | ||||||
| 	u32 mailbox; | 	u32 uninitialized_var(mailbox); | ||||||
| 	unsigned int nports; | 	unsigned int nports; | ||||||
| 	unsigned short chip_number; | 	unsigned short chip_number; | ||||||
| 	int index, port; | 	int uninitialized_var(index), port; | ||||||
| 
 | 
 | ||||||
| 	spin_lock_init(&cinfo->card_lock); | 	spin_lock_init(&cinfo->card_lock); | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -368,7 +368,7 @@ int ubi_eba_read_leb(struct ubi_device *ubi, int vol_id, int lnum, void *buf, | ||||||
| 	int err, pnum, scrub = 0, idx = vol_id2idx(ubi, vol_id); | 	int err, pnum, scrub = 0, idx = vol_id2idx(ubi, vol_id); | ||||||
| 	struct ubi_vid_hdr *vid_hdr; | 	struct ubi_vid_hdr *vid_hdr; | ||||||
| 	struct ubi_volume *vol = ubi->volumes[idx]; | 	struct ubi_volume *vol = ubi->volumes[idx]; | ||||||
| 	uint32_t crc; | 	uint32_t uninitialized_var(crc); | ||||||
| 
 | 
 | ||||||
| 	err = leb_read_lock(ubi, vol_id, lnum); | 	err = leb_read_lock(ubi, vol_id, lnum); | ||||||
| 	if (err) | 	if (err) | ||||||
|  |  | ||||||
|  | @ -2338,7 +2338,7 @@ static int rtl8169_xmit_frags(struct rtl8169_private *tp, struct sk_buff *skb, | ||||||
| { | { | ||||||
| 	struct skb_shared_info *info = skb_shinfo(skb); | 	struct skb_shared_info *info = skb_shinfo(skb); | ||||||
| 	unsigned int cur_frag, entry; | 	unsigned int cur_frag, entry; | ||||||
| 	struct TxDesc *txd; | 	struct TxDesc * uninitialized_var(txd); | ||||||
| 
 | 
 | ||||||
| 	entry = tp->cur_tx; | 	entry = tp->cur_tx; | ||||||
| 	for (cur_frag = 0; cur_frag < info->nr_frags; cur_frag++) { | 	for (cur_frag = 0; cur_frag < info->nr_frags; cur_frag++) { | ||||||
|  |  | ||||||
|  | @ -3692,7 +3692,6 @@ static int smctr_process_rx_packet(MAC_HEADER *rmf, __u16 size, | ||||||
|         __u16 rcode, correlator; |         __u16 rcode, correlator; | ||||||
|         int err = 0; |         int err = 0; | ||||||
|         __u8 xframe = 1; |         __u8 xframe = 1; | ||||||
|         __u16 tx_fstatus; |  | ||||||
| 
 | 
 | ||||||
|         rmf->vl = SWAP_BYTES(rmf->vl); |         rmf->vl = SWAP_BYTES(rmf->vl); | ||||||
|         if(rx_status & FCB_RX_STATUS_DA_MATCHED) |         if(rx_status & FCB_RX_STATUS_DA_MATCHED) | ||||||
|  | @ -3783,7 +3782,9 @@ static int smctr_process_rx_packet(MAC_HEADER *rmf, __u16 size, | ||||||
|                                 } |                                 } | ||||||
|                                 break; |                                 break; | ||||||
| 
 | 
 | ||||||
|                         case TX_FORWARD: |                         case TX_FORWARD: { | ||||||
|  |         			__u16 uninitialized_var(tx_fstatus); | ||||||
|  | 
 | ||||||
|                                 if((rcode = smctr_rcv_tx_forward(dev, rmf)) |                                 if((rcode = smctr_rcv_tx_forward(dev, rmf)) | ||||||
|                                         != POSITIVE_ACK) |                                         != POSITIVE_ACK) | ||||||
|                                 { |                                 { | ||||||
|  | @ -3811,6 +3812,7 @@ static int smctr_process_rx_packet(MAC_HEADER *rmf, __u16 size, | ||||||
|                                         } |                                         } | ||||||
|                                 } |                                 } | ||||||
|                                 break; |                                 break; | ||||||
|  | 			} | ||||||
| 
 | 
 | ||||||
|                         /* Received MAC Frames Processed by CRS/REM/RPS. */ |                         /* Received MAC Frames Processed by CRS/REM/RPS. */ | ||||||
|                         case RSP: |                         case RSP: | ||||||
|  |  | ||||||
|  | @ -664,7 +664,7 @@ static int auerchain_control_msg (pauerchain_t acp, struct usb_device *dev, unsi | ||||||
| 	int ret; | 	int ret; | ||||||
| 	struct usb_ctrlrequest *dr; | 	struct usb_ctrlrequest *dr; | ||||||
| 	struct urb *urb; | 	struct urb *urb; | ||||||
|         int length; |         int uninitialized_var(length); | ||||||
| 
 | 
 | ||||||
|         dbg ("auerchain_control_msg"); |         dbg ("auerchain_control_msg"); | ||||||
|         dr = kmalloc (sizeof (struct usb_ctrlrequest), GFP_KERNEL); |         dr = kmalloc (sizeof (struct usb_ctrlrequest), GFP_KERNEL); | ||||||
|  |  | ||||||
|  | @ -273,8 +273,11 @@ static int matroxfb_PLL_mavenclock(const struct matrox_pll_features2* pll, | ||||||
| 			} | 			} | ||||||
| 		} | 		} | ||||||
| 	} | 	} | ||||||
|  | 
 | ||||||
|  | 	/* if h2/post/in/feed have not been assigned, return zero (error) */ | ||||||
| 	if (besth2 < 2) | 	if (besth2 < 2) | ||||||
| 		return 0; | 		return 0; | ||||||
|  | 
 | ||||||
| 	dprintk(KERN_ERR "clk: %02X %02X %02X %d %d\n", *in, *feed, *post, fxtal, fwant); | 	dprintk(KERN_ERR "clk: %02X %02X %02X %d %d\n", *in, *feed, *post, fxtal, fwant); | ||||||
| 	return fxtal * (*feed) / (*in) * ctl->den; | 	return fxtal * (*feed) / (*in) * ctl->den; | ||||||
| } | } | ||||||
|  | @ -284,7 +287,7 @@ static unsigned int matroxfb_mavenclock(const struct matrox_pll_ctl* ctl, | ||||||
| 		unsigned int* in, unsigned int* feed, unsigned int* post, | 		unsigned int* in, unsigned int* feed, unsigned int* post, | ||||||
| 		unsigned int* htotal2) { | 		unsigned int* htotal2) { | ||||||
| 	unsigned int fvco; | 	unsigned int fvco; | ||||||
| 	unsigned int p; | 	unsigned int uninitialized_var(p); | ||||||
| 
 | 
 | ||||||
| 	fvco = matroxfb_PLL_mavenclock(&maven1000_pll, ctl, htotal, vtotal, in, feed, &p, htotal2); | 	fvco = matroxfb_PLL_mavenclock(&maven1000_pll, ctl, htotal, vtotal, in, feed, &p, htotal2); | ||||||
| 	if (!fvco) | 	if (!fvco) | ||||||
|  | @ -715,7 +718,9 @@ static int maven_find_exact_clocks(unsigned int ht, unsigned int vt, | ||||||
| 	m->regs[0x82] = 0x81; | 	m->regs[0x82] = 0x81; | ||||||
| 
 | 
 | ||||||
| 	for (x = 0; x < 8; x++) { | 	for (x = 0; x < 8; x++) { | ||||||
| 		unsigned int a, b, c, h2; | 		unsigned int c; | ||||||
|  | 		unsigned int uninitialized_var(a), uninitialized_var(b), | ||||||
|  | 			     uninitialized_var(h2); | ||||||
| 		unsigned int h = ht + 2 + x; | 		unsigned int h = ht + 2 + x; | ||||||
| 
 | 
 | ||||||
| 		if (!matroxfb_mavenclock((m->mode == MATROXFB_OUTPUT_MODE_PAL) ? &maven_PAL : &maven_NTSC, h, vt, &a, &b, &c, &h2)) { | 		if (!matroxfb_mavenclock((m->mode == MATROXFB_OUTPUT_MODE_PAL) ? &maven_PAL : &maven_NTSC, h, vt, &a, &b, &c, &h2)) { | ||||||
|  |  | ||||||
|  | @ -1223,6 +1223,8 @@ static int CalcVClock | ||||||
|         } |         } | ||||||
|     } |     } | ||||||
|     } |     } | ||||||
|  | 
 | ||||||
|  |     /* non-zero: M/N/P/clock values assigned.  zero: error (not set) */ | ||||||
|     return (DeltaOld != 0xFFFFFFFF); |     return (DeltaOld != 0xFFFFFFFF); | ||||||
| } | } | ||||||
| /*
 | /*
 | ||||||
|  | @ -1240,7 +1242,10 @@ int CalcStateExt | ||||||
|     int            dotClock |     int            dotClock | ||||||
| ) | ) | ||||||
| { | { | ||||||
|     int pixelDepth, VClk, m, n, p; |     int pixelDepth; | ||||||
|  |     int uninitialized_var(VClk),uninitialized_var(m), | ||||||
|  |         uninitialized_var(n),	uninitialized_var(p); | ||||||
|  | 
 | ||||||
|     /*
 |     /*
 | ||||||
|      * Save mode parameters. |      * Save mode parameters. | ||||||
|      */ |      */ | ||||||
|  |  | ||||||
		Loading…
	
	Add table
		
		Reference in a new issue
	
	 Jeff Garzik
						Jeff Garzik