public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-11-27 01:11:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform/x86: msi-wmi-platform: Fix typo in WMI GUID

Browse source 
The WMI driver core only supports GUID strings containing only
uppercase characters, however the GUID string used by the
msi-wmi-platform driver contains a single lowercase character.
This prevents the WMI driver core from matching said driver to
its WMI device.

Fix this by turning the lowercase character into a uppercase
character. Also update the WMI driver development guide to warn
about this.

Reported-by: Antheas Kapenekakis <lkml@antheas.dev>
Fixes: 9c0beb6b29 ("platform/x86: wmi: Add MSI WMI Platform driver")
Tested-by: Antheas Kapenekakis <lkml@antheas.dev>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://patch.msgid.link/20251110111253.16204-3-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
Armin Wolf 2025-11-10 12:12:53 +01:00 • committed by Ilpo Järvinen
parent c93433fd4e
commit 97b726eb1d
No known key found for this signature in database
GPG key ID: 59AC4F6153E5CE31
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Documentation/wmi/driver-development-guide.rst
View file

@ -54,6 +54,7 @@ to matching WMI devices using a struct wmi_device_id table:
:: ::
static const struct wmi_device_id foo_id_table[] = { static const struct wmi_device_id foo_id_table[] = {
/* Only use uppercase letters! */
{ "936DA01F-9ABD-4D9D-80C7-02AF85C822A8", NULL }, { "936DA01F-9ABD-4D9D-80C7-02AF85C822A8", NULL },
{ } { }
}; };

2
drivers/platform/x86/msi-wmi-platform.c
View file

@ -29,7 +29,7 @@
#define DRIVER_NAME "msi-wmi-platform" #define DRIVER_NAME "msi-wmi-platform"
#define MSI_PLATFORM_GUID "ABBC0F6E-8EA1-11d1-00A0-C90629100000" #define MSI_PLATFORM_GUID "ABBC0F6E-8EA1-11D1-00A0-C90629100000"
#define MSI_WMI_PLATFORM_INTERFACE_VERSION 2 #define MSI_WMI_PLATFORM_INTERFACE_VERSION 2