public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

intel_th: gth: Fix an off-by-one in output unassigning

Browse source 
Commit 9ed3f22223 ("intel_th: Don't reference unassigned outputs")
fixes a NULL dereference for all masters except the last one ("256+"),
which keeps the stale pointer after the output driver had been unassigned.

Fix the off-by-one.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Fixes: 9ed3f22223 ("intel_th: Don't reference unassigned outputs")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Alexander Shishkin 2019-03-01 10:09:55 +02:00 • committed by Greg Kroah-Hartman
parent 8c8448792a
commit 91d3f8a629
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/hwtracing/intel_th/gth.c
View file

@ -616,7 +616,7 @@ static void intel_th_gth_unassign(struct intel_th_device *thdev,
othdev->output.port = -1; othdev->output.port = -1;
othdev->output.active = false; othdev->output.active = false;
gth->output[port].output = NULL; gth->output[port].output = NULL;
for (master = 0; master < TH_CONFIGURABLE_MASTERS; master++) for (master = 0; master <= TH_CONFIGURABLE_MASTERS; master++)
if (gth->master[master] == port) if (gth->master[master] == port)
gth->master[master] = -1; gth->master[master] = -1;
spin_unlock(&gth->gth_lock); spin_unlock(&gth->gth_lock);