public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASoC: SOF: Intel: disable traces when switching to S0Ix D0I3

Browse source 
We should always disable DMA trace on S0Ix. When staying at S0-D0I3,
we should enable DMA trace while both DMA Trace debug is enabled and
hda_enable_trace_D0I3_S0 is set. This commit corrects the existed
logic errors about that.

Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200727183613.1419005-3-ranjani.sridharan@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Marcin Rajwa 2020-07-27 11:36:13 -07:00 • committed by Mark Brown
parent 195f101980
commit 79560b8aeb
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
sound/soc/sof/intel/hda-dsp.c
View file

@ -408,11 +408,13 @@ static int hda_dsp_set_D0_state(struct snd_sof_dev *sdev,
value = SOF_HDA_VS_D0I3C_I3; value = SOF_HDA_VS_D0I3C_I3;
/* /*
* Trace DMA is disabled by default when the DSP enters D0I3. * Trace DMA need to be disabled when the DSP enters
* But it can be kept enabled when the DSP enters D0I3 while the * D0I3 for S0Ix suspend, but it can be kept enabled
* system is in S0 for debug. * when the DSP enters D0I3 while the system is in S0
* for debug purpose.
*/ */
if (hda_enable_trace_D0I3_S0 && if (!sdev->dtrace_is_supported ||
!hda_enable_trace_D0I3_S0 ||
sdev->system_suspend_target != SOF_SUSPEND_NONE) sdev->system_suspend_target != SOF_SUSPEND_NONE)
flags = HDA_PM_NO_DMA_TRACE; flags = HDA_PM_NO_DMA_TRACE;
} else { } else {