public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-04-13 09:59:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

xfs: report the correct read/write dio alignment for reflinked inodes

Browse source 
For I/O to reflinked blocks we always need to write an entire new
file system block, and the code enforces the file system block alignment
for the entire file if it has any reflinked blocks.

Use the new STATX_DIO_READ_ALIGN flag to report the asymmetric read
vs write alignments for reflinked files.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250109083109.1441561-5-hch@lst.de
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Christoph Hellwig 2025-01-09 09:31:04 +01:00 • committed by Christian Brauner
parent 7e17483c7b
commit 7422bbd030
No known key found for this signature in database
GPG key ID: 91C61BC06578DCA2
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
fs/xfs/xfs_iops.c
View file

@ -580,9 +580,24 @@ xfs_report_dioalign(
struct xfs_buftarg *target = xfs_inode_buftarg(ip);
struct block_device *bdev = target->bt_bdev;
stat->result_mask |= STATX_DIOALIGN;
stat->result_mask |= STATX_DIOALIGN | STATX_DIO_READ_ALIGN;
stat->dio_mem_align = bdev_dma_alignment(bdev) + 1;
stat->dio_offset_align = bdev_logical_block_size(bdev);
/*
* For COW inodes, we can only perform out of place writes of entire
* allocation units (blocks or RT extents).
* For writes smaller than the allocation unit, we must fall back to
* buffered I/O to perform read-modify-write cycles. At best this is
* highly inefficient; at worst it leads to page cache invalidation
* races. Tell applications to avoid this by reporting the larger write
* alignment in dio_offset_align, and the smaller read alignment in
* dio_read_offset_align.
*/
stat->dio_read_offset_align = bdev_logical_block_size(bdev);
if (xfs_is_cow_inode(ip))
stat->dio_offset_align = xfs_inode_alloc_unitsize(ip);
else
stat->dio_offset_align = stat->dio_read_offset_align;
}
static void
@ -658,7 +673,7 @@ xfs_vn_getattr(
stat->rdev = inode->i_rdev;
break;
case S_IFREG:
if (request_mask & STATX_DIOALIGN)
if (request_mask & (STATX_DIOALIGN | STATX_DIO_READ_ALIGN))
xfs_report_dioalign(ip, stat);
if (request_mask & STATX_WRITE_ATOMIC)
xfs_report_atomic_write(ip, stat);