mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-04-13 09:59:31 +00:00
Disable SLUB_TINY for build testing
... and don't error out so hard on missing module descriptions. Before commit6c6c1fc09d
("modpost: require a MODULE_DESCRIPTION()") we used to warn about missing module descriptions, but only when building with extra warnigns (ie 'W=1'). After that commit the warning became an unconditional hard error. And it turns out not all modules have been converted despite the claims to the contrary. As reported by Damian Tometzki, the slub KUnit test didn't have a module description, and apparently nobody ever really noticed. The reason nobody noticed seems to be that the slub KUnit tests get disabled by SLUB_TINY, which also ends up disabling a lot of other code, both in tests and in slub itself. And so anybody doing full build tests didn't actually see this failre. So let's disable SLUB_TINY for build-only tests, since it clearly ends up limiting build coverage. Also turn the missing module descriptions error back into a warning, but let's keep it around for non-'W=1' builds. Reported-by: Damian Tometzki <damian@riscv-rocks.de> Link: https://lore.kernel.org/all/01070196099fd059-e8463438-7b1b-4ec8-816d-173874be9966-000000@eu-central-1.amazonses.com/ Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Jeff Johnson <jeff.johnson@oss.qualcomm.com> Fixes:6c6c1fc09d
("modpost: require a MODULE_DESCRIPTION()") Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
16cd1c2657
commit
6f110a5e4f
2 changed files with 2 additions and 2 deletions
|
@ -201,7 +201,7 @@ config KVFREE_RCU_BATCHED
|
|||
|
||||
config SLUB_TINY
|
||||
bool "Configure for minimal memory footprint"
|
||||
depends on EXPERT
|
||||
depends on EXPERT && !COMPILE_TEST
|
||||
select SLAB_MERGE_DEFAULT
|
||||
help
|
||||
Configures the slab allocator in a way to achieve minimal memory
|
||||
|
|
|
@ -1603,7 +1603,7 @@ static void read_symbols(const char *modname)
|
|||
}
|
||||
|
||||
if (!get_modinfo(&info, "description"))
|
||||
error("missing MODULE_DESCRIPTION() in %s\n", modname);
|
||||
warn("missing MODULE_DESCRIPTION() in %s\n", modname);
|
||||
}
|
||||
|
||||
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
|
||||
|
|
Loading…
Add table
Reference in a new issue