public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

btrfs: use uuid_is_null() to verify if an uuid is empty

Browse source 
At btrfs_is_empty_uuid() we have our custom code to check if an uuid is
empty, however there a kernel uuid library that has a function named
uuid_is_null() which does the same and probably more efficient.

So change btrfs_is_empty_uuid() to use uuid_is_null(), which is almost
a directly replacement, it just wraps the necessary casting since our
uuid types are u8 arrays while the uuid kernel library uses the uuid_t
type, which is just a typedef of an u8 array of 16 elements as well.

Also since the function is now to trivial, make it a static inline
function in fs.h.

Suggested-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Filipe Manana 2024-12-17 12:00:39 +00:00 • committed by David Sterba
parent de9c8265b7
commit 6a2b3d7a36
2 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
fs/btrfs/fs.c
View file

@ -55,15 +55,6 @@ size_t __attribute_const__ btrfs_get_num_csums(void)
return ARRAY_SIZE(btrfs_csums); return ARRAY_SIZE(btrfs_csums);
} }
bool __pure btrfs_is_empty_uuid(const u8 *uuid)
{
for (int i = 0; i < BTRFS_UUID_SIZE; i++) {
if (uuid[i] != 0)
return false;
}
return true;
}
/* /*
* Start exclusive operation @type, return true on success. * Start exclusive operation @type, return true on success.
*/ */

5
fs/btrfs/fs.h
View file

@ -996,7 +996,10 @@ const char *btrfs_super_csum_name(u16 csum_type);
const char *btrfs_super_csum_driver(u16 csum_type); const char *btrfs_super_csum_driver(u16 csum_type);
size_t __attribute_const__ btrfs_get_num_csums(void); size_t __attribute_const__ btrfs_get_num_csums(void);
bool __pure btrfs_is_empty_uuid(const u8 *uuid); static inline bool btrfs_is_empty_uuid(const u8 *uuid)
{
return uuid_is_null((const uuid_t *)uuid);
}
/* Compatibility and incompatibility defines */ /* Compatibility and incompatibility defines */
void __btrfs_set_fs_incompat(struct btrfs_fs_info *fs_info, u64 flag, void __btrfs_set_fs_incompat(struct btrfs_fs_info *fs_info, u64 flag,