mirror of
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-08-05 16:54:27 +00:00
drm/pl111: Fix return value check in pl111_amba_probe()
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: bed41005e6
("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/20170521010152.6186-1-weiyj.lk@gmail.com
This commit is contained in:
parent
f90dee20b4
commit
665f37e7ee
1 changed files with 2 additions and 2 deletions
|
@ -200,9 +200,9 @@ static int pl111_amba_probe(struct amba_device *amba_dev,
|
||||||
drm->dev_private = priv;
|
drm->dev_private = priv;
|
||||||
|
|
||||||
priv->regs = devm_ioremap_resource(dev, &amba_dev->res);
|
priv->regs = devm_ioremap_resource(dev, &amba_dev->res);
|
||||||
if (!priv->regs) {
|
if (IS_ERR(priv->regs)) {
|
||||||
dev_err(dev, "%s failed mmio\n", __func__);
|
dev_err(dev, "%s failed mmio\n", __func__);
|
||||||
return -EINVAL;
|
return PTR_ERR(priv->regs);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* turn off interrupts before requesting the irq */
|
/* turn off interrupts before requesting the irq */
|
||||||
|
|
Loading…
Add table
Reference in a new issue