public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

sunrpc: change sp_nrthreads from atomic_t to unsigned int.

Browse source 
sp_nrthreads is only ever accessed under the service mutex
  nlmsvc_mutex nfs_callback_mutex nfsd_mutex
so these is no need for it to be an atomic_t.

The fact that all code using it is single-threaded means that we can
simplify svc_pool_victim and remove the temporary elevation of
sp_nrthreads.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This commit is contained in:
NeilBrown 2024-07-15 17:14:18 +10:00 • committed by Chuck Lever
parent 16ef80eedc
commit 60749cbe3d
4 changed files with 15 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/nfsd/nfsctl.c
View file

@ -1769,7 +1769,7 @@ int nfsd_nl_threads_get_doit(struct sk_buff *skb, struct genl_info *info)
struct svc_pool *sp = &nn->nfsd_serv->sv_pools[i]; struct svc_pool *sp = &nn->nfsd_serv->sv_pools[i];
err = nla_put_u32(skb, NFSD_A_SERVER_THREADS, err = nla_put_u32(skb, NFSD_A_SERVER_THREADS,
atomic_read(&sp->sp_nrthreads)); sp->sp_nrthreads);
if (err) if (err)
goto err_unlock; goto err_unlock;
} }

2
fs/nfsd/nfssvc.c
View file

@ -641,7 +641,7 @@ int nfsd_get_nrthreads(int n, int *nthreads, struct net *net)
if (serv) if (serv)
for (i = 0; i < serv->sv_nrpools && i < n; i++) for (i = 0; i < serv->sv_nrpools && i < n; i++)
nthreads[i] = atomic_read(&serv->sv_pools[i].sp_nrthreads); nthreads[i] = serv->sv_pools[i].sp_nrthreads;
return 0; return 0;
} }

4
include/linux/sunrpc/svc.h
View file

@ -33,9 +33,9 @@
* node traffic on multi-node NUMA NFS servers. * node traffic on multi-node NUMA NFS servers.
*/ */
struct svc_pool { struct svc_pool {
unsigned int sp_id; /* pool id; also node id on NUMA */ unsigned int sp_id; /* pool id; also node id on NUMA */
struct lwq sp_xprts; /* pending transports */ struct lwq sp_xprts; /* pending transports */
atomic_t sp_nrthreads; /* # of threads in pool */ unsigned int sp_nrthreads; /* # of threads in pool */
struct list_head sp_all_threads; /* all server threads */ struct list_head sp_all_threads; /* all server threads */
struct llist_head sp_idle_threads; /* idle server threads */ struct llist_head sp_idle_threads; /* idle server threads */

31
net/sunrpc/svc.c
View file

@ -725,7 +725,7 @@ svc_prepare_thread(struct svc_serv *serv, struct svc_pool *pool, int node)
serv->sv_nrthreads += 1; serv->sv_nrthreads += 1;
spin_unlock_bh(&serv->sv_lock); spin_unlock_bh(&serv->sv_lock);
atomic_inc(&pool->sp_nrthreads); pool->sp_nrthreads += 1;
/* Protected by whatever lock the service uses when calling /* Protected by whatever lock the service uses when calling
* svc_set_num_threads() * svc_set_num_threads()
@ -780,31 +780,22 @@ svc_pool_victim(struct svc_serv *serv, struct svc_pool *target_pool,
struct svc_pool *pool; struct svc_pool *pool;
unsigned int i; unsigned int i;
retry:
pool = target_pool; pool = target_pool;
if (pool != NULL) { if (!pool) {
if (atomic_inc_not_zero(&pool->sp_nrthreads))
goto found_pool;
return NULL;
} else {
for (i = 0; i < serv->sv_nrpools; i++) { for (i = 0; i < serv->sv_nrpools; i++) {
pool = &serv->sv_pools[--(*state) % serv->sv_nrpools]; pool = &serv->sv_pools[--(*state) % serv->sv_nrpools];
if (atomic_inc_not_zero(&pool->sp_nrthreads)) if (pool->sp_nrthreads)
goto found_pool; break;
} }
return NULL;
} }
found_pool: if (pool && pool->sp_nrthreads) {
set_bit(SP_VICTIM_REMAINS, &pool->sp_flags); set_bit(SP_VICTIM_REMAINS, &pool->sp_flags);
set_bit(SP_NEED_VICTIM, &pool->sp_flags); set_bit(SP_NEED_VICTIM, &pool->sp_flags);
if (!atomic_dec_and_test(&pool->sp_nrthreads))
return pool; return pool;
/* Nothing left in this pool any more */ }
clear_bit(SP_NEED_VICTIM, &pool->sp_flags); return NULL;
clear_bit(SP_VICTIM_REMAINS, &pool->sp_flags);
goto retry;
} }
static int static int
@ -883,7 +874,7 @@ svc_set_num_threads(struct svc_serv *serv, struct svc_pool *pool, int nrservs)
if (!pool) if (!pool)
nrservs -= serv->sv_nrthreads; nrservs -= serv->sv_nrthreads;
else else
nrservs -= atomic_read(&pool->sp_nrthreads); nrservs -= pool->sp_nrthreads;
if (nrservs > 0) if (nrservs > 0)
return svc_start_kthreads(serv, pool, nrservs); return svc_start_kthreads(serv, pool, nrservs);
@ -967,7 +958,7 @@ svc_exit_thread(struct svc_rqst *rqstp)
list_del_rcu(&rqstp->rq_all); list_del_rcu(&rqstp->rq_all);
atomic_dec(&pool->sp_nrthreads); pool->sp_nrthreads -= 1;
spin_lock_bh(&serv->sv_lock); spin_lock_bh(&serv->sv_lock);
serv->sv_nrthreads -= 1; serv->sv_nrthreads -= 1;