public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

gpio: ts4900: Fix comment formatting and grammar

Browse source 
The issues were pointed out after the prior commit was applied.

Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
This commit is contained in:
Kris Bahnsen 2022-03-11 10:19:58 -08:00 • committed by Bartosz Golaszewski
parent f443e374ae
commit 576892a84f
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/gpio/gpio-ts4900.c
View file

@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
{ {
struct ts4900_gpio_priv *priv = gpiochip_get_data(chip); struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
/* Only clear the OE bit here, requires a RMW. Prevents potential issue /*
* with OE and data getting to the physical pin at different times. * Only clear the OE bit here, requires a RMW. Prevents a potential issue
* with OE and DAT getting to the physical pin at different times.
*/ */
return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0); return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
} }
@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
unsigned int reg; unsigned int reg;
int ret; int ret;
/* If changing from an input to an output, we need to first set the /*
* proper data bit to what is requested and then set OE bit. This * If changing from an input to an output, we need to first set the
* prevents a glitch that can occur on the IO line * GPIO's DAT bit to what is requested and then set the OE bit. This
* prevents a glitch that can occur on the IO line.
*/ */
regmap_read(priv->regmap, offset, &reg); regmap_read(priv->regmap, offset, &reg);
if (!(reg & TS4900_GPIO_OE)) { if (!(reg & TS4900_GPIO_OE)) {