public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-11-01 09:13:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

firmware: turris-mox-rwtm: Initialize completion before mailbox

Browse source 
Initialize the completion before the mailbox channel is requested.

Fixes: 389711b374 ("firmware: Add Turris Mox rWTM firmware driver")
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This commit is contained in:
Marek Behún 2024-07-15 13:59:12 +02:00 • committed by Arnd Bergmann
parent 8467cfe821
commit 49e24c80d3
No known key found for this signature in database
GPG key ID: 60AB47FFC9095227
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/firmware/turris-mox-rwtm.c
View file

@ -499,6 +499,7 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rwtm); platform_set_drvdata(pdev, rwtm);
mutex_init(&rwtm->busy); mutex_init(&rwtm->busy);
init_completion(&rwtm->cmd_done);
rwtm->mbox_client.dev = dev; rwtm->mbox_client.dev = dev;
rwtm->mbox_client.rx_callback = mox_rwtm_rx_callback; rwtm->mbox_client.rx_callback = mox_rwtm_rx_callback;
@ -512,8 +513,6 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev)
goto remove_files; goto remove_files;
} }
init_completion(&rwtm->cmd_done);
ret = mox_get_board_info(rwtm); ret = mox_get_board_info(rwtm);
if (ret < 0) if (ret < 0)
dev_warn(dev, "Cannot read board information: %i\n", ret); dev_warn(dev, "Cannot read board information: %i\n", ret);