public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

btrfs: convert process_page_range() to use filemap_get_folios_contig()

Browse source 
Converted function to use folios throughout.  This is in preparation for
the removal of find_get_pages_contig().  Now also supports large folios.

Since we may receive more than nr_pages pages, nr_pages may underflow. 
Since nr_pages > 0 is equivalent to index <= end_index, we replaced it
with this check instead.

Also minor comment renaming for consistency in subpage.

Link: https://lkml.kernel.org/r/20220824004023.77310-5-vishal.moola@gmail.com
Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Acked-by: David Sterba <dsterb@suse.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Chris Mason <clm@fb.com>
Cc: David Sterba <dsterba@suse.com>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Vishal Moola (Oracle) 2022-08-23 17:40:20 -07:00 • committed by Andrew Morton
parent a75b81c3f6
commit 47d5541995
2 changed files with 18 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
fs/btrfs/subpage.c
View file

@ -337,7 +337,7 @@ bool btrfs_subpage_end_and_test_writer(const struct btrfs_fs_info *fs_info,
* *
* Even with 0 returned, the page still need extra check to make sure * Even with 0 returned, the page still need extra check to make sure
* it's really the correct page, as the caller is using * it's really the correct page, as the caller is using
* find_get_pages_contig(), which can race with page invalidating. * filemap_get_folios_contig(), which can race with page invalidating.
*/ */
int btrfs_page_start_writer_lock(const struct btrfs_fs_info *fs_info, int btrfs_page_start_writer_lock(const struct btrfs_fs_info *fs_info,
struct page *page, u64 start, u32 len) struct page *page, u64 start, u32 len)

32
fs/btrfs/tests/extent-io-tests.c
View file

@ -4,6 +4,7 @@
*/ */
#include <linux/pagemap.h> #include <linux/pagemap.h>
#include <linux/pagevec.h>
#include <linux/sched.h> #include <linux/sched.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/sizes.h> #include <linux/sizes.h>
@ -20,39 +21,40 @@ static noinline int process_page_range(struct inode *inode, u64 start, u64 end,
unsigned long flags) unsigned long flags)
{ {
int ret; int ret;
struct page *pages[16]; struct folio_batch fbatch;
unsigned long index = start >> PAGE_SHIFT; unsigned long index = start >> PAGE_SHIFT;
unsigned long end_index = end >> PAGE_SHIFT; unsigned long end_index = end >> PAGE_SHIFT;
unsigned long nr_pages = end_index - index + 1;
int i; int i;
int count = 0; int count = 0;
int loops = 0; int loops = 0;
while (nr_pages > 0) { folio_batch_init(&fbatch);
ret = find_get_pages_contig(inode->i_mapping, index,
min_t(unsigned long, nr_pages, while (index <= end_index) {
ARRAY_SIZE(pages)), pages); ret = filemap_get_folios_contig(inode->i_mapping, &index,
end_index, &fbatch);
for (i = 0; i < ret; i++) { for (i = 0; i < ret; i++) {
struct folio *folio = fbatch.folios[i];
if (flags & PROCESS_TEST_LOCKED && if (flags & PROCESS_TEST_LOCKED &&
!PageLocked(pages[i])) !folio_test_locked(folio))
count++; count++;
if (flags & PROCESS_UNLOCK && PageLocked(pages[i])) if (flags & PROCESS_UNLOCK && folio_test_locked(folio))
unlock_page(pages[i]); folio_unlock(folio);
put_page(pages[i]);
if (flags & PROCESS_RELEASE) if (flags & PROCESS_RELEASE)
put_page(pages[i]); folio_put(folio);
} }
nr_pages -= ret; folio_batch_release(&fbatch);
index += ret;
cond_resched(); cond_resched();
loops++; loops++;
if (loops > 100000) { if (loops > 100000) {
printk(KERN_ERR printk(KERN_ERR
"stuck in a loop, start %llu, end %llu, nr_pages %lu, ret %d\n", "stuck in a loop, start %llu, end %llu, ret %d\n",
start, end, nr_pages, ret); start, end, ret);
break; break;
} }
} }
return count; return count;
} }