public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

scsi: snic: Remove useless code in snic_dr_clean_pending_req()

Browse source 
Return error code directly to save space and be more clear.

Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20231020023326.43898-1-suhui@nfschina.com
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Su Hui 2023-10-20 10:33:27 +08:00 • committed by Martin K. Petersen
parent 82f52b2cd5
commit 44a31659ea
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/scsi/snic/snic_scsi.c
View file

@ -1850,7 +1850,7 @@ snic_dr_clean_pending_req(struct snic *snic, struct scsi_cmnd *lr_sc)
{ {
struct scsi_device *lr_sdev = lr_sc->device; struct scsi_device *lr_sdev = lr_sc->device;
u32 tag = 0; u32 tag = 0;
int ret = FAILED; int ret;
for (tag = 0; tag < snic->max_tag_id; tag++) { for (tag = 0; tag < snic->max_tag_id; tag++) {
if (tag == snic_cmd_tag(lr_sc)) if (tag == snic_cmd_tag(lr_sc))
@ -1859,7 +1859,6 @@ snic_dr_clean_pending_req(struct snic *snic, struct scsi_cmnd *lr_sc)
ret = snic_dr_clean_single_req(snic, tag, lr_sdev); ret = snic_dr_clean_single_req(snic, tag, lr_sdev);
if (ret) { if (ret) {
SNIC_HOST_ERR(snic->shost, "clean_err:tag = %d\n", tag); SNIC_HOST_ERR(snic->shost, "clean_err:tag = %d\n", tag);
goto clean_err; goto clean_err;
} }
} }
@ -1867,24 +1866,19 @@ snic_dr_clean_pending_req(struct snic *snic, struct scsi_cmnd *lr_sc)
schedule_timeout(msecs_to_jiffies(100)); schedule_timeout(msecs_to_jiffies(100));
/* Walk through all the cmds and check abts status. */ /* Walk through all the cmds and check abts status. */
if (snic_is_abts_pending(snic, lr_sc)) { if (snic_is_abts_pending(snic, lr_sc))
ret = FAILED;
goto clean_err; goto clean_err;
}
ret = 0;
SNIC_SCSI_DBG(snic->shost, "clean_pending_req: Success.\n"); SNIC_SCSI_DBG(snic->shost, "clean_pending_req: Success.\n");
return ret; return 0;
clean_err: clean_err:
ret = FAILED;
SNIC_HOST_ERR(snic->shost, SNIC_HOST_ERR(snic->shost,
"Failed to Clean Pending IOs on %s device.\n", "Failed to Clean Pending IOs on %s device.\n",
dev_name(&lr_sdev->sdev_gendev)); dev_name(&lr_sdev->sdev_gendev));
return ret; return FAILED;
} /* end of snic_dr_clean_pending_req */ } /* end of snic_dr_clean_pending_req */