public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

hwmon: (spd5118) Use generic parity calculation

Browse source 
Make use of the new generic helper for calculating the parity.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Link: https://lore.kernel.org/r/20250107090204.6593-3-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Wolfram Sang 2025-01-07 10:02:00 +01:00 • committed by Alexandre Belloni
parent c320592f3f
commit 32a8d362b5
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/hwmon/spd5118.c
View file

@ -291,12 +291,6 @@ static umode_t spd5118_is_visible(const void *_data, enum hwmon_sensor_types typ
} }
} }
static inline bool spd5118_parity8(u8 w)
{
w ^= w >> 4;
return (0x6996 >> (w & 0xf)) & 1;
}
/* /*
* Bank and vendor id are 8-bit fields with seven data bits and odd parity. * Bank and vendor id are 8-bit fields with seven data bits and odd parity.
* Vendor IDs 0 and 0x7f are invalid. * Vendor IDs 0 and 0x7f are invalid.
@ -304,7 +298,7 @@ static inline bool spd5118_parity8(u8 w)
*/ */
static bool spd5118_vendor_valid(u8 bank, u8 id) static bool spd5118_vendor_valid(u8 bank, u8 id)
{ {
if (!spd5118_parity8(bank) || !spd5118_parity8(id)) if (parity8(bank) == 0 || parity8(id) == 0)
return false; return false;
id &= 0x7f; id &= 0x7f;