public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

xfs: fix two memory leaks in xfs_attr_list.c error paths

Browse source 
This plugs 2 trivial leaks in xfs_attr_shortform_list and
xfs_attr3_leaf_list_int.

Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Mateusz Guzik 2016-03-02 09:51:09 +11:00 • committed by Dave Chinner
parent 36f90b0a2d
commit 2e83b79b2d
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
fs/xfs/xfs_attr_list.c
View file

@ -202,8 +202,10 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context)
sbp->namelen, sbp->namelen,
sbp->valuelen, sbp->valuelen,
&sbp->name[sbp->namelen]); &sbp->name[sbp->namelen]);
if (error) if (error) {
kmem_free(sbuf);
return error; return error;
}
if (context->seen_enough) if (context->seen_enough)
break; break;
cursor->offset++; cursor->offset++;
@ -454,14 +456,13 @@ xfs_attr3_leaf_list_int(
args.rmtblkcnt = xfs_attr3_rmt_blocks( args.rmtblkcnt = xfs_attr3_rmt_blocks(
args.dp->i_mount, valuelen); args.dp->i_mount, valuelen);
retval = xfs_attr_rmtval_get(&args); retval = xfs_attr_rmtval_get(&args);
if (retval) if (!retval)
return retval; retval = context->put_listent(context,
retval = context->put_listent(context, entry->flags,
entry->flags, name_rmt->name,
name_rmt->name, (int)name_rmt->namelen,
(int)name_rmt->namelen, valuelen,
valuelen, args.value);
args.value);
kmem_free(args.value); kmem_free(args.value);
} else { } else {
retval = context->put_listent(context, retval = context->put_listent(context,