public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-10-31 08:44:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

gpio-ich: Fix value returned by ichx_gpio_request

Browse source 
Per Documentation/gpio.txt, gpio_request callbacks should return 0 on
success or a negative value on error. So it is not clear what was
meant by letting ichx_gpio_request return 1 in some cases, nor how a
caller would interpret it.

Align the code with the comment above it and consider pins as
available by default.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Jean Delvare 2013-03-05 09:06:58 +01:00 • committed by Linus Walleij
parent a937536b86
commit 2ab3a749eb
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/gpio/gpio-ich.c
View file

@ -214,7 +214,7 @@ static int ichx_gpio_request(struct gpio_chip *chip, unsigned nr)
* If it can't be trusted, assume that the pin can be used as a GPIO. * If it can't be trusted, assume that the pin can be used as a GPIO.
*/ */
if (ichx_priv.desc->use_sel_ignore[nr / 32] & (1 << (nr & 0x1f))) if (ichx_priv.desc->use_sel_ignore[nr / 32] & (1 << (nr & 0x1f)))
return 1; return 0;
return ichx_read_bit(GPIO_USE_SEL, nr) ? 0 : -ENODEV; return ichx_read_bit(GPIO_USE_SEL, nr) ? 0 : -ENODEV;
} }