public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

gpio: lpc18xx: Make irq_chip immutable

Browse source 
Kernel warns about mutable irq_chips:
"not an immutable chip, please consider fixing!"

Constify lpc18xx_gpio_pin_ic, flag the irq_chip as IRQCHIP_IMMUTABLE,
add the new helper functions, and call the appropriate gpiolib functions.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250509-gpio-v1-3-639377c98288@nxp.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Peng Fan 2025-05-09 12:45:34 +08:00 • committed by Bartosz Golaszewski
parent a30be40bf1
commit 289e42df13
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/gpio/gpio-lpc18xx.c
View file

@ -42,6 +42,7 @@ struct lpc18xx_gpio_pin_ic {
void __iomem *base; void __iomem *base;
struct irq_domain *domain; struct irq_domain *domain;
struct raw_spinlock lock; struct raw_spinlock lock;
struct gpio_chip *gpio;
}; };
struct lpc18xx_gpio_chip { struct lpc18xx_gpio_chip {
@ -74,6 +75,7 @@ static void lpc18xx_gpio_pin_ic_mask(struct irq_data *d)
{ {
struct lpc18xx_gpio_pin_ic *ic = d->chip_data; struct lpc18xx_gpio_pin_ic *ic = d->chip_data;
u32 type = irqd_get_trigger_type(d); u32 type = irqd_get_trigger_type(d);
irq_hw_number_t hwirq = irqd_to_hwirq(d);
raw_spin_lock(&ic->lock); raw_spin_lock(&ic->lock);
@ -88,12 +90,17 @@ static void lpc18xx_gpio_pin_ic_mask(struct irq_data *d)
raw_spin_unlock(&ic->lock); raw_spin_unlock(&ic->lock);
irq_chip_mask_parent(d); irq_chip_mask_parent(d);
gpiochip_disable_irq(ic->gpio, hwirq);
} }
static void lpc18xx_gpio_pin_ic_unmask(struct irq_data *d) static void lpc18xx_gpio_pin_ic_unmask(struct irq_data *d)
{ {
struct lpc18xx_gpio_pin_ic *ic = d->chip_data; struct lpc18xx_gpio_pin_ic *ic = d->chip_data;
u32 type = irqd_get_trigger_type(d); u32 type = irqd_get_trigger_type(d);
irq_hw_number_t hwirq = irqd_to_hwirq(d);
gpiochip_enable_irq(ic->gpio, hwirq);
raw_spin_lock(&ic->lock); raw_spin_lock(&ic->lock);
@ -149,13 +156,14 @@ static int lpc18xx_gpio_pin_ic_set_type(struct irq_data *d, unsigned int type)
return 0; return 0;
} }
static struct irq_chip lpc18xx_gpio_pin_ic = { static const struct irq_chip lpc18xx_gpio_pin_ic = {
.name = "LPC18xx GPIO pin", .name = "LPC18xx GPIO pin",
.irq_mask = lpc18xx_gpio_pin_ic_mask, .irq_mask = lpc18xx_gpio_pin_ic_mask,
.irq_unmask = lpc18xx_gpio_pin_ic_unmask, .irq_unmask = lpc18xx_gpio_pin_ic_unmask,
.irq_eoi = lpc18xx_gpio_pin_ic_eoi, .irq_eoi = lpc18xx_gpio_pin_ic_eoi,
.irq_set_type = lpc18xx_gpio_pin_ic_set_type, .irq_set_type = lpc18xx_gpio_pin_ic_set_type,
.flags = IRQCHIP_SET_TYPE_MASKED, .flags = IRQCHIP_IMMUTABLE | IRQCHIP_SET_TYPE_MASKED,
GPIOCHIP_IRQ_RESOURCE_HELPERS,
}; };
static int lpc18xx_gpio_pin_ic_domain_alloc(struct irq_domain *domain, static int lpc18xx_gpio_pin_ic_domain_alloc(struct irq_domain *domain,
@ -251,6 +259,7 @@ static int lpc18xx_gpio_pin_ic_probe(struct lpc18xx_gpio_chip *gc)
goto free_iomap; goto free_iomap;
} }
ic->gpio = &gc->gpio;
gc->pin_ic = ic; gc->pin_ic = ic;
return 0; return 0;