public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-05-24 10:39:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

crypto: stm32/hash - Fix PM reference leak on stm32-hash.c

Browse source 
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Shixin Liu 2021-04-08 15:18:35 +08:00 • committed by Herbert Xu
parent cc987ae915
commit 1cb3ad7019
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/crypto/stm32/stm32-hash.c
View file

@ -813,7 +813,7 @@ static void stm32_hash_finish_req(struct ahash_request *req, int err)
static int stm32_hash_hw_init(struct stm32_hash_dev *hdev, static int stm32_hash_hw_init(struct stm32_hash_dev *hdev,
struct stm32_hash_request_ctx *rctx) struct stm32_hash_request_ctx *rctx)
{ {
pm_runtime_get_sync(hdev->dev); pm_runtime_resume_and_get(hdev->dev);
if (!(HASH_FLAGS_INIT & hdev->flags)) { if (!(HASH_FLAGS_INIT & hdev->flags)) {
stm32_hash_write(hdev, HASH_CR, HASH_CR_INIT); stm32_hash_write(hdev, HASH_CR, HASH_CR_INIT);
@ -962,7 +962,7 @@ static int stm32_hash_export(struct ahash_request *req, void *out)
u32 *preg; u32 *preg;
unsigned int i; unsigned int i;
pm_runtime_get_sync(hdev->dev); pm_runtime_resume_and_get(hdev->dev);
while ((stm32_hash_read(hdev, HASH_SR) & HASH_SR_BUSY)) while ((stm32_hash_read(hdev, HASH_SR) & HASH_SR_BUSY))
cpu_relax(); cpu_relax();
@ -1000,7 +1000,7 @@ static int stm32_hash_import(struct ahash_request *req, const void *in)
preg = rctx->hw_context; preg = rctx->hw_context;
pm_runtime_get_sync(hdev->dev); pm_runtime_resume_and_get(hdev->dev);
stm32_hash_write(hdev, HASH_IMR, *preg++); stm32_hash_write(hdev, HASH_IMR, *preg++);
stm32_hash_write(hdev, HASH_STR, *preg++); stm32_hash_write(hdev, HASH_STR, *preg++);
@ -1566,7 +1566,7 @@ static int stm32_hash_remove(struct platform_device *pdev)
if (!hdev) if (!hdev)
return -ENODEV; return -ENODEV;
ret = pm_runtime_get_sync(hdev->dev); ret = pm_runtime_resume_and_get(hdev->dev);
if (ret < 0) if (ret < 0)
return ret; return ret;