mirror of
				git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
				synced 2025-10-31 08:44:41 +00:00 
			
		
		
		
	rtc: ds1511: let the core handle invalid time
Returning a valid time when the time is invalid is a bad practice, because then userspace is not able to react on the information. Also, it doesn't make sense to return epoch because it is already the default time. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
		
							parent
							
								
									347876ad47
								
							
						
					
					
						commit
						1c90d9f1c8
					
				
					 1 changed files with 0 additions and 4 deletions
				
			
		|  | @ -277,10 +277,6 @@ static int ds1511_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm) | |||
| 
 | ||||
| 	rtc_tm->tm_mon--; | ||||
| 
 | ||||
| 	if (rtc_valid_tm(rtc_tm) < 0) { | ||||
| 		dev_err(dev, "retrieved date/time is not valid.\n"); | ||||
| 		rtc_time_to_tm(0, rtc_tm); | ||||
| 	} | ||||
| 	return 0; | ||||
| } | ||||
| 
 | ||||
|  |  | |||
		Loading…
	
	Add table
		
		Reference in a new issue
	
	 Alexandre Belloni
						Alexandre Belloni