public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-03 15:55:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

backlight: mbp_nvidia_bl - Add a debug switch

Browse source 
This patch adds a debug switch to enable (little) diagnostic
output, to help to trace down the remaining problems.

Signed-off-by: Mario Schwalbe <schwalbe@inf.tu-dresden.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
This commit is contained in:
Mario Schwalbe 2009-01-11 00:19:31 +00:00 • committed by Richard Purdie
parent c78a628849
commit 1a468ba10c
1 changed files with 31 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
drivers/video/backlight/mbp_nvidia_bl.c
View file

@ -36,6 +36,11 @@ struct dmi_match_data {
struct backlight_ops backlight_ops; struct backlight_ops backlight_ops;
}; };
/* Module parameters. */
static int debug;
module_param_named(debug, debug, int, 0644);
MODULE_PARM_DESC(debug, "Set to one to enable debugging messages.");
/* /*
* Implementation for MacBooks with Intel chipset. * Implementation for MacBooks with Intel chipset.
*/ */
@ -43,6 +48,10 @@ static int intel_chipset_send_intensity(struct backlight_device *bd)
{ {
int intensity = bd->props.brightness; int intensity = bd->props.brightness;
if (debug)
printk(KERN_DEBUG "mbp_nvidia_bl: setting brightness to %d\n",
intensity);
outb(0x04 | (intensity << 4), 0xb3); outb(0x04 | (intensity << 4), 0xb3);
outb(0xbf, 0xb2); outb(0xbf, 0xb2);
return 0; return 0;
@ -50,9 +59,17 @@ static int intel_chipset_send_intensity(struct backlight_device *bd)
static int intel_chipset_get_intensity(struct backlight_device *bd) static int intel_chipset_get_intensity(struct backlight_device *bd)
{ {
int intensity;
outb(0x03, 0xb3); outb(0x03, 0xb3);
outb(0xbf, 0xb2); outb(0xbf, 0xb2);
return inb(0xb3) >> 4; intensity = inb(0xb3) >> 4;
if (debug)
printk(KERN_DEBUG "mbp_nvidia_bl: read brightness of %d\n",
intensity);
return intensity;
} }
static const struct dmi_match_data intel_chipset_data = { static const struct dmi_match_data intel_chipset_data = {
@ -72,6 +89,10 @@ static int nvidia_chipset_send_intensity(struct backlight_device *bd)
{ {
int intensity = bd->props.brightness; int intensity = bd->props.brightness;
if (debug)
printk(KERN_DEBUG "mbp_nvidia_bl: setting brightness to %d\n",
intensity);
outb(0x04 | (intensity << 4), 0x52f); outb(0x04 | (intensity << 4), 0x52f);
outb(0xbf, 0x52e); outb(0xbf, 0x52e);
return 0; return 0;
@ -79,9 +100,17 @@ static int nvidia_chipset_send_intensity(struct backlight_device *bd)
static int nvidia_chipset_get_intensity(struct backlight_device *bd) static int nvidia_chipset_get_intensity(struct backlight_device *bd)
{ {
int intensity;
outb(0x03, 0x52f); outb(0x03, 0x52f);
outb(0xbf, 0x52e); outb(0xbf, 0x52e);
return inb(0x52f) >> 4; intensity = inb(0x52f) >> 4;
if (debug)
printk(KERN_DEBUG "mbp_nvidia_bl: read brightness of %d\n",
intensity);
return intensity;
} }
static const struct dmi_match_data nvidia_chipset_data = { static const struct dmi_match_data nvidia_chipset_data = {