public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

cdx: Unlock on error path in rescan_store()

Browse source 
We added locking to this function but these two error paths were
accidentally overlooked.

Fixes: f0af816834 ("cdx: Introduce lock to protect controller ops")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
Link: https://lore.kernel.org/r/a7994b47-6f78-4e2c-a30a-ee5995d428ec@moroto.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2024-01-02 16:11:16 +03:00 • committed by Greg Kroah-Hartman
parent 87736ae12e
commit 1960932eef
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/cdx/cdx.c
View file

@ -607,7 +607,8 @@ static ssize_t rescan_store(const struct bus_type *bus,
pd = of_find_device_by_node(np); pd = of_find_device_by_node(np);
if (!pd) { if (!pd) {
of_node_put(np); of_node_put(np);
return -EINVAL; count = -EINVAL;
goto unlock;
} }
cdx = platform_get_drvdata(pd); cdx = platform_get_drvdata(pd);
@ -617,6 +618,7 @@ static ssize_t rescan_store(const struct bus_type *bus,
put_device(&pd->dev); put_device(&pd->dev);
} }
unlock:
mutex_unlock(&cdx_controller_lock); mutex_unlock(&cdx_controller_lock);
return count; return count;