public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-04-13 09:59:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

PM: runtime: Convert pm_runtime_blocked() to static inline

Browse source 
The comment in pm_runtime_blocked() is acutally wrong: power.last_status
is not a bit field.  Its data type is an enum and so one can reasonably
assume that partial updates of it will not be observed.

Accordingly, pm_runtime_blocked() can be converted to a static inline
function and the related locking overhead can be eliminated, so long
as it is only used in system suspend/resume code paths because
power.last_status is not expected to be updated concurrently while
that code is running.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Link: https://patch.msgid.link/1923449.tdWV9SEqCh@rjwysocki.net
This commit is contained in:
Rafael J. Wysocki 2025-02-27 11:47:33 +01:00
parent cb88c229fe
commit 1476bb20ee
2 changed files with 11 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
drivers/base/power/runtime.c
View file

@ -1560,23 +1560,6 @@ out:
}
EXPORT_SYMBOL_GPL(pm_runtime_enable);
bool pm_runtime_blocked(struct device *dev)
{
bool ret;
/*
* dev->power.last_status is a bit field, so in case it is updated via
* RMW, read it under the spin lock.
*/
spin_lock_irq(&dev->power.lock);
ret = dev->power.last_status == RPM_BLOCKED;
spin_unlock_irq(&dev->power.lock);
return ret;
}
static void pm_runtime_disable_action(void *data)
{
pm_runtime_dont_use_autosuspend(data);

12
include/linux/pm_runtime.h
View file

@ -82,7 +82,6 @@ extern bool pm_runtime_block_if_disabled(struct device *dev);
extern void pm_runtime_unblock(struct device *dev);
extern void pm_runtime_enable(struct device *dev);
extern void __pm_runtime_disable(struct device *dev, bool check_resume);
extern bool pm_runtime_blocked(struct device *dev);
extern void pm_runtime_allow(struct device *dev);
extern void pm_runtime_forbid(struct device *dev);
extern void pm_runtime_no_callbacks(struct device *dev);
@ -200,6 +199,17 @@ static inline bool pm_runtime_enabled(struct device *dev)
return !dev->power.disable_depth;
}
/**
* pm_runtime_blocked - Check if runtime PM enabling is blocked.
* @dev: Target device.
*
* Do not call this function outside system suspend/resume code paths.
*/
static inline bool pm_runtime_blocked(struct device *dev)
{
return dev->power.last_status == RPM_BLOCKED;
}
/**
* pm_runtime_has_no_callbacks - Check if runtime PM callbacks may be present.
* @dev: Target device.