public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rtc: m48t59: use generic nvmem

Browse source 
Instead of adding a binary sysfs attribute from the driver (which suffers
from a race condition as the attribute appears after the device), use the
core to register an nvmem device.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Alexandre Belloni 2018-02-12 23:47:40 +01:00
parent affb842b84
commit 0ff3565d88
1 changed files with 26 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
drivers/rtc/rtc-m48t59.c
View file

@ -334,16 +334,16 @@ static const struct rtc_class_ops m48t02_rtc_ops = {
.set_time = m48t59_rtc_set_time, .set_time = m48t59_rtc_set_time,
}; };
static ssize_t m48t59_nvram_read(struct file *filp, struct kobject *kobj, static int m48t59_nvram_read(void *priv, unsigned int offset, void *val,
struct bin_attribute *bin_attr, size_t size)
char *buf, loff_t pos, size_t size)
{ {
struct device *dev = container_of(kobj, struct device, kobj); struct platform_device *pdev = priv;
struct platform_device *pdev = to_platform_device(dev); struct device *dev = &pdev->dev;
struct m48t59_plat_data *pdata = dev_get_platdata(&pdev->dev); struct m48t59_plat_data *pdata = dev_get_platdata(&pdev->dev);
struct m48t59_private *m48t59 = platform_get_drvdata(pdev); struct m48t59_private *m48t59 = platform_get_drvdata(pdev);
ssize_t cnt = 0; ssize_t cnt = 0;
unsigned long flags; unsigned long flags;
u8 *buf = val;
spin_lock_irqsave(&m48t59->lock, flags); spin_lock_irqsave(&m48t59->lock, flags);
@ -352,19 +352,19 @@ static ssize_t m48t59_nvram_read(struct file *filp, struct kobject *kobj,
spin_unlock_irqrestore(&m48t59->lock, flags); spin_unlock_irqrestore(&m48t59->lock, flags);
return cnt; return 0;
} }
static ssize_t m48t59_nvram_write(struct file *filp, struct kobject *kobj, static int m48t59_nvram_write(void *priv, unsigned int offset, void *val,
struct bin_attribute *bin_attr, size_t size)
char *buf, loff_t pos, size_t size)
{ {
struct device *dev = container_of(kobj, struct device, kobj); struct platform_device *pdev = priv;
struct platform_device *pdev = to_platform_device(dev); struct device *dev = &pdev->dev;
struct m48t59_plat_data *pdata = dev_get_platdata(&pdev->dev); struct m48t59_plat_data *pdata = dev_get_platdata(&pdev->dev);
struct m48t59_private *m48t59 = platform_get_drvdata(pdev); struct m48t59_private *m48t59 = platform_get_drvdata(pdev);
ssize_t cnt = 0; ssize_t cnt = 0;
unsigned long flags; unsigned long flags;
u8 *buf = val;
spin_lock_irqsave(&m48t59->lock, flags); spin_lock_irqsave(&m48t59->lock, flags);
@ -373,18 +373,9 @@ static ssize_t m48t59_nvram_write(struct file *filp, struct kobject *kobj,
spin_unlock_irqrestore(&m48t59->lock, flags); spin_unlock_irqrestore(&m48t59->lock, flags);
return cnt; return 0;
} }
static struct bin_attribute m48t59_nvram_attr = {
.attr = {
.name = "nvram",
.mode = S_IRUGO | S_IWUSR,
},
.read = m48t59_nvram_read,
.write = m48t59_nvram_write,
};
static int m48t59_rtc_probe(struct platform_device *pdev) static int m48t59_rtc_probe(struct platform_device *pdev)
{ {
struct m48t59_plat_data *pdata = dev_get_platdata(&pdev->dev); struct m48t59_plat_data *pdata = dev_get_platdata(&pdev->dev);
@ -393,6 +384,14 @@ static int m48t59_rtc_probe(struct platform_device *pdev)
int ret = -ENOMEM; int ret = -ENOMEM;
char *name; char *name;
const struct rtc_class_ops *ops; const struct rtc_class_ops *ops;
struct nvmem_config nvmem_cfg = {
.name = "m48t59-",
.word_size = 1,
.stride = 1,
.reg_read = m48t59_nvram_read,
.reg_write = m48t59_nvram_write,
.priv = pdev,
};
/* This chip could be memory-mapped or I/O-mapped */ /* This chip could be memory-mapped or I/O-mapped */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@ -484,24 +483,18 @@ static int m48t59_rtc_probe(struct platform_device *pdev)
if (IS_ERR(m48t59->rtc)) if (IS_ERR(m48t59->rtc))
return PTR_ERR(m48t59->rtc); return PTR_ERR(m48t59->rtc);
m48t59->rtc->nvram_old_abi = true;
m48t59->rtc->ops = ops; m48t59->rtc->ops = ops;
nvmem_cfg.size = pdata->offset;
ret = rtc_nvmem_register(m48t59->rtc, &nvmem_cfg);
if (ret)
return ret;
ret = rtc_register_device(m48t59->rtc); ret = rtc_register_device(m48t59->rtc);
if (ret) if (ret)
return ret; return ret;
m48t59_nvram_attr.size = pdata->offset;
ret = sysfs_create_bin_file(&pdev->dev.kobj, &m48t59_nvram_attr);
if (ret)
return ret;
return 0;
}
static int m48t59_rtc_remove(struct platform_device *pdev)
{
sysfs_remove_bin_file(&pdev->dev.kobj, &m48t59_nvram_attr);
return 0; return 0;
} }
@ -513,7 +506,6 @@ static struct platform_driver m48t59_rtc_driver = {
.name = "rtc-m48t59", .name = "rtc-m48t59",
}, },
.probe = m48t59_rtc_probe, .probe = m48t59_rtc_probe,
.remove = m48t59_rtc_remove,
}; };
module_platform_driver(m48t59_rtc_driver); module_platform_driver(m48t59_rtc_driver);