mirror of
				git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
				synced 2025-10-31 08:44:41 +00:00 
			
		
		
		
	GFS2: Prevent recovery before the local journal is set
This patch uses a completion to prevent dlm's recovery process from referencing and trying to recover a journal before a journal has been opened. Signed-off-by: Bob Peterson <rpeterso@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
This commit is contained in:
		
							parent
							
								
									9dd868e1c0
								
							
						
					
					
						commit
						0e48e055a7
					
				
					 3 changed files with 8 additions and 0 deletions
				
			
		|  | @ -728,6 +728,8 @@ struct gfs2_sbd { | |||
| 	struct gfs2_holder sd_sc_gh; | ||||
| 	struct gfs2_holder sd_qc_gh; | ||||
| 
 | ||||
| 	struct completion sd_journal_ready; | ||||
| 
 | ||||
| 	/* Daemon stuff */ | ||||
| 
 | ||||
| 	struct task_struct *sd_logd_process; | ||||
|  |  | |||
|  | @ -94,6 +94,7 @@ static struct gfs2_sbd *init_sbd(struct super_block *sb) | |||
| 	INIT_LIST_HEAD(&sdp->sd_jindex_list); | ||||
| 	spin_lock_init(&sdp->sd_jindex_spin); | ||||
| 	mutex_init(&sdp->sd_jindex_mutex); | ||||
| 	init_completion(&sdp->sd_journal_ready); | ||||
| 
 | ||||
| 	INIT_LIST_HEAD(&sdp->sd_quota_list); | ||||
| 	mutex_init(&sdp->sd_quota_mutex); | ||||
|  | @ -796,6 +797,7 @@ static int init_inodes(struct gfs2_sbd *sdp, int undo) | |||
| 		goto fail_qinode; | ||||
| 
 | ||||
| 	error = init_journal(sdp, undo); | ||||
| 	complete_all(&sdp->sd_journal_ready); | ||||
| 	if (error) | ||||
| 		goto fail; | ||||
| 
 | ||||
|  | @ -1212,6 +1214,7 @@ fail_sb: | |||
| fail_locking: | ||||
| 	init_locking(sdp, &mount_gh, UNDO); | ||||
| fail_lm: | ||||
| 	complete_all(&sdp->sd_journal_ready); | ||||
| 	gfs2_gl_hash_clear(sdp); | ||||
| 	gfs2_lm_unmount(sdp); | ||||
| fail_debug: | ||||
|  |  | |||
|  | @ -407,6 +407,9 @@ int gfs2_recover_set(struct gfs2_sbd *sdp, unsigned jid) | |||
| 	struct gfs2_jdesc *jd; | ||||
| 	int rv; | ||||
| 
 | ||||
| 	/* Wait for our primary journal to be initialized */ | ||||
| 	wait_for_completion(&sdp->sd_journal_ready); | ||||
| 
 | ||||
| 	spin_lock(&sdp->sd_jindex_spin); | ||||
| 	rv = -EBUSY; | ||||
| 	if (sdp->sd_jdesc->jd_jid == jid) | ||||
|  |  | |||
		Loading…
	
	Add table
		
		Reference in a new issue
	
	 Bob Peterson
						Bob Peterson