public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-09-18 22:14:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fbdev/controlfb: Initialize fb_ops to fbdev I/O-memory helpers

Browse source 
Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.

No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-12-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann 2023-09-27 09:26:44 +02:00
parent d47f9775c1
commit 076b705df1
2 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/video/fbdev/Kconfig
View file

@ -309,9 +309,7 @@ config FB_OF
config FB_CONTROL config FB_CONTROL
bool "Apple \"control\" display support" bool "Apple \"control\" display support"
depends on (FB = y) && ((PPC_PMAC && PPC32) || COMPILE_TEST) depends on (FB = y) && ((PPC_PMAC && PPC32) || COMPILE_TEST)
select FB_CFB_FILLRECT select FB_IOMEM_HELPERS
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
select FB_MACMODES select FB_MACMODES
help help
This driver supports a frame buffer for the graphics adapter in the This driver supports a frame buffer for the graphics adapter in the

5
drivers/video/fbdev/controlfb.c
View file

@ -755,15 +755,14 @@ static int controlfb_mmap(struct fb_info *info,
static const struct fb_ops controlfb_ops = { static const struct fb_ops controlfb_ops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
__FB_DEFAULT_IOMEM_OPS_RDWR,
.fb_check_var = controlfb_check_var, .fb_check_var = controlfb_check_var,
.fb_set_par = controlfb_set_par, .fb_set_par = controlfb_set_par,
.fb_setcolreg = controlfb_setcolreg, .fb_setcolreg = controlfb_setcolreg,
.fb_pan_display = controlfb_pan_display, .fb_pan_display = controlfb_pan_display,
.fb_blank = controlfb_blank, .fb_blank = controlfb_blank,
__FB_DEFAULT_IOMEM_OPS_DRAW,
.fb_mmap = controlfb_mmap, .fb_mmap = controlfb_mmap,
.fb_fillrect = cfb_fillrect,
.fb_copyarea = cfb_copyarea,
.fb_imageblit = cfb_imageblit,
}; };
/* /*