public-mirrors/linux
1
0
Fork 0
mirror of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2025-08-05 16:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

spi: mxs: fix reference leak in mxs_spi_probe

Browse source 
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in mxs_spi_probe, so we should fix it.

Fixes: b7969caf41 ("spi: mxs: implement runtime pm")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201106012421.95420-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Zhang Qilong 2020-11-06 09:24:21 +08:00 • committed by Mark Brown
parent 6e3dbfcb3c
commit 03fc41afaa
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/spi/spi-mxs.c
View file

@ -607,6 +607,7 @@ static int mxs_spi_probe(struct platform_device *pdev)
ret = pm_runtime_get_sync(ssp->dev); ret = pm_runtime_get_sync(ssp->dev);
if (ret < 0) { if (ret < 0) {
pm_runtime_put_noidle(ssp->dev);
dev_err(ssp->dev, "runtime_get_sync failed\n"); dev_err(ssp->dev, "runtime_get_sync failed\n");
goto out_pm_runtime_disable; goto out_pm_runtime_disable;
} }