2018-03-22 10:08:48 -07:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2018-04-26 08:08:09 -07:00
|
|
|
/* Copyright(c) 2013 - 2018 Intel Corporation. */
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2018-09-14 17:37:48 -07:00
|
|
|
#include "iavf.h"
|
2018-09-14 17:37:56 -07:00
|
|
|
#include "iavf_prototype.h"
|
2018-09-14 17:37:48 -07:00
|
|
|
#include "iavf_client.h"
|
2013-12-21 06:13:01 +00:00
|
|
|
|
|
|
|
/* busy wait delay in msec */
|
2018-09-14 17:37:46 -07:00
|
|
|
#define IAVF_BUSY_WAIT_DELAY 10
|
|
|
|
#define IAVF_BUSY_WAIT_COUNT 50
|
2013-12-21 06:13:01 +00:00
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_send_pf_msg
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
* @op: virtual channel opcode
|
|
|
|
* @msg: pointer to message buffer
|
|
|
|
* @len: message length
|
|
|
|
*
|
|
|
|
* Send message to PF and print status if failure.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
static int iavf_send_pf_msg(struct iavf_adapter *adapter,
|
|
|
|
enum virtchnl_ops op, u8 *msg, u16 len)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2018-09-14 17:37:52 -07:00
|
|
|
struct iavf_hw *hw = &adapter->hw;
|
2019-04-17 15:17:30 -07:00
|
|
|
enum iavf_status err;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
if (adapter->flags & IAVF_FLAG_PF_COMMS_FAILED)
|
i40evf: refactor reset handling
Respond better to a VF reset event. When a reset is signaled by the
PF, or detected by the watchdog task, prevent the watchdog from
processing admin queue requests, and schedule the reset task.
In the reset task, wait first for the reset to start, then for it to
complete, then reinit the driver.
If the reset never appears to complete after a long, long time (>10
seconds is possible depending on what's going on with the PF driver),
then set a flag to indicate that PF communications have failed.
If this flag is set, check for the reset to complete in the watchdog,
and attempt to do a full reinitialization of the driver from scratch.
With these changes the VF driver correctly handles a PF reset event
while running on bare metal, or in a VM.
Also update copyrights.
Change-ID: I93513efd0b50523a8345e7f6a33a5e4f8a2a5996
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-02-13 03:48:53 -08:00
|
|
|
return 0; /* nothing to see here, move along */
|
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
err = iavf_aq_send_msg_to_pf(hw, op, 0, msg, len, NULL);
|
2013-12-21 06:13:01 +00:00
|
|
|
if (err)
|
2017-07-14 09:27:01 -04:00
|
|
|
dev_dbg(&adapter->pdev->dev, "Unable to send opcode %d to PF, err %s, aq_err %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
op, iavf_stat_str(hw, err),
|
|
|
|
iavf_aq_str(hw, hw->aq.asq_last_status));
|
2013-12-21 06:13:01 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_send_api_ver
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Send API version admin queue message to the PF. The reply is not checked
|
|
|
|
* in this function. Returns 0 if the message was successfully
|
2019-04-17 15:17:37 -07:00
|
|
|
* sent, or one of the IAVF_ADMIN_QUEUE_ERROR_ statuses if not.
|
2013-12-21 06:13:01 +00:00
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
int iavf_send_api_ver(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_version_info vvi;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
vvi.major = VIRTCHNL_VERSION_MAJOR;
|
|
|
|
vvi.minor = VIRTCHNL_VERSION_MINOR;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
return iavf_send_pf_msg(adapter, VIRTCHNL_OP_VERSION, (u8 *)&vvi,
|
|
|
|
sizeof(vvi));
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_verify_api_ver
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Compare API versions with the PF. Must be called after admin queue is
|
2014-06-05 00:09:17 +00:00
|
|
|
* initialized. Returns 0 if API versions match, -EIO if they do not,
|
2019-04-17 15:17:33 -07:00
|
|
|
* IAVF_ERR_ADMIN_QUEUE_NO_WORK if the admin queue is empty, and any errors
|
2014-06-05 00:09:17 +00:00
|
|
|
* from the firmware are propagated.
|
2013-12-21 06:13:01 +00:00
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
int iavf_verify_api_ver(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_version_info *pf_vvi;
|
2018-09-14 17:37:52 -07:00
|
|
|
struct iavf_hw *hw = &adapter->hw;
|
2019-04-17 15:17:32 -07:00
|
|
|
struct iavf_arq_event_info event;
|
2017-05-11 11:23:11 -07:00
|
|
|
enum virtchnl_ops op;
|
2019-04-17 15:17:30 -07:00
|
|
|
enum iavf_status err;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
event.buf_len = IAVF_MAX_AQ_BUF_SIZE;
|
2014-11-11 20:02:19 +00:00
|
|
|
event.msg_buf = kzalloc(event.buf_len, GFP_KERNEL);
|
2013-12-21 06:13:01 +00:00
|
|
|
if (!event.msg_buf) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2014-10-25 03:24:33 +00:00
|
|
|
while (1) {
|
2018-09-14 17:37:46 -07:00
|
|
|
err = iavf_clean_arq_element(hw, &event, NULL);
|
|
|
|
/* When the AQ is empty, iavf_clean_arq_element will return
|
2014-10-25 03:24:33 +00:00
|
|
|
* nonzero and this loop will terminate.
|
|
|
|
*/
|
|
|
|
if (err)
|
|
|
|
goto out_alloc;
|
|
|
|
op =
|
2017-05-11 11:23:11 -07:00
|
|
|
(enum virtchnl_ops)le32_to_cpu(event.desc.cookie_high);
|
|
|
|
if (op == VIRTCHNL_OP_VERSION)
|
2014-10-25 03:24:33 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2019-04-17 15:17:30 -07:00
|
|
|
err = (enum iavf_status)le32_to_cpu(event.desc.cookie_low);
|
2014-06-05 00:09:17 +00:00
|
|
|
if (err)
|
2013-12-21 06:13:01 +00:00
|
|
|
goto out_alloc;
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (op != VIRTCHNL_OP_VERSION) {
|
2014-06-05 00:09:17 +00:00
|
|
|
dev_info(&adapter->pdev->dev, "Invalid reply type %d from PF\n",
|
2014-10-25 03:24:33 +00:00
|
|
|
op);
|
2013-12-21 06:13:01 +00:00
|
|
|
err = -EIO;
|
|
|
|
goto out_alloc;
|
|
|
|
}
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
pf_vvi = (struct virtchnl_version_info *)event.msg_buf;
|
2015-06-04 16:23:59 -04:00
|
|
|
adapter->pf_version = *pf_vvi;
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if ((pf_vvi->major > VIRTCHNL_VERSION_MAJOR) ||
|
|
|
|
((pf_vvi->major == VIRTCHNL_VERSION_MAJOR) &&
|
|
|
|
(pf_vvi->minor > VIRTCHNL_VERSION_MINOR)))
|
2013-12-21 06:13:01 +00:00
|
|
|
err = -EIO;
|
|
|
|
|
|
|
|
out_alloc:
|
|
|
|
kfree(event.msg_buf);
|
|
|
|
out:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_send_vf_config_msg
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Send VF configuration request admin queue message to the PF. The reply
|
|
|
|
* is not checked in this function. Returns 0 if the message was
|
2019-04-17 15:17:37 -07:00
|
|
|
* successfully sent, or one of the IAVF_ADMIN_QUEUE_ERROR_ statuses if not.
|
2013-12-21 06:13:01 +00:00
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
int iavf_send_vf_config_msg(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
i40evf: handle big resets
The most common type of reset that the VF will encounter is a PF reset
that cascades down into a VF reset for each VF. In this case, the VF
will always be assigned the same VSI and recovery is fairly simple.
However, in the case of 'bigger' resets, such as a Core or EMP reset,
when the device is reinitialized, it's probable that the VF will NOT get
the same VSI. When this happens, the VF will not be able to recover, as
it will continue to request resources for its original VSI.
Add an extra state to the admin queue state machine so that the driver
can re-request its configuration information at runtime. During reset
recovery, set this bit in the aq_required field, and fetch the (possibly
new) configuration information before attempting to bring the driver
back up. Since the driver doesn't know what kind of reset it has
encountered, this step is done even for a PF reset, but it doesn't hurt
anything - it just gets the same VSI back.
Change-ID: I915d59ffb40375215117362f4ac7a37811aba748
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2015-06-04 16:23:58 -04:00
|
|
|
u32 caps;
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
caps = VIRTCHNL_VF_OFFLOAD_L2 |
|
|
|
|
VIRTCHNL_VF_OFFLOAD_RSS_PF |
|
|
|
|
VIRTCHNL_VF_OFFLOAD_RSS_AQ |
|
|
|
|
VIRTCHNL_VF_OFFLOAD_RSS_REG |
|
|
|
|
VIRTCHNL_VF_OFFLOAD_VLAN |
|
|
|
|
VIRTCHNL_VF_OFFLOAD_WB_ON_ITR |
|
|
|
|
VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2 |
|
|
|
|
VIRTCHNL_VF_OFFLOAD_ENCAP |
|
2021-11-29 16:16:00 -08:00
|
|
|
VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
|
2017-08-22 06:57:50 -04:00
|
|
|
VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM |
|
2018-01-23 08:50:57 -08:00
|
|
|
VIRTCHNL_VF_OFFLOAD_REQ_QUEUES |
|
2020-06-05 10:09:43 -07:00
|
|
|
VIRTCHNL_VF_OFFLOAD_ADQ |
|
2021-03-02 10:12:13 -08:00
|
|
|
VIRTCHNL_VF_OFFLOAD_USO |
|
2021-03-09 11:08:11 +08:00
|
|
|
VIRTCHNL_VF_OFFLOAD_FDIR_PF |
|
2021-04-13 08:48:41 +08:00
|
|
|
VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF |
|
2020-06-05 10:09:43 -07:00
|
|
|
VIRTCHNL_VF_CAP_ADV_LINK_SPEED;
|
2017-05-11 11:23:11 -07:00
|
|
|
|
|
|
|
adapter->current_op = VIRTCHNL_OP_GET_VF_RESOURCES;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_GET_CONFIG;
|
i40evf: handle big resets
The most common type of reset that the VF will encounter is a PF reset
that cascades down into a VF reset for each VF. In this case, the VF
will always be assigned the same VSI and recovery is fairly simple.
However, in the case of 'bigger' resets, such as a Core or EMP reset,
when the device is reinitialized, it's probable that the VF will NOT get
the same VSI. When this happens, the VF will not be able to recover, as
it will continue to request resources for its original VSI.
Add an extra state to the admin queue state machine so that the driver
can re-request its configuration information at runtime. During reset
recovery, set this bit in the aq_required field, and fetch the (possibly
new) configuration information before attempting to bring the driver
back up. Since the driver doesn't know what kind of reset it has
encountered, this step is done even for a PF reset, but it doesn't hurt
anything - it just gets the same VSI back.
Change-ID: I915d59ffb40375215117362f4ac7a37811aba748
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2015-06-04 16:23:58 -04:00
|
|
|
if (PF_IS_V11(adapter))
|
2018-09-14 17:37:47 -07:00
|
|
|
return iavf_send_pf_msg(adapter, VIRTCHNL_OP_GET_VF_RESOURCES,
|
|
|
|
(u8 *)&caps, sizeof(caps));
|
i40evf: handle big resets
The most common type of reset that the VF will encounter is a PF reset
that cascades down into a VF reset for each VF. In this case, the VF
will always be assigned the same VSI and recovery is fairly simple.
However, in the case of 'bigger' resets, such as a Core or EMP reset,
when the device is reinitialized, it's probable that the VF will NOT get
the same VSI. When this happens, the VF will not be able to recover, as
it will continue to request resources for its original VSI.
Add an extra state to the admin queue state machine so that the driver
can re-request its configuration information at runtime. During reset
recovery, set this bit in the aq_required field, and fetch the (possibly
new) configuration information before attempting to bring the driver
back up. Since the driver doesn't know what kind of reset it has
encountered, this step is done even for a PF reset, but it doesn't hurt
anything - it just gets the same VSI back.
Change-ID: I915d59ffb40375215117362f4ac7a37811aba748
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2015-06-04 16:23:58 -04:00
|
|
|
else
|
2018-09-14 17:37:47 -07:00
|
|
|
return iavf_send_pf_msg(adapter, VIRTCHNL_OP_GET_VF_RESOURCES,
|
|
|
|
NULL, 0);
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
2021-11-29 16:16:00 -08:00
|
|
|
int iavf_send_vf_offload_vlan_v2_msg(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_GET_OFFLOAD_VLAN_V2_CAPS;
|
|
|
|
|
|
|
|
if (!VLAN_V2_ALLOWED(adapter))
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
|
|
|
|
adapter->current_op = VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS;
|
|
|
|
|
|
|
|
return iavf_send_pf_msg(adapter, VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS,
|
|
|
|
NULL, 0);
|
|
|
|
}
|
|
|
|
|
2018-08-20 08:12:29 -07:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_validate_num_queues
|
2018-08-20 08:12:29 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Validate that the number of queues the PF has sent in
|
|
|
|
* VIRTCHNL_OP_GET_VF_RESOURCES is not larger than the VF can handle.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
static void iavf_validate_num_queues(struct iavf_adapter *adapter)
|
2018-08-20 08:12:29 -07:00
|
|
|
{
|
2018-09-14 17:37:46 -07:00
|
|
|
if (adapter->vf_res->num_queue_pairs > IAVF_MAX_REQ_QUEUES) {
|
2018-08-20 08:12:29 -07:00
|
|
|
struct virtchnl_vsi_resource *vsi_res;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
dev_info(&adapter->pdev->dev, "Received %d queues, but can only have a max of %d\n",
|
|
|
|
adapter->vf_res->num_queue_pairs,
|
2018-09-14 17:37:46 -07:00
|
|
|
IAVF_MAX_REQ_QUEUES);
|
2018-08-20 08:12:29 -07:00
|
|
|
dev_info(&adapter->pdev->dev, "Fixing by reducing queues to %d\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
IAVF_MAX_REQ_QUEUES);
|
|
|
|
adapter->vf_res->num_queue_pairs = IAVF_MAX_REQ_QUEUES;
|
2018-08-20 08:12:29 -07:00
|
|
|
for (i = 0; i < adapter->vf_res->num_vsis; i++) {
|
|
|
|
vsi_res = &adapter->vf_res->vsi_res[i];
|
2018-09-14 17:37:46 -07:00
|
|
|
vsi_res->num_queue_pairs = IAVF_MAX_REQ_QUEUES;
|
2018-08-20 08:12:29 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_get_vf_config
|
2018-04-20 01:41:33 -07:00
|
|
|
* @adapter: private adapter structure
|
2013-12-21 06:13:01 +00:00
|
|
|
*
|
|
|
|
* Get VF configuration from PF and populate hw structure. Must be called after
|
|
|
|
* admin queue is initialized. Busy waits until response is received from PF,
|
|
|
|
* with maximum timeout. Response from PF is returned in the buffer for further
|
|
|
|
* processing by the caller.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
int iavf_get_vf_config(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2018-09-14 17:37:52 -07:00
|
|
|
struct iavf_hw *hw = &adapter->hw;
|
2019-04-17 15:17:32 -07:00
|
|
|
struct iavf_arq_event_info event;
|
2017-05-11 11:23:11 -07:00
|
|
|
enum virtchnl_ops op;
|
2019-04-17 15:17:30 -07:00
|
|
|
enum iavf_status err;
|
2014-10-25 03:24:33 +00:00
|
|
|
u16 len;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
len = sizeof(struct virtchnl_vf_resource) +
|
2018-09-14 17:37:55 -07:00
|
|
|
IAVF_MAX_VF_VSI * sizeof(struct virtchnl_vsi_resource);
|
2014-11-11 20:02:19 +00:00
|
|
|
event.buf_len = len;
|
|
|
|
event.msg_buf = kzalloc(event.buf_len, GFP_KERNEL);
|
2013-12-21 06:13:01 +00:00
|
|
|
if (!event.msg_buf) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2014-10-25 03:24:33 +00:00
|
|
|
while (1) {
|
2018-09-14 17:37:46 -07:00
|
|
|
/* When the AQ is empty, iavf_clean_arq_element will return
|
2014-10-25 03:24:33 +00:00
|
|
|
* nonzero and this loop will terminate.
|
|
|
|
*/
|
2018-09-14 17:37:46 -07:00
|
|
|
err = iavf_clean_arq_element(hw, &event, NULL);
|
2014-10-25 03:24:33 +00:00
|
|
|
if (err)
|
|
|
|
goto out_alloc;
|
|
|
|
op =
|
2017-05-11 11:23:11 -07:00
|
|
|
(enum virtchnl_ops)le32_to_cpu(event.desc.cookie_high);
|
|
|
|
if (op == VIRTCHNL_OP_GET_VF_RESOURCES)
|
2014-10-25 03:24:33 +00:00
|
|
|
break;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
2019-04-17 15:17:30 -07:00
|
|
|
err = (enum iavf_status)le32_to_cpu(event.desc.cookie_low);
|
2014-11-11 20:02:19 +00:00
|
|
|
memcpy(adapter->vf_res, event.msg_buf, min(event.msg_len, len));
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2018-08-20 08:12:29 -07:00
|
|
|
/* some PFs send more queues than we should have so validate that
|
|
|
|
* we aren't getting too many queues
|
|
|
|
*/
|
|
|
|
if (!err)
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_validate_num_queues(adapter);
|
|
|
|
iavf_vf_parse_hw_config(hw, adapter->vf_res);
|
2013-12-21 06:13:01 +00:00
|
|
|
out_alloc:
|
|
|
|
kfree(event.msg_buf);
|
|
|
|
out:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2021-11-29 16:16:00 -08:00
|
|
|
int iavf_get_vf_vlan_v2_caps(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct iavf_hw *hw = &adapter->hw;
|
|
|
|
struct iavf_arq_event_info event;
|
|
|
|
enum virtchnl_ops op;
|
|
|
|
enum iavf_status err;
|
|
|
|
u16 len;
|
|
|
|
|
|
|
|
len = sizeof(struct virtchnl_vlan_caps);
|
|
|
|
event.buf_len = len;
|
|
|
|
event.msg_buf = kzalloc(event.buf_len, GFP_KERNEL);
|
|
|
|
if (!event.msg_buf) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
while (1) {
|
|
|
|
/* When the AQ is empty, iavf_clean_arq_element will return
|
|
|
|
* nonzero and this loop will terminate.
|
|
|
|
*/
|
|
|
|
err = iavf_clean_arq_element(hw, &event, NULL);
|
|
|
|
if (err)
|
|
|
|
goto out_alloc;
|
|
|
|
op = (enum virtchnl_ops)le32_to_cpu(event.desc.cookie_high);
|
|
|
|
if (op == VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = (enum iavf_status)le32_to_cpu(event.desc.cookie_low);
|
|
|
|
if (err)
|
|
|
|
goto out_alloc;
|
|
|
|
|
|
|
|
memcpy(&adapter->vlan_v2_caps, event.msg_buf, min(event.msg_len, len));
|
|
|
|
out_alloc:
|
|
|
|
kfree(event.msg_buf);
|
|
|
|
out:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_configure_queues
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF set up our (previously allocated) queues.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_configure_queues(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_vsi_queue_config_info *vqci;
|
|
|
|
struct virtchnl_queue_pair_info *vqpi;
|
2014-10-25 03:24:34 +00:00
|
|
|
int pairs = adapter->num_active_queues;
|
2019-06-14 16:23:20 -07:00
|
|
|
int i, max_frame = IAVF_MAX_RXBUFFER;
|
|
|
|
size_t len;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot configure queues, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_CONFIG_VSI_QUEUES;
|
2019-06-14 16:23:20 -07:00
|
|
|
len = struct_size(vqci, qpair, pairs);
|
2015-11-06 15:26:04 -08:00
|
|
|
vqci = kzalloc(len, GFP_KERNEL);
|
2014-05-10 04:49:04 +00:00
|
|
|
if (!vqci)
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
2014-05-10 04:49:04 +00:00
|
|
|
|
2017-03-14 10:15:27 -07:00
|
|
|
/* Limit maximum frame size when jumbo frames is not enabled */
|
2018-09-14 17:37:46 -07:00
|
|
|
if (!(adapter->flags & IAVF_FLAG_LEGACY_RX) &&
|
2017-03-14 10:15:27 -07:00
|
|
|
(adapter->netdev->mtu <= ETH_DATA_LEN))
|
2018-09-14 17:37:55 -07:00
|
|
|
max_frame = IAVF_RXBUFFER_1536 - NET_IP_ALIGN;
|
2017-03-14 10:15:27 -07:00
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
vqci->vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
vqci->num_queue_pairs = pairs;
|
|
|
|
vqpi = vqci->qpair;
|
|
|
|
/* Size check is not needed here - HW max is 16 queue pairs, and we
|
|
|
|
* can fit info for 31 of them into the AQ buffer before it overflows.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < pairs; i++) {
|
|
|
|
vqpi->txq.vsi_id = vqci->vsi_id;
|
|
|
|
vqpi->txq.queue_id = i;
|
2015-10-26 19:44:40 -04:00
|
|
|
vqpi->txq.ring_len = adapter->tx_rings[i].count;
|
|
|
|
vqpi->txq.dma_ring_addr = adapter->tx_rings[i].dma;
|
2013-12-21 06:13:01 +00:00
|
|
|
vqpi->rxq.vsi_id = vqci->vsi_id;
|
|
|
|
vqpi->rxq.queue_id = i;
|
2015-10-26 19:44:40 -04:00
|
|
|
vqpi->rxq.ring_len = adapter->rx_rings[i].count;
|
|
|
|
vqpi->rxq.dma_ring_addr = adapter->rx_rings[i].dma;
|
2017-03-14 10:15:27 -07:00
|
|
|
vqpi->rxq.max_pkt_size = max_frame;
|
|
|
|
vqpi->rxq.databuffer_size =
|
|
|
|
ALIGN(adapter->rx_rings[i].rx_buf_len,
|
2018-09-14 17:37:55 -07:00
|
|
|
BIT_ULL(IAVF_RXQ_CTX_DBUFF_SHIFT));
|
2013-12-21 06:13:01 +00:00
|
|
|
vqpi++;
|
|
|
|
}
|
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_CONFIGURE_QUEUES;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_CONFIG_VSI_QUEUES,
|
|
|
|
(u8 *)vqci, len);
|
2013-12-21 06:13:01 +00:00
|
|
|
kfree(vqci);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_enable_queues
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF enable all of our queues.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_enable_queues(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_queue_select vqs;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot enable queues, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_ENABLE_QUEUES;
|
2013-12-21 06:13:01 +00:00
|
|
|
vqs.vsi_id = adapter->vsi_res->vsi_id;
|
2015-06-04 16:24:02 -04:00
|
|
|
vqs.tx_queues = BIT(adapter->num_active_queues) - 1;
|
2013-12-21 06:13:01 +00:00
|
|
|
vqs.rx_queues = vqs.tx_queues;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ENABLE_QUEUES;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ENABLE_QUEUES,
|
|
|
|
(u8 *)&vqs, sizeof(vqs));
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_disable_queues
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF disable all of our queues.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_disable_queues(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_queue_select vqs;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot disable queues, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_DISABLE_QUEUES;
|
2013-12-21 06:13:01 +00:00
|
|
|
vqs.vsi_id = adapter->vsi_res->vsi_id;
|
2015-06-04 16:24:02 -04:00
|
|
|
vqs.tx_queues = BIT(adapter->num_active_queues) - 1;
|
2013-12-21 06:13:01 +00:00
|
|
|
vqs.rx_queues = vqs.tx_queues;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DISABLE_QUEUES;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DISABLE_QUEUES,
|
|
|
|
(u8 *)&vqs, sizeof(vqs));
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_map_queues
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF map queues to interrupt vectors. Misc causes, including
|
|
|
|
* admin queue, are always mapped to vector 0.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_map_queues(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_irq_map_info *vimi;
|
2017-12-29 08:51:20 -05:00
|
|
|
struct virtchnl_vector_map *vecmap;
|
2018-09-14 17:37:55 -07:00
|
|
|
struct iavf_q_vector *q_vector;
|
2019-06-14 16:23:20 -07:00
|
|
|
int v_idx, q_vectors;
|
|
|
|
size_t len;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot map queues to vectors, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_CONFIG_IRQ_MAP;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
|
|
|
q_vectors = adapter->num_msix_vectors - NONQ_VECS;
|
|
|
|
|
2019-06-14 16:23:20 -07:00
|
|
|
len = struct_size(vimi, vecmap, adapter->num_msix_vectors);
|
2015-11-06 15:26:04 -08:00
|
|
|
vimi = kzalloc(len, GFP_KERNEL);
|
2014-05-10 04:49:04 +00:00
|
|
|
if (!vimi)
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
vimi->num_vectors = adapter->num_msix_vectors;
|
|
|
|
/* Queue vectors first */
|
|
|
|
for (v_idx = 0; v_idx < q_vectors; v_idx++) {
|
2017-12-29 08:51:20 -05:00
|
|
|
q_vector = &adapter->q_vectors[v_idx];
|
|
|
|
vecmap = &vimi->vecmap[v_idx];
|
|
|
|
|
|
|
|
vecmap->vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
vecmap->vector_id = v_idx + NONQ_VECS;
|
|
|
|
vecmap->txq_map = q_vector->ring_mask;
|
|
|
|
vecmap->rxq_map = q_vector->ring_mask;
|
2018-09-14 17:37:55 -07:00
|
|
|
vecmap->rxitr_idx = IAVF_RX_ITR;
|
|
|
|
vecmap->txitr_idx = IAVF_TX_ITR;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
/* Misc vector last - this is only for AdminQ messages */
|
2017-12-29 08:51:20 -05:00
|
|
|
vecmap = &vimi->vecmap[v_idx];
|
|
|
|
vecmap->vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
vecmap->vector_id = 0;
|
|
|
|
vecmap->txq_map = 0;
|
|
|
|
vecmap->rxq_map = 0;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_MAP_VECTORS;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_CONFIG_IRQ_MAP,
|
|
|
|
(u8 *)vimi, len);
|
2013-12-21 06:13:01 +00:00
|
|
|
kfree(vimi);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_add_ether_addrs
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF add one or more addresses to our filters.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_add_ether_addrs(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_ether_addr_list *veal;
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_mac_filter *f;
|
2019-06-14 16:23:20 -07:00
|
|
|
int i = 0, count = 0;
|
2015-10-21 19:47:12 -04:00
|
|
|
bool more = false;
|
2019-06-14 16:23:20 -07:00
|
|
|
size_t len;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot add filters, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-10-27 11:06:50 -04:00
|
|
|
|
|
|
|
spin_lock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
list_for_each_entry(f, &adapter->mac_filter_list, list) {
|
|
|
|
if (f->add)
|
|
|
|
count++;
|
|
|
|
}
|
|
|
|
if (!count) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_MAC_FILTER;
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_ADD_ETH_ADDR;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2019-06-14 16:23:20 -07:00
|
|
|
len = struct_size(veal, list, count);
|
2018-09-14 17:37:46 -07:00
|
|
|
if (len > IAVF_MAX_AQ_BUF_SIZE) {
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_warn(&adapter->pdev->dev, "Too many add MAC changes in one request\n");
|
2018-09-14 17:37:46 -07:00
|
|
|
count = (IAVF_MAX_AQ_BUF_SIZE -
|
2017-05-11 11:23:11 -07:00
|
|
|
sizeof(struct virtchnl_ether_addr_list)) /
|
|
|
|
sizeof(struct virtchnl_ether_addr);
|
2019-06-14 16:23:20 -07:00
|
|
|
len = struct_size(veal, list, count);
|
2015-10-21 19:47:12 -04:00
|
|
|
more = true;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
2018-01-12 02:27:13 +00:00
|
|
|
veal = kzalloc(len, GFP_ATOMIC);
|
2017-10-27 11:06:50 -04:00
|
|
|
if (!veal) {
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
2017-10-27 11:06:50 -04:00
|
|
|
}
|
2014-05-10 04:49:04 +00:00
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
veal->vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
veal->num_elements = count;
|
|
|
|
list_for_each_entry(f, &adapter->mac_filter_list, list) {
|
|
|
|
if (f->add) {
|
2014-05-22 06:32:02 +00:00
|
|
|
ether_addr_copy(veal->list[i].addr, f->macaddr);
|
2013-12-21 06:13:01 +00:00
|
|
|
i++;
|
|
|
|
f->add = false;
|
2016-05-16 10:26:36 -07:00
|
|
|
if (i == count)
|
|
|
|
break;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
}
|
2015-10-21 19:47:12 -04:00
|
|
|
if (!more)
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_MAC_FILTER;
|
2017-10-27 11:06:50 -04:00
|
|
|
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
2018-09-14 17:37:47 -07:00
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ADD_ETH_ADDR, (u8 *)veal, len);
|
2013-12-21 06:13:01 +00:00
|
|
|
kfree(veal);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_del_ether_addrs
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF remove one or more addresses from our filters.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_del_ether_addrs(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_ether_addr_list *veal;
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_mac_filter *f, *ftmp;
|
2019-06-14 16:23:20 -07:00
|
|
|
int i = 0, count = 0;
|
2015-10-21 19:47:12 -04:00
|
|
|
bool more = false;
|
2019-06-14 16:23:20 -07:00
|
|
|
size_t len;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot remove filters, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-10-27 11:06:50 -04:00
|
|
|
|
|
|
|
spin_lock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
list_for_each_entry(f, &adapter->mac_filter_list, list) {
|
|
|
|
if (f->remove)
|
|
|
|
count++;
|
|
|
|
}
|
|
|
|
if (!count) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_MAC_FILTER;
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_DEL_ETH_ADDR;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2019-06-14 16:23:20 -07:00
|
|
|
len = struct_size(veal, list, count);
|
2018-09-14 17:37:46 -07:00
|
|
|
if (len > IAVF_MAX_AQ_BUF_SIZE) {
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_warn(&adapter->pdev->dev, "Too many delete MAC changes in one request\n");
|
2018-09-14 17:37:46 -07:00
|
|
|
count = (IAVF_MAX_AQ_BUF_SIZE -
|
2017-05-11 11:23:11 -07:00
|
|
|
sizeof(struct virtchnl_ether_addr_list)) /
|
|
|
|
sizeof(struct virtchnl_ether_addr);
|
2019-06-14 16:23:20 -07:00
|
|
|
len = struct_size(veal, list, count);
|
2015-10-21 19:47:12 -04:00
|
|
|
more = true;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
2018-01-12 02:27:13 +00:00
|
|
|
veal = kzalloc(len, GFP_ATOMIC);
|
2017-10-27 11:06:50 -04:00
|
|
|
if (!veal) {
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
2017-10-27 11:06:50 -04:00
|
|
|
}
|
2014-05-10 04:49:04 +00:00
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
veal->vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
veal->num_elements = count;
|
|
|
|
list_for_each_entry_safe(f, ftmp, &adapter->mac_filter_list, list) {
|
|
|
|
if (f->remove) {
|
2014-05-22 06:32:02 +00:00
|
|
|
ether_addr_copy(veal->list[i].addr, f->macaddr);
|
2013-12-21 06:13:01 +00:00
|
|
|
i++;
|
|
|
|
list_del(&f->list);
|
|
|
|
kfree(f);
|
2016-05-16 10:26:36 -07:00
|
|
|
if (i == count)
|
|
|
|
break;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
}
|
2015-10-21 19:47:12 -04:00
|
|
|
if (!more)
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_MAC_FILTER;
|
2017-10-27 11:06:50 -04:00
|
|
|
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
2018-09-14 17:37:47 -07:00
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DEL_ETH_ADDR, (u8 *)veal, len);
|
2013-12-21 06:13:01 +00:00
|
|
|
kfree(veal);
|
|
|
|
}
|
|
|
|
|
2021-08-18 10:42:17 -07:00
|
|
|
/**
|
|
|
|
* iavf_mac_add_ok
|
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Submit list of filters based on PF response.
|
|
|
|
**/
|
|
|
|
static void iavf_mac_add_ok(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct iavf_mac_filter *f, *ftmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
list_for_each_entry_safe(f, ftmp, &adapter->mac_filter_list, list) {
|
|
|
|
f->is_new_mac = false;
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_mac_add_reject
|
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Remove filters from list based on PF response.
|
|
|
|
**/
|
|
|
|
static void iavf_mac_add_reject(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct net_device *netdev = adapter->netdev;
|
|
|
|
struct iavf_mac_filter *f, *ftmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
list_for_each_entry_safe(f, ftmp, &adapter->mac_filter_list, list) {
|
|
|
|
if (f->remove && ether_addr_equal(f->macaddr, netdev->dev_addr))
|
|
|
|
f->remove = false;
|
|
|
|
|
|
|
|
if (f->is_new_mac) {
|
|
|
|
list_del(&f->list);
|
|
|
|
kfree(f);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
}
|
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_add_vlans
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF add one or more VLAN filters to our VSI.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_add_vlans(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
|
|
|
int len, i = 0, count = 0;
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_vlan_filter *f;
|
2015-10-21 19:47:12 -04:00
|
|
|
bool more = false;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot add VLANs, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_lock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
list_for_each_entry(f, &adapter->vlan_filter_list, list) {
|
|
|
|
if (f->add)
|
|
|
|
count++;
|
|
|
|
}
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
if (!count || !VLAN_FILTERING_ALLOWED(adapter)) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_VLAN_FILTER;
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
if (VLAN_ALLOWED(adapter)) {
|
|
|
|
struct virtchnl_vlan_filter_list *vvfl;
|
|
|
|
|
|
|
|
adapter->current_op = VIRTCHNL_OP_ADD_VLAN;
|
|
|
|
|
|
|
|
len = sizeof(*vvfl) + (count * sizeof(u16));
|
|
|
|
if (len > IAVF_MAX_AQ_BUF_SIZE) {
|
|
|
|
dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
|
|
|
|
count = (IAVF_MAX_AQ_BUF_SIZE - sizeof(*vvfl)) /
|
|
|
|
sizeof(u16);
|
|
|
|
len = sizeof(*vvfl) + (count * sizeof(u16));
|
|
|
|
more = true;
|
|
|
|
}
|
|
|
|
vvfl = kzalloc(len, GFP_ATOMIC);
|
|
|
|
if (!vvfl) {
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
vvfl->vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
vvfl->num_elements = count;
|
|
|
|
list_for_each_entry(f, &adapter->vlan_filter_list, list) {
|
|
|
|
if (f->add) {
|
|
|
|
vvfl->vlan_id[i] = f->vlan.vid;
|
|
|
|
i++;
|
|
|
|
f->add = false;
|
|
|
|
if (i == count)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!more)
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_VLAN_FILTER;
|
|
|
|
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2014-05-10 04:49:04 +00:00
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ADD_VLAN, (u8 *)vvfl, len);
|
|
|
|
kfree(vvfl);
|
|
|
|
} else {
|
|
|
|
struct virtchnl_vlan_filter_list_v2 *vvfl_v2;
|
|
|
|
|
|
|
|
adapter->current_op = VIRTCHNL_OP_ADD_VLAN_V2;
|
|
|
|
|
|
|
|
len = sizeof(*vvfl_v2) + ((count - 1) *
|
|
|
|
sizeof(struct virtchnl_vlan_filter));
|
|
|
|
if (len > IAVF_MAX_AQ_BUF_SIZE) {
|
|
|
|
dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
|
|
|
|
count = (IAVF_MAX_AQ_BUF_SIZE - sizeof(*vvfl_v2)) /
|
|
|
|
sizeof(struct virtchnl_vlan_filter);
|
|
|
|
len = sizeof(*vvfl_v2) +
|
|
|
|
((count - 1) *
|
|
|
|
sizeof(struct virtchnl_vlan_filter));
|
|
|
|
more = true;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
2017-10-27 11:06:50 -04:00
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
vvfl_v2 = kzalloc(len, GFP_ATOMIC);
|
|
|
|
if (!vvfl_v2) {
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
return;
|
|
|
|
}
|
2017-10-27 11:06:50 -04:00
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
vvfl_v2->vport_id = adapter->vsi_res->vsi_id;
|
|
|
|
vvfl_v2->num_elements = count;
|
|
|
|
list_for_each_entry(f, &adapter->vlan_filter_list, list) {
|
|
|
|
if (f->add) {
|
|
|
|
struct virtchnl_vlan_supported_caps *filtering_support =
|
|
|
|
&adapter->vlan_v2_caps.filtering.filtering_support;
|
|
|
|
struct virtchnl_vlan *vlan;
|
|
|
|
|
|
|
|
/* give priority over outer if it's enabled */
|
|
|
|
if (filtering_support->outer)
|
|
|
|
vlan = &vvfl_v2->filters[i].outer;
|
|
|
|
else
|
|
|
|
vlan = &vvfl_v2->filters[i].inner;
|
|
|
|
|
|
|
|
vlan->tci = f->vlan.vid;
|
|
|
|
vlan->tpid = f->vlan.tpid;
|
|
|
|
|
|
|
|
i++;
|
|
|
|
f->add = false;
|
|
|
|
if (i == count)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!more)
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_VLAN_FILTER;
|
|
|
|
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ADD_VLAN_V2,
|
|
|
|
(u8 *)vvfl_v2, len);
|
|
|
|
kfree(vvfl_v2);
|
|
|
|
}
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_del_vlans
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF remove one or more VLAN filters from our VSI.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_del_vlans(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_vlan_filter *f, *ftmp;
|
2013-12-21 06:13:01 +00:00
|
|
|
int len, i = 0, count = 0;
|
2015-10-21 19:47:12 -04:00
|
|
|
bool more = false;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot remove VLANs, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_lock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
iavf: Fix VLAN feature flags after VFR
When a VF goes through a reset, it's possible for the VF's feature set
to change. For example it may lose the VIRTCHNL_VF_OFFLOAD_VLAN
capability after VF reset. Unfortunately, the driver doesn't correctly
deal with this situation and errors are seen from downing/upping the
interface and/or moving the interface in/out of a network namespace.
When setting the interface down/up we see the following errors after the
VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from the VF:
ice 0000:51:00.1: VF 1 failed opcode 12, retval: -64 iavf 0000:51:09.1:
Failed to add VLAN filter, error IAVF_NOT_SUPPORTED ice 0000:51:00.1: VF
1 failed opcode 13, retval: -64 iavf 0000:51:09.1: Failed to delete VLAN
filter, error IAVF_NOT_SUPPORTED
These add/delete errors are happening because the VLAN filters are
tracked internally to the driver and regardless of the VLAN_ALLOWED()
setting the driver tries to delete/re-add them over virtchnl.
Fix the delete failure by making sure to delete any VLAN filter tracking
in the driver when a removal request is made, while preventing the
virtchnl request. This makes it so the driver's VLAN list is up to date
and the errors are
Fix the add failure by making sure the check for VLAN_ALLOWED() during
reset is done after the VF receives its capability list from the PF via
VIRTCHNL_OP_GET_VF_RESOURCES. If VLAN functionality is not allowed, then
prevent requesting re-adding the filters over virtchnl.
When moving the interface into a network namespace we see the following
errors after the VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from
the VF:
iavf 0000:51:09.1 enp81s0f1v1: NIC Link is Up Speed is 25 Gbps Full Duplex
iavf 0000:51:09.1 temp_27: renamed from enp81s0f1v1
iavf 0000:51:09.1 mgmt: renamed from temp_27
iavf 0000:51:09.1 dev27: set_features() failed (-22); wanted 0x020190001fd54833, left 0x020190001fd54bb3
These errors are happening because we aren't correctly updating the
netdev capabilities and dealing with ndo_fix_features() and
ndo_set_features() correctly.
Fix this by only reporting errors in the driver's ndo_set_features()
callback when VIRTCHNL_VF_OFFLOAD_VLAN is not allowed and any attempt to
enable the VLAN features is made. Also, make sure to disable VLAN
insertion, filtering, and stripping since the VIRTCHNL_VF_OFFLOAD_VLAN
flag applies to all of them and not just VLAN stripping.
Also, after we process the capabilities in the VF reset path, make sure
to call netdev_update_features() in case the capabilities have changed
in order to update the netdev's feature set to match the VF's actual
capabilities.
Lastly, make sure to always report success on VLAN filter delete when
VIRTCHNL_VF_OFFLOAD_VLAN is not supported. The changed flow in
iavf_del_vlans() allows the stack to delete previosly existing VLAN
filters even if VLAN filtering is not allowed. This makes it so the VLAN
filter list is up to date.
Fixes: 8774370d268f ("i40e/i40evf: support for VF VLAN tag stripping control")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-05 09:20:25 -07:00
|
|
|
list_for_each_entry_safe(f, ftmp, &adapter->vlan_filter_list, list) {
|
|
|
|
/* since VLAN capabilities are not allowed, we dont want to send
|
|
|
|
* a VLAN delete request because it will most likely fail and
|
|
|
|
* create unnecessary errors/noise, so just free the VLAN
|
|
|
|
* filters marked for removal to enable bailing out before
|
|
|
|
* sending a virtchnl message
|
|
|
|
*/
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
if (f->remove && !VLAN_FILTERING_ALLOWED(adapter)) {
|
iavf: Fix VLAN feature flags after VFR
When a VF goes through a reset, it's possible for the VF's feature set
to change. For example it may lose the VIRTCHNL_VF_OFFLOAD_VLAN
capability after VF reset. Unfortunately, the driver doesn't correctly
deal with this situation and errors are seen from downing/upping the
interface and/or moving the interface in/out of a network namespace.
When setting the interface down/up we see the following errors after the
VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from the VF:
ice 0000:51:00.1: VF 1 failed opcode 12, retval: -64 iavf 0000:51:09.1:
Failed to add VLAN filter, error IAVF_NOT_SUPPORTED ice 0000:51:00.1: VF
1 failed opcode 13, retval: -64 iavf 0000:51:09.1: Failed to delete VLAN
filter, error IAVF_NOT_SUPPORTED
These add/delete errors are happening because the VLAN filters are
tracked internally to the driver and regardless of the VLAN_ALLOWED()
setting the driver tries to delete/re-add them over virtchnl.
Fix the delete failure by making sure to delete any VLAN filter tracking
in the driver when a removal request is made, while preventing the
virtchnl request. This makes it so the driver's VLAN list is up to date
and the errors are
Fix the add failure by making sure the check for VLAN_ALLOWED() during
reset is done after the VF receives its capability list from the PF via
VIRTCHNL_OP_GET_VF_RESOURCES. If VLAN functionality is not allowed, then
prevent requesting re-adding the filters over virtchnl.
When moving the interface into a network namespace we see the following
errors after the VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from
the VF:
iavf 0000:51:09.1 enp81s0f1v1: NIC Link is Up Speed is 25 Gbps Full Duplex
iavf 0000:51:09.1 temp_27: renamed from enp81s0f1v1
iavf 0000:51:09.1 mgmt: renamed from temp_27
iavf 0000:51:09.1 dev27: set_features() failed (-22); wanted 0x020190001fd54833, left 0x020190001fd54bb3
These errors are happening because we aren't correctly updating the
netdev capabilities and dealing with ndo_fix_features() and
ndo_set_features() correctly.
Fix this by only reporting errors in the driver's ndo_set_features()
callback when VIRTCHNL_VF_OFFLOAD_VLAN is not allowed and any attempt to
enable the VLAN features is made. Also, make sure to disable VLAN
insertion, filtering, and stripping since the VIRTCHNL_VF_OFFLOAD_VLAN
flag applies to all of them and not just VLAN stripping.
Also, after we process the capabilities in the VF reset path, make sure
to call netdev_update_features() in case the capabilities have changed
in order to update the netdev's feature set to match the VF's actual
capabilities.
Lastly, make sure to always report success on VLAN filter delete when
VIRTCHNL_VF_OFFLOAD_VLAN is not supported. The changed flow in
iavf_del_vlans() allows the stack to delete previosly existing VLAN
filters even if VLAN filtering is not allowed. This makes it so the VLAN
filter list is up to date.
Fixes: 8774370d268f ("i40e/i40evf: support for VF VLAN tag stripping control")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-05 09:20:25 -07:00
|
|
|
list_del(&f->list);
|
|
|
|
kfree(f);
|
|
|
|
} else if (f->remove) {
|
2013-12-21 06:13:01 +00:00
|
|
|
count++;
|
iavf: Fix VLAN feature flags after VFR
When a VF goes through a reset, it's possible for the VF's feature set
to change. For example it may lose the VIRTCHNL_VF_OFFLOAD_VLAN
capability after VF reset. Unfortunately, the driver doesn't correctly
deal with this situation and errors are seen from downing/upping the
interface and/or moving the interface in/out of a network namespace.
When setting the interface down/up we see the following errors after the
VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from the VF:
ice 0000:51:00.1: VF 1 failed opcode 12, retval: -64 iavf 0000:51:09.1:
Failed to add VLAN filter, error IAVF_NOT_SUPPORTED ice 0000:51:00.1: VF
1 failed opcode 13, retval: -64 iavf 0000:51:09.1: Failed to delete VLAN
filter, error IAVF_NOT_SUPPORTED
These add/delete errors are happening because the VLAN filters are
tracked internally to the driver and regardless of the VLAN_ALLOWED()
setting the driver tries to delete/re-add them over virtchnl.
Fix the delete failure by making sure to delete any VLAN filter tracking
in the driver when a removal request is made, while preventing the
virtchnl request. This makes it so the driver's VLAN list is up to date
and the errors are
Fix the add failure by making sure the check for VLAN_ALLOWED() during
reset is done after the VF receives its capability list from the PF via
VIRTCHNL_OP_GET_VF_RESOURCES. If VLAN functionality is not allowed, then
prevent requesting re-adding the filters over virtchnl.
When moving the interface into a network namespace we see the following
errors after the VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from
the VF:
iavf 0000:51:09.1 enp81s0f1v1: NIC Link is Up Speed is 25 Gbps Full Duplex
iavf 0000:51:09.1 temp_27: renamed from enp81s0f1v1
iavf 0000:51:09.1 mgmt: renamed from temp_27
iavf 0000:51:09.1 dev27: set_features() failed (-22); wanted 0x020190001fd54833, left 0x020190001fd54bb3
These errors are happening because we aren't correctly updating the
netdev capabilities and dealing with ndo_fix_features() and
ndo_set_features() correctly.
Fix this by only reporting errors in the driver's ndo_set_features()
callback when VIRTCHNL_VF_OFFLOAD_VLAN is not allowed and any attempt to
enable the VLAN features is made. Also, make sure to disable VLAN
insertion, filtering, and stripping since the VIRTCHNL_VF_OFFLOAD_VLAN
flag applies to all of them and not just VLAN stripping.
Also, after we process the capabilities in the VF reset path, make sure
to call netdev_update_features() in case the capabilities have changed
in order to update the netdev's feature set to match the VF's actual
capabilities.
Lastly, make sure to always report success on VLAN filter delete when
VIRTCHNL_VF_OFFLOAD_VLAN is not supported. The changed flow in
iavf_del_vlans() allows the stack to delete previosly existing VLAN
filters even if VLAN filtering is not allowed. This makes it so the VLAN
filter list is up to date.
Fixes: 8774370d268f ("i40e/i40evf: support for VF VLAN tag stripping control")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-05 09:20:25 -07:00
|
|
|
}
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
if (!count || !VLAN_FILTERING_ALLOWED(adapter)) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_VLAN_FILTER;
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
if (VLAN_ALLOWED(adapter)) {
|
|
|
|
struct virtchnl_vlan_filter_list *vvfl;
|
|
|
|
|
|
|
|
adapter->current_op = VIRTCHNL_OP_DEL_VLAN;
|
|
|
|
|
|
|
|
len = sizeof(*vvfl) + (count * sizeof(u16));
|
|
|
|
if (len > IAVF_MAX_AQ_BUF_SIZE) {
|
|
|
|
dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
|
|
|
|
count = (IAVF_MAX_AQ_BUF_SIZE - sizeof(*vvfl)) /
|
|
|
|
sizeof(u16);
|
|
|
|
len = sizeof(*vvfl) + (count * sizeof(u16));
|
|
|
|
more = true;
|
|
|
|
}
|
|
|
|
vvfl = kzalloc(len, GFP_ATOMIC);
|
|
|
|
if (!vvfl) {
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
vvfl->vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
vvfl->num_elements = count;
|
|
|
|
list_for_each_entry_safe(f, ftmp, &adapter->vlan_filter_list, list) {
|
|
|
|
if (f->remove) {
|
|
|
|
vvfl->vlan_id[i] = f->vlan.vid;
|
|
|
|
i++;
|
|
|
|
list_del(&f->list);
|
|
|
|
kfree(f);
|
|
|
|
if (i == count)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!more)
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_VLAN_FILTER;
|
|
|
|
|
2017-10-27 11:06:50 -04:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2014-05-10 04:49:04 +00:00
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DEL_VLAN, (u8 *)vvfl, len);
|
|
|
|
kfree(vvfl);
|
|
|
|
} else {
|
|
|
|
struct virtchnl_vlan_filter_list_v2 *vvfl_v2;
|
|
|
|
|
|
|
|
adapter->current_op = VIRTCHNL_OP_DEL_VLAN_V2;
|
|
|
|
|
|
|
|
len = sizeof(*vvfl_v2) +
|
|
|
|
((count - 1) * sizeof(struct virtchnl_vlan_filter));
|
|
|
|
if (len > IAVF_MAX_AQ_BUF_SIZE) {
|
|
|
|
dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
|
|
|
|
count = (IAVF_MAX_AQ_BUF_SIZE -
|
|
|
|
sizeof(*vvfl_v2)) /
|
|
|
|
sizeof(struct virtchnl_vlan_filter);
|
|
|
|
len = sizeof(*vvfl_v2) +
|
|
|
|
((count - 1) *
|
|
|
|
sizeof(struct virtchnl_vlan_filter));
|
|
|
|
more = true;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
2017-10-27 11:06:50 -04:00
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
vvfl_v2 = kzalloc(len, GFP_ATOMIC);
|
|
|
|
if (!vvfl_v2) {
|
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
vvfl_v2->vport_id = adapter->vsi_res->vsi_id;
|
|
|
|
vvfl_v2->num_elements = count;
|
|
|
|
list_for_each_entry_safe(f, ftmp, &adapter->vlan_filter_list, list) {
|
|
|
|
if (f->remove) {
|
|
|
|
struct virtchnl_vlan_supported_caps *filtering_support =
|
|
|
|
&adapter->vlan_v2_caps.filtering.filtering_support;
|
|
|
|
struct virtchnl_vlan *vlan;
|
|
|
|
|
|
|
|
/* give priority over outer if it's enabled */
|
|
|
|
if (filtering_support->outer)
|
|
|
|
vlan = &vvfl_v2->filters[i].outer;
|
|
|
|
else
|
|
|
|
vlan = &vvfl_v2->filters[i].inner;
|
|
|
|
|
|
|
|
vlan->tci = f->vlan.vid;
|
|
|
|
vlan->tpid = f->vlan.tpid;
|
|
|
|
|
|
|
|
list_del(&f->list);
|
|
|
|
kfree(f);
|
|
|
|
i++;
|
|
|
|
if (i == count)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!more)
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_VLAN_FILTER;
|
2017-10-27 11:06:50 -04:00
|
|
|
|
iavf: Add support VIRTCHNL_VF_OFFLOAD_VLAN_V2 during netdev config
Based on VIRTCHNL_VF_OFFLOAD_VLAN_V2, the VF can now support more VLAN
capabilities (i.e. 802.1AD offloads and filtering). In order to
communicate these capabilities to the netdev layer, the VF needs to
parse its VLAN capabilities based on whether it was able to negotiation
VIRTCHNL_VF_OFFLOAD_VLAN or VIRTCHNL_VF_OFFLOAD_VLAN_V2 or neither of
these.
In order to support this, add the following functionality:
iavf_get_netdev_vlan_hw_features() - This is used to determine the VLAN
features that the underlying hardware supports and that can be toggled
off/on based on the negotiated capabiltiies. For example, if
VIRTCHNL_VF_OFFLOAD_VLAN_V2 was negotiated, then any capability marked
with VIRTCHNL_VLAN_TOGGLE can be toggled on/off by the VF. If
VIRTCHNL_VF_OFFLOAD_VLAN was negotiated, then only VLAN insertion and/or
stripping can be toggled on/off.
iavf_get_netdev_vlan_features() - This is used to determine the VLAN
features that the underlying hardware supports and that should be
enabled by default. For example, if VIRTHCNL_VF_OFFLOAD_VLAN_V2 was
negotiated, then any supported capability that has its ethertype_init
filed set should be enabled by default. If VIRTCHNL_VF_OFFLOAD_VLAN was
negotiated, then filtering, stripping, and insertion should be enabled
by default.
Also, refactor iavf_fix_features() to take into account the new
capabilities. To do this, query all the supported features (enabled by
default and toggleable) and make sure the requested change is supported.
If VIRTCHNL_VF_OFFLOAD_VLAN_V2 is successfully negotiated, there is no
need to check VIRTCHNL_VLAN_TOGGLE here because the driver already told
the netdev layer which features can be toggled via netdev->hw_features
during iavf_process_config(), so only those features will be requested
to change.
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-29 16:16:01 -08:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DEL_VLAN_V2,
|
|
|
|
(u8 *)vvfl_v2, len);
|
|
|
|
kfree(vvfl_v2);
|
|
|
|
}
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_set_promiscuous
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
* @flags: bitmask to control unicast/multicast promiscuous.
|
|
|
|
*
|
|
|
|
* Request that the PF enable promiscuous mode for our VSI.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_set_promiscuous(struct iavf_adapter *adapter, int flags)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_promisc_info vpi;
|
2016-05-03 15:13:10 -07:00
|
|
|
int promisc_all;
|
2013-12-21 06:13:01 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* bail because we already have a command pending */
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Cannot set promiscuous mode, command %d pending\n",
|
|
|
|
adapter->current_op);
|
2013-12-21 06:13:01 +00:00
|
|
|
return;
|
|
|
|
}
|
2016-04-12 08:30:52 -07:00
|
|
|
|
2017-05-11 11:23:16 -07:00
|
|
|
promisc_all = FLAG_VF_UNICAST_PROMISC |
|
|
|
|
FLAG_VF_MULTICAST_PROMISC;
|
2016-05-03 15:13:10 -07:00
|
|
|
if ((flags & promisc_all) == promisc_all) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->flags |= IAVF_FLAG_PROMISC_ON;
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_REQUEST_PROMISC;
|
2016-04-12 08:30:52 -07:00
|
|
|
dev_info(&adapter->pdev->dev, "Entering promiscuous mode\n");
|
2016-05-03 15:13:10 -07:00
|
|
|
}
|
|
|
|
|
2017-05-11 11:23:16 -07:00
|
|
|
if (flags & FLAG_VF_MULTICAST_PROMISC) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->flags |= IAVF_FLAG_ALLMULTI_ON;
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_REQUEST_ALLMULTI;
|
2021-06-04 09:53:32 -07:00
|
|
|
dev_info(&adapter->pdev->dev, "%s is entering multicast promiscuous mode\n",
|
|
|
|
adapter->netdev->name);
|
2016-05-03 15:13:10 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!flags) {
|
2021-06-04 09:53:32 -07:00
|
|
|
if (adapter->flags & IAVF_FLAG_PROMISC_ON) {
|
|
|
|
adapter->flags &= ~IAVF_FLAG_PROMISC_ON;
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_RELEASE_PROMISC;
|
|
|
|
dev_info(&adapter->pdev->dev, "Leaving promiscuous mode\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (adapter->flags & IAVF_FLAG_ALLMULTI_ON) {
|
|
|
|
adapter->flags &= ~IAVF_FLAG_ALLMULTI_ON;
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_RELEASE_ALLMULTI;
|
|
|
|
dev_info(&adapter->pdev->dev, "%s is leaving multicast promiscuous mode\n",
|
|
|
|
adapter->netdev->name);
|
|
|
|
}
|
2016-04-12 08:30:52 -07:00
|
|
|
}
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE;
|
2013-12-21 06:13:01 +00:00
|
|
|
vpi.vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
vpi.flags = flags;
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE,
|
|
|
|
(u8 *)&vpi, sizeof(vpi));
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_request_stats
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request VSI statistics from PF.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_request_stats(struct iavf_adapter *adapter)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_queue_select vqs;
|
2014-11-11 20:02:42 +00:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2013-12-21 06:13:01 +00:00
|
|
|
/* no error message, this isn't crucial */
|
|
|
|
return;
|
|
|
|
}
|
2021-09-15 09:01:00 +00:00
|
|
|
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_REQUEST_STATS;
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_GET_STATS;
|
2013-12-21 06:13:01 +00:00
|
|
|
vqs.vsi_id = adapter->vsi_res->vsi_id;
|
|
|
|
/* queue maps are ignored for this message - only the vsi is used */
|
2018-09-14 17:37:47 -07:00
|
|
|
if (iavf_send_pf_msg(adapter, VIRTCHNL_OP_GET_STATS, (u8 *)&vqs,
|
|
|
|
sizeof(vqs)))
|
2013-12-21 06:13:01 +00:00
|
|
|
/* if the request failed, don't lock out others */
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
2016-04-12 08:30:44 -07:00
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_get_hena
|
2016-04-12 08:30:44 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request hash enable capabilities from PF
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_get_hena(struct iavf_adapter *adapter)
|
2016-04-12 08:30:44 -07:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2016-04-12 08:30:44 -07:00
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot get RSS hash capabilities, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_GET_RSS_HENA_CAPS;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_GET_HENA;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_GET_RSS_HENA_CAPS, NULL, 0);
|
2016-04-12 08:30:44 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_set_hena
|
2016-04-12 08:30:44 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request the PF to set our RSS hash capabilities
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_set_hena(struct iavf_adapter *adapter)
|
2016-04-12 08:30:44 -07:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_rss_hena vrh;
|
2016-04-12 08:30:44 -07:00
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2016-04-12 08:30:44 -07:00
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot set RSS hash enable, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
vrh.hena = adapter->hena;
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_SET_RSS_HENA;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_SET_HENA;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_SET_RSS_HENA, (u8 *)&vrh,
|
|
|
|
sizeof(vrh));
|
2016-04-12 08:30:44 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_set_rss_key
|
2016-04-12 08:30:44 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request the PF to set our RSS hash key
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_set_rss_key(struct iavf_adapter *adapter)
|
2016-04-12 08:30:44 -07:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_rss_key *vrk;
|
2016-04-12 08:30:44 -07:00
|
|
|
int len;
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2016-04-12 08:30:44 -07:00
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot set RSS key, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
len = sizeof(struct virtchnl_rss_key) +
|
2016-04-12 08:30:44 -07:00
|
|
|
(adapter->rss_key_size * sizeof(u8)) - 1;
|
|
|
|
vrk = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!vrk)
|
|
|
|
return;
|
|
|
|
vrk->vsi_id = adapter->vsi.id;
|
|
|
|
vrk->key_len = adapter->rss_key_size;
|
|
|
|
memcpy(vrk->key, adapter->rss_key, adapter->rss_key_size);
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_CONFIG_RSS_KEY;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_SET_RSS_KEY;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_CONFIG_RSS_KEY, (u8 *)vrk, len);
|
2016-04-12 08:30:44 -07:00
|
|
|
kfree(vrk);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_set_rss_lut
|
2016-04-12 08:30:44 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request the PF to set our RSS lookup table
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_set_rss_lut(struct iavf_adapter *adapter)
|
2016-04-12 08:30:44 -07:00
|
|
|
{
|
2017-05-11 11:23:11 -07:00
|
|
|
struct virtchnl_rss_lut *vrl;
|
2016-04-12 08:30:44 -07:00
|
|
|
int len;
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
2016-04-12 08:30:44 -07:00
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot set RSS LUT, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
2017-05-11 11:23:11 -07:00
|
|
|
len = sizeof(struct virtchnl_rss_lut) +
|
2016-04-12 08:30:44 -07:00
|
|
|
(adapter->rss_lut_size * sizeof(u8)) - 1;
|
|
|
|
vrl = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!vrl)
|
|
|
|
return;
|
|
|
|
vrl->vsi_id = adapter->vsi.id;
|
|
|
|
vrl->lut_entries = adapter->rss_lut_size;
|
|
|
|
memcpy(vrl->lut, adapter->rss_lut, adapter->rss_lut_size);
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_CONFIG_RSS_LUT;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_SET_RSS_LUT;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_CONFIG_RSS_LUT, (u8 *)vrl, len);
|
2016-04-12 08:30:44 -07:00
|
|
|
kfree(vrl);
|
|
|
|
}
|
|
|
|
|
2017-07-17 22:09:45 -07:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_enable_vlan_stripping
|
2017-07-17 22:09:45 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request VLAN header stripping to be enabled
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_enable_vlan_stripping(struct iavf_adapter *adapter)
|
2017-07-17 22:09:45 -07:00
|
|
|
{
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot enable stripping, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
adapter->current_op = VIRTCHNL_OP_ENABLE_VLAN_STRIPPING;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ENABLE_VLAN_STRIPPING;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ENABLE_VLAN_STRIPPING, NULL, 0);
|
2017-07-17 22:09:45 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_disable_vlan_stripping
|
2017-07-17 22:09:45 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request VLAN header stripping to be disabled
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_disable_vlan_stripping(struct iavf_adapter *adapter)
|
2017-07-17 22:09:45 -07:00
|
|
|
{
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot disable stripping, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
adapter->current_op = VIRTCHNL_OP_DISABLE_VLAN_STRIPPING;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DISABLE_VLAN_STRIPPING;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DISABLE_VLAN_STRIPPING, NULL, 0);
|
2017-07-17 22:09:45 -07:00
|
|
|
}
|
|
|
|
|
2021-11-29 16:16:03 -08:00
|
|
|
/**
|
|
|
|
* iavf_tpid_to_vc_ethertype - transform from VLAN TPID to virtchnl ethertype
|
|
|
|
* @tpid: VLAN TPID (i.e. 0x8100, 0x88a8, etc.)
|
|
|
|
*/
|
|
|
|
static u32 iavf_tpid_to_vc_ethertype(u16 tpid)
|
|
|
|
{
|
|
|
|
switch (tpid) {
|
|
|
|
case ETH_P_8021Q:
|
|
|
|
return VIRTCHNL_VLAN_ETHERTYPE_8100;
|
|
|
|
case ETH_P_8021AD:
|
|
|
|
return VIRTCHNL_VLAN_ETHERTYPE_88A8;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_set_vc_offload_ethertype - set virtchnl ethertype for offload message
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @msg: message structure used for updating offloads over virtchnl to update
|
|
|
|
* @tpid: VLAN TPID (i.e. 0x8100, 0x88a8, etc.)
|
|
|
|
* @offload_op: opcode used to determine which support structure to check
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
iavf_set_vc_offload_ethertype(struct iavf_adapter *adapter,
|
|
|
|
struct virtchnl_vlan_setting *msg, u16 tpid,
|
|
|
|
enum virtchnl_ops offload_op)
|
|
|
|
{
|
|
|
|
struct virtchnl_vlan_supported_caps *offload_support;
|
|
|
|
u16 vc_ethertype = iavf_tpid_to_vc_ethertype(tpid);
|
|
|
|
|
|
|
|
/* reference the correct offload support structure */
|
|
|
|
switch (offload_op) {
|
|
|
|
case VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2:
|
|
|
|
case VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2:
|
|
|
|
offload_support =
|
|
|
|
&adapter->vlan_v2_caps.offloads.stripping_support;
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2:
|
|
|
|
case VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2:
|
|
|
|
offload_support =
|
|
|
|
&adapter->vlan_v2_caps.offloads.insertion_support;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
dev_err(&adapter->pdev->dev, "Invalid opcode %d for setting virtchnl ethertype to enable/disable VLAN offloads\n",
|
|
|
|
offload_op);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* make sure ethertype is supported */
|
|
|
|
if (offload_support->outer & vc_ethertype &&
|
|
|
|
offload_support->outer & VIRTCHNL_VLAN_TOGGLE) {
|
|
|
|
msg->outer_ethertype_setting = vc_ethertype;
|
|
|
|
} else if (offload_support->inner & vc_ethertype &&
|
|
|
|
offload_support->inner & VIRTCHNL_VLAN_TOGGLE) {
|
|
|
|
msg->inner_ethertype_setting = vc_ethertype;
|
|
|
|
} else {
|
|
|
|
dev_dbg(&adapter->pdev->dev, "opcode %d unsupported for VLAN TPID 0x%04x\n",
|
|
|
|
offload_op, tpid);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_clear_offload_v2_aq_required - clear AQ required bit for offload request
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @tpid: VLAN TPID
|
|
|
|
* @offload_op: opcode used to determine which AQ required bit to clear
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
iavf_clear_offload_v2_aq_required(struct iavf_adapter *adapter, u16 tpid,
|
|
|
|
enum virtchnl_ops offload_op)
|
|
|
|
{
|
|
|
|
switch (offload_op) {
|
|
|
|
case VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2:
|
|
|
|
if (tpid == ETH_P_8021Q)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_ENABLE_CTAG_VLAN_STRIPPING;
|
|
|
|
else if (tpid == ETH_P_8021AD)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_ENABLE_STAG_VLAN_STRIPPING;
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2:
|
|
|
|
if (tpid == ETH_P_8021Q)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_DISABLE_CTAG_VLAN_STRIPPING;
|
|
|
|
else if (tpid == ETH_P_8021AD)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_DISABLE_STAG_VLAN_STRIPPING;
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2:
|
|
|
|
if (tpid == ETH_P_8021Q)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_ENABLE_CTAG_VLAN_INSERTION;
|
|
|
|
else if (tpid == ETH_P_8021AD)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_ENABLE_STAG_VLAN_INSERTION;
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2:
|
|
|
|
if (tpid == ETH_P_8021Q)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_DISABLE_CTAG_VLAN_INSERTION;
|
|
|
|
else if (tpid == ETH_P_8021AD)
|
|
|
|
adapter->aq_required &=
|
|
|
|
~IAVF_FLAG_AQ_DISABLE_STAG_VLAN_INSERTION;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
dev_err(&adapter->pdev->dev, "Unsupported opcode %d specified for clearing aq_required bits for VIRTCHNL_VF_OFFLOAD_VLAN_V2 offload request\n",
|
|
|
|
offload_op);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_send_vlan_offload_v2 - send offload enable/disable over virtchnl
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @tpid: VLAN TPID used for the command (i.e. 0x8100 or 0x88a8)
|
|
|
|
* @offload_op: offload_op used to make the request over virtchnl
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
iavf_send_vlan_offload_v2(struct iavf_adapter *adapter, u16 tpid,
|
|
|
|
enum virtchnl_ops offload_op)
|
|
|
|
{
|
|
|
|
struct virtchnl_vlan_setting *msg;
|
|
|
|
int len = sizeof(*msg);
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot send %d, command %d pending\n",
|
|
|
|
offload_op, adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
adapter->current_op = offload_op;
|
|
|
|
|
|
|
|
msg = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!msg)
|
|
|
|
return;
|
|
|
|
|
|
|
|
msg->vport_id = adapter->vsi_res->vsi_id;
|
|
|
|
|
|
|
|
/* always clear to prevent unsupported and endless requests */
|
|
|
|
iavf_clear_offload_v2_aq_required(adapter, tpid, offload_op);
|
|
|
|
|
|
|
|
/* only send valid offload requests */
|
|
|
|
if (!iavf_set_vc_offload_ethertype(adapter, msg, tpid, offload_op))
|
|
|
|
iavf_send_pf_msg(adapter, offload_op, (u8 *)msg, len);
|
|
|
|
else
|
|
|
|
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
|
|
|
|
|
|
|
|
kfree(msg);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_enable_vlan_stripping_v2 - enable VLAN stripping
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @tpid: VLAN TPID used to enable VLAN stripping
|
|
|
|
*/
|
|
|
|
void iavf_enable_vlan_stripping_v2(struct iavf_adapter *adapter, u16 tpid)
|
|
|
|
{
|
|
|
|
iavf_send_vlan_offload_v2(adapter, tpid,
|
|
|
|
VIRTCHNL_OP_ENABLE_VLAN_STRIPPING_V2);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_disable_vlan_stripping_v2 - disable VLAN stripping
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @tpid: VLAN TPID used to disable VLAN stripping
|
|
|
|
*/
|
|
|
|
void iavf_disable_vlan_stripping_v2(struct iavf_adapter *adapter, u16 tpid)
|
|
|
|
{
|
|
|
|
iavf_send_vlan_offload_v2(adapter, tpid,
|
|
|
|
VIRTCHNL_OP_DISABLE_VLAN_STRIPPING_V2);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_enable_vlan_insertion_v2 - enable VLAN insertion
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @tpid: VLAN TPID used to enable VLAN insertion
|
|
|
|
*/
|
|
|
|
void iavf_enable_vlan_insertion_v2(struct iavf_adapter *adapter, u16 tpid)
|
|
|
|
{
|
|
|
|
iavf_send_vlan_offload_v2(adapter, tpid,
|
|
|
|
VIRTCHNL_OP_ENABLE_VLAN_INSERTION_V2);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_disable_vlan_insertion_v2 - disable VLAN insertion
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @tpid: VLAN TPID used to disable VLAN insertion
|
|
|
|
*/
|
|
|
|
void iavf_disable_vlan_insertion_v2(struct iavf_adapter *adapter, u16 tpid)
|
|
|
|
{
|
|
|
|
iavf_send_vlan_offload_v2(adapter, tpid,
|
|
|
|
VIRTCHNL_OP_DISABLE_VLAN_INSERTION_V2);
|
|
|
|
}
|
|
|
|
|
2020-06-05 10:09:43 -07:00
|
|
|
#define IAVF_MAX_SPEED_STRLEN 13
|
|
|
|
|
2016-08-04 11:37:02 -07:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_print_link_message - print link up or down
|
2016-08-04 11:37:02 -07:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Log a message telling the world of our wonderous link status
|
|
|
|
*/
|
2018-09-14 17:37:46 -07:00
|
|
|
static void iavf_print_link_message(struct iavf_adapter *adapter)
|
2016-08-04 11:37:02 -07:00
|
|
|
{
|
|
|
|
struct net_device *netdev = adapter->netdev;
|
2020-06-05 10:09:43 -07:00
|
|
|
int link_speed_mbps;
|
|
|
|
char *speed;
|
2016-08-04 11:37:02 -07:00
|
|
|
|
|
|
|
if (!adapter->link_up) {
|
|
|
|
netdev_info(netdev, "NIC Link is Down\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-12-29 21:53:01 +08:00
|
|
|
speed = kzalloc(IAVF_MAX_SPEED_STRLEN, GFP_KERNEL);
|
2020-06-05 10:09:43 -07:00
|
|
|
if (!speed)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (ADV_LINK_SUPPORT(adapter)) {
|
|
|
|
link_speed_mbps = adapter->link_speed_mbps;
|
|
|
|
goto print_link_msg;
|
|
|
|
}
|
|
|
|
|
2016-08-04 11:37:02 -07:00
|
|
|
switch (adapter->link_speed) {
|
2020-06-05 10:09:44 -07:00
|
|
|
case VIRTCHNL_LINK_SPEED_40GB:
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps = SPEED_40000;
|
2016-08-04 11:37:02 -07:00
|
|
|
break;
|
2020-06-05 10:09:44 -07:00
|
|
|
case VIRTCHNL_LINK_SPEED_25GB:
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps = SPEED_25000;
|
2016-11-21 13:03:48 -08:00
|
|
|
break;
|
2020-06-05 10:09:44 -07:00
|
|
|
case VIRTCHNL_LINK_SPEED_20GB:
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps = SPEED_20000;
|
2016-08-04 11:37:02 -07:00
|
|
|
break;
|
2020-06-05 10:09:44 -07:00
|
|
|
case VIRTCHNL_LINK_SPEED_10GB:
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps = SPEED_10000;
|
2016-08-04 11:37:02 -07:00
|
|
|
break;
|
2020-06-05 10:09:45 -07:00
|
|
|
case VIRTCHNL_LINK_SPEED_5GB:
|
|
|
|
link_speed_mbps = SPEED_5000;
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_LINK_SPEED_2_5GB:
|
|
|
|
link_speed_mbps = SPEED_2500;
|
|
|
|
break;
|
2020-06-05 10:09:44 -07:00
|
|
|
case VIRTCHNL_LINK_SPEED_1GB:
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps = SPEED_1000;
|
2016-08-04 11:37:02 -07:00
|
|
|
break;
|
2020-06-05 10:09:44 -07:00
|
|
|
case VIRTCHNL_LINK_SPEED_100MB:
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps = SPEED_100;
|
2016-08-04 11:37:02 -07:00
|
|
|
break;
|
|
|
|
default:
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps = SPEED_UNKNOWN;
|
2016-08-04 11:37:02 -07:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2020-06-05 10:09:43 -07:00
|
|
|
print_link_msg:
|
|
|
|
if (link_speed_mbps > SPEED_1000) {
|
|
|
|
if (link_speed_mbps == SPEED_2500)
|
|
|
|
snprintf(speed, IAVF_MAX_SPEED_STRLEN, "2.5 Gbps");
|
|
|
|
else
|
|
|
|
/* convert to Gbps inline */
|
|
|
|
snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
|
|
|
|
link_speed_mbps / 1000, "Gbps");
|
|
|
|
} else if (link_speed_mbps == SPEED_UNKNOWN) {
|
|
|
|
snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%s", "Unknown Mbps");
|
|
|
|
} else {
|
2021-08-31 13:39:01 +02:00
|
|
|
snprintf(speed, IAVF_MAX_SPEED_STRLEN, "%d %s",
|
2020-06-05 10:09:43 -07:00
|
|
|
link_speed_mbps, "Mbps");
|
|
|
|
}
|
|
|
|
|
|
|
|
netdev_info(netdev, "NIC Link is Up Speed is %s Full Duplex\n", speed);
|
|
|
|
kfree(speed);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_get_vpe_link_status
|
|
|
|
* @adapter: adapter structure
|
|
|
|
* @vpe: virtchnl_pf_event structure
|
|
|
|
*
|
|
|
|
* Helper function for determining the link status
|
|
|
|
**/
|
|
|
|
static bool
|
|
|
|
iavf_get_vpe_link_status(struct iavf_adapter *adapter,
|
|
|
|
struct virtchnl_pf_event *vpe)
|
|
|
|
{
|
|
|
|
if (ADV_LINK_SUPPORT(adapter))
|
|
|
|
return vpe->event_data.link_event_adv.link_status;
|
|
|
|
else
|
|
|
|
return vpe->event_data.link_event.link_status;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_set_adapter_link_speed_from_vpe
|
|
|
|
* @adapter: adapter structure for which we are setting the link speed
|
|
|
|
* @vpe: virtchnl_pf_event structure that contains the link speed we are setting
|
|
|
|
*
|
|
|
|
* Helper function for setting iavf_adapter link speed
|
|
|
|
**/
|
|
|
|
static void
|
|
|
|
iavf_set_adapter_link_speed_from_vpe(struct iavf_adapter *adapter,
|
|
|
|
struct virtchnl_pf_event *vpe)
|
|
|
|
{
|
|
|
|
if (ADV_LINK_SUPPORT(adapter))
|
|
|
|
adapter->link_speed_mbps =
|
|
|
|
vpe->event_data.link_event_adv.link_speed;
|
|
|
|
else
|
|
|
|
adapter->link_speed = vpe->event_data.link_event.link_speed;
|
2016-08-04 11:37:02 -07:00
|
|
|
}
|
|
|
|
|
2018-01-23 08:50:57 -08:00
|
|
|
/**
|
2021-03-18 16:18:52 -07:00
|
|
|
* iavf_enable_channels
|
2018-01-23 08:50:57 -08:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF enable channels as specified by
|
|
|
|
* the user via tc tool.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_enable_channels(struct iavf_adapter *adapter)
|
2018-01-23 08:50:57 -08:00
|
|
|
{
|
|
|
|
struct virtchnl_tc_info *vti = NULL;
|
2019-06-14 16:23:20 -07:00
|
|
|
size_t len;
|
2018-01-23 08:50:57 -08:00
|
|
|
int i;
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot configure mqprio, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-06-14 16:23:20 -07:00
|
|
|
len = struct_size(vti, list, adapter->num_tc - 1);
|
2018-01-23 08:50:57 -08:00
|
|
|
vti = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!vti)
|
|
|
|
return;
|
|
|
|
vti->num_tc = adapter->num_tc;
|
|
|
|
for (i = 0; i < vti->num_tc; i++) {
|
|
|
|
vti->list[i].count = adapter->ch_config.ch_info[i].count;
|
|
|
|
vti->list[i].offset = adapter->ch_config.ch_info[i].offset;
|
2018-01-23 08:51:01 -08:00
|
|
|
vti->list[i].pad = 0;
|
|
|
|
vti->list[i].max_tx_rate =
|
|
|
|
adapter->ch_config.ch_info[i].max_tx_rate;
|
2018-01-23 08:50:57 -08:00
|
|
|
}
|
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->ch_config.state = __IAVF_TC_RUNNING;
|
|
|
|
adapter->flags |= IAVF_FLAG_REINIT_ITR_NEEDED;
|
2018-01-23 08:50:57 -08:00
|
|
|
adapter->current_op = VIRTCHNL_OP_ENABLE_CHANNELS;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ENABLE_CHANNELS;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ENABLE_CHANNELS, (u8 *)vti, len);
|
2018-01-23 08:50:57 -08:00
|
|
|
kfree(vti);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2021-03-18 16:18:52 -07:00
|
|
|
* iavf_disable_channels
|
2018-01-23 08:50:57 -08:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF disable channels that are configured
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_disable_channels(struct iavf_adapter *adapter)
|
2018-01-23 08:50:57 -08:00
|
|
|
{
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot configure mqprio, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->ch_config.state = __IAVF_TC_INVALID;
|
|
|
|
adapter->flags |= IAVF_FLAG_REINIT_ITR_NEEDED;
|
2018-01-23 08:50:57 -08:00
|
|
|
adapter->current_op = VIRTCHNL_OP_DISABLE_CHANNELS;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DISABLE_CHANNELS;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DISABLE_CHANNELS, NULL, 0);
|
2018-01-23 08:50:57 -08:00
|
|
|
}
|
|
|
|
|
2018-01-23 08:51:05 -08:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_print_cloud_filter
|
2018-01-23 08:51:05 -08:00
|
|
|
* @adapter: adapter structure
|
|
|
|
* @f: cloud filter to print
|
|
|
|
*
|
|
|
|
* Print the cloud filter
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
static void iavf_print_cloud_filter(struct iavf_adapter *adapter,
|
|
|
|
struct virtchnl_filter *f)
|
2018-01-23 08:51:05 -08:00
|
|
|
{
|
2018-02-15 19:26:05 +00:00
|
|
|
switch (f->flow_type) {
|
2018-01-23 08:51:05 -08:00
|
|
|
case VIRTCHNL_TCP_V4_FLOW:
|
|
|
|
dev_info(&adapter->pdev->dev, "dst_mac: %pM src_mac: %pM vlan_id: %hu dst_ip: %pI4 src_ip %pI4 dst_port %hu src_port %hu\n",
|
2018-02-15 19:26:05 +00:00
|
|
|
&f->data.tcp_spec.dst_mac,
|
|
|
|
&f->data.tcp_spec.src_mac,
|
|
|
|
ntohs(f->data.tcp_spec.vlan_id),
|
|
|
|
&f->data.tcp_spec.dst_ip[0],
|
|
|
|
&f->data.tcp_spec.src_ip[0],
|
|
|
|
ntohs(f->data.tcp_spec.dst_port),
|
|
|
|
ntohs(f->data.tcp_spec.src_port));
|
2018-01-23 08:51:05 -08:00
|
|
|
break;
|
|
|
|
case VIRTCHNL_TCP_V6_FLOW:
|
|
|
|
dev_info(&adapter->pdev->dev, "dst_mac: %pM src_mac: %pM vlan_id: %hu dst_ip: %pI6 src_ip %pI6 dst_port %hu src_port %hu\n",
|
2018-02-15 19:26:05 +00:00
|
|
|
&f->data.tcp_spec.dst_mac,
|
|
|
|
&f->data.tcp_spec.src_mac,
|
|
|
|
ntohs(f->data.tcp_spec.vlan_id),
|
|
|
|
&f->data.tcp_spec.dst_ip,
|
|
|
|
&f->data.tcp_spec.src_ip,
|
|
|
|
ntohs(f->data.tcp_spec.dst_port),
|
|
|
|
ntohs(f->data.tcp_spec.src_port));
|
2018-01-23 08:51:05 -08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_add_cloud_filter
|
2018-01-23 08:51:05 -08:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF add cloud filters as specified
|
|
|
|
* by the user via tc tool.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_add_cloud_filter(struct iavf_adapter *adapter)
|
2018-01-23 08:51:05 -08:00
|
|
|
{
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_cloud_filter *cf;
|
2018-01-23 08:51:05 -08:00
|
|
|
struct virtchnl_filter *f;
|
|
|
|
int len = 0, count = 0;
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot add cloud filter, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
list_for_each_entry(cf, &adapter->cloud_filter_list, list) {
|
|
|
|
if (cf->add) {
|
|
|
|
count++;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!count) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_CLOUD_FILTER;
|
2018-01-23 08:51:05 -08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
adapter->current_op = VIRTCHNL_OP_ADD_CLOUD_FILTER;
|
|
|
|
|
|
|
|
len = sizeof(struct virtchnl_filter);
|
|
|
|
f = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!f)
|
|
|
|
return;
|
|
|
|
|
|
|
|
list_for_each_entry(cf, &adapter->cloud_filter_list, list) {
|
|
|
|
if (cf->add) {
|
|
|
|
memcpy(f, &cf->f, sizeof(struct virtchnl_filter));
|
|
|
|
cf->add = false;
|
2018-09-14 17:37:46 -07:00
|
|
|
cf->state = __IAVF_CF_ADD_PENDING;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ADD_CLOUD_FILTER,
|
|
|
|
(u8 *)f, len);
|
2018-01-23 08:51:05 -08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
kfree(f);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_del_cloud_filter
|
2018-01-23 08:51:05 -08:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF delete cloud filters as specified
|
|
|
|
* by the user via tc tool.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_del_cloud_filter(struct iavf_adapter *adapter)
|
2018-01-23 08:51:05 -08:00
|
|
|
{
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_cloud_filter *cf, *cftmp;
|
2018-01-23 08:51:05 -08:00
|
|
|
struct virtchnl_filter *f;
|
|
|
|
int len = 0, count = 0;
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot remove cloud filter, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
list_for_each_entry(cf, &adapter->cloud_filter_list, list) {
|
|
|
|
if (cf->del) {
|
|
|
|
count++;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!count) {
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_CLOUD_FILTER;
|
2018-01-23 08:51:05 -08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
adapter->current_op = VIRTCHNL_OP_DEL_CLOUD_FILTER;
|
|
|
|
|
|
|
|
len = sizeof(struct virtchnl_filter);
|
|
|
|
f = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!f)
|
|
|
|
return;
|
|
|
|
|
|
|
|
list_for_each_entry_safe(cf, cftmp, &adapter->cloud_filter_list, list) {
|
|
|
|
if (cf->del) {
|
|
|
|
memcpy(f, &cf->f, sizeof(struct virtchnl_filter));
|
|
|
|
cf->del = false;
|
2018-09-14 17:37:46 -07:00
|
|
|
cf->state = __IAVF_CF_DEL_PENDING;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DEL_CLOUD_FILTER,
|
|
|
|
(u8 *)f, len);
|
2018-01-23 08:51:05 -08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
kfree(f);
|
|
|
|
}
|
|
|
|
|
2021-03-09 11:08:11 +08:00
|
|
|
/**
|
|
|
|
* iavf_add_fdir_filter
|
|
|
|
* @adapter: the VF adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF add Flow Director filters as specified
|
|
|
|
* by the user via ethtool.
|
|
|
|
**/
|
|
|
|
void iavf_add_fdir_filter(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct iavf_fdir_fltr *fdir;
|
|
|
|
struct virtchnl_fdir_add *f;
|
|
|
|
bool process_fltr = false;
|
|
|
|
int len;
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot add Flow Director filter, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
len = sizeof(struct virtchnl_fdir_add);
|
|
|
|
f = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!f)
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
list_for_each_entry(fdir, &adapter->fdir_list_head, list) {
|
|
|
|
if (fdir->state == IAVF_FDIR_FLTR_ADD_REQUEST) {
|
|
|
|
process_fltr = true;
|
|
|
|
fdir->state = IAVF_FDIR_FLTR_ADD_PENDING;
|
|
|
|
memcpy(f, &fdir->vc_add_msg, len);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
|
|
|
|
if (!process_fltr) {
|
|
|
|
/* prevent iavf_add_fdir_filter() from being called when there
|
|
|
|
* are no filters to add
|
|
|
|
*/
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_FDIR_FILTER;
|
|
|
|
kfree(f);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
adapter->current_op = VIRTCHNL_OP_ADD_FDIR_FILTER;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ADD_FDIR_FILTER, (u8 *)f, len);
|
|
|
|
kfree(f);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_del_fdir_filter
|
|
|
|
* @adapter: the VF adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF delete Flow Director filters as specified
|
|
|
|
* by the user via ethtool.
|
|
|
|
**/
|
|
|
|
void iavf_del_fdir_filter(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct iavf_fdir_fltr *fdir;
|
|
|
|
struct virtchnl_fdir_del f;
|
|
|
|
bool process_fltr = false;
|
|
|
|
int len;
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot remove Flow Director filter, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
len = sizeof(struct virtchnl_fdir_del);
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
list_for_each_entry(fdir, &adapter->fdir_list_head, list) {
|
|
|
|
if (fdir->state == IAVF_FDIR_FLTR_DEL_REQUEST) {
|
|
|
|
process_fltr = true;
|
|
|
|
memset(&f, 0, len);
|
|
|
|
f.vsi_id = fdir->vc_add_msg.vsi_id;
|
|
|
|
f.flow_id = fdir->flow_id;
|
|
|
|
fdir->state = IAVF_FDIR_FLTR_DEL_PENDING;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
|
|
|
|
if (!process_fltr) {
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_FDIR_FILTER;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
adapter->current_op = VIRTCHNL_OP_DEL_FDIR_FILTER;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DEL_FDIR_FILTER, (u8 *)&f, len);
|
|
|
|
}
|
|
|
|
|
2021-04-13 08:48:41 +08:00
|
|
|
/**
|
|
|
|
* iavf_add_adv_rss_cfg
|
|
|
|
* @adapter: the VF adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF add RSS configuration as specified
|
|
|
|
* by the user via ethtool.
|
|
|
|
**/
|
|
|
|
void iavf_add_adv_rss_cfg(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct virtchnl_rss_cfg *rss_cfg;
|
|
|
|
struct iavf_adv_rss *rss;
|
|
|
|
bool process_rss = false;
|
|
|
|
int len;
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot add RSS configuration, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
len = sizeof(struct virtchnl_rss_cfg);
|
|
|
|
rss_cfg = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!rss_cfg)
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->adv_rss_lock);
|
|
|
|
list_for_each_entry(rss, &adapter->adv_rss_list_head, list) {
|
|
|
|
if (rss->state == IAVF_ADV_RSS_ADD_REQUEST) {
|
|
|
|
process_rss = true;
|
|
|
|
rss->state = IAVF_ADV_RSS_ADD_PENDING;
|
|
|
|
memcpy(rss_cfg, &rss->cfg_msg, len);
|
2021-04-13 08:48:42 +08:00
|
|
|
iavf_print_adv_rss_cfg(adapter, rss,
|
|
|
|
"Input set change for",
|
|
|
|
"is pending");
|
2021-04-13 08:48:41 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->adv_rss_lock);
|
|
|
|
|
|
|
|
if (process_rss) {
|
|
|
|
adapter->current_op = VIRTCHNL_OP_ADD_RSS_CFG;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_ADD_RSS_CFG,
|
|
|
|
(u8 *)rss_cfg, len);
|
|
|
|
} else {
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_ADD_ADV_RSS_CFG;
|
|
|
|
}
|
|
|
|
|
|
|
|
kfree(rss_cfg);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* iavf_del_adv_rss_cfg
|
|
|
|
* @adapter: the VF adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF delete RSS configuration as specified
|
|
|
|
* by the user via ethtool.
|
|
|
|
**/
|
|
|
|
void iavf_del_adv_rss_cfg(struct iavf_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct virtchnl_rss_cfg *rss_cfg;
|
|
|
|
struct iavf_adv_rss *rss;
|
|
|
|
bool process_rss = false;
|
|
|
|
int len;
|
|
|
|
|
|
|
|
if (adapter->current_op != VIRTCHNL_OP_UNKNOWN) {
|
|
|
|
/* bail because we already have a command pending */
|
|
|
|
dev_err(&adapter->pdev->dev, "Cannot remove RSS configuration, command %d pending\n",
|
|
|
|
adapter->current_op);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
len = sizeof(struct virtchnl_rss_cfg);
|
|
|
|
rss_cfg = kzalloc(len, GFP_KERNEL);
|
|
|
|
if (!rss_cfg)
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->adv_rss_lock);
|
|
|
|
list_for_each_entry(rss, &adapter->adv_rss_list_head, list) {
|
|
|
|
if (rss->state == IAVF_ADV_RSS_DEL_REQUEST) {
|
|
|
|
process_rss = true;
|
|
|
|
rss->state = IAVF_ADV_RSS_DEL_PENDING;
|
|
|
|
memcpy(rss_cfg, &rss->cfg_msg, len);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->adv_rss_lock);
|
|
|
|
|
|
|
|
if (process_rss) {
|
|
|
|
adapter->current_op = VIRTCHNL_OP_DEL_RSS_CFG;
|
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_DEL_RSS_CFG,
|
|
|
|
(u8 *)rss_cfg, len);
|
|
|
|
} else {
|
|
|
|
adapter->aq_required &= ~IAVF_FLAG_AQ_DEL_ADV_RSS_CFG;
|
|
|
|
}
|
|
|
|
|
|
|
|
kfree(rss_cfg);
|
|
|
|
}
|
|
|
|
|
2014-02-20 19:29:05 -08:00
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_request_reset
|
2014-02-20 19:29:05 -08:00
|
|
|
* @adapter: adapter structure
|
|
|
|
*
|
|
|
|
* Request that the PF reset this VF. No response is expected.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_request_reset(struct iavf_adapter *adapter)
|
2014-02-20 19:29:05 -08:00
|
|
|
{
|
|
|
|
/* Don't check CURRENT_OP - this is always higher priority */
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_send_pf_msg(adapter, VIRTCHNL_OP_RESET_VF, NULL, 0);
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
|
2014-02-20 19:29:05 -08:00
|
|
|
}
|
2013-12-21 06:13:01 +00:00
|
|
|
|
|
|
|
/**
|
2018-09-14 17:37:46 -07:00
|
|
|
* iavf_virtchnl_completion
|
2013-12-21 06:13:01 +00:00
|
|
|
* @adapter: adapter structure
|
|
|
|
* @v_opcode: opcode sent by PF
|
|
|
|
* @v_retval: retval sent by PF
|
|
|
|
* @msg: message sent by PF
|
|
|
|
* @msglen: message length
|
|
|
|
*
|
|
|
|
* Asynchronous completion function for admin queue messages. Rather than busy
|
|
|
|
* wait, we fire off our requests and assume that no errors will be returned.
|
|
|
|
* This function handles the reply messages.
|
|
|
|
**/
|
2018-09-14 17:37:46 -07:00
|
|
|
void iavf_virtchnl_completion(struct iavf_adapter *adapter,
|
2019-04-17 15:17:30 -07:00
|
|
|
enum virtchnl_ops v_opcode,
|
|
|
|
enum iavf_status v_retval, u8 *msg, u16 msglen)
|
2013-12-21 06:13:01 +00:00
|
|
|
{
|
|
|
|
struct net_device *netdev = adapter->netdev;
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
if (v_opcode == VIRTCHNL_OP_EVENT) {
|
|
|
|
struct virtchnl_pf_event *vpe =
|
|
|
|
(struct virtchnl_pf_event *)msg;
|
2020-06-05 10:09:43 -07:00
|
|
|
bool link_up = iavf_get_vpe_link_status(adapter, vpe);
|
2018-09-14 17:37:47 -07:00
|
|
|
|
2013-12-21 06:13:01 +00:00
|
|
|
switch (vpe->event) {
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_EVENT_LINK_CHANGE:
|
2020-06-05 10:09:43 -07:00
|
|
|
iavf_set_adapter_link_speed_from_vpe(adapter, vpe);
|
2018-01-05 04:55:21 -05:00
|
|
|
|
|
|
|
/* we've already got the right link status, bail */
|
|
|
|
if (adapter->link_up == link_up)
|
|
|
|
break;
|
|
|
|
|
2018-01-23 08:50:55 -08:00
|
|
|
if (link_up) {
|
|
|
|
/* If we get link up message and start queues
|
|
|
|
* before our queues are configured it will
|
|
|
|
* trigger a TX hang. In that case, just ignore
|
|
|
|
* the link status message,we'll get another one
|
|
|
|
* after we enable queues and actually prepared
|
|
|
|
* to send traffic.
|
|
|
|
*/
|
2018-09-14 17:37:46 -07:00
|
|
|
if (adapter->state != __IAVF_RUNNING)
|
2018-01-23 08:50:55 -08:00
|
|
|
break;
|
|
|
|
|
|
|
|
/* For ADq enabled VF, we reconfigure VSIs and
|
|
|
|
* re-allocate queues. Hence wait till all
|
|
|
|
* queues are enabled.
|
|
|
|
*/
|
|
|
|
if (adapter->flags &
|
2018-09-14 17:37:46 -07:00
|
|
|
IAVF_FLAG_QUEUES_DISABLED)
|
2018-01-23 08:50:55 -08:00
|
|
|
break;
|
|
|
|
}
|
2018-01-05 04:55:21 -05:00
|
|
|
|
|
|
|
adapter->link_up = link_up;
|
|
|
|
if (link_up) {
|
|
|
|
netif_tx_start_all_queues(netdev);
|
|
|
|
netif_carrier_on(netdev);
|
|
|
|
} else {
|
|
|
|
netif_tx_stop_all_queues(netdev);
|
|
|
|
netif_carrier_off(netdev);
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_print_link_message(adapter);
|
2013-12-21 06:13:01 +00:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_EVENT_RESET_IMPENDING:
|
2021-08-31 12:12:02 +02:00
|
|
|
dev_info(&adapter->pdev->dev, "Reset indication received from the PF\n");
|
2018-09-14 17:37:46 -07:00
|
|
|
if (!(adapter->flags & IAVF_FLAG_RESET_PENDING)) {
|
|
|
|
adapter->flags |= IAVF_FLAG_RESET_PENDING;
|
i40evf: refactor reset handling
Respond better to a VF reset event. When a reset is signaled by the
PF, or detected by the watchdog task, prevent the watchdog from
processing admin queue requests, and schedule the reset task.
In the reset task, wait first for the reset to start, then for it to
complete, then reinit the driver.
If the reset never appears to complete after a long, long time (>10
seconds is possible depending on what's going on with the PF driver),
then set a flag to indicate that PF communications have failed.
If this flag is set, check for the reset to complete in the watchdog,
and attempt to do a full reinitialization of the driver from scratch.
With these changes the VF driver correctly handles a PF reset event
while running on bare metal, or in a VM.
Also update copyrights.
Change-ID: I93513efd0b50523a8345e7f6a33a5e4f8a2a5996
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-02-13 03:48:53 -08:00
|
|
|
dev_info(&adapter->pdev->dev, "Scheduling reset task\n");
|
2019-05-14 10:37:05 -07:00
|
|
|
queue_work(iavf_wq, &adapter->reset_task);
|
i40evf: refactor reset handling
Respond better to a VF reset event. When a reset is signaled by the
PF, or detected by the watchdog task, prevent the watchdog from
processing admin queue requests, and schedule the reset task.
In the reset task, wait first for the reset to start, then for it to
complete, then reinit the driver.
If the reset never appears to complete after a long, long time (>10
seconds is possible depending on what's going on with the PF driver),
then set a flag to indicate that PF communications have failed.
If this flag is set, check for the reset to complete in the watchdog,
and attempt to do a full reinitialization of the driver from scratch.
With these changes the VF driver correctly handles a PF reset event
while running on bare metal, or in a VM.
Also update copyrights.
Change-ID: I93513efd0b50523a8345e7f6a33a5e4f8a2a5996
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-02-13 03:48:53 -08:00
|
|
|
}
|
2013-12-21 06:13:01 +00:00
|
|
|
break;
|
|
|
|
default:
|
2015-08-26 15:14:17 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Unknown event %d from PF\n",
|
|
|
|
vpe->event);
|
2013-12-21 06:13:01 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (v_retval) {
|
2015-10-21 19:47:11 -04:00
|
|
|
switch (v_opcode) {
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_ADD_VLAN:
|
2015-10-21 19:47:11 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Failed to add VLAN filter, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw, v_retval));
|
2015-10-21 19:47:11 -04:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_ADD_ETH_ADDR:
|
2015-10-21 19:47:11 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Failed to add MAC filter, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw, v_retval));
|
2021-08-18 10:42:17 -07:00
|
|
|
iavf_mac_add_reject(adapter);
|
2019-09-05 08:34:22 +02:00
|
|
|
/* restore administratively set MAC address */
|
|
|
|
ether_addr_copy(adapter->hw.mac.addr, netdev->dev_addr);
|
2015-10-21 19:47:11 -04:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_DEL_VLAN:
|
2015-10-21 19:47:11 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Failed to delete VLAN filter, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw, v_retval));
|
2015-10-21 19:47:11 -04:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_DEL_ETH_ADDR:
|
2015-10-21 19:47:11 -04:00
|
|
|
dev_err(&adapter->pdev->dev, "Failed to delete MAC filter, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw, v_retval));
|
2015-10-21 19:47:11 -04:00
|
|
|
break;
|
2018-01-23 08:50:57 -08:00
|
|
|
case VIRTCHNL_OP_ENABLE_CHANNELS:
|
|
|
|
dev_err(&adapter->pdev->dev, "Failed to configure queue channels, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw, v_retval));
|
|
|
|
adapter->flags &= ~IAVF_FLAG_REINIT_ITR_NEEDED;
|
|
|
|
adapter->ch_config.state = __IAVF_TC_INVALID;
|
2018-01-23 08:50:57 -08:00
|
|
|
netdev_reset_tc(netdev);
|
|
|
|
netif_tx_start_all_queues(netdev);
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DISABLE_CHANNELS:
|
|
|
|
dev_err(&adapter->pdev->dev, "Failed to disable queue channels, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw, v_retval));
|
|
|
|
adapter->flags &= ~IAVF_FLAG_REINIT_ITR_NEEDED;
|
|
|
|
adapter->ch_config.state = __IAVF_TC_RUNNING;
|
2018-01-23 08:50:57 -08:00
|
|
|
netif_tx_start_all_queues(netdev);
|
|
|
|
break;
|
2018-01-23 08:51:05 -08:00
|
|
|
case VIRTCHNL_OP_ADD_CLOUD_FILTER: {
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_cloud_filter *cf, *cftmp;
|
2018-01-23 08:51:05 -08:00
|
|
|
|
|
|
|
list_for_each_entry_safe(cf, cftmp,
|
|
|
|
&adapter->cloud_filter_list,
|
|
|
|
list) {
|
2018-09-14 17:37:46 -07:00
|
|
|
if (cf->state == __IAVF_CF_ADD_PENDING) {
|
|
|
|
cf->state = __IAVF_CF_INVALID;
|
2018-01-23 08:51:05 -08:00
|
|
|
dev_info(&adapter->pdev->dev, "Failed to add cloud filter, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw,
|
|
|
|
v_retval));
|
|
|
|
iavf_print_cloud_filter(adapter,
|
|
|
|
&cf->f);
|
2018-01-23 08:51:05 -08:00
|
|
|
list_del(&cf->list);
|
|
|
|
kfree(cf);
|
|
|
|
adapter->num_cloud_filters--;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DEL_CLOUD_FILTER: {
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_cloud_filter *cf;
|
2018-01-23 08:51:05 -08:00
|
|
|
|
|
|
|
list_for_each_entry(cf, &adapter->cloud_filter_list,
|
|
|
|
list) {
|
2018-09-14 17:37:46 -07:00
|
|
|
if (cf->state == __IAVF_CF_DEL_PENDING) {
|
|
|
|
cf->state = __IAVF_CF_ACTIVE;
|
2018-01-23 08:51:05 -08:00
|
|
|
dev_info(&adapter->pdev->dev, "Failed to del cloud filter, error %s\n",
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_stat_str(&adapter->hw,
|
|
|
|
v_retval));
|
|
|
|
iavf_print_cloud_filter(adapter,
|
|
|
|
&cf->f);
|
2018-01-23 08:51:05 -08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
2021-03-09 11:08:11 +08:00
|
|
|
case VIRTCHNL_OP_ADD_FDIR_FILTER: {
|
|
|
|
struct iavf_fdir_fltr *fdir, *fdir_tmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
list_for_each_entry_safe(fdir, fdir_tmp,
|
|
|
|
&adapter->fdir_list_head,
|
|
|
|
list) {
|
|
|
|
if (fdir->state == IAVF_FDIR_FLTR_ADD_PENDING) {
|
|
|
|
dev_info(&adapter->pdev->dev, "Failed to add Flow Director filter, error %s\n",
|
|
|
|
iavf_stat_str(&adapter->hw,
|
|
|
|
v_retval));
|
2021-03-09 11:08:12 +08:00
|
|
|
iavf_print_fdir_fltr(adapter, fdir);
|
2021-03-09 11:08:11 +08:00
|
|
|
if (msglen)
|
|
|
|
dev_err(&adapter->pdev->dev,
|
|
|
|
"%s\n", msg);
|
|
|
|
list_del(&fdir->list);
|
|
|
|
kfree(fdir);
|
|
|
|
adapter->fdir_active_fltr--;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DEL_FDIR_FILTER: {
|
|
|
|
struct iavf_fdir_fltr *fdir;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
list_for_each_entry(fdir, &adapter->fdir_list_head,
|
|
|
|
list) {
|
|
|
|
if (fdir->state == IAVF_FDIR_FLTR_DEL_PENDING) {
|
|
|
|
fdir->state = IAVF_FDIR_FLTR_ACTIVE;
|
|
|
|
dev_info(&adapter->pdev->dev, "Failed to del Flow Director filter, error %s\n",
|
|
|
|
iavf_stat_str(&adapter->hw,
|
|
|
|
v_retval));
|
2021-03-09 11:08:12 +08:00
|
|
|
iavf_print_fdir_fltr(adapter, fdir);
|
2021-03-09 11:08:11 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
}
|
|
|
|
break;
|
2021-04-13 08:48:41 +08:00
|
|
|
case VIRTCHNL_OP_ADD_RSS_CFG: {
|
|
|
|
struct iavf_adv_rss *rss, *rss_tmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->adv_rss_lock);
|
|
|
|
list_for_each_entry_safe(rss, rss_tmp,
|
|
|
|
&adapter->adv_rss_list_head,
|
|
|
|
list) {
|
|
|
|
if (rss->state == IAVF_ADV_RSS_ADD_PENDING) {
|
2021-04-13 08:48:42 +08:00
|
|
|
iavf_print_adv_rss_cfg(adapter, rss,
|
|
|
|
"Failed to change the input set for",
|
|
|
|
NULL);
|
2021-04-13 08:48:41 +08:00
|
|
|
list_del(&rss->list);
|
|
|
|
kfree(rss);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->adv_rss_lock);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DEL_RSS_CFG: {
|
|
|
|
struct iavf_adv_rss *rss;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->adv_rss_lock);
|
|
|
|
list_for_each_entry(rss, &adapter->adv_rss_list_head,
|
|
|
|
list) {
|
|
|
|
if (rss->state == IAVF_ADV_RSS_DEL_PENDING) {
|
|
|
|
rss->state = IAVF_ADV_RSS_ACTIVE;
|
|
|
|
dev_err(&adapter->pdev->dev, "Failed to delete RSS configuration, error %s\n",
|
|
|
|
iavf_stat_str(&adapter->hw,
|
|
|
|
v_retval));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->adv_rss_lock);
|
|
|
|
}
|
|
|
|
break;
|
2021-03-09 11:08:11 +08:00
|
|
|
case VIRTCHNL_OP_ENABLE_VLAN_STRIPPING:
|
|
|
|
case VIRTCHNL_OP_DISABLE_VLAN_STRIPPING:
|
|
|
|
dev_warn(&adapter->pdev->dev, "Changing VLAN Stripping is not allowed when Port VLAN is configured\n");
|
|
|
|
break;
|
2015-10-21 19:47:11 -04:00
|
|
|
default:
|
|
|
|
dev_err(&adapter->pdev->dev, "PF returned error %d (%s) to our request %d\n",
|
2018-09-14 17:37:47 -07:00
|
|
|
v_retval, iavf_stat_str(&adapter->hw, v_retval),
|
2015-10-21 19:47:11 -04:00
|
|
|
v_opcode);
|
|
|
|
}
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|
|
|
|
switch (v_opcode) {
|
2021-08-18 10:42:17 -07:00
|
|
|
case VIRTCHNL_OP_ADD_ETH_ADDR:
|
|
|
|
if (!v_retval)
|
|
|
|
iavf_mac_add_ok(adapter);
|
2019-09-05 08:34:22 +02:00
|
|
|
if (!ether_addr_equal(netdev->dev_addr, adapter->hw.mac.addr))
|
2021-10-01 14:32:23 -07:00
|
|
|
eth_hw_addr_set(netdev, adapter->hw.mac.addr);
|
2019-09-05 08:34:22 +02:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_GET_STATS: {
|
2018-09-14 17:37:55 -07:00
|
|
|
struct iavf_eth_stats *stats =
|
|
|
|
(struct iavf_eth_stats *)msg;
|
2017-04-06 08:46:28 +02:00
|
|
|
netdev->stats.rx_packets = stats->rx_unicast +
|
|
|
|
stats->rx_multicast +
|
|
|
|
stats->rx_broadcast;
|
|
|
|
netdev->stats.tx_packets = stats->tx_unicast +
|
|
|
|
stats->tx_multicast +
|
|
|
|
stats->tx_broadcast;
|
|
|
|
netdev->stats.rx_bytes = stats->rx_bytes;
|
|
|
|
netdev->stats.tx_bytes = stats->tx_bytes;
|
|
|
|
netdev->stats.tx_errors = stats->tx_errors;
|
|
|
|
netdev->stats.rx_dropped = stats->rx_discards;
|
|
|
|
netdev->stats.tx_dropped = stats->tx_discards;
|
2013-12-21 06:13:01 +00:00
|
|
|
adapter->current_stats = *stats;
|
|
|
|
}
|
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_GET_VF_RESOURCES: {
|
|
|
|
u16 len = sizeof(struct virtchnl_vf_resource) +
|
2018-09-14 17:37:55 -07:00
|
|
|
IAVF_MAX_VF_VSI *
|
2017-05-11 11:23:11 -07:00
|
|
|
sizeof(struct virtchnl_vsi_resource);
|
i40evf: handle big resets
The most common type of reset that the VF will encounter is a PF reset
that cascades down into a VF reset for each VF. In this case, the VF
will always be assigned the same VSI and recovery is fairly simple.
However, in the case of 'bigger' resets, such as a Core or EMP reset,
when the device is reinitialized, it's probable that the VF will NOT get
the same VSI. When this happens, the VF will not be able to recover, as
it will continue to request resources for its original VSI.
Add an extra state to the admin queue state machine so that the driver
can re-request its configuration information at runtime. During reset
recovery, set this bit in the aq_required field, and fetch the (possibly
new) configuration information before attempting to bring the driver
back up. Since the driver doesn't know what kind of reset it has
encountered, this step is done even for a PF reset, but it doesn't hurt
anything - it just gets the same VSI back.
Change-ID: I915d59ffb40375215117362f4ac7a37811aba748
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2015-06-04 16:23:58 -04:00
|
|
|
memcpy(adapter->vf_res, msg, min(msglen, len));
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_validate_num_queues(adapter);
|
|
|
|
iavf_vf_parse_hw_config(&adapter->hw, adapter->vf_res);
|
2018-08-20 08:12:26 -07:00
|
|
|
if (is_zero_ether_addr(adapter->hw.mac.addr)) {
|
|
|
|
/* restore current mac address */
|
|
|
|
ether_addr_copy(adapter->hw.mac.addr, netdev->dev_addr);
|
|
|
|
} else {
|
|
|
|
/* refresh current mac address if changed */
|
2021-10-01 14:32:23 -07:00
|
|
|
eth_hw_addr_set(netdev, adapter->hw.mac.addr);
|
2018-08-20 08:12:26 -07:00
|
|
|
ether_addr_copy(netdev->perm_addr,
|
|
|
|
adapter->hw.mac.addr);
|
|
|
|
}
|
2019-12-17 11:29:23 +01:00
|
|
|
spin_lock_bh(&adapter->mac_vlan_list_lock);
|
|
|
|
iavf_add_filter(adapter, adapter->hw.mac.addr);
|
iavf: Fix VLAN feature flags after VFR
When a VF goes through a reset, it's possible for the VF's feature set
to change. For example it may lose the VIRTCHNL_VF_OFFLOAD_VLAN
capability after VF reset. Unfortunately, the driver doesn't correctly
deal with this situation and errors are seen from downing/upping the
interface and/or moving the interface in/out of a network namespace.
When setting the interface down/up we see the following errors after the
VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from the VF:
ice 0000:51:00.1: VF 1 failed opcode 12, retval: -64 iavf 0000:51:09.1:
Failed to add VLAN filter, error IAVF_NOT_SUPPORTED ice 0000:51:00.1: VF
1 failed opcode 13, retval: -64 iavf 0000:51:09.1: Failed to delete VLAN
filter, error IAVF_NOT_SUPPORTED
These add/delete errors are happening because the VLAN filters are
tracked internally to the driver and regardless of the VLAN_ALLOWED()
setting the driver tries to delete/re-add them over virtchnl.
Fix the delete failure by making sure to delete any VLAN filter tracking
in the driver when a removal request is made, while preventing the
virtchnl request. This makes it so the driver's VLAN list is up to date
and the errors are
Fix the add failure by making sure the check for VLAN_ALLOWED() during
reset is done after the VF receives its capability list from the PF via
VIRTCHNL_OP_GET_VF_RESOURCES. If VLAN functionality is not allowed, then
prevent requesting re-adding the filters over virtchnl.
When moving the interface into a network namespace we see the following
errors after the VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from
the VF:
iavf 0000:51:09.1 enp81s0f1v1: NIC Link is Up Speed is 25 Gbps Full Duplex
iavf 0000:51:09.1 temp_27: renamed from enp81s0f1v1
iavf 0000:51:09.1 mgmt: renamed from temp_27
iavf 0000:51:09.1 dev27: set_features() failed (-22); wanted 0x020190001fd54833, left 0x020190001fd54bb3
These errors are happening because we aren't correctly updating the
netdev capabilities and dealing with ndo_fix_features() and
ndo_set_features() correctly.
Fix this by only reporting errors in the driver's ndo_set_features()
callback when VIRTCHNL_VF_OFFLOAD_VLAN is not allowed and any attempt to
enable the VLAN features is made. Also, make sure to disable VLAN
insertion, filtering, and stripping since the VIRTCHNL_VF_OFFLOAD_VLAN
flag applies to all of them and not just VLAN stripping.
Also, after we process the capabilities in the VF reset path, make sure
to call netdev_update_features() in case the capabilities have changed
in order to update the netdev's feature set to match the VF's actual
capabilities.
Lastly, make sure to always report success on VLAN filter delete when
VIRTCHNL_VF_OFFLOAD_VLAN is not supported. The changed flow in
iavf_del_vlans() allows the stack to delete previosly existing VLAN
filters even if VLAN filtering is not allowed. This makes it so the VLAN
filter list is up to date.
Fixes: 8774370d268f ("i40e/i40evf: support for VF VLAN tag stripping control")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-05 09:20:25 -07:00
|
|
|
|
|
|
|
if (VLAN_ALLOWED(adapter)) {
|
|
|
|
if (!list_empty(&adapter->vlan_filter_list)) {
|
|
|
|
struct iavf_vlan_filter *vlf;
|
|
|
|
|
|
|
|
/* re-add all VLAN filters over virtchnl */
|
|
|
|
list_for_each_entry(vlf,
|
|
|
|
&adapter->vlan_filter_list,
|
|
|
|
list)
|
|
|
|
vlf->add = true;
|
|
|
|
|
|
|
|
adapter->aq_required |=
|
|
|
|
IAVF_FLAG_AQ_ADD_VLAN_FILTER;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-17 11:29:23 +01:00
|
|
|
spin_unlock_bh(&adapter->mac_vlan_list_lock);
|
2021-11-29 16:16:00 -08:00
|
|
|
|
|
|
|
iavf_parse_vf_resource_msg(adapter);
|
|
|
|
|
|
|
|
/* negotiated VIRTCHNL_VF_OFFLOAD_VLAN_V2, so wait for the
|
|
|
|
* response to VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS to finish
|
|
|
|
* configuration
|
|
|
|
*/
|
|
|
|
if (VLAN_V2_ALLOWED(adapter))
|
|
|
|
break;
|
|
|
|
/* fallthrough and finish config if VIRTCHNL_VF_OFFLOAD_VLAN_V2
|
|
|
|
* wasn't successfully negotiated with the PF
|
|
|
|
*/
|
|
|
|
}
|
|
|
|
fallthrough;
|
|
|
|
case VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS: {
|
|
|
|
if (v_opcode == VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS)
|
|
|
|
memcpy(&adapter->vlan_v2_caps, msg,
|
|
|
|
min_t(u16, msglen,
|
|
|
|
sizeof(adapter->vlan_v2_caps)));
|
|
|
|
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_process_config(adapter);
|
iavf: Fix VLAN feature flags after VFR
When a VF goes through a reset, it's possible for the VF's feature set
to change. For example it may lose the VIRTCHNL_VF_OFFLOAD_VLAN
capability after VF reset. Unfortunately, the driver doesn't correctly
deal with this situation and errors are seen from downing/upping the
interface and/or moving the interface in/out of a network namespace.
When setting the interface down/up we see the following errors after the
VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from the VF:
ice 0000:51:00.1: VF 1 failed opcode 12, retval: -64 iavf 0000:51:09.1:
Failed to add VLAN filter, error IAVF_NOT_SUPPORTED ice 0000:51:00.1: VF
1 failed opcode 13, retval: -64 iavf 0000:51:09.1: Failed to delete VLAN
filter, error IAVF_NOT_SUPPORTED
These add/delete errors are happening because the VLAN filters are
tracked internally to the driver and regardless of the VLAN_ALLOWED()
setting the driver tries to delete/re-add them over virtchnl.
Fix the delete failure by making sure to delete any VLAN filter tracking
in the driver when a removal request is made, while preventing the
virtchnl request. This makes it so the driver's VLAN list is up to date
and the errors are
Fix the add failure by making sure the check for VLAN_ALLOWED() during
reset is done after the VF receives its capability list from the PF via
VIRTCHNL_OP_GET_VF_RESOURCES. If VLAN functionality is not allowed, then
prevent requesting re-adding the filters over virtchnl.
When moving the interface into a network namespace we see the following
errors after the VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from
the VF:
iavf 0000:51:09.1 enp81s0f1v1: NIC Link is Up Speed is 25 Gbps Full Duplex
iavf 0000:51:09.1 temp_27: renamed from enp81s0f1v1
iavf 0000:51:09.1 mgmt: renamed from temp_27
iavf 0000:51:09.1 dev27: set_features() failed (-22); wanted 0x020190001fd54833, left 0x020190001fd54bb3
These errors are happening because we aren't correctly updating the
netdev capabilities and dealing with ndo_fix_features() and
ndo_set_features() correctly.
Fix this by only reporting errors in the driver's ndo_set_features()
callback when VIRTCHNL_VF_OFFLOAD_VLAN is not allowed and any attempt to
enable the VLAN features is made. Also, make sure to disable VLAN
insertion, filtering, and stripping since the VIRTCHNL_VF_OFFLOAD_VLAN
flag applies to all of them and not just VLAN stripping.
Also, after we process the capabilities in the VF reset path, make sure
to call netdev_update_features() in case the capabilities have changed
in order to update the netdev's feature set to match the VF's actual
capabilities.
Lastly, make sure to always report success on VLAN filter delete when
VIRTCHNL_VF_OFFLOAD_VLAN is not supported. The changed flow in
iavf_del_vlans() allows the stack to delete previosly existing VLAN
filters even if VLAN filtering is not allowed. This makes it so the VLAN
filter list is up to date.
Fixes: 8774370d268f ("i40e/i40evf: support for VF VLAN tag stripping control")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-05 09:20:25 -07:00
|
|
|
|
|
|
|
/* unlock crit_lock before acquiring rtnl_lock as other
|
|
|
|
* processes holding rtnl_lock could be waiting for the same
|
|
|
|
* crit_lock
|
|
|
|
*/
|
|
|
|
mutex_unlock(&adapter->crit_lock);
|
2021-11-29 16:16:00 -08:00
|
|
|
/* VLAN capabilities can change during VFR, so make sure to
|
|
|
|
* update the netdev features with the new capabilities
|
|
|
|
*/
|
iavf: Fix VLAN feature flags after VFR
When a VF goes through a reset, it's possible for the VF's feature set
to change. For example it may lose the VIRTCHNL_VF_OFFLOAD_VLAN
capability after VF reset. Unfortunately, the driver doesn't correctly
deal with this situation and errors are seen from downing/upping the
interface and/or moving the interface in/out of a network namespace.
When setting the interface down/up we see the following errors after the
VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from the VF:
ice 0000:51:00.1: VF 1 failed opcode 12, retval: -64 iavf 0000:51:09.1:
Failed to add VLAN filter, error IAVF_NOT_SUPPORTED ice 0000:51:00.1: VF
1 failed opcode 13, retval: -64 iavf 0000:51:09.1: Failed to delete VLAN
filter, error IAVF_NOT_SUPPORTED
These add/delete errors are happening because the VLAN filters are
tracked internally to the driver and regardless of the VLAN_ALLOWED()
setting the driver tries to delete/re-add them over virtchnl.
Fix the delete failure by making sure to delete any VLAN filter tracking
in the driver when a removal request is made, while preventing the
virtchnl request. This makes it so the driver's VLAN list is up to date
and the errors are
Fix the add failure by making sure the check for VLAN_ALLOWED() during
reset is done after the VF receives its capability list from the PF via
VIRTCHNL_OP_GET_VF_RESOURCES. If VLAN functionality is not allowed, then
prevent requesting re-adding the filters over virtchnl.
When moving the interface into a network namespace we see the following
errors after the VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from
the VF:
iavf 0000:51:09.1 enp81s0f1v1: NIC Link is Up Speed is 25 Gbps Full Duplex
iavf 0000:51:09.1 temp_27: renamed from enp81s0f1v1
iavf 0000:51:09.1 mgmt: renamed from temp_27
iavf 0000:51:09.1 dev27: set_features() failed (-22); wanted 0x020190001fd54833, left 0x020190001fd54bb3
These errors are happening because we aren't correctly updating the
netdev capabilities and dealing with ndo_fix_features() and
ndo_set_features() correctly.
Fix this by only reporting errors in the driver's ndo_set_features()
callback when VIRTCHNL_VF_OFFLOAD_VLAN is not allowed and any attempt to
enable the VLAN features is made. Also, make sure to disable VLAN
insertion, filtering, and stripping since the VIRTCHNL_VF_OFFLOAD_VLAN
flag applies to all of them and not just VLAN stripping.
Also, after we process the capabilities in the VF reset path, make sure
to call netdev_update_features() in case the capabilities have changed
in order to update the netdev's feature set to match the VF's actual
capabilities.
Lastly, make sure to always report success on VLAN filter delete when
VIRTCHNL_VF_OFFLOAD_VLAN is not supported. The changed flow in
iavf_del_vlans() allows the stack to delete previosly existing VLAN
filters even if VLAN filtering is not allowed. This makes it so the VLAN
filter list is up to date.
Fixes: 8774370d268f ("i40e/i40evf: support for VF VLAN tag stripping control")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-05 09:20:25 -07:00
|
|
|
rtnl_lock();
|
2021-11-29 16:16:00 -08:00
|
|
|
netdev_update_features(netdev);
|
iavf: Fix VLAN feature flags after VFR
When a VF goes through a reset, it's possible for the VF's feature set
to change. For example it may lose the VIRTCHNL_VF_OFFLOAD_VLAN
capability after VF reset. Unfortunately, the driver doesn't correctly
deal with this situation and errors are seen from downing/upping the
interface and/or moving the interface in/out of a network namespace.
When setting the interface down/up we see the following errors after the
VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from the VF:
ice 0000:51:00.1: VF 1 failed opcode 12, retval: -64 iavf 0000:51:09.1:
Failed to add VLAN filter, error IAVF_NOT_SUPPORTED ice 0000:51:00.1: VF
1 failed opcode 13, retval: -64 iavf 0000:51:09.1: Failed to delete VLAN
filter, error IAVF_NOT_SUPPORTED
These add/delete errors are happening because the VLAN filters are
tracked internally to the driver and regardless of the VLAN_ALLOWED()
setting the driver tries to delete/re-add them over virtchnl.
Fix the delete failure by making sure to delete any VLAN filter tracking
in the driver when a removal request is made, while preventing the
virtchnl request. This makes it so the driver's VLAN list is up to date
and the errors are
Fix the add failure by making sure the check for VLAN_ALLOWED() during
reset is done after the VF receives its capability list from the PF via
VIRTCHNL_OP_GET_VF_RESOURCES. If VLAN functionality is not allowed, then
prevent requesting re-adding the filters over virtchnl.
When moving the interface into a network namespace we see the following
errors after the VIRTCHNL_VF_OFFLOAD_VLAN capability was taken away from
the VF:
iavf 0000:51:09.1 enp81s0f1v1: NIC Link is Up Speed is 25 Gbps Full Duplex
iavf 0000:51:09.1 temp_27: renamed from enp81s0f1v1
iavf 0000:51:09.1 mgmt: renamed from temp_27
iavf 0000:51:09.1 dev27: set_features() failed (-22); wanted 0x020190001fd54833, left 0x020190001fd54bb3
These errors are happening because we aren't correctly updating the
netdev capabilities and dealing with ndo_fix_features() and
ndo_set_features() correctly.
Fix this by only reporting errors in the driver's ndo_set_features()
callback when VIRTCHNL_VF_OFFLOAD_VLAN is not allowed and any attempt to
enable the VLAN features is made. Also, make sure to disable VLAN
insertion, filtering, and stripping since the VIRTCHNL_VF_OFFLOAD_VLAN
flag applies to all of them and not just VLAN stripping.
Also, after we process the capabilities in the VF reset path, make sure
to call netdev_update_features() in case the capabilities have changed
in order to update the netdev's feature set to match the VF's actual
capabilities.
Lastly, make sure to always report success on VLAN filter delete when
VIRTCHNL_VF_OFFLOAD_VLAN is not supported. The changed flow in
iavf_del_vlans() allows the stack to delete previosly existing VLAN
filters even if VLAN filtering is not allowed. This makes it so the VLAN
filter list is up to date.
Fixes: 8774370d268f ("i40e/i40evf: support for VF VLAN tag stripping control")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
2021-11-05 09:20:25 -07:00
|
|
|
rtnl_unlock();
|
|
|
|
if (iavf_lock_timeout(&adapter->crit_lock, 10000))
|
|
|
|
dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n",
|
|
|
|
__FUNCTION__);
|
|
|
|
|
2021-11-29 16:16:03 -08:00
|
|
|
/* Request VLAN offload settings */
|
|
|
|
if (VLAN_V2_ALLOWED(adapter))
|
|
|
|
iavf_set_vlan_offload_features(adapter, 0,
|
|
|
|
netdev->features);
|
|
|
|
|
2021-11-29 16:16:02 -08:00
|
|
|
iavf_set_queue_vlan_tag_loc(adapter);
|
|
|
|
|
i40evf: handle big resets
The most common type of reset that the VF will encounter is a PF reset
that cascades down into a VF reset for each VF. In this case, the VF
will always be assigned the same VSI and recovery is fairly simple.
However, in the case of 'bigger' resets, such as a Core or EMP reset,
when the device is reinitialized, it's probable that the VF will NOT get
the same VSI. When this happens, the VF will not be able to recover, as
it will continue to request resources for its original VSI.
Add an extra state to the admin queue state machine so that the driver
can re-request its configuration information at runtime. During reset
recovery, set this bit in the aq_required field, and fetch the (possibly
new) configuration information before attempting to bring the driver
back up. Since the driver doesn't know what kind of reset it has
encountered, this step is done even for a PF reset, but it doesn't hurt
anything - it just gets the same VSI back.
Change-ID: I915d59ffb40375215117362f4ac7a37811aba748
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
2015-06-04 16:23:58 -04:00
|
|
|
}
|
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_ENABLE_QUEUES:
|
2013-12-21 06:13:01 +00:00
|
|
|
/* enable transmits */
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_irq_enable(adapter, true);
|
|
|
|
adapter->flags &= ~IAVF_FLAG_QUEUES_DISABLED;
|
2013-12-21 06:13:01 +00:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_DISABLE_QUEUES:
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_free_all_tx_resources(adapter);
|
|
|
|
iavf_free_all_rx_resources(adapter);
|
|
|
|
if (adapter->state == __IAVF_DOWN_PENDING) {
|
2021-08-19 08:47:40 +00:00
|
|
|
iavf_change_state(adapter, __IAVF_DOWN);
|
2017-06-23 04:24:44 -04:00
|
|
|
wake_up(&adapter->down_waitqueue);
|
|
|
|
}
|
2013-12-21 06:13:01 +00:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_VERSION:
|
|
|
|
case VIRTCHNL_OP_CONFIG_IRQ_MAP:
|
2015-04-07 19:45:32 -04:00
|
|
|
/* Don't display an error if we get these out of sequence.
|
|
|
|
* If the firmware needed to get kicked, we'll get these and
|
|
|
|
* it's no problem.
|
|
|
|
*/
|
|
|
|
if (v_opcode != adapter->current_op)
|
|
|
|
return;
|
2013-12-21 06:13:01 +00:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_IWARP:
|
2017-01-24 10:23:59 -08:00
|
|
|
/* Gobble zero-length replies from the PF. They indicate that
|
|
|
|
* a previous message was received OK, and the client doesn't
|
|
|
|
* care about that.
|
|
|
|
*/
|
|
|
|
if (msglen && CLIENT_ENABLED(adapter))
|
2018-09-14 17:37:46 -07:00
|
|
|
iavf_notify_client_message(&adapter->vsi, msg, msglen);
|
2017-01-24 10:23:59 -08:00
|
|
|
break;
|
|
|
|
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP:
|
2017-02-09 23:35:18 -08:00
|
|
|
adapter->client_pending &=
|
2017-05-11 11:23:11 -07:00
|
|
|
~(BIT(VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP));
|
2017-02-09 23:35:18 -08:00
|
|
|
break;
|
2017-05-11 11:23:11 -07:00
|
|
|
case VIRTCHNL_OP_GET_RSS_HENA_CAPS: {
|
2017-05-11 11:23:15 -07:00
|
|
|
struct virtchnl_rss_hena *vrh = (struct virtchnl_rss_hena *)msg;
|
2018-09-14 17:37:47 -07:00
|
|
|
|
2016-04-12 08:30:44 -07:00
|
|
|
if (msglen == sizeof(*vrh))
|
|
|
|
adapter->hena = vrh->hena;
|
|
|
|
else
|
|
|
|
dev_warn(&adapter->pdev->dev,
|
|
|
|
"Invalid message %d from PF\n", v_opcode);
|
|
|
|
}
|
|
|
|
break;
|
2017-08-22 06:57:50 -04:00
|
|
|
case VIRTCHNL_OP_REQUEST_QUEUES: {
|
|
|
|
struct virtchnl_vf_res_request *vfres =
|
|
|
|
(struct virtchnl_vf_res_request *)msg;
|
2018-09-14 17:37:47 -07:00
|
|
|
|
2017-10-11 14:49:43 -07:00
|
|
|
if (vfres->num_queue_pairs != adapter->num_req_queues) {
|
2017-08-22 06:57:50 -04:00
|
|
|
dev_info(&adapter->pdev->dev,
|
|
|
|
"Requested %d queues, PF can support %d\n",
|
|
|
|
adapter->num_req_queues,
|
|
|
|
vfres->num_queue_pairs);
|
|
|
|
adapter->num_req_queues = 0;
|
2018-09-14 17:37:46 -07:00
|
|
|
adapter->flags &= ~IAVF_FLAG_REINIT_ITR_NEEDED;
|
2017-08-22 06:57:50 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
2018-01-23 08:51:05 -08:00
|
|
|
case VIRTCHNL_OP_ADD_CLOUD_FILTER: {
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_cloud_filter *cf;
|
2018-01-23 08:51:05 -08:00
|
|
|
|
|
|
|
list_for_each_entry(cf, &adapter->cloud_filter_list, list) {
|
2018-09-14 17:37:46 -07:00
|
|
|
if (cf->state == __IAVF_CF_ADD_PENDING)
|
|
|
|
cf->state = __IAVF_CF_ACTIVE;
|
2018-01-23 08:51:05 -08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DEL_CLOUD_FILTER: {
|
2018-09-14 17:37:46 -07:00
|
|
|
struct iavf_cloud_filter *cf, *cftmp;
|
2018-01-23 08:51:05 -08:00
|
|
|
|
|
|
|
list_for_each_entry_safe(cf, cftmp, &adapter->cloud_filter_list,
|
|
|
|
list) {
|
2018-09-14 17:37:46 -07:00
|
|
|
if (cf->state == __IAVF_CF_DEL_PENDING) {
|
|
|
|
cf->state = __IAVF_CF_INVALID;
|
2018-01-23 08:51:05 -08:00
|
|
|
list_del(&cf->list);
|
|
|
|
kfree(cf);
|
|
|
|
adapter->num_cloud_filters--;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
2021-03-09 11:08:11 +08:00
|
|
|
case VIRTCHNL_OP_ADD_FDIR_FILTER: {
|
|
|
|
struct virtchnl_fdir_add *add_fltr = (struct virtchnl_fdir_add *)msg;
|
|
|
|
struct iavf_fdir_fltr *fdir, *fdir_tmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
list_for_each_entry_safe(fdir, fdir_tmp,
|
|
|
|
&adapter->fdir_list_head,
|
|
|
|
list) {
|
|
|
|
if (fdir->state == IAVF_FDIR_FLTR_ADD_PENDING) {
|
|
|
|
if (add_fltr->status == VIRTCHNL_FDIR_SUCCESS) {
|
2021-03-09 11:08:12 +08:00
|
|
|
dev_info(&adapter->pdev->dev, "Flow Director filter with location %u is added\n",
|
|
|
|
fdir->loc);
|
2021-03-09 11:08:11 +08:00
|
|
|
fdir->state = IAVF_FDIR_FLTR_ACTIVE;
|
|
|
|
fdir->flow_id = add_fltr->flow_id;
|
|
|
|
} else {
|
|
|
|
dev_info(&adapter->pdev->dev, "Failed to add Flow Director filter with status: %d\n",
|
|
|
|
add_fltr->status);
|
2021-03-09 11:08:12 +08:00
|
|
|
iavf_print_fdir_fltr(adapter, fdir);
|
2021-03-09 11:08:11 +08:00
|
|
|
list_del(&fdir->list);
|
|
|
|
kfree(fdir);
|
|
|
|
adapter->fdir_active_fltr--;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DEL_FDIR_FILTER: {
|
|
|
|
struct virtchnl_fdir_del *del_fltr = (struct virtchnl_fdir_del *)msg;
|
|
|
|
struct iavf_fdir_fltr *fdir, *fdir_tmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
list_for_each_entry_safe(fdir, fdir_tmp, &adapter->fdir_list_head,
|
|
|
|
list) {
|
|
|
|
if (fdir->state == IAVF_FDIR_FLTR_DEL_PENDING) {
|
|
|
|
if (del_fltr->status == VIRTCHNL_FDIR_SUCCESS) {
|
2021-03-09 11:08:12 +08:00
|
|
|
dev_info(&adapter->pdev->dev, "Flow Director filter with location %u is deleted\n",
|
|
|
|
fdir->loc);
|
2021-03-09 11:08:11 +08:00
|
|
|
list_del(&fdir->list);
|
|
|
|
kfree(fdir);
|
|
|
|
adapter->fdir_active_fltr--;
|
|
|
|
} else {
|
|
|
|
fdir->state = IAVF_FDIR_FLTR_ACTIVE;
|
|
|
|
dev_info(&adapter->pdev->dev, "Failed to delete Flow Director filter with status: %d\n",
|
|
|
|
del_fltr->status);
|
2021-03-09 11:08:12 +08:00
|
|
|
iavf_print_fdir_fltr(adapter, fdir);
|
2021-03-09 11:08:11 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->fdir_fltr_lock);
|
|
|
|
}
|
|
|
|
break;
|
2021-04-13 08:48:41 +08:00
|
|
|
case VIRTCHNL_OP_ADD_RSS_CFG: {
|
|
|
|
struct iavf_adv_rss *rss;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->adv_rss_lock);
|
2021-04-13 08:48:42 +08:00
|
|
|
list_for_each_entry(rss, &adapter->adv_rss_list_head, list) {
|
|
|
|
if (rss->state == IAVF_ADV_RSS_ADD_PENDING) {
|
|
|
|
iavf_print_adv_rss_cfg(adapter, rss,
|
|
|
|
"Input set change for",
|
|
|
|
"successful");
|
2021-04-13 08:48:41 +08:00
|
|
|
rss->state = IAVF_ADV_RSS_ACTIVE;
|
2021-04-13 08:48:42 +08:00
|
|
|
}
|
|
|
|
}
|
2021-04-13 08:48:41 +08:00
|
|
|
spin_unlock_bh(&adapter->adv_rss_lock);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case VIRTCHNL_OP_DEL_RSS_CFG: {
|
|
|
|
struct iavf_adv_rss *rss, *rss_tmp;
|
|
|
|
|
|
|
|
spin_lock_bh(&adapter->adv_rss_lock);
|
|
|
|
list_for_each_entry_safe(rss, rss_tmp,
|
|
|
|
&adapter->adv_rss_list_head, list) {
|
|
|
|
if (rss->state == IAVF_ADV_RSS_DEL_PENDING) {
|
|
|
|
list_del(&rss->list);
|
|
|
|
kfree(rss);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_bh(&adapter->adv_rss_lock);
|
|
|
|
}
|
|
|
|
break;
|
2013-12-21 06:13:01 +00:00
|
|
|
default:
|
2017-01-24 10:23:59 -08:00
|
|
|
if (adapter->current_op && (v_opcode != adapter->current_op))
|
2015-04-07 19:45:32 -04:00
|
|
|
dev_warn(&adapter->pdev->dev, "Expected response %d from PF, received %d\n",
|
|
|
|
adapter->current_op, v_opcode);
|
2013-12-21 06:13:01 +00:00
|
|
|
break;
|
|
|
|
} /* switch v_opcode */
|
2017-05-11 11:23:11 -07:00
|
|
|
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
|
2013-12-21 06:13:01 +00:00
|
|
|
}
|