License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 15:07:57 +01:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2015-04-23 14:21:41 -04:00
|
|
|
/*
|
|
|
|
*
|
|
|
|
* A test for the patch "Allow compaction of unevictable pages".
|
|
|
|
* With this patch we should be able to allocate at least 1/4
|
|
|
|
* of RAM in huge pages. Without the patch much less is
|
|
|
|
* allocated.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <sys/mman.h>
|
|
|
|
#include <sys/resource.h>
|
|
|
|
#include <fcntl.h>
|
|
|
|
#include <errno.h>
|
|
|
|
#include <unistd.h>
|
|
|
|
#include <string.h>
|
|
|
|
|
2018-06-13 21:31:43 -06:00
|
|
|
#include "../kselftest.h"
|
|
|
|
|
2020-10-13 16:57:04 -07:00
|
|
|
#define MAP_SIZE_MB 100
|
|
|
|
#define MAP_SIZE (MAP_SIZE_MB * 1024 * 1024)
|
2015-04-23 14:21:41 -04:00
|
|
|
|
|
|
|
struct map_list {
|
|
|
|
void *map;
|
|
|
|
struct map_list *next;
|
|
|
|
};
|
|
|
|
|
|
|
|
int read_memory_info(unsigned long *memfree, unsigned long *hugepagesize)
|
|
|
|
{
|
|
|
|
char buffer[256] = {0};
|
|
|
|
char *cmd = "cat /proc/meminfo | grep -i memfree | grep -o '[0-9]*'";
|
|
|
|
FILE *cmdfile = popen(cmd, "r");
|
|
|
|
|
|
|
|
if (!(fgets(buffer, sizeof(buffer), cmdfile))) {
|
2024-01-01 13:36:12 +05:00
|
|
|
ksft_print_msg("Failed to read meminfo: %s\n", strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
pclose(cmdfile);
|
|
|
|
|
|
|
|
*memfree = atoll(buffer);
|
|
|
|
cmd = "cat /proc/meminfo | grep -i hugepagesize | grep -o '[0-9]*'";
|
|
|
|
cmdfile = popen(cmd, "r");
|
|
|
|
|
|
|
|
if (!(fgets(buffer, sizeof(buffer), cmdfile))) {
|
2024-01-01 13:36:12 +05:00
|
|
|
ksft_print_msg("Failed to read meminfo: %s\n", strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
pclose(cmdfile);
|
|
|
|
*hugepagesize = atoll(buffer);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int prereq(void)
|
|
|
|
{
|
|
|
|
char allowed;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
fd = open("/proc/sys/vm/compact_unevictable_allowed",
|
|
|
|
O_RDONLY | O_NONBLOCK);
|
|
|
|
if (fd < 0) {
|
2024-01-01 13:36:12 +05:00
|
|
|
ksft_print_msg("Failed to open /proc/sys/vm/compact_unevictable_allowed: %s\n",
|
|
|
|
strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (read(fd, &allowed, sizeof(char)) != sizeof(char)) {
|
2024-01-01 13:36:12 +05:00
|
|
|
ksft_print_msg("Failed to read from /proc/sys/vm/compact_unevictable_allowed: %s\n",
|
|
|
|
strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
close(fd);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
close(fd);
|
|
|
|
if (allowed == '1')
|
|
|
|
return 0;
|
|
|
|
|
2024-01-01 13:36:12 +05:00
|
|
|
ksft_print_msg("Compaction isn't allowed\n");
|
2015-04-23 14:21:41 -04:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation
Reset nr_hugepages to zero before the start of the test.
If a non-zero number of hugepages is already set before the start of the
test, the following problems arise:
- The probability of the test getting OOM-killed increases. Proof:
The test wants to run on 80% of available memory to prevent OOM-killing
(see original code comments). Let the value of mem_free at the start
of the test, when nr_hugepages = 0, be x. In the other case, when
nr_hugepages > 0, let the memory consumed by hugepages be y. In the
former case, the test operates on 0.8 * x of memory. In the latter,
the test operates on 0.8 * (x - y) of memory, with y already filled,
hence, memory consumed is y + 0.8 * (x - y) = 0.8 * x + 0.2 * y > 0.8 *
x. Q.E.D
- The probability of a bogus test success increases. Proof: Let the
memory consumed by hugepages be greater than 25% of x, with x and y
defined as above. The definition of compaction_index is c_index = (x -
y)/z where z is the memory consumed by hugepages after trying to
increase them again. In check_compaction(), we set the number of
hugepages to zero, and then increase them back; the probability that
they will be set back to consume at least y amount of memory again is
very high (since there is not much delay between the two attempts of
changing nr_hugepages). Hence, z >= y > (x/4) (by the 25% assumption).
Therefore, c_index = (x - y)/z <= (x - y)/y = x/y - 1 < 4 - 1 = 3
hence, c_index can always be forced to be less than 3, thereby the test
succeeding always. Q.E.D
Link: https://lkml.kernel.org/r/20240521074358.675031-4-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:58 +05:30
|
|
|
int check_compaction(unsigned long mem_free, unsigned long hugepage_size,
|
|
|
|
unsigned long initial_nr_hugepages)
|
2015-04-23 14:21:41 -04:00
|
|
|
{
|
selftests/mm: compaction_test: fix bogus test success on Aarch64
Patch series "Fixes for compaction_test", v2.
The compaction_test memory selftest introduces fragmentation in memory
and then tries to allocate as many hugepages as possible. This series
addresses some problems.
On Aarch64, if nr_hugepages == 0, then the test trivially succeeds since
compaction_index becomes 0, which is less than 3, due to no division by
zero exception being raised. We fix that by checking for division by
zero.
Secondly, correctly set the number of hugepages to zero before trying
to set a large number of them.
Now, consider a situation in which, at the start of the test, a non-zero
number of hugepages have been already set (while running the entire
selftests/mm suite, or manually by the admin). The test operates on 80%
of memory to avoid OOM-killer invocation, and because some memory is
already blocked by hugepages, it would increase the chance of OOM-killing.
Also, since mem_free used in check_compaction() is the value before we
set nr_hugepages to zero, the chance that the compaction_index will
be small is very high if the preset nr_hugepages was high, leading to a
bogus test success.
This patch (of 3):
Currently, if at runtime we are not able to allocate a huge page, the test
will trivially pass on Aarch64 due to no exception being raised on
division by zero while computing compaction_index. Fix that by checking
for nr_hugepages == 0. Anyways, in general, avoid a division by zero by
exiting the program beforehand. While at it, fix a typo, and handle the
case where the number of hugepages may overflow an integer.
Link: https://lkml.kernel.org/r/20240521074358.675031-1-dev.jain@arm.com
Link: https://lkml.kernel.org/r/20240521074358.675031-2-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:56 +05:30
|
|
|
unsigned long nr_hugepages_ul;
|
2024-01-01 13:36:12 +05:00
|
|
|
int fd, ret = -1;
|
2015-04-23 14:21:41 -04:00
|
|
|
int compaction_index = 0;
|
selftests/mm: compaction_test: fix bogus test success on Aarch64
Patch series "Fixes for compaction_test", v2.
The compaction_test memory selftest introduces fragmentation in memory
and then tries to allocate as many hugepages as possible. This series
addresses some problems.
On Aarch64, if nr_hugepages == 0, then the test trivially succeeds since
compaction_index becomes 0, which is less than 3, due to no division by
zero exception being raised. We fix that by checking for division by
zero.
Secondly, correctly set the number of hugepages to zero before trying
to set a large number of them.
Now, consider a situation in which, at the start of the test, a non-zero
number of hugepages have been already set (while running the entire
selftests/mm suite, or manually by the admin). The test operates on 80%
of memory to avoid OOM-killer invocation, and because some memory is
already blocked by hugepages, it would increase the chance of OOM-killing.
Also, since mem_free used in check_compaction() is the value before we
set nr_hugepages to zero, the chance that the compaction_index will
be small is very high if the preset nr_hugepages was high, leading to a
bogus test success.
This patch (of 3):
Currently, if at runtime we are not able to allocate a huge page, the test
will trivially pass on Aarch64 due to no exception being raised on
division by zero while computing compaction_index. Fix that by checking
for nr_hugepages == 0. Anyways, in general, avoid a division by zero by
exiting the program beforehand. While at it, fix a typo, and handle the
case where the number of hugepages may overflow an integer.
Link: https://lkml.kernel.org/r/20240521074358.675031-1-dev.jain@arm.com
Link: https://lkml.kernel.org/r/20240521074358.675031-2-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:56 +05:30
|
|
|
char nr_hugepages[20] = {0};
|
2024-08-09 15:32:30 +03:00
|
|
|
char init_nr_hugepages[24] = {0};
|
selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation
Reset nr_hugepages to zero before the start of the test.
If a non-zero number of hugepages is already set before the start of the
test, the following problems arise:
- The probability of the test getting OOM-killed increases. Proof:
The test wants to run on 80% of available memory to prevent OOM-killing
(see original code comments). Let the value of mem_free at the start
of the test, when nr_hugepages = 0, be x. In the other case, when
nr_hugepages > 0, let the memory consumed by hugepages be y. In the
former case, the test operates on 0.8 * x of memory. In the latter,
the test operates on 0.8 * (x - y) of memory, with y already filled,
hence, memory consumed is y + 0.8 * (x - y) = 0.8 * x + 0.2 * y > 0.8 *
x. Q.E.D
- The probability of a bogus test success increases. Proof: Let the
memory consumed by hugepages be greater than 25% of x, with x and y
defined as above. The definition of compaction_index is c_index = (x -
y)/z where z is the memory consumed by hugepages after trying to
increase them again. In check_compaction(), we set the number of
hugepages to zero, and then increase them back; the probability that
they will be set back to consume at least y amount of memory again is
very high (since there is not much delay between the two attempts of
changing nr_hugepages). Hence, z >= y > (x/4) (by the 25% assumption).
Therefore, c_index = (x - y)/z <= (x - y)/y = x/y - 1 < 4 - 1 = 3
hence, c_index can always be forced to be less than 3, thereby the test
succeeding always. Q.E.D
Link: https://lkml.kernel.org/r/20240521074358.675031-4-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:58 +05:30
|
|
|
|
2024-08-09 15:32:30 +03:00
|
|
|
snprintf(init_nr_hugepages, sizeof(init_nr_hugepages),
|
|
|
|
"%lu", initial_nr_hugepages);
|
2015-04-23 14:21:41 -04:00
|
|
|
|
|
|
|
/* We want to test with 80% of available memory. Else, OOM killer comes
|
|
|
|
in to play */
|
|
|
|
mem_free = mem_free * 0.8;
|
|
|
|
|
|
|
|
fd = open("/proc/sys/vm/nr_hugepages", O_RDWR | O_NONBLOCK);
|
|
|
|
if (fd < 0) {
|
2024-02-09 14:30:04 +00:00
|
|
|
ksft_print_msg("Failed to open /proc/sys/vm/nr_hugepages: %s\n",
|
|
|
|
strerror(errno));
|
|
|
|
ret = -1;
|
|
|
|
goto out;
|
2015-04-23 14:21:41 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Request a large number of huge pages. The Kernel will allocate
|
|
|
|
as much as it can */
|
|
|
|
if (write(fd, "100000", (6*sizeof(char))) != (6*sizeof(char))) {
|
2024-02-09 14:30:04 +00:00
|
|
|
ksft_print_msg("Failed to write 100000 to /proc/sys/vm/nr_hugepages: %s\n",
|
|
|
|
strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
goto close_fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
lseek(fd, 0, SEEK_SET);
|
|
|
|
|
|
|
|
if (read(fd, nr_hugepages, sizeof(nr_hugepages)) <= 0) {
|
2024-02-09 14:30:04 +00:00
|
|
|
ksft_print_msg("Failed to re-read from /proc/sys/vm/nr_hugepages: %s\n",
|
|
|
|
strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
goto close_fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* We should have been able to request at least 1/3 rd of the memory in
|
|
|
|
huge pages */
|
selftests/mm: compaction_test: fix bogus test success on Aarch64
Patch series "Fixes for compaction_test", v2.
The compaction_test memory selftest introduces fragmentation in memory
and then tries to allocate as many hugepages as possible. This series
addresses some problems.
On Aarch64, if nr_hugepages == 0, then the test trivially succeeds since
compaction_index becomes 0, which is less than 3, due to no division by
zero exception being raised. We fix that by checking for division by
zero.
Secondly, correctly set the number of hugepages to zero before trying
to set a large number of them.
Now, consider a situation in which, at the start of the test, a non-zero
number of hugepages have been already set (while running the entire
selftests/mm suite, or manually by the admin). The test operates on 80%
of memory to avoid OOM-killer invocation, and because some memory is
already blocked by hugepages, it would increase the chance of OOM-killing.
Also, since mem_free used in check_compaction() is the value before we
set nr_hugepages to zero, the chance that the compaction_index will
be small is very high if the preset nr_hugepages was high, leading to a
bogus test success.
This patch (of 3):
Currently, if at runtime we are not able to allocate a huge page, the test
will trivially pass on Aarch64 due to no exception being raised on
division by zero while computing compaction_index. Fix that by checking
for nr_hugepages == 0. Anyways, in general, avoid a division by zero by
exiting the program beforehand. While at it, fix a typo, and handle the
case where the number of hugepages may overflow an integer.
Link: https://lkml.kernel.org/r/20240521074358.675031-1-dev.jain@arm.com
Link: https://lkml.kernel.org/r/20240521074358.675031-2-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:56 +05:30
|
|
|
nr_hugepages_ul = strtoul(nr_hugepages, NULL, 10);
|
|
|
|
if (!nr_hugepages_ul) {
|
|
|
|
ksft_print_msg("ERROR: No memory is available as huge pages\n");
|
|
|
|
goto close_fd;
|
|
|
|
}
|
|
|
|
compaction_index = mem_free/(nr_hugepages_ul * hugepage_size);
|
2015-04-23 14:21:41 -04:00
|
|
|
|
2018-01-09 17:26:24 +01:00
|
|
|
lseek(fd, 0, SEEK_SET);
|
|
|
|
|
selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation
Reset nr_hugepages to zero before the start of the test.
If a non-zero number of hugepages is already set before the start of the
test, the following problems arise:
- The probability of the test getting OOM-killed increases. Proof:
The test wants to run on 80% of available memory to prevent OOM-killing
(see original code comments). Let the value of mem_free at the start
of the test, when nr_hugepages = 0, be x. In the other case, when
nr_hugepages > 0, let the memory consumed by hugepages be y. In the
former case, the test operates on 0.8 * x of memory. In the latter,
the test operates on 0.8 * (x - y) of memory, with y already filled,
hence, memory consumed is y + 0.8 * (x - y) = 0.8 * x + 0.2 * y > 0.8 *
x. Q.E.D
- The probability of a bogus test success increases. Proof: Let the
memory consumed by hugepages be greater than 25% of x, with x and y
defined as above. The definition of compaction_index is c_index = (x -
y)/z where z is the memory consumed by hugepages after trying to
increase them again. In check_compaction(), we set the number of
hugepages to zero, and then increase them back; the probability that
they will be set back to consume at least y amount of memory again is
very high (since there is not much delay between the two attempts of
changing nr_hugepages). Hence, z >= y > (x/4) (by the 25% assumption).
Therefore, c_index = (x - y)/z <= (x - y)/y = x/y - 1 < 4 - 1 = 3
hence, c_index can always be forced to be less than 3, thereby the test
succeeding always. Q.E.D
Link: https://lkml.kernel.org/r/20240521074358.675031-4-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:58 +05:30
|
|
|
if (write(fd, init_nr_hugepages, strlen(init_nr_hugepages))
|
|
|
|
!= strlen(init_nr_hugepages)) {
|
2024-02-09 14:30:04 +00:00
|
|
|
ksft_print_msg("Failed to write value to /proc/sys/vm/nr_hugepages: %s\n",
|
|
|
|
strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
goto close_fd;
|
|
|
|
}
|
|
|
|
|
selftests/mm: compaction_test: fix bogus test success on Aarch64
Patch series "Fixes for compaction_test", v2.
The compaction_test memory selftest introduces fragmentation in memory
and then tries to allocate as many hugepages as possible. This series
addresses some problems.
On Aarch64, if nr_hugepages == 0, then the test trivially succeeds since
compaction_index becomes 0, which is less than 3, due to no division by
zero exception being raised. We fix that by checking for division by
zero.
Secondly, correctly set the number of hugepages to zero before trying
to set a large number of them.
Now, consider a situation in which, at the start of the test, a non-zero
number of hugepages have been already set (while running the entire
selftests/mm suite, or manually by the admin). The test operates on 80%
of memory to avoid OOM-killer invocation, and because some memory is
already blocked by hugepages, it would increase the chance of OOM-killing.
Also, since mem_free used in check_compaction() is the value before we
set nr_hugepages to zero, the chance that the compaction_index will
be small is very high if the preset nr_hugepages was high, leading to a
bogus test success.
This patch (of 3):
Currently, if at runtime we are not able to allocate a huge page, the test
will trivially pass on Aarch64 due to no exception being raised on
division by zero while computing compaction_index. Fix that by checking
for nr_hugepages == 0. Anyways, in general, avoid a division by zero by
exiting the program beforehand. While at it, fix a typo, and handle the
case where the number of hugepages may overflow an integer.
Link: https://lkml.kernel.org/r/20240521074358.675031-1-dev.jain@arm.com
Link: https://lkml.kernel.org/r/20240521074358.675031-2-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:56 +05:30
|
|
|
ksft_print_msg("Number of huge pages allocated = %lu\n",
|
|
|
|
nr_hugepages_ul);
|
2024-02-09 14:30:04 +00:00
|
|
|
|
2024-01-01 13:36:12 +05:00
|
|
|
if (compaction_index > 3) {
|
selftests/mm: compaction_test: fix bogus test success on Aarch64
Patch series "Fixes for compaction_test", v2.
The compaction_test memory selftest introduces fragmentation in memory
and then tries to allocate as many hugepages as possible. This series
addresses some problems.
On Aarch64, if nr_hugepages == 0, then the test trivially succeeds since
compaction_index becomes 0, which is less than 3, due to no division by
zero exception being raised. We fix that by checking for division by
zero.
Secondly, correctly set the number of hugepages to zero before trying
to set a large number of them.
Now, consider a situation in which, at the start of the test, a non-zero
number of hugepages have been already set (while running the entire
selftests/mm suite, or manually by the admin). The test operates on 80%
of memory to avoid OOM-killer invocation, and because some memory is
already blocked by hugepages, it would increase the chance of OOM-killing.
Also, since mem_free used in check_compaction() is the value before we
set nr_hugepages to zero, the chance that the compaction_index will
be small is very high if the preset nr_hugepages was high, leading to a
bogus test success.
This patch (of 3):
Currently, if at runtime we are not able to allocate a huge page, the test
will trivially pass on Aarch64 due to no exception being raised on
division by zero while computing compaction_index. Fix that by checking
for nr_hugepages == 0. Anyways, in general, avoid a division by zero by
exiting the program beforehand. While at it, fix a typo, and handle the
case where the number of hugepages may overflow an integer.
Link: https://lkml.kernel.org/r/20240521074358.675031-1-dev.jain@arm.com
Link: https://lkml.kernel.org/r/20240521074358.675031-2-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:56 +05:30
|
|
|
ksft_print_msg("ERROR: Less than 1/%d of memory is available\n"
|
2024-01-01 13:36:12 +05:00
|
|
|
"as huge pages\n", compaction_index);
|
|
|
|
goto close_fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = 0;
|
2015-04-23 14:21:41 -04:00
|
|
|
|
|
|
|
close_fd:
|
|
|
|
close(fd);
|
2024-02-09 14:30:04 +00:00
|
|
|
out:
|
|
|
|
ksft_test_result(ret == 0, "check_compaction\n");
|
2024-01-01 13:36:12 +05:00
|
|
|
return ret;
|
2015-04-23 14:21:41 -04:00
|
|
|
}
|
|
|
|
|
selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation
Reset nr_hugepages to zero before the start of the test.
If a non-zero number of hugepages is already set before the start of the
test, the following problems arise:
- The probability of the test getting OOM-killed increases. Proof:
The test wants to run on 80% of available memory to prevent OOM-killing
(see original code comments). Let the value of mem_free at the start
of the test, when nr_hugepages = 0, be x. In the other case, when
nr_hugepages > 0, let the memory consumed by hugepages be y. In the
former case, the test operates on 0.8 * x of memory. In the latter,
the test operates on 0.8 * (x - y) of memory, with y already filled,
hence, memory consumed is y + 0.8 * (x - y) = 0.8 * x + 0.2 * y > 0.8 *
x. Q.E.D
- The probability of a bogus test success increases. Proof: Let the
memory consumed by hugepages be greater than 25% of x, with x and y
defined as above. The definition of compaction_index is c_index = (x -
y)/z where z is the memory consumed by hugepages after trying to
increase them again. In check_compaction(), we set the number of
hugepages to zero, and then increase them back; the probability that
they will be set back to consume at least y amount of memory again is
very high (since there is not much delay between the two attempts of
changing nr_hugepages). Hence, z >= y > (x/4) (by the 25% assumption).
Therefore, c_index = (x - y)/z <= (x - y)/y = x/y - 1 < 4 - 1 = 3
hence, c_index can always be forced to be less than 3, thereby the test
succeeding always. Q.E.D
Link: https://lkml.kernel.org/r/20240521074358.675031-4-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:58 +05:30
|
|
|
int set_zero_hugepages(unsigned long *initial_nr_hugepages)
|
|
|
|
{
|
|
|
|
int fd, ret = -1;
|
|
|
|
char nr_hugepages[20] = {0};
|
|
|
|
|
|
|
|
fd = open("/proc/sys/vm/nr_hugepages", O_RDWR | O_NONBLOCK);
|
|
|
|
if (fd < 0) {
|
|
|
|
ksft_print_msg("Failed to open /proc/sys/vm/nr_hugepages: %s\n",
|
|
|
|
strerror(errno));
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
if (read(fd, nr_hugepages, sizeof(nr_hugepages)) <= 0) {
|
|
|
|
ksft_print_msg("Failed to read from /proc/sys/vm/nr_hugepages: %s\n",
|
|
|
|
strerror(errno));
|
|
|
|
goto close_fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
lseek(fd, 0, SEEK_SET);
|
|
|
|
|
|
|
|
/* Start with the initial condition of 0 huge pages */
|
|
|
|
if (write(fd, "0", sizeof(char)) != sizeof(char)) {
|
|
|
|
ksft_print_msg("Failed to write 0 to /proc/sys/vm/nr_hugepages: %s\n",
|
|
|
|
strerror(errno));
|
|
|
|
goto close_fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
*initial_nr_hugepages = strtoul(nr_hugepages, NULL, 10);
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
close_fd:
|
|
|
|
close(fd);
|
|
|
|
|
|
|
|
out:
|
|
|
|
return ret;
|
|
|
|
}
|
2015-04-23 14:21:41 -04:00
|
|
|
|
|
|
|
int main(int argc, char **argv)
|
|
|
|
{
|
|
|
|
struct rlimit lim;
|
2024-01-01 13:36:12 +05:00
|
|
|
struct map_list *list = NULL, *entry;
|
2015-04-23 14:21:41 -04:00
|
|
|
size_t page_size, i;
|
|
|
|
void *map = NULL;
|
|
|
|
unsigned long mem_free = 0;
|
|
|
|
unsigned long hugepage_size = 0;
|
2020-10-13 16:57:04 -07:00
|
|
|
long mem_fragmentable_MB = 0;
|
selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation
Reset nr_hugepages to zero before the start of the test.
If a non-zero number of hugepages is already set before the start of the
test, the following problems arise:
- The probability of the test getting OOM-killed increases. Proof:
The test wants to run on 80% of available memory to prevent OOM-killing
(see original code comments). Let the value of mem_free at the start
of the test, when nr_hugepages = 0, be x. In the other case, when
nr_hugepages > 0, let the memory consumed by hugepages be y. In the
former case, the test operates on 0.8 * x of memory. In the latter,
the test operates on 0.8 * (x - y) of memory, with y already filled,
hence, memory consumed is y + 0.8 * (x - y) = 0.8 * x + 0.2 * y > 0.8 *
x. Q.E.D
- The probability of a bogus test success increases. Proof: Let the
memory consumed by hugepages be greater than 25% of x, with x and y
defined as above. The definition of compaction_index is c_index = (x -
y)/z where z is the memory consumed by hugepages after trying to
increase them again. In check_compaction(), we set the number of
hugepages to zero, and then increase them back; the probability that
they will be set back to consume at least y amount of memory again is
very high (since there is not much delay between the two attempts of
changing nr_hugepages). Hence, z >= y > (x/4) (by the 25% assumption).
Therefore, c_index = (x - y)/z <= (x - y)/y = x/y - 1 < 4 - 1 = 3
hence, c_index can always be forced to be less than 3, thereby the test
succeeding always. Q.E.D
Link: https://lkml.kernel.org/r/20240521074358.675031-4-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:58 +05:30
|
|
|
unsigned long initial_nr_hugepages;
|
2015-04-23 14:21:41 -04:00
|
|
|
|
2024-01-01 13:36:12 +05:00
|
|
|
ksft_print_header();
|
|
|
|
|
2024-01-01 13:36:13 +05:00
|
|
|
if (prereq() || geteuid())
|
2024-04-24 10:24:07 -07:00
|
|
|
ksft_exit_skip("Prerequisites unsatisfied\n");
|
2024-01-01 13:36:12 +05:00
|
|
|
|
|
|
|
ksft_set_plan(1);
|
2015-04-23 14:21:41 -04:00
|
|
|
|
selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation
Reset nr_hugepages to zero before the start of the test.
If a non-zero number of hugepages is already set before the start of the
test, the following problems arise:
- The probability of the test getting OOM-killed increases. Proof:
The test wants to run on 80% of available memory to prevent OOM-killing
(see original code comments). Let the value of mem_free at the start
of the test, when nr_hugepages = 0, be x. In the other case, when
nr_hugepages > 0, let the memory consumed by hugepages be y. In the
former case, the test operates on 0.8 * x of memory. In the latter,
the test operates on 0.8 * (x - y) of memory, with y already filled,
hence, memory consumed is y + 0.8 * (x - y) = 0.8 * x + 0.2 * y > 0.8 *
x. Q.E.D
- The probability of a bogus test success increases. Proof: Let the
memory consumed by hugepages be greater than 25% of x, with x and y
defined as above. The definition of compaction_index is c_index = (x -
y)/z where z is the memory consumed by hugepages after trying to
increase them again. In check_compaction(), we set the number of
hugepages to zero, and then increase them back; the probability that
they will be set back to consume at least y amount of memory again is
very high (since there is not much delay between the two attempts of
changing nr_hugepages). Hence, z >= y > (x/4) (by the 25% assumption).
Therefore, c_index = (x - y)/z <= (x - y)/y = x/y - 1 < 4 - 1 = 3
hence, c_index can always be forced to be less than 3, thereby the test
succeeding always. Q.E.D
Link: https://lkml.kernel.org/r/20240521074358.675031-4-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:58 +05:30
|
|
|
/* Start the test without hugepages reducing mem_free */
|
|
|
|
if (set_zero_hugepages(&initial_nr_hugepages))
|
|
|
|
ksft_exit_fail();
|
|
|
|
|
2015-04-23 14:21:41 -04:00
|
|
|
lim.rlim_cur = RLIM_INFINITY;
|
|
|
|
lim.rlim_max = RLIM_INFINITY;
|
2024-01-01 13:36:12 +05:00
|
|
|
if (setrlimit(RLIMIT_MEMLOCK, &lim))
|
|
|
|
ksft_exit_fail_msg("Failed to set rlimit: %s\n", strerror(errno));
|
2015-04-23 14:21:41 -04:00
|
|
|
|
|
|
|
page_size = getpagesize();
|
|
|
|
|
2024-01-01 13:36:12 +05:00
|
|
|
if (read_memory_info(&mem_free, &hugepage_size) != 0)
|
|
|
|
ksft_exit_fail_msg("Failed to get meminfo\n");
|
2015-04-23 14:21:41 -04:00
|
|
|
|
2020-10-13 16:57:04 -07:00
|
|
|
mem_fragmentable_MB = mem_free * 0.8 / 1024;
|
2015-04-23 14:21:41 -04:00
|
|
|
|
2020-10-13 16:57:04 -07:00
|
|
|
while (mem_fragmentable_MB > 0) {
|
2015-04-23 14:21:41 -04:00
|
|
|
map = mmap(NULL, MAP_SIZE, PROT_READ | PROT_WRITE,
|
|
|
|
MAP_ANONYMOUS | MAP_PRIVATE | MAP_LOCKED, -1, 0);
|
|
|
|
if (map == MAP_FAILED)
|
|
|
|
break;
|
|
|
|
|
|
|
|
entry = malloc(sizeof(struct map_list));
|
|
|
|
if (!entry) {
|
|
|
|
munmap(map, MAP_SIZE);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
entry->map = map;
|
|
|
|
entry->next = list;
|
|
|
|
list = entry;
|
|
|
|
|
|
|
|
/* Write something (in this case the address of the map) to
|
|
|
|
* ensure that KSM can't merge the mapped pages
|
|
|
|
*/
|
|
|
|
for (i = 0; i < MAP_SIZE; i += page_size)
|
|
|
|
*(unsigned long *)(map + i) = (unsigned long)map + i;
|
|
|
|
|
2020-10-13 16:57:04 -07:00
|
|
|
mem_fragmentable_MB -= MAP_SIZE_MB;
|
2015-04-23 14:21:41 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
for (entry = list; entry != NULL; entry = entry->next) {
|
|
|
|
munmap(entry->map, MAP_SIZE);
|
|
|
|
if (!entry->next)
|
|
|
|
break;
|
|
|
|
entry = entry->next;
|
|
|
|
}
|
|
|
|
|
selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation
Reset nr_hugepages to zero before the start of the test.
If a non-zero number of hugepages is already set before the start of the
test, the following problems arise:
- The probability of the test getting OOM-killed increases. Proof:
The test wants to run on 80% of available memory to prevent OOM-killing
(see original code comments). Let the value of mem_free at the start
of the test, when nr_hugepages = 0, be x. In the other case, when
nr_hugepages > 0, let the memory consumed by hugepages be y. In the
former case, the test operates on 0.8 * x of memory. In the latter,
the test operates on 0.8 * (x - y) of memory, with y already filled,
hence, memory consumed is y + 0.8 * (x - y) = 0.8 * x + 0.2 * y > 0.8 *
x. Q.E.D
- The probability of a bogus test success increases. Proof: Let the
memory consumed by hugepages be greater than 25% of x, with x and y
defined as above. The definition of compaction_index is c_index = (x -
y)/z where z is the memory consumed by hugepages after trying to
increase them again. In check_compaction(), we set the number of
hugepages to zero, and then increase them back; the probability that
they will be set back to consume at least y amount of memory again is
very high (since there is not much delay between the two attempts of
changing nr_hugepages). Hence, z >= y > (x/4) (by the 25% assumption).
Therefore, c_index = (x - y)/z <= (x - y)/y = x/y - 1 < 4 - 1 = 3
hence, c_index can always be forced to be less than 3, thereby the test
succeeding always. Q.E.D
Link: https://lkml.kernel.org/r/20240521074358.675031-4-dev.jain@arm.com
Fixes: bd67d5c15cc1 ("Test compaction of mlocked memory")
Signed-off-by: Dev Jain <dev.jain@arm.com>
Cc: <stable@vger.kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Sri Jayaramappa <sjayaram@akamai.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2024-05-21 13:13:58 +05:30
|
|
|
if (check_compaction(mem_free, hugepage_size,
|
|
|
|
initial_nr_hugepages) == 0)
|
2024-04-24 10:24:07 -07:00
|
|
|
ksft_exit_pass();
|
2015-04-23 14:21:41 -04:00
|
|
|
|
2024-04-24 10:24:07 -07:00
|
|
|
ksft_exit_fail();
|
2015-04-23 14:21:41 -04:00
|
|
|
}
|