2015-03-18 10:46:04 +01:00
|
|
|
/*
|
2019-05-28 10:29:49 +01:00
|
|
|
* SPDX-License-Identifier: MIT
|
2015-03-18 10:46:04 +01:00
|
|
|
*
|
2019-05-28 10:29:49 +01:00
|
|
|
* Copyright © 2008-2015 Intel Corporation
|
2015-03-18 10:46:04 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/oom.h>
|
2018-07-11 08:36:02 +01:00
|
|
|
#include <linux/sched/mm.h>
|
2015-03-18 10:46:04 +01:00
|
|
|
#include <linux/shmem_fs.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/swap.h>
|
|
|
|
#include <linux/pci.h>
|
|
|
|
#include <linux/dma-buf.h>
|
2016-04-04 14:46:43 +01:00
|
|
|
#include <linux/vmalloc.h>
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2020-07-08 18:37:45 +01:00
|
|
|
#include "gt/intel_gt_requests.h"
|
|
|
|
|
2015-03-18 10:46:04 +01:00
|
|
|
#include "i915_trace.h"
|
|
|
|
|
2015-12-04 15:58:54 +00:00
|
|
|
static bool swap_available(void)
|
|
|
|
{
|
|
|
|
return get_nr_swap_pages() > 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool can_release_pages(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
2016-11-01 14:44:10 +00:00
|
|
|
/* Consider only shrinkable ojects. */
|
|
|
|
if (!i915_gem_object_is_shrinkable(obj))
|
2016-04-20 12:09:52 +01:00
|
|
|
return false;
|
|
|
|
|
2019-09-02 05:02:47 +01:00
|
|
|
/*
|
|
|
|
* We can only return physical pages to the system if we can either
|
2015-12-04 15:58:54 +00:00
|
|
|
* discard the contents (because the user has marked them as being
|
|
|
|
* purgeable) or if we can move their contents out to swap.
|
|
|
|
*/
|
2016-10-28 13:58:35 +01:00
|
|
|
return swap_available() || obj->mm.madv == I915_MADV_DONTNEED;
|
2015-12-04 15:58:54 +00:00
|
|
|
}
|
|
|
|
|
2019-07-03 10:17:17 +01:00
|
|
|
static bool unsafe_drop_pages(struct drm_i915_gem_object *obj,
|
|
|
|
unsigned long shrink)
|
2016-10-28 13:58:36 +01:00
|
|
|
{
|
2019-07-03 10:17:17 +01:00
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
flags = 0;
|
|
|
|
if (shrink & I915_SHRINK_ACTIVE)
|
|
|
|
flags = I915_GEM_OBJECT_UNBIND_ACTIVE;
|
2020-04-01 23:39:24 +01:00
|
|
|
if (!(shrink & I915_SHRINK_BOUND))
|
|
|
|
flags = I915_GEM_OBJECT_UNBIND_TEST;
|
2019-07-03 10:17:17 +01:00
|
|
|
|
|
|
|
if (i915_gem_object_unbind(obj, flags) == 0)
|
drm/i915: Switch obj->mm.lock lockdep annotations on its head
The trouble with having a plain nesting flag for locks which do not
naturally nest (unlike block devices and their partitions, which is
the original motivation for nesting levels) is that lockdep will
never spot a true deadlock if you screw up.
This patch is an attempt at trying better, by highlighting a bit more
of the actual nature of the nesting that's going on. Essentially we
have two kinds of objects:
- objects without pages allocated, which cannot be on any lru and are
hence inaccessible to the shrinker.
- objects which have pages allocated, which are on an lru, and which
the shrinker can decide to throw out.
For the former type of object, memory allocations while holding
obj->mm.lock are permissible. For the latter they are not. And
get/put_pages transitions between the two types of objects.
This is still not entirely fool-proof since the rules might change.
But as long as we run such a code ever at runtime lockdep should be
able to observe the inconsistency and complain (like with any other
lockdep class that we've split up in multiple classes). But there are
a few clear benefits:
- We can drop the nesting flag parameter from
__i915_gem_object_put_pages, because that function by definition is
never going allocate memory, and calling it on an object which
doesn't have its pages allocated would be a bug.
- We strictly catch more bugs, since there's not only one place in the
entire tree which is annotated with the special class. All the
other places that had explicit lockdep nesting annotations we're now
going to leave up to lockdep again.
- Specifically this catches stuff like calling get_pages from
put_pages (which isn't really a good idea, if we can call get_pages
so could the shrinker). I've seen patches do exactly that.
Of course I fully expect CI will show me for the fool I am with this
one here :-)
v2: There can only be one (lockdep only has a cache for the first
subclass, not for deeper ones, and we don't want to make these locks
even slower). Still separate enums for better documentation.
Real fix: don't forget about phys objs and pin_map(), and fix the
shrinker to have the right annotations ... silly me.
v3: Forgot usertptr too ...
v4: Improve comment for pages_pin_count, drop the IMPORTANT comment
and instead prime lockdep (Chris).
v5: Appease checkpatch, no double empty lines (Chris)
v6: More rebasing over selftest changes. Also somehow I forgot to
push this patch :-/
Also format comments consistently while at it.
v7: Fix typo in commit message (Joonas)
Also drop the priming, with the lmem merge we now have allocations
while holding the lmem lock, which wreaks the generic priming I've
done in earlier patches. Should probably be resurrected when lmem is
fixed. See
commit 232a6ebae419193f5b8da4fa869ae5089ab105c2
Author: Matthew Auld <matthew.auld@intel.com>
Date: Tue Oct 8 17:01:14 2019 +0100
drm/i915: introduce intel_memory_region
I'm keeping the priming patch locally so it wont get lost.
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Tang, CQ" <cq.tang@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> (v5)
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> (v6)
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191105090148.30269-1-daniel.vetter@ffwll.ch
[mlankhorst: Fix commit typos pointed out by Michael Ruhl]
2019-11-05 10:01:48 +01:00
|
|
|
__i915_gem_object_put_pages(obj);
|
2019-07-03 10:17:17 +01:00
|
|
|
|
2017-10-13 21:26:13 +01:00
|
|
|
return !i915_gem_object_has_pages(obj);
|
2015-12-04 15:58:54 +00:00
|
|
|
}
|
|
|
|
|
2019-05-28 10:29:46 +01:00
|
|
|
static void try_to_writeback(struct drm_i915_gem_object *obj,
|
|
|
|
unsigned int flags)
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 12:55:39 +01:00
|
|
|
{
|
|
|
|
switch (obj->mm.madv) {
|
|
|
|
case I915_MADV_DONTNEED:
|
2019-05-28 10:29:46 +01:00
|
|
|
i915_gem_object_truncate(obj);
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 12:55:39 +01:00
|
|
|
case __I915_MADV_PURGED:
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-05-28 10:29:46 +01:00
|
|
|
if (flags & I915_SHRINK_WRITEBACK)
|
|
|
|
i915_gem_object_writeback(obj);
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 12:55:39 +01:00
|
|
|
}
|
|
|
|
|
2015-03-18 14:47:59 +01:00
|
|
|
/**
|
|
|
|
* i915_gem_shrink - Shrink buffer object caches
|
2017-11-23 11:53:38 +00:00
|
|
|
* @i915: i915 device
|
2015-03-18 14:47:59 +01:00
|
|
|
* @target: amount of memory to make available, in pages
|
2017-09-06 16:19:30 -07:00
|
|
|
* @nr_scanned: optional output for number of pages scanned (incremental)
|
2019-06-12 16:13:11 +01:00
|
|
|
* @shrink: control flags for selecting cache types
|
2015-03-18 14:47:59 +01:00
|
|
|
*
|
|
|
|
* This function is the main interface to the shrinker. It will try to release
|
|
|
|
* up to @target pages of main memory backing storage from buffer objects.
|
|
|
|
* Selection of the specific caches can be done with @flags. This is e.g. useful
|
|
|
|
* when purgeable objects should be removed from caches preferentially.
|
|
|
|
*
|
|
|
|
* Note that it's not guaranteed that released amount is actually available as
|
|
|
|
* free system memory - the pages might still be in-used to due to other reasons
|
|
|
|
* (like cpu mmaps) or the mm core has reused them before we could grab them.
|
|
|
|
* Therefore code that needs to explicitly shrink buffer objects caches (e.g. to
|
|
|
|
* avoid deadlocks in memory reclaim) must fall back to i915_gem_shrink_all().
|
|
|
|
*
|
|
|
|
* Also note that any kind of pinning (both per-vma address space pins and
|
|
|
|
* backing storage pins at the buffer object level) result in the shrinker code
|
|
|
|
* having to skip the object.
|
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* The number of pages of backing storage actually released.
|
|
|
|
*/
|
2015-03-18 10:46:04 +01:00
|
|
|
unsigned long
|
2017-11-23 11:53:38 +00:00
|
|
|
i915_gem_shrink(struct drm_i915_private *i915,
|
2017-09-06 16:19:30 -07:00
|
|
|
unsigned long target,
|
|
|
|
unsigned long *nr_scanned,
|
2019-06-10 15:54:30 +01:00
|
|
|
unsigned int shrink)
|
2015-03-18 10:46:04 +01:00
|
|
|
{
|
|
|
|
const struct {
|
|
|
|
struct list_head *list;
|
|
|
|
unsigned int bit;
|
|
|
|
} phases[] = {
|
2019-05-30 21:34:59 +01:00
|
|
|
{ &i915->mm.purge_list, ~0u },
|
2019-06-12 11:57:20 +01:00
|
|
|
{
|
|
|
|
&i915->mm.shrink_list,
|
|
|
|
I915_SHRINK_BOUND | I915_SHRINK_UNBOUND
|
|
|
|
},
|
2015-03-18 10:46:04 +01:00
|
|
|
{ NULL, 0 },
|
|
|
|
}, *phase;
|
2019-01-14 14:21:18 +00:00
|
|
|
intel_wakeref_t wakeref = 0;
|
2015-03-18 10:46:04 +01:00
|
|
|
unsigned long count = 0;
|
2017-09-06 16:19:30 -07:00
|
|
|
unsigned long scanned = 0;
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2019-06-10 15:54:30 +01:00
|
|
|
trace_i915_gem_shrink(i915, target, shrink);
|
2015-10-01 12:18:26 +01:00
|
|
|
|
2016-05-02 14:10:28 +05:30
|
|
|
/*
|
|
|
|
* Unbinding of objects will require HW access; Let us not wake the
|
|
|
|
* device just to recover a little memory. If absolutely necessary,
|
|
|
|
* we will force the wake during oom-notifier.
|
|
|
|
*/
|
2019-06-10 15:54:30 +01:00
|
|
|
if (shrink & I915_SHRINK_BOUND) {
|
2019-06-13 16:21:54 -07:00
|
|
|
wakeref = intel_runtime_pm_get_if_in_use(&i915->runtime_pm);
|
2019-01-14 14:21:18 +00:00
|
|
|
if (!wakeref)
|
2019-06-10 15:54:30 +01:00
|
|
|
shrink &= ~I915_SHRINK_BOUND;
|
2019-01-14 14:21:18 +00:00
|
|
|
}
|
2016-05-02 14:10:28 +05:30
|
|
|
|
2020-07-08 18:37:45 +01:00
|
|
|
/*
|
|
|
|
* When shrinking the active list, we should also consider active
|
|
|
|
* contexts. Active contexts are pinned until they are retired, and
|
|
|
|
* so can not be simply unbound to retire and unpin their pages. To
|
|
|
|
* shrink the contexts, we must wait until the gpu is idle and
|
|
|
|
* completed its switch to the kernel context. In short, we do
|
|
|
|
* not have a good mechanism for idling a specific context, but
|
|
|
|
* what we can do is give them a kick so that we do not keep idle
|
|
|
|
* contexts around longer than is necessary.
|
|
|
|
*/
|
|
|
|
if (shrink & I915_SHRINK_ACTIVE)
|
|
|
|
/* Retire requests to unpin all idle contexts */
|
|
|
|
intel_gt_retire_requests(&i915->gt);
|
|
|
|
|
2015-03-18 10:46:04 +01:00
|
|
|
/*
|
|
|
|
* As we may completely rewrite the (un)bound list whilst unbinding
|
|
|
|
* (due to retiring requests) we have to strictly process only
|
|
|
|
* one element of the list at the time, and recheck the list
|
|
|
|
* on every iteration.
|
|
|
|
*
|
|
|
|
* In particular, we must hold a reference whilst removing the
|
|
|
|
* object as we may end up waiting for and/or retiring the objects.
|
|
|
|
* This might release the final reference (held by the active list)
|
|
|
|
* and result in the object being freed from under us. This is
|
|
|
|
* similar to the precautions the eviction code must take whilst
|
|
|
|
* removing objects.
|
|
|
|
*
|
|
|
|
* Also note that although these lists do not hold a reference to
|
|
|
|
* the object we can safely grab one here: The final object
|
|
|
|
* unreferencing and the bound_list are both protected by the
|
|
|
|
* dev->struct_mutex and so we won't ever be able to observe an
|
|
|
|
* object on the bound_list with a reference count equals 0.
|
|
|
|
*/
|
|
|
|
for (phase = phases; phase->list; phase++) {
|
|
|
|
struct list_head still_in_list;
|
2016-07-26 12:01:51 +01:00
|
|
|
struct drm_i915_gem_object *obj;
|
2019-06-10 15:54:30 +01:00
|
|
|
unsigned long flags;
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2019-06-10 15:54:30 +01:00
|
|
|
if ((shrink & phase->bit) == 0)
|
2015-03-18 10:46:04 +01:00
|
|
|
continue;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&still_in_list);
|
2017-10-16 12:40:37 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We serialize our access to unreferenced objects through
|
|
|
|
* the use of the struct_mutex. While the objects are not
|
|
|
|
* yet freed (due to RCU then a workqueue) we still want
|
|
|
|
* to be able to shrink their pages, so they remain on
|
|
|
|
* the unbound/bound list until actually freed.
|
|
|
|
*/
|
2019-06-10 15:54:30 +01:00
|
|
|
spin_lock_irqsave(&i915->mm.obj_lock, flags);
|
2016-07-26 12:01:51 +01:00
|
|
|
while (count < target &&
|
|
|
|
(obj = list_first_entry_or_null(phase->list,
|
|
|
|
typeof(*obj),
|
2017-10-16 12:40:37 +01:00
|
|
|
mm.link))) {
|
|
|
|
list_move_tail(&obj->mm.link, &still_in_list);
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2019-06-10 15:54:30 +01:00
|
|
|
if (shrink & I915_SHRINK_VMAPS &&
|
2016-10-28 13:58:35 +01:00
|
|
|
!is_vmalloc_addr(obj->mm.mapping))
|
2016-04-08 12:11:12 +01:00
|
|
|
continue;
|
|
|
|
|
2019-06-10 15:54:30 +01:00
|
|
|
if (!(shrink & I915_SHRINK_ACTIVE) &&
|
2019-07-03 10:17:17 +01:00
|
|
|
i915_gem_object_is_framebuffer(obj))
|
2015-10-01 12:18:29 +01:00
|
|
|
continue;
|
|
|
|
|
2015-12-04 15:58:54 +00:00
|
|
|
if (!can_release_pages(obj))
|
|
|
|
continue;
|
|
|
|
|
2019-06-18 08:41:29 +01:00
|
|
|
if (!kref_get_unless_zero(&obj->base.refcount))
|
|
|
|
continue;
|
|
|
|
|
2019-06-10 15:54:30 +01:00
|
|
|
spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
|
2017-10-16 12:40:37 +01:00
|
|
|
|
2019-07-03 10:17:17 +01:00
|
|
|
if (unsafe_drop_pages(obj, shrink)) {
|
2016-10-31 12:40:48 +00:00
|
|
|
/* May arrive from get_pages on another bo */
|
drm/i915: Switch obj->mm.lock lockdep annotations on its head
The trouble with having a plain nesting flag for locks which do not
naturally nest (unlike block devices and their partitions, which is
the original motivation for nesting levels) is that lockdep will
never spot a true deadlock if you screw up.
This patch is an attempt at trying better, by highlighting a bit more
of the actual nature of the nesting that's going on. Essentially we
have two kinds of objects:
- objects without pages allocated, which cannot be on any lru and are
hence inaccessible to the shrinker.
- objects which have pages allocated, which are on an lru, and which
the shrinker can decide to throw out.
For the former type of object, memory allocations while holding
obj->mm.lock are permissible. For the latter they are not. And
get/put_pages transitions between the two types of objects.
This is still not entirely fool-proof since the rules might change.
But as long as we run such a code ever at runtime lockdep should be
able to observe the inconsistency and complain (like with any other
lockdep class that we've split up in multiple classes). But there are
a few clear benefits:
- We can drop the nesting flag parameter from
__i915_gem_object_put_pages, because that function by definition is
never going allocate memory, and calling it on an object which
doesn't have its pages allocated would be a bug.
- We strictly catch more bugs, since there's not only one place in the
entire tree which is annotated with the special class. All the
other places that had explicit lockdep nesting annotations we're now
going to leave up to lockdep again.
- Specifically this catches stuff like calling get_pages from
put_pages (which isn't really a good idea, if we can call get_pages
so could the shrinker). I've seen patches do exactly that.
Of course I fully expect CI will show me for the fool I am with this
one here :-)
v2: There can only be one (lockdep only has a cache for the first
subclass, not for deeper ones, and we don't want to make these locks
even slower). Still separate enums for better documentation.
Real fix: don't forget about phys objs and pin_map(), and fix the
shrinker to have the right annotations ... silly me.
v3: Forgot usertptr too ...
v4: Improve comment for pages_pin_count, drop the IMPORTANT comment
and instead prime lockdep (Chris).
v5: Appease checkpatch, no double empty lines (Chris)
v6: More rebasing over selftest changes. Also somehow I forgot to
push this patch :-/
Also format comments consistently while at it.
v7: Fix typo in commit message (Joonas)
Also drop the priming, with the lmem merge we now have allocations
while holding the lmem lock, which wreaks the generic priming I've
done in earlier patches. Should probably be resurrected when lmem is
fixed. See
commit 232a6ebae419193f5b8da4fa869ae5089ab105c2
Author: Matthew Auld <matthew.auld@intel.com>
Date: Tue Oct 8 17:01:14 2019 +0100
drm/i915: introduce intel_memory_region
I'm keeping the priming patch locally so it wont get lost.
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Tang, CQ" <cq.tang@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> (v5)
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> (v6)
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191105090148.30269-1-daniel.vetter@ffwll.ch
[mlankhorst: Fix commit typos pointed out by Michael Ruhl]
2019-11-05 10:01:48 +01:00
|
|
|
mutex_lock(&obj->mm.lock);
|
2017-10-13 21:26:13 +01:00
|
|
|
if (!i915_gem_object_has_pages(obj)) {
|
2019-06-10 15:54:30 +01:00
|
|
|
try_to_writeback(obj, shrink);
|
2016-10-28 13:58:37 +01:00
|
|
|
count += obj->base.size >> PAGE_SHIFT;
|
|
|
|
}
|
|
|
|
mutex_unlock(&obj->mm.lock);
|
|
|
|
}
|
2019-06-18 08:41:29 +01:00
|
|
|
|
2017-10-13 21:26:18 +01:00
|
|
|
scanned += obj->base.size >> PAGE_SHIFT;
|
2019-06-18 08:41:29 +01:00
|
|
|
i915_gem_object_put(obj);
|
2017-10-16 12:40:37 +01:00
|
|
|
|
2019-06-10 15:54:30 +01:00
|
|
|
spin_lock_irqsave(&i915->mm.obj_lock, flags);
|
2015-03-18 10:46:04 +01:00
|
|
|
}
|
2016-11-01 08:48:43 +00:00
|
|
|
list_splice_tail(&still_in_list, phase->list);
|
2019-06-10 15:54:30 +01:00
|
|
|
spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
|
2015-03-18 10:46:04 +01:00
|
|
|
}
|
|
|
|
|
2019-06-10 15:54:30 +01:00
|
|
|
if (shrink & I915_SHRINK_BOUND)
|
2019-06-13 16:21:54 -07:00
|
|
|
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
|
2016-05-02 14:10:28 +05:30
|
|
|
|
2017-09-06 16:19:30 -07:00
|
|
|
if (nr_scanned)
|
|
|
|
*nr_scanned += scanned;
|
2015-03-18 10:46:04 +01:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2015-03-18 14:47:59 +01:00
|
|
|
/**
|
2015-10-06 14:47:55 +02:00
|
|
|
* i915_gem_shrink_all - Shrink buffer object caches completely
|
2017-11-23 11:53:38 +00:00
|
|
|
* @i915: i915 device
|
2015-03-18 14:47:59 +01:00
|
|
|
*
|
|
|
|
* This is a simple wraper around i915_gem_shrink() to aggressively shrink all
|
|
|
|
* caches completely. It also first waits for and retires all outstanding
|
|
|
|
* requests to also be able to release backing storage for active objects.
|
|
|
|
*
|
|
|
|
* This should only be used in code to intentionally quiescent the gpu or as a
|
|
|
|
* last-ditch effort when memory seems to have run out.
|
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* The number of pages of backing storage actually released.
|
|
|
|
*/
|
2017-11-23 11:53:38 +00:00
|
|
|
unsigned long i915_gem_shrink_all(struct drm_i915_private *i915)
|
2015-03-18 10:46:04 +01:00
|
|
|
{
|
2019-01-14 14:21:18 +00:00
|
|
|
intel_wakeref_t wakeref;
|
2019-01-14 14:21:23 +00:00
|
|
|
unsigned long freed = 0;
|
drm/i915: Enable lockless lookup of request tracking via RCU
If we enable RCU for the requests (providing a grace period where we can
inspect a "dead" request before it is freed), we can allow callers to
carefully perform lockless lookup of an active request.
However, by enabling deferred freeing of requests, we can potentially
hog a lot of memory when dealing with tens of thousands of requests per
second - with a quick insertion of a synchronize_rcu() inside our
shrinker callback, that issue disappears.
v2: Currently, it is our responsibility to handle reclaim i.e. to avoid
hogging memory with the delayed slab frees. At the moment, we wait for a
grace period in the shrinker, and block for all RCU callbacks on oom.
Suggested alternatives focus on flushing our RCU callback when we have a
certain number of outstanding request frees, and blocking on that flush
after a second high watermark. (So rather than wait for the system to
run out of memory, we stop issuing requests - both are nondeterministic.)
Paul E. McKenney wrote:
Another approach is synchronize_rcu() after some largish number of
requests. The advantage of this approach is that it throttles the
production of callbacks at the source. The corresponding disadvantage
is that it slows things up.
Another approach is to use call_rcu(), but if the previous call_rcu()
is still in flight, block waiting for it. Yet another approach is
the get_state_synchronize_rcu() / cond_synchronize_rcu() pair. The
idea is to do something like this:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
You would of course do an initial get_state_synchronize_rcu() to
get things going. This would not block unless there was less than
one grace period's worth of time between invocations. But this
assumes a busy system, where there is almost always a grace period
in flight. But you can make that happen as follows:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
call_rcu(&my_rcu_head, noop_function);
Note that you need additional code to make sure that the old callback
has completed before doing a new one. Setting and clearing a flag
with appropriate memory ordering control suffices (e.g,. smp_load_acquire()
and smp_store_release()).
v3: More comments on compiler and processor order of operations within
the RCU lookup and discover we can use rcu_access_pointer() here instead.
v4: Wrap i915_gem_active_get_rcu() to take the rcu_read_lock itself.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Goel, Akash" <akash.goel@intel.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1470324762-2545-25-git-send-email-chris@chris-wilson.co.uk
2016-08-04 16:32:41 +01:00
|
|
|
|
2019-06-13 16:21:55 -07:00
|
|
|
with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
|
2019-01-14 14:21:23 +00:00
|
|
|
freed = i915_gem_shrink(i915, -1UL, NULL,
|
|
|
|
I915_SHRINK_BOUND |
|
2020-02-21 22:18:18 +00:00
|
|
|
I915_SHRINK_UNBOUND);
|
2019-01-14 14:21:23 +00:00
|
|
|
}
|
2017-02-08 10:47:10 +00:00
|
|
|
|
drm/i915: Enable lockless lookup of request tracking via RCU
If we enable RCU for the requests (providing a grace period where we can
inspect a "dead" request before it is freed), we can allow callers to
carefully perform lockless lookup of an active request.
However, by enabling deferred freeing of requests, we can potentially
hog a lot of memory when dealing with tens of thousands of requests per
second - with a quick insertion of a synchronize_rcu() inside our
shrinker callback, that issue disappears.
v2: Currently, it is our responsibility to handle reclaim i.e. to avoid
hogging memory with the delayed slab frees. At the moment, we wait for a
grace period in the shrinker, and block for all RCU callbacks on oom.
Suggested alternatives focus on flushing our RCU callback when we have a
certain number of outstanding request frees, and blocking on that flush
after a second high watermark. (So rather than wait for the system to
run out of memory, we stop issuing requests - both are nondeterministic.)
Paul E. McKenney wrote:
Another approach is synchronize_rcu() after some largish number of
requests. The advantage of this approach is that it throttles the
production of callbacks at the source. The corresponding disadvantage
is that it slows things up.
Another approach is to use call_rcu(), but if the previous call_rcu()
is still in flight, block waiting for it. Yet another approach is
the get_state_synchronize_rcu() / cond_synchronize_rcu() pair. The
idea is to do something like this:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
You would of course do an initial get_state_synchronize_rcu() to
get things going. This would not block unless there was less than
one grace period's worth of time between invocations. But this
assumes a busy system, where there is almost always a grace period
in flight. But you can make that happen as follows:
cond_synchronize_rcu(cookie);
cookie = get_state_synchronize_rcu();
call_rcu(&my_rcu_head, noop_function);
Note that you need additional code to make sure that the old callback
has completed before doing a new one. Setting and clearing a flag
with appropriate memory ordering control suffices (e.g,. smp_load_acquire()
and smp_store_release()).
v3: More comments on compiler and processor order of operations within
the RCU lookup and discover we can use rcu_access_pointer() here instead.
v4: Wrap i915_gem_active_get_rcu() to take the rcu_read_lock itself.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: "Goel, Akash" <akash.goel@intel.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1470324762-2545-25-git-send-email-chris@chris-wilson.co.uk
2016-08-04 16:32:41 +01:00
|
|
|
return freed;
|
2015-03-18 10:46:04 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned long
|
|
|
|
i915_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc)
|
|
|
|
{
|
2017-10-13 21:26:19 +01:00
|
|
|
struct drm_i915_private *i915 =
|
2015-03-18 10:46:04 +01:00
|
|
|
container_of(shrinker, struct drm_i915_private, mm.shrinker);
|
2019-05-30 21:35:00 +01:00
|
|
|
unsigned long num_objects;
|
|
|
|
unsigned long count;
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2019-05-30 21:35:00 +01:00
|
|
|
count = READ_ONCE(i915->mm.shrink_memory) >> PAGE_SHIFT;
|
|
|
|
num_objects = READ_ONCE(i915->mm.shrink_count);
|
2017-10-13 21:26:19 +01:00
|
|
|
|
2019-05-30 21:35:00 +01:00
|
|
|
/*
|
|
|
|
* Update our preferred vmscan batch size for the next pass.
|
2017-10-13 21:26:19 +01:00
|
|
|
* Our rough guess for an effective batch size is roughly 2
|
|
|
|
* available GEM objects worth of pages. That is we don't want
|
|
|
|
* the shrinker to fire, until it is worth the cost of freeing an
|
|
|
|
* entire GEM object.
|
|
|
|
*/
|
|
|
|
if (num_objects) {
|
|
|
|
unsigned long avg = 2 * count / num_objects;
|
|
|
|
|
|
|
|
i915->mm.shrinker.batch =
|
|
|
|
max((i915->mm.shrinker.batch + avg) >> 1,
|
|
|
|
128ul /* default SHRINK_BATCH */);
|
|
|
|
}
|
2015-03-18 10:46:04 +01:00
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned long
|
|
|
|
i915_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc)
|
|
|
|
{
|
2017-11-23 11:53:38 +00:00
|
|
|
struct drm_i915_private *i915 =
|
2015-03-18 10:46:04 +01:00
|
|
|
container_of(shrinker, struct drm_i915_private, mm.shrinker);
|
|
|
|
unsigned long freed;
|
|
|
|
|
2017-09-06 16:19:30 -07:00
|
|
|
sc->nr_scanned = 0;
|
|
|
|
|
2017-11-23 11:53:38 +00:00
|
|
|
freed = i915_gem_shrink(i915,
|
2015-03-18 10:46:04 +01:00
|
|
|
sc->nr_to_scan,
|
2017-09-06 16:19:30 -07:00
|
|
|
&sc->nr_scanned,
|
2015-03-18 10:46:04 +01:00
|
|
|
I915_SHRINK_BOUND |
|
drm/i915: Pull i915_vma_pin under the vm->mutex
Replace the struct_mutex requirement for pinning the i915_vma with the
local vm->mutex instead. Note that the vm->mutex is tainted by the
shrinker (we require unbinding from inside fs-reclaim) and so we cannot
allocate while holding that mutex. Instead we have to preallocate
workers to do allocate and apply the PTE updates after we have we
reserved their slot in the drm_mm (using fences to order the PTE writes
with the GPU work and with later unbind).
In adding the asynchronous vma binding, one subtle requirement is to
avoid coupling the binding fence into the backing object->resv. That is
the asynchronous binding only applies to the vma timeline itself and not
to the pages as that is a more global timeline (the binding of one vma
does not need to be ordered with another vma, nor does the implicit GEM
fencing depend on a vma, only on writes to the backing store). Keeping
the vma binding distinct from the backing store timelines is verified by
a number of async gem_exec_fence and gem_exec_schedule tests. The way we
do this is quite simple, we keep the fence for the vma binding separate
and only wait on it as required, and never add it to the obj->resv
itself.
Another consequence in reducing the locking around the vma is the
destruction of the vma is no longer globally serialised by struct_mutex.
A natural solution would be to add a kref to i915_vma, but that requires
decoupling the reference cycles, possibly by introducing a new
i915_mm_pages object that is own by both obj->mm and vma->pages.
However, we have not taken that route due to the overshadowing lmem/ttm
discussions, and instead play a series of complicated games with
trylocks to (hopefully) ensure that only one destruction path is called!
v2: Add some commentary, and some helpers to reduce patch churn.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191004134015.13204-4-chris@chris-wilson.co.uk
2019-10-04 14:39:58 +01:00
|
|
|
I915_SHRINK_UNBOUND);
|
2018-01-15 21:24:46 +00:00
|
|
|
if (sc->nr_scanned < sc->nr_to_scan && current_is_kswapd()) {
|
2019-01-14 14:21:18 +00:00
|
|
|
intel_wakeref_t wakeref;
|
|
|
|
|
2019-06-13 16:21:55 -07:00
|
|
|
with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
|
2019-01-14 14:21:23 +00:00
|
|
|
freed += i915_gem_shrink(i915,
|
|
|
|
sc->nr_to_scan - sc->nr_scanned,
|
|
|
|
&sc->nr_scanned,
|
|
|
|
I915_SHRINK_ACTIVE |
|
|
|
|
I915_SHRINK_BOUND |
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 12:55:39 +01:00
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_WRITEBACK);
|
2019-01-14 14:21:23 +00:00
|
|
|
}
|
2017-06-01 14:33:29 +01:00
|
|
|
}
|
2017-04-07 13:49:34 +03:00
|
|
|
|
2017-09-06 16:19:30 -07:00
|
|
|
return sc->nr_scanned ? freed : SHRINK_STOP;
|
2015-03-18 10:46:04 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_shrinker_oom(struct notifier_block *nb, unsigned long event, void *ptr)
|
|
|
|
{
|
2017-11-23 11:53:38 +00:00
|
|
|
struct drm_i915_private *i915 =
|
2015-03-18 10:46:04 +01:00
|
|
|
container_of(nb, struct drm_i915_private, mm.oom_notifier);
|
|
|
|
struct drm_i915_gem_object *obj;
|
2019-06-12 11:57:20 +01:00
|
|
|
unsigned long unevictable, available, freed_pages;
|
2019-01-14 14:21:18 +00:00
|
|
|
intel_wakeref_t wakeref;
|
2019-06-10 15:54:30 +01:00
|
|
|
unsigned long flags;
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2019-01-14 14:21:23 +00:00
|
|
|
freed_pages = 0;
|
2019-06-13 16:21:55 -07:00
|
|
|
with_intel_runtime_pm(&i915->runtime_pm, wakeref)
|
2019-01-14 14:21:23 +00:00
|
|
|
freed_pages += i915_gem_shrink(i915, -1UL, NULL,
|
|
|
|
I915_SHRINK_BOUND |
|
drm/i915: Start writeback from the shrinker
When we are called to relieve mempressue via the shrinker, the only way
we can make progress is either by discarding unwanted pages (those
objects that userspace has marked MADV_DONTNEED) or by reclaiming the
dirty objects via swap. As we know that is the only way to make further
progress, we can initiate the writeback as we invalidate the objects.
This means the objects we put onto the inactive anon lru list are
already marked for reclaim+writeback and so will trigger a wait upon the
writeback inside direct reclaim, greatly improving the success rate of
direct reclaim on i915 objects.
The corollary is that we may start a slow swap on opportunistic
mempressure from the likes of the compaction + migration kthreads. This
is limited by those threads only being allowed to shrink idle pages, but
also that if we reactivate the page before it is swapped out by gpu
activity, we only page the cost of repinning the page. The cost is most
felt when an object is reused after mempressure, which hopefully
excludes the latency sensitive tasks (as we are just extending the
impact of swap thrashing to them).
Apparently this is not the first time we've had this idea. Back in
commit 5537252b6b6d ("drm/i915: Invalidate our pages under memory
pressure") we wanted to start writeback but settled on invalidate after
Hugh Dickins warned us about a possibility of a deadlock within shmemfs
if we started writeback from shrink_slab. Looking at the callchain,
using writeback from i915_gem_shrink should be equivalent to the pageout
also employed by shrink_slab, i.e. it should not be any riskier afaict.
v2: Leave mmapings intact. At this point, the only mmapings of our
objects will be via CPU mmaps on the shmemfs filp, which are
out-of-scope for our LRU tracking. Instead leave those pages to the
inactive anon LRU page list for aging and pageout as normal.
v3: Be selective on which paths trigger writeback, in particular
excluding paths shrinking just to reclaim vm space (e.g. mmap, vmap
reapers) and avoid starting writeback on the entire process space from
within the pm freezer.
References: https://bugs.freedesktop.org/show_bug.cgi?id=108686
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Michal Hocko <mhocko@suse.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20190420115539.29081-1-chris@chris-wilson.co.uk
2019-04-20 12:55:39 +01:00
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_WRITEBACK);
|
2015-03-18 10:46:04 +01:00
|
|
|
|
|
|
|
/* Because we may be allocating inside our own driver, we cannot
|
|
|
|
* assert that there are no objects with pinned pages that are not
|
|
|
|
* being pointed to by hardware.
|
|
|
|
*/
|
2019-06-12 11:57:20 +01:00
|
|
|
available = unevictable = 0;
|
2019-06-10 15:54:30 +01:00
|
|
|
spin_lock_irqsave(&i915->mm.obj_lock, flags);
|
2019-06-12 11:57:20 +01:00
|
|
|
list_for_each_entry(obj, &i915->mm.shrink_list, mm.link) {
|
2016-04-20 12:09:51 +01:00
|
|
|
if (!can_release_pages(obj))
|
|
|
|
unevictable += obj->base.size >> PAGE_SHIFT;
|
2015-03-18 10:46:04 +01:00
|
|
|
else
|
2019-06-12 11:57:20 +01:00
|
|
|
available += obj->base.size >> PAGE_SHIFT;
|
2015-03-18 10:46:04 +01:00
|
|
|
}
|
2019-06-10 15:54:30 +01:00
|
|
|
spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2019-06-12 11:57:20 +01:00
|
|
|
if (freed_pages || available)
|
2016-04-20 12:09:51 +01:00
|
|
|
pr_info("Purging GPU memory, %lu pages freed, "
|
2019-06-12 11:57:20 +01:00
|
|
|
"%lu pages still pinned, %lu pages left available.\n",
|
|
|
|
freed_pages, unevictable, available);
|
2015-03-18 10:46:04 +01:00
|
|
|
|
|
|
|
*(unsigned long *)ptr += freed_pages;
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
2016-04-04 14:46:43 +01:00
|
|
|
static int
|
|
|
|
i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr)
|
|
|
|
{
|
2017-11-23 11:53:38 +00:00
|
|
|
struct drm_i915_private *i915 =
|
2016-04-04 14:46:43 +01:00
|
|
|
container_of(nb, struct drm_i915_private, mm.vmap_notifier);
|
2016-04-28 09:56:39 +01:00
|
|
|
struct i915_vma *vma, *next;
|
|
|
|
unsigned long freed_pages = 0;
|
2019-01-14 14:21:18 +00:00
|
|
|
intel_wakeref_t wakeref;
|
2016-04-04 14:46:43 +01:00
|
|
|
|
2019-06-13 16:21:55 -07:00
|
|
|
with_intel_runtime_pm(&i915->runtime_pm, wakeref)
|
2019-01-14 14:21:23 +00:00
|
|
|
freed_pages += i915_gem_shrink(i915, -1UL, NULL,
|
|
|
|
I915_SHRINK_BOUND |
|
|
|
|
I915_SHRINK_UNBOUND |
|
|
|
|
I915_SHRINK_VMAPS);
|
2016-04-28 09:56:39 +01:00
|
|
|
|
|
|
|
/* We also want to clear any cached iomaps as they wrap vmap */
|
2019-01-28 10:23:53 +00:00
|
|
|
mutex_lock(&i915->ggtt.vm.mutex);
|
2016-04-28 09:56:39 +01:00
|
|
|
list_for_each_entry_safe(vma, next,
|
2019-01-28 10:23:52 +00:00
|
|
|
&i915->ggtt.vm.bound_list, vm_link) {
|
2016-04-28 09:56:39 +01:00
|
|
|
unsigned long count = vma->node.size >> PAGE_SHIFT;
|
2019-01-28 10:23:52 +00:00
|
|
|
|
|
|
|
if (!vma->iomap || i915_vma_is_active(vma))
|
|
|
|
continue;
|
|
|
|
|
drm/i915: Pull i915_vma_pin under the vm->mutex
Replace the struct_mutex requirement for pinning the i915_vma with the
local vm->mutex instead. Note that the vm->mutex is tainted by the
shrinker (we require unbinding from inside fs-reclaim) and so we cannot
allocate while holding that mutex. Instead we have to preallocate
workers to do allocate and apply the PTE updates after we have we
reserved their slot in the drm_mm (using fences to order the PTE writes
with the GPU work and with later unbind).
In adding the asynchronous vma binding, one subtle requirement is to
avoid coupling the binding fence into the backing object->resv. That is
the asynchronous binding only applies to the vma timeline itself and not
to the pages as that is a more global timeline (the binding of one vma
does not need to be ordered with another vma, nor does the implicit GEM
fencing depend on a vma, only on writes to the backing store). Keeping
the vma binding distinct from the backing store timelines is verified by
a number of async gem_exec_fence and gem_exec_schedule tests. The way we
do this is quite simple, we keep the fence for the vma binding separate
and only wait on it as required, and never add it to the obj->resv
itself.
Another consequence in reducing the locking around the vma is the
destruction of the vma is no longer globally serialised by struct_mutex.
A natural solution would be to add a kref to i915_vma, but that requires
decoupling the reference cycles, possibly by introducing a new
i915_mm_pages object that is own by both obj->mm and vma->pages.
However, we have not taken that route due to the overshadowing lmem/ttm
discussions, and instead play a series of complicated games with
trylocks to (hopefully) ensure that only one destruction path is called!
v2: Add some commentary, and some helpers to reduce patch churn.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191004134015.13204-4-chris@chris-wilson.co.uk
2019-10-04 14:39:58 +01:00
|
|
|
if (__i915_vma_unbind(vma) == 0)
|
2016-04-28 09:56:39 +01:00
|
|
|
freed_pages += count;
|
|
|
|
}
|
2019-01-28 10:23:53 +00:00
|
|
|
mutex_unlock(&i915->ggtt.vm.mutex);
|
2016-04-04 14:46:43 +01:00
|
|
|
|
|
|
|
*(unsigned long *)ptr += freed_pages;
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
2019-08-06 13:42:59 +01:00
|
|
|
void i915_gem_driver_register__shrinker(struct drm_i915_private *i915)
|
2015-03-18 10:46:04 +01:00
|
|
|
{
|
2017-11-23 11:53:38 +00:00
|
|
|
i915->mm.shrinker.scan_objects = i915_gem_shrinker_scan;
|
|
|
|
i915->mm.shrinker.count_objects = i915_gem_shrinker_count;
|
|
|
|
i915->mm.shrinker.seeks = DEFAULT_SEEKS;
|
|
|
|
i915->mm.shrinker.batch = 4096;
|
drm/i915/gem: Make WARN* drm specific where drm_priv ptr is available
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automatically with below coccinelle semantic
patch. checkpatch errors/warnings are fixed manually.
@rule1@
identifier func, T;
@@
func(...) {
...
struct drm_i915_private *T = ...;
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
command: spatch --sp-file <script> --dir drivers/gpu/drm/i915/gem \
--linux-spacing --in-place
Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200115034455.17658-6-pankaj.laxminarayan.bharadiya@intel.com
2020-01-15 09:14:49 +05:30
|
|
|
drm_WARN_ON(&i915->drm, register_shrinker(&i915->mm.shrinker));
|
2015-03-18 10:46:04 +01:00
|
|
|
|
2017-11-23 11:53:38 +00:00
|
|
|
i915->mm.oom_notifier.notifier_call = i915_gem_shrinker_oom;
|
drm/i915/gem: Make WARN* drm specific where drm_priv ptr is available
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automatically with below coccinelle semantic
patch. checkpatch errors/warnings are fixed manually.
@rule1@
identifier func, T;
@@
func(...) {
...
struct drm_i915_private *T = ...;
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
command: spatch --sp-file <script> --dir drivers/gpu/drm/i915/gem \
--linux-spacing --in-place
Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200115034455.17658-6-pankaj.laxminarayan.bharadiya@intel.com
2020-01-15 09:14:49 +05:30
|
|
|
drm_WARN_ON(&i915->drm, register_oom_notifier(&i915->mm.oom_notifier));
|
2016-04-04 14:46:43 +01:00
|
|
|
|
2017-11-23 11:53:38 +00:00
|
|
|
i915->mm.vmap_notifier.notifier_call = i915_gem_shrinker_vmap;
|
drm/i915/gem: Make WARN* drm specific where drm_priv ptr is available
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automatically with below coccinelle semantic
patch. checkpatch errors/warnings are fixed manually.
@rule1@
identifier func, T;
@@
func(...) {
...
struct drm_i915_private *T = ...;
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
command: spatch --sp-file <script> --dir drivers/gpu/drm/i915/gem \
--linux-spacing --in-place
Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200115034455.17658-6-pankaj.laxminarayan.bharadiya@intel.com
2020-01-15 09:14:49 +05:30
|
|
|
drm_WARN_ON(&i915->drm,
|
|
|
|
register_vmap_purge_notifier(&i915->mm.vmap_notifier));
|
2016-01-19 15:26:28 +02:00
|
|
|
}
|
|
|
|
|
2019-08-06 13:42:59 +01:00
|
|
|
void i915_gem_driver_unregister__shrinker(struct drm_i915_private *i915)
|
2016-01-19 15:26:28 +02:00
|
|
|
{
|
drm/i915/gem: Make WARN* drm specific where drm_priv ptr is available
drm specific WARN* calls include device information in the
backtrace, so we know what device the warnings originate from.
Covert all the calls of WARN* with device specific drm_WARN*
variants in functions where drm_i915_private struct pointer is readily
available.
The conversion was done automatically with below coccinelle semantic
patch. checkpatch errors/warnings are fixed manually.
@rule1@
identifier func, T;
@@
func(...) {
...
struct drm_i915_private *T = ...;
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<+...
(
-WARN(
+drm_WARN(&T->drm,
...)
|
-WARN_ON(
+drm_WARN_ON(&T->drm,
...)
|
-WARN_ONCE(
+drm_WARN_ONCE(&T->drm,
...)
|
-WARN_ON_ONCE(
+drm_WARN_ON_ONCE(&T->drm,
...)
)
...+>
}
command: spatch --sp-file <script> --dir drivers/gpu/drm/i915/gem \
--linux-spacing --in-place
Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200115034455.17658-6-pankaj.laxminarayan.bharadiya@intel.com
2020-01-15 09:14:49 +05:30
|
|
|
drm_WARN_ON(&i915->drm,
|
|
|
|
unregister_vmap_purge_notifier(&i915->mm.vmap_notifier));
|
|
|
|
drm_WARN_ON(&i915->drm,
|
|
|
|
unregister_oom_notifier(&i915->mm.oom_notifier));
|
2017-11-23 11:53:38 +00:00
|
|
|
unregister_shrinker(&i915->mm.shrinker);
|
2015-03-18 10:46:04 +01:00
|
|
|
}
|
2018-07-11 08:36:02 +01:00
|
|
|
|
2019-01-07 11:54:24 +00:00
|
|
|
void i915_gem_shrinker_taints_mutex(struct drm_i915_private *i915,
|
|
|
|
struct mutex *mutex)
|
2018-07-11 08:36:02 +01:00
|
|
|
{
|
|
|
|
if (!IS_ENABLED(CONFIG_LOCKDEP))
|
|
|
|
return;
|
|
|
|
|
|
|
|
fs_reclaim_acquire(GFP_KERNEL);
|
2019-01-07 11:54:24 +00:00
|
|
|
|
|
|
|
mutex_acquire(&mutex->dep_map, 0, 0, _RET_IP_);
|
2019-09-19 12:09:40 -04:00
|
|
|
mutex_release(&mutex->dep_map, _RET_IP_);
|
2019-01-07 11:54:24 +00:00
|
|
|
|
2018-07-11 08:36:02 +01:00
|
|
|
fs_reclaim_release(GFP_KERNEL);
|
|
|
|
}
|
2019-08-02 22:21:36 +01:00
|
|
|
|
|
|
|
#define obj_to_i915(obj__) to_i915((obj__)->base.dev)
|
|
|
|
|
|
|
|
void i915_gem_object_make_unshrinkable(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
2019-09-10 22:22:04 +01:00
|
|
|
struct drm_i915_private *i915 = obj_to_i915(obj);
|
|
|
|
unsigned long flags;
|
|
|
|
|
2019-08-02 22:21:36 +01:00
|
|
|
/*
|
|
|
|
* We can only be called while the pages are pinned or when
|
|
|
|
* the pages are released. If pinned, we should only be called
|
|
|
|
* from a single caller under controlled conditions; and on release
|
|
|
|
* only one caller may release us. Neither the two may cross.
|
|
|
|
*/
|
2019-09-10 22:22:04 +01:00
|
|
|
if (atomic_add_unless(&obj->mm.shrink_pin, 1, 0))
|
|
|
|
return;
|
2019-08-02 22:21:36 +01:00
|
|
|
|
2019-09-10 22:22:04 +01:00
|
|
|
spin_lock_irqsave(&i915->mm.obj_lock, flags);
|
|
|
|
if (!atomic_fetch_inc(&obj->mm.shrink_pin) &&
|
|
|
|
!list_empty(&obj->mm.link)) {
|
2019-08-02 22:21:36 +01:00
|
|
|
list_del_init(&obj->mm.link);
|
|
|
|
i915->mm.shrink_count--;
|
|
|
|
i915->mm.shrink_memory -= obj->base.size;
|
|
|
|
}
|
2019-09-10 22:22:04 +01:00
|
|
|
spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
|
2019-08-02 22:21:36 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static void __i915_gem_object_make_shrinkable(struct drm_i915_gem_object *obj,
|
|
|
|
struct list_head *head)
|
|
|
|
{
|
2019-09-10 22:22:04 +01:00
|
|
|
struct drm_i915_private *i915 = obj_to_i915(obj);
|
|
|
|
unsigned long flags;
|
|
|
|
|
2019-08-02 22:21:36 +01:00
|
|
|
GEM_BUG_ON(!i915_gem_object_has_pages(obj));
|
2019-09-10 22:22:04 +01:00
|
|
|
if (!i915_gem_object_is_shrinkable(obj))
|
|
|
|
return;
|
2019-08-02 22:21:36 +01:00
|
|
|
|
2019-09-10 22:22:04 +01:00
|
|
|
if (atomic_add_unless(&obj->mm.shrink_pin, -1, 1))
|
|
|
|
return;
|
2019-08-02 22:21:36 +01:00
|
|
|
|
2019-09-10 22:22:04 +01:00
|
|
|
spin_lock_irqsave(&i915->mm.obj_lock, flags);
|
|
|
|
GEM_BUG_ON(!kref_read(&obj->base.refcount));
|
|
|
|
if (atomic_dec_and_test(&obj->mm.shrink_pin)) {
|
|
|
|
GEM_BUG_ON(!list_empty(&obj->mm.link));
|
2019-08-02 22:21:36 +01:00
|
|
|
|
|
|
|
list_add_tail(&obj->mm.link, head);
|
|
|
|
i915->mm.shrink_count++;
|
|
|
|
i915->mm.shrink_memory += obj->base.size;
|
|
|
|
|
|
|
|
}
|
2019-09-10 22:22:04 +01:00
|
|
|
spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
|
2019-08-02 22:21:36 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void i915_gem_object_make_shrinkable(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
|
|
|
__i915_gem_object_make_shrinkable(obj,
|
|
|
|
&obj_to_i915(obj)->mm.shrink_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
void i915_gem_object_make_purgeable(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
|
|
|
__i915_gem_object_make_shrinkable(obj,
|
|
|
|
&obj_to_i915(obj)->mm.purge_list);
|
|
|
|
}
|