2011-12-13 13:19:38 -08:00
|
|
|
/*
|
|
|
|
* Copyright © 2011 Intel Corporation
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
* Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
|
|
* SOFTWARE.
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Jesse Barnes <jbarnes@virtuousgeek.org>
|
|
|
|
*
|
|
|
|
* New plane/sprite handling.
|
|
|
|
*
|
|
|
|
* The older chips had a separate interface for programming plane related
|
|
|
|
* registers; newer ones are much simpler and we can use the new DRM plane
|
|
|
|
* support.
|
|
|
|
*/
|
2019-04-05 14:00:09 +03:00
|
|
|
|
|
|
|
#include <drm/drm_atomic.h>
|
2017-08-01 09:58:16 -07:00
|
|
|
#include <drm/drm_atomic_helper.h>
|
2019-04-05 14:00:09 +03:00
|
|
|
#include <drm/drm_color_mgmt.h>
|
2012-10-02 18:01:07 +01:00
|
|
|
#include <drm/drm_crtc.h>
|
2020-06-25 18:01:47 -07:00
|
|
|
#include <drm/drm_damage_helper.h>
|
2012-10-02 18:01:07 +01:00
|
|
|
#include <drm/drm_fourcc.h>
|
2014-12-23 10:41:52 -08:00
|
|
|
#include <drm/drm_plane_helper.h>
|
2019-04-05 14:00:09 +03:00
|
|
|
#include <drm/drm_rect.h>
|
|
|
|
|
2011-12-13 13:19:38 -08:00
|
|
|
#include "i915_drv.h"
|
2019-08-06 13:07:28 +03:00
|
|
|
#include "i915_trace.h"
|
2020-02-27 16:44:06 +02:00
|
|
|
#include "i915_vgpu.h"
|
2019-04-05 14:00:19 +03:00
|
|
|
#include "intel_atomic_plane.h"
|
2019-08-06 14:39:33 +03:00
|
|
|
#include "intel_display_types.h"
|
2019-04-05 14:00:09 +03:00
|
|
|
#include "intel_frontbuffer.h"
|
2019-04-05 14:00:24 +03:00
|
|
|
#include "intel_sprite.h"
|
2020-12-21 13:09:57 +02:00
|
|
|
#include "i9xx_plane.h"
|
2021-01-22 15:26:40 -08:00
|
|
|
#include "intel_vrr.h"
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2018-09-18 17:02:43 +03:00
|
|
|
int intel_plane_check_stride(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
|
|
|
unsigned int rotation = plane_state->hw.rotation;
|
2018-09-18 17:02:43 +03:00
|
|
|
u32 stride, max_stride;
|
|
|
|
|
2019-05-09 15:21:56 +03:00
|
|
|
/*
|
|
|
|
* We ignore stride for all invisible planes that
|
|
|
|
* can be remapped. Otherwise we could end up
|
|
|
|
* with a false positive when the remapping didn't
|
|
|
|
* kick in due the plane being invisible.
|
|
|
|
*/
|
|
|
|
if (intel_plane_can_remap(plane_state) &&
|
2019-10-31 12:26:08 +01:00
|
|
|
!plane_state->uapi.visible)
|
2019-05-09 15:21:56 +03:00
|
|
|
return 0;
|
|
|
|
|
2018-09-18 17:02:43 +03:00
|
|
|
/* FIXME other color planes? */
|
|
|
|
stride = plane_state->color_plane[0].stride;
|
|
|
|
max_stride = plane->max_stride(plane, fb->format->format,
|
|
|
|
fb->modifier, rotation);
|
|
|
|
|
|
|
|
if (stride > max_stride) {
|
|
|
|
DRM_DEBUG_KMS("[FB:%d] stride (%d) exceeds [PLANE:%d:%s] max stride (%d)\n",
|
|
|
|
fb->base.id, stride,
|
|
|
|
plane->base.base.id, plane->base.name, max_stride);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-31 12:26:08 +01:00
|
|
|
struct drm_rect *src = &plane_state->uapi.src;
|
2019-03-22 14:59:52 +01:00
|
|
|
u32 src_x, src_y, src_w, src_h, hsub, vsub;
|
2019-10-31 12:26:07 +01:00
|
|
|
bool rotated = drm_rotation_90_or_270(plane_state->hw.rotation);
|
2018-09-07 18:24:09 +03:00
|
|
|
|
2020-02-28 18:05:23 +02:00
|
|
|
/*
|
|
|
|
* FIXME hsub/vsub vs. block size is a mess. Pre-tgl CCS
|
|
|
|
* abuses hsub/vsub so we can't use them here. But as they
|
|
|
|
* are limited to 32bpp RGB formats we don't actually need
|
|
|
|
* to check anything.
|
|
|
|
*/
|
|
|
|
if (fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS ||
|
|
|
|
fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS)
|
|
|
|
return 0;
|
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
/*
|
|
|
|
* Hardware doesn't handle subpixel coordinates.
|
|
|
|
* Adjust to (macro)pixel boundary, but be careful not to
|
|
|
|
* increase the source viewport size, because that could
|
|
|
|
* push the downscaling factor out of bounds.
|
|
|
|
*/
|
|
|
|
src_x = src->x1 >> 16;
|
|
|
|
src_w = drm_rect_width(src) >> 16;
|
|
|
|
src_y = src->y1 >> 16;
|
|
|
|
src_h = drm_rect_height(src) >> 16;
|
|
|
|
|
2019-09-30 16:42:14 +03:00
|
|
|
drm_rect_init(src, src_x << 16, src_y << 16,
|
|
|
|
src_w << 16, src_h << 16);
|
2018-09-07 18:24:09 +03:00
|
|
|
|
2020-02-28 18:05:23 +02:00
|
|
|
if (fb->format->format == DRM_FORMAT_RGB565 && rotated) {
|
|
|
|
hsub = 2;
|
|
|
|
vsub = 2;
|
|
|
|
} else {
|
2019-03-22 14:59:52 +01:00
|
|
|
hsub = fb->format->hsub;
|
|
|
|
vsub = fb->format->vsub;
|
|
|
|
}
|
|
|
|
|
2020-02-28 18:05:23 +02:00
|
|
|
if (rotated)
|
|
|
|
hsub = vsub = max(hsub, vsub);
|
|
|
|
|
2019-03-22 14:59:52 +01:00
|
|
|
if (src_x % hsub || src_w % hsub) {
|
2020-02-28 18:05:23 +02:00
|
|
|
DRM_DEBUG_KMS("src x/w (%u, %u) must be a multiple of %u (rotated: %s)\n",
|
|
|
|
src_x, src_w, hsub, yesno(rotated));
|
2018-09-07 18:24:09 +03:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2019-03-22 14:59:52 +01:00
|
|
|
if (src_y % vsub || src_h % vsub) {
|
2020-02-28 18:05:23 +02:00
|
|
|
DRM_DEBUG_KMS("src y/h (%u, %u) must be a multiple of %u (rotated: %s)\n",
|
|
|
|
src_y, src_h, vsub, yesno(rotated));
|
2018-09-20 12:27:11 +02:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-07-03 23:08:21 +03:00
|
|
|
static void i9xx_plane_linear_gamma(u16 gamma[8])
|
|
|
|
{
|
|
|
|
/* The points are not evenly spaced. */
|
|
|
|
static const u8 in[8] = { 0, 1, 2, 4, 8, 16, 24, 32 };
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < 8; i++)
|
|
|
|
gamma[i] = (in[i] << 8) / 32;
|
|
|
|
}
|
|
|
|
|
2014-10-20 19:47:53 +03:00
|
|
|
static void
|
drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
Turns out the VLV/CHV fixed function sprite CSC expects full range
data as input. We've been feeding it limited range data to it all
along. To expand the data out to full range we'll use the color
correction registers (brightness, contrast, and saturation).
On CHV pipe B we were actually doing the right thing already because we
progammed the custom CSC matrix to do expect limited range input. Now
that well pre-expand the data out with the color correction unit, we
need to change the CSC matrix to operate with full range input instead.
This should make the sprite output of the other pipes match the sprite
output of pipe B reasonably well. Looking at the resulting pipe CRCs,
there can be a slight difference in the output, but as I don't know
the formula used by the fixed function CSC of the other pipes, I don't
think it's worth the effort to try to match the output exactly. It
might not even be possible due to difference in internal precision etc.
One slight caveat here is that the color correction registers are single
bufferred, so we should really be updating them during vblank, but we
still don't have a mechanism for that, so just toss in another FIXME.
v2: Rebase
v3: s/bri/brightness/ s/con/contrast/ (Shashank)
v4: Clarify the constants and math (Shashank)
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: "Tang, Jun" <jun.tang@intel.com>
Reported-by: "Tang, Jun" <jun.tang@intel.com>
Cc: stable@vger.kernel.org
Fixes: 7f1f3851feb0 ("drm/i915: sprite support for ValleyView v4")
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180214192327.3250-5-ville.syrjala@linux.intel.com
2018-02-14 21:23:23 +02:00
|
|
|
chv_update_csc(const struct intel_plane_state *plane_state)
|
2014-10-20 19:47:53 +03:00
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2017-03-27 21:55:33 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2017-03-27 21:55:33 +03:00
|
|
|
enum plane_id plane_id = plane->id;
|
2014-10-20 19:47:53 +03:00
|
|
|
/*
|
2018-02-14 21:23:25 +02:00
|
|
|
* |r| | c0 c1 c2 | |cr|
|
|
|
|
* |g| = | c3 c4 c5 | x |y |
|
|
|
|
* |b| | c6 c7 c8 | |cb|
|
2014-10-20 19:47:53 +03:00
|
|
|
*
|
2018-02-14 21:23:25 +02:00
|
|
|
* Coefficients are s3.12.
|
2014-10-20 19:47:53 +03:00
|
|
|
*
|
2018-02-14 21:23:25 +02:00
|
|
|
* Cb and Cr apparently come in as signed already, and
|
|
|
|
* we always get full range data in on account of CLRC0/1.
|
2014-10-20 19:47:53 +03:00
|
|
|
*/
|
2018-02-14 21:23:25 +02:00
|
|
|
static const s16 csc_matrix[][9] = {
|
|
|
|
/* BT.601 full range YCbCr -> full range RGB */
|
|
|
|
[DRM_COLOR_YCBCR_BT601] = {
|
|
|
|
5743, 4096, 0,
|
|
|
|
-2925, 4096, -1410,
|
|
|
|
0, 4096, 7258,
|
|
|
|
},
|
|
|
|
/* BT.709 full range YCbCr -> full range RGB */
|
|
|
|
[DRM_COLOR_YCBCR_BT709] = {
|
|
|
|
6450, 4096, 0,
|
|
|
|
-1917, 4096, -767,
|
|
|
|
0, 4096, 7601,
|
|
|
|
},
|
|
|
|
};
|
2019-10-31 12:26:07 +01:00
|
|
|
const s16 *csc = csc_matrix[plane_state->hw.color_encoding];
|
2014-10-20 19:47:53 +03:00
|
|
|
|
|
|
|
/* Seems RGB data bypasses the CSC always */
|
2018-07-17 18:13:43 +01:00
|
|
|
if (!fb->format->is_yuv)
|
2014-10-20 19:47:53 +03:00
|
|
|
return;
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPCSCYGOFF(plane_id),
|
|
|
|
SPCSC_OOFF(0) | SPCSC_IOFF(0));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCCBOFF(plane_id),
|
|
|
|
SPCSC_OOFF(0) | SPCSC_IOFF(0));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCCROFF(plane_id),
|
|
|
|
SPCSC_OOFF(0) | SPCSC_IOFF(0));
|
|
|
|
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCC01(plane_id),
|
|
|
|
SPCSC_C1(csc[1]) | SPCSC_C0(csc[0]));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCC23(plane_id),
|
|
|
|
SPCSC_C1(csc[3]) | SPCSC_C0(csc[2]));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCC45(plane_id),
|
|
|
|
SPCSC_C1(csc[5]) | SPCSC_C0(csc[4]));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCC67(plane_id),
|
|
|
|
SPCSC_C1(csc[7]) | SPCSC_C0(csc[6]));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCC8(plane_id), SPCSC_C0(csc[8]));
|
|
|
|
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCYGICLAMP(plane_id),
|
|
|
|
SPCSC_IMAX(1023) | SPCSC_IMIN(0));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCCBICLAMP(plane_id),
|
|
|
|
SPCSC_IMAX(512) | SPCSC_IMIN(-512));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCCRICLAMP(plane_id),
|
|
|
|
SPCSC_IMAX(512) | SPCSC_IMIN(-512));
|
|
|
|
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCYGOCLAMP(plane_id),
|
|
|
|
SPCSC_OMAX(1023) | SPCSC_OMIN(0));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCCBOCLAMP(plane_id),
|
|
|
|
SPCSC_OMAX(1023) | SPCSC_OMIN(0));
|
|
|
|
intel_de_write_fw(dev_priv, SPCSCCROCLAMP(plane_id),
|
|
|
|
SPCSC_OMAX(1023) | SPCSC_OMIN(0));
|
2014-10-20 19:47:53 +03:00
|
|
|
}
|
|
|
|
|
drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
Turns out the VLV/CHV fixed function sprite CSC expects full range
data as input. We've been feeding it limited range data to it all
along. To expand the data out to full range we'll use the color
correction registers (brightness, contrast, and saturation).
On CHV pipe B we were actually doing the right thing already because we
progammed the custom CSC matrix to do expect limited range input. Now
that well pre-expand the data out with the color correction unit, we
need to change the CSC matrix to operate with full range input instead.
This should make the sprite output of the other pipes match the sprite
output of pipe B reasonably well. Looking at the resulting pipe CRCs,
there can be a slight difference in the output, but as I don't know
the formula used by the fixed function CSC of the other pipes, I don't
think it's worth the effort to try to match the output exactly. It
might not even be possible due to difference in internal precision etc.
One slight caveat here is that the color correction registers are single
bufferred, so we should really be updating them during vblank, but we
still don't have a mechanism for that, so just toss in another FIXME.
v2: Rebase
v3: s/bri/brightness/ s/con/contrast/ (Shashank)
v4: Clarify the constants and math (Shashank)
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: "Tang, Jun" <jun.tang@intel.com>
Reported-by: "Tang, Jun" <jun.tang@intel.com>
Cc: stable@vger.kernel.org
Fixes: 7f1f3851feb0 ("drm/i915: sprite support for ValleyView v4")
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180214192327.3250-5-ville.syrjala@linux.intel.com
2018-02-14 21:23:23 +02:00
|
|
|
#define SIN_0 0
|
|
|
|
#define COS_0 1
|
|
|
|
|
|
|
|
static void
|
|
|
|
vlv_update_clrc(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
Turns out the VLV/CHV fixed function sprite CSC expects full range
data as input. We've been feeding it limited range data to it all
along. To expand the data out to full range we'll use the color
correction registers (brightness, contrast, and saturation).
On CHV pipe B we were actually doing the right thing already because we
progammed the custom CSC matrix to do expect limited range input. Now
that well pre-expand the data out with the color correction unit, we
need to change the CSC matrix to operate with full range input instead.
This should make the sprite output of the other pipes match the sprite
output of pipe B reasonably well. Looking at the resulting pipe CRCs,
there can be a slight difference in the output, but as I don't know
the formula used by the fixed function CSC of the other pipes, I don't
think it's worth the effort to try to match the output exactly. It
might not even be possible due to difference in internal precision etc.
One slight caveat here is that the color correction registers are single
bufferred, so we should really be updating them during vblank, but we
still don't have a mechanism for that, so just toss in another FIXME.
v2: Rebase
v3: s/bri/brightness/ s/con/contrast/ (Shashank)
v4: Clarify the constants and math (Shashank)
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: "Tang, Jun" <jun.tang@intel.com>
Reported-by: "Tang, Jun" <jun.tang@intel.com>
Cc: stable@vger.kernel.org
Fixes: 7f1f3851feb0 ("drm/i915: sprite support for ValleyView v4")
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180214192327.3250-5-ville.syrjala@linux.intel.com
2018-02-14 21:23:23 +02:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
Turns out the VLV/CHV fixed function sprite CSC expects full range
data as input. We've been feeding it limited range data to it all
along. To expand the data out to full range we'll use the color
correction registers (brightness, contrast, and saturation).
On CHV pipe B we were actually doing the right thing already because we
progammed the custom CSC matrix to do expect limited range input. Now
that well pre-expand the data out with the color correction unit, we
need to change the CSC matrix to operate with full range input instead.
This should make the sprite output of the other pipes match the sprite
output of pipe B reasonably well. Looking at the resulting pipe CRCs,
there can be a slight difference in the output, but as I don't know
the formula used by the fixed function CSC of the other pipes, I don't
think it's worth the effort to try to match the output exactly. It
might not even be possible due to difference in internal precision etc.
One slight caveat here is that the color correction registers are single
bufferred, so we should really be updating them during vblank, but we
still don't have a mechanism for that, so just toss in another FIXME.
v2: Rebase
v3: s/bri/brightness/ s/con/contrast/ (Shashank)
v4: Clarify the constants and math (Shashank)
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: "Tang, Jun" <jun.tang@intel.com>
Reported-by: "Tang, Jun" <jun.tang@intel.com>
Cc: stable@vger.kernel.org
Fixes: 7f1f3851feb0 ("drm/i915: sprite support for ValleyView v4")
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180214192327.3250-5-ville.syrjala@linux.intel.com
2018-02-14 21:23:23 +02:00
|
|
|
enum pipe pipe = plane->pipe;
|
|
|
|
enum plane_id plane_id = plane->id;
|
|
|
|
int contrast, brightness, sh_scale, sh_sin, sh_cos;
|
|
|
|
|
2018-07-17 18:13:43 +01:00
|
|
|
if (fb->format->is_yuv &&
|
2019-10-31 12:26:07 +01:00
|
|
|
plane_state->hw.color_range == DRM_COLOR_YCBCR_LIMITED_RANGE) {
|
drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
Turns out the VLV/CHV fixed function sprite CSC expects full range
data as input. We've been feeding it limited range data to it all
along. To expand the data out to full range we'll use the color
correction registers (brightness, contrast, and saturation).
On CHV pipe B we were actually doing the right thing already because we
progammed the custom CSC matrix to do expect limited range input. Now
that well pre-expand the data out with the color correction unit, we
need to change the CSC matrix to operate with full range input instead.
This should make the sprite output of the other pipes match the sprite
output of pipe B reasonably well. Looking at the resulting pipe CRCs,
there can be a slight difference in the output, but as I don't know
the formula used by the fixed function CSC of the other pipes, I don't
think it's worth the effort to try to match the output exactly. It
might not even be possible due to difference in internal precision etc.
One slight caveat here is that the color correction registers are single
bufferred, so we should really be updating them during vblank, but we
still don't have a mechanism for that, so just toss in another FIXME.
v2: Rebase
v3: s/bri/brightness/ s/con/contrast/ (Shashank)
v4: Clarify the constants and math (Shashank)
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: "Tang, Jun" <jun.tang@intel.com>
Reported-by: "Tang, Jun" <jun.tang@intel.com>
Cc: stable@vger.kernel.org
Fixes: 7f1f3851feb0 ("drm/i915: sprite support for ValleyView v4")
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180214192327.3250-5-ville.syrjala@linux.intel.com
2018-02-14 21:23:23 +02:00
|
|
|
/*
|
|
|
|
* Expand limited range to full range:
|
|
|
|
* Contrast is applied first and is used to expand Y range.
|
|
|
|
* Brightness is applied second and is used to remove the
|
|
|
|
* offset from Y. Saturation/hue is used to expand CbCr range.
|
|
|
|
*/
|
|
|
|
contrast = DIV_ROUND_CLOSEST(255 << 6, 235 - 16);
|
|
|
|
brightness = -DIV_ROUND_CLOSEST(16 * 255, 235 - 16);
|
|
|
|
sh_scale = DIV_ROUND_CLOSEST(128 << 7, 240 - 128);
|
|
|
|
sh_sin = SIN_0 * sh_scale;
|
|
|
|
sh_cos = COS_0 * sh_scale;
|
|
|
|
} else {
|
|
|
|
/* Pass-through everything. */
|
|
|
|
contrast = 1 << 6;
|
|
|
|
brightness = 0;
|
|
|
|
sh_scale = 1 << 7;
|
|
|
|
sh_sin = SIN_0 * sh_scale;
|
|
|
|
sh_cos = COS_0 * sh_scale;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* FIXME these register are single buffered :( */
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPCLRC0(pipe, plane_id),
|
|
|
|
SP_CONTRAST(contrast) | SP_BRIGHTNESS(brightness));
|
|
|
|
intel_de_write_fw(dev_priv, SPCLRC1(pipe, plane_id),
|
|
|
|
SP_SH_SIN(sh_sin) | SP_SH_COS(sh_cos));
|
drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
Turns out the VLV/CHV fixed function sprite CSC expects full range
data as input. We've been feeding it limited range data to it all
along. To expand the data out to full range we'll use the color
correction registers (brightness, contrast, and saturation).
On CHV pipe B we were actually doing the right thing already because we
progammed the custom CSC matrix to do expect limited range input. Now
that well pre-expand the data out with the color correction unit, we
need to change the CSC matrix to operate with full range input instead.
This should make the sprite output of the other pipes match the sprite
output of pipe B reasonably well. Looking at the resulting pipe CRCs,
there can be a slight difference in the output, but as I don't know
the formula used by the fixed function CSC of the other pipes, I don't
think it's worth the effort to try to match the output exactly. It
might not even be possible due to difference in internal precision etc.
One slight caveat here is that the color correction registers are single
bufferred, so we should really be updating them during vblank, but we
still don't have a mechanism for that, so just toss in another FIXME.
v2: Rebase
v3: s/bri/brightness/ s/con/contrast/ (Shashank)
v4: Clarify the constants and math (Shashank)
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: "Tang, Jun" <jun.tang@intel.com>
Reported-by: "Tang, Jun" <jun.tang@intel.com>
Cc: stable@vger.kernel.org
Fixes: 7f1f3851feb0 ("drm/i915: sprite support for ValleyView v4")
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180214192327.3250-5-ville.syrjala@linux.intel.com
2018-02-14 21:23:23 +02:00
|
|
|
}
|
|
|
|
|
2019-10-15 22:30:26 +03:00
|
|
|
static void
|
|
|
|
vlv_plane_ratio(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state,
|
|
|
|
unsigned int *num, unsigned int *den)
|
|
|
|
{
|
|
|
|
u8 active_planes = crtc_state->active_planes & ~BIT(PLANE_CURSOR);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-15 22:30:26 +03:00
|
|
|
unsigned int cpp = fb->format->cpp[0];
|
|
|
|
|
|
|
|
/*
|
|
|
|
* VLV bspec only considers cases where all three planes are
|
|
|
|
* enabled, and cases where the primary and one sprite is enabled.
|
|
|
|
* Let's assume the case with just two sprites enabled also
|
|
|
|
* maps to the latter case.
|
|
|
|
*/
|
|
|
|
if (hweight8(active_planes) == 3) {
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 11;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
case 4:
|
|
|
|
*num = 18;
|
|
|
|
*den = 16;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else if (hweight8(active_planes) == 2) {
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 10;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
case 4:
|
|
|
|
*num = 17;
|
|
|
|
*den = 16;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 10;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
int vlv_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
|
|
|
unsigned int pixel_rate;
|
|
|
|
unsigned int num, den;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Note that crtc_state->pixel_rate accounts for both
|
|
|
|
* horizontal and vertical panel fitter downscaling factors.
|
|
|
|
* Pre-HSW bspec tells us to only consider the horizontal
|
|
|
|
* downscaling factor here. We ignore that and just consider
|
|
|
|
* both for simplicity.
|
|
|
|
*/
|
|
|
|
pixel_rate = crtc_state->pixel_rate;
|
|
|
|
|
|
|
|
vlv_plane_ratio(crtc_state, plane_state, &num, &den);
|
|
|
|
|
|
|
|
return DIV_ROUND_UP(pixel_rate * num, den);
|
|
|
|
}
|
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
static u32 vlv_sprite_ctl_crtc(const struct intel_crtc_state *crtc_state)
|
|
|
|
{
|
2019-02-07 22:39:13 +02:00
|
|
|
u32 sprctl = 0;
|
|
|
|
|
|
|
|
if (crtc_state->gamma_enable)
|
|
|
|
sprctl |= SP_GAMMA_ENABLE;
|
|
|
|
|
|
|
|
return sprctl;
|
2019-02-05 18:08:36 +02:00
|
|
|
}
|
|
|
|
|
2017-03-17 23:17:58 +02:00
|
|
|
static u32 vlv_sprite_ctl(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
2013-04-02 11:22:20 -07:00
|
|
|
{
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
|
|
|
unsigned int rotation = plane_state->hw.rotation;
|
2016-01-07 11:54:06 +01:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2017-03-17 23:17:58 +02:00
|
|
|
u32 sprctl;
|
2013-04-02 11:22:20 -07:00
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
sprctl = SP_ENABLE;
|
2013-04-02 11:22:20 -07:00
|
|
|
|
2016-12-14 23:32:55 +02:00
|
|
|
switch (fb->format->format) {
|
2013-04-02 11:22:20 -07:00
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YUYV;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YVYU;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_UYVY;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_VYUY;
|
|
|
|
break;
|
2019-10-31 18:56:49 +02:00
|
|
|
case DRM_FORMAT_C8:
|
|
|
|
sprctl |= SP_FORMAT_8BPP;
|
|
|
|
break;
|
2013-04-02 11:22:20 -07:00
|
|
|
case DRM_FORMAT_RGB565:
|
|
|
|
sprctl |= SP_FORMAT_BGR565;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
|
|
|
sprctl |= SP_FORMAT_BGRX8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_ARGB8888:
|
|
|
|
sprctl |= SP_FORMAT_BGRA8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XBGR2101010:
|
|
|
|
sprctl |= SP_FORMAT_RGBX1010102;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_ABGR2101010:
|
|
|
|
sprctl |= SP_FORMAT_RGBA1010102;
|
|
|
|
break;
|
2019-10-31 18:56:48 +02:00
|
|
|
case DRM_FORMAT_XRGB2101010:
|
|
|
|
sprctl |= SP_FORMAT_BGRX1010102;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_ARGB2101010:
|
|
|
|
sprctl |= SP_FORMAT_BGRA1010102;
|
|
|
|
break;
|
2013-04-02 11:22:20 -07:00
|
|
|
case DRM_FORMAT_XBGR8888:
|
|
|
|
sprctl |= SP_FORMAT_RGBX8888;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_ABGR8888:
|
|
|
|
sprctl |= SP_FORMAT_RGBA8888;
|
|
|
|
break;
|
|
|
|
default:
|
2017-03-17 23:17:58 +02:00
|
|
|
MISSING_CASE(fb->format->format);
|
|
|
|
return 0;
|
2013-04-02 11:22:20 -07:00
|
|
|
}
|
|
|
|
|
2019-10-31 12:26:07 +01:00
|
|
|
if (plane_state->hw.color_encoding == DRM_COLOR_YCBCR_BT709)
|
2018-02-14 21:23:25 +02:00
|
|
|
sprctl |= SP_YUV_FORMAT_BT709;
|
|
|
|
|
2016-11-16 13:33:16 +02:00
|
|
|
if (fb->modifier == I915_FORMAT_MOD_X_TILED)
|
2013-04-02 11:22:20 -07:00
|
|
|
sprctl |= SP_TILED;
|
|
|
|
|
2017-05-19 16:50:17 -04:00
|
|
|
if (rotation & DRM_MODE_ROTATE_180)
|
2016-11-14 18:53:59 +02:00
|
|
|
sprctl |= SP_ROTATE_180;
|
|
|
|
|
2017-05-19 16:50:17 -04:00
|
|
|
if (rotation & DRM_MODE_REFLECT_X)
|
2016-11-14 18:54:00 +02:00
|
|
|
sprctl |= SP_MIRROR;
|
|
|
|
|
2017-03-09 17:44:32 +02:00
|
|
|
if (key->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
sprctl |= SP_SOURCE_KEY;
|
|
|
|
|
2017-03-17 23:17:58 +02:00
|
|
|
return sprctl;
|
|
|
|
}
|
|
|
|
|
2019-07-03 23:08:21 +03:00
|
|
|
static void vlv_update_gamma(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2019-07-03 23:08:21 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-07-03 23:08:21 +03:00
|
|
|
enum pipe pipe = plane->pipe;
|
|
|
|
enum plane_id plane_id = plane->id;
|
|
|
|
u16 gamma[8];
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Seems RGB data bypasses the gamma always */
|
|
|
|
if (!fb->format->is_yuv)
|
|
|
|
return;
|
|
|
|
|
|
|
|
i9xx_plane_linear_gamma(gamma);
|
|
|
|
|
|
|
|
/* FIXME these register are single buffered :( */
|
|
|
|
/* The two end points are implicit (0.0 and 1.0) */
|
|
|
|
for (i = 1; i < 8 - 1; i++)
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPGAMC(pipe, plane_id, i - 1),
|
|
|
|
gamma[i] << 16 | gamma[i] << 8 | gamma[i]);
|
2019-07-03 23:08:21 +03:00
|
|
|
}
|
|
|
|
|
2017-03-17 23:17:58 +02:00
|
|
|
static void
|
2017-03-27 21:55:33 +03:00
|
|
|
vlv_update_plane(struct intel_plane *plane,
|
2017-03-17 23:17:58 +02:00
|
|
|
const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2017-03-27 21:55:33 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum pipe pipe = plane->pipe;
|
|
|
|
enum plane_id plane_id = plane->id;
|
2018-09-07 18:24:04 +03:00
|
|
|
u32 sprsurf_offset = plane_state->color_plane[0].offset;
|
2017-03-23 21:27:12 +02:00
|
|
|
u32 linear_offset;
|
2017-03-17 23:17:58 +02:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2019-10-31 12:26:08 +01:00
|
|
|
int crtc_x = plane_state->uapi.dst.x1;
|
|
|
|
int crtc_y = plane_state->uapi.dst.y1;
|
|
|
|
u32 crtc_w = drm_rect_width(&plane_state->uapi.dst);
|
|
|
|
u32 crtc_h = drm_rect_height(&plane_state->uapi.dst);
|
2019-01-16 11:15:28 +02:00
|
|
|
u32 x = plane_state->color_plane[0].x;
|
|
|
|
u32 y = plane_state->color_plane[0].y;
|
2017-03-17 23:17:58 +02:00
|
|
|
unsigned long irqflags;
|
2019-02-05 18:08:36 +02:00
|
|
|
u32 sprctl;
|
|
|
|
|
|
|
|
sprctl = plane_state->ctl | vlv_sprite_ctl_crtc(crtc_state);
|
2017-03-17 23:17:58 +02:00
|
|
|
|
2013-04-02 11:22:20 -07:00
|
|
|
/* Sizes are 0 based */
|
|
|
|
crtc_w--;
|
|
|
|
crtc_h--;
|
|
|
|
|
2016-01-20 18:02:50 +02:00
|
|
|
linear_offset = intel_fb_xy_to_linear(x, y, plane_state, 0);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 13:16:41 +03:00
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPSTRIDE(pipe, plane_id),
|
|
|
|
plane_state->color_plane[0].stride);
|
|
|
|
intel_de_write_fw(dev_priv, SPPOS(pipe, plane_id),
|
|
|
|
(crtc_y << 16) | crtc_x);
|
|
|
|
intel_de_write_fw(dev_priv, SPSIZE(pipe, plane_id),
|
|
|
|
(crtc_h << 16) | crtc_w);
|
|
|
|
intel_de_write_fw(dev_priv, SPCONSTALPHA(pipe, plane_id), 0);
|
2018-11-14 23:07:17 +02:00
|
|
|
|
2017-03-09 17:44:32 +02:00
|
|
|
if (IS_CHERRYVIEW(dev_priv) && pipe == PIPE_B)
|
drm/i915: Correctly handle limited range YCbCr data on VLV/CHV
Turns out the VLV/CHV fixed function sprite CSC expects full range
data as input. We've been feeding it limited range data to it all
along. To expand the data out to full range we'll use the color
correction registers (brightness, contrast, and saturation).
On CHV pipe B we were actually doing the right thing already because we
progammed the custom CSC matrix to do expect limited range input. Now
that well pre-expand the data out with the color correction unit, we
need to change the CSC matrix to operate with full range input instead.
This should make the sprite output of the other pipes match the sprite
output of pipe B reasonably well. Looking at the resulting pipe CRCs,
there can be a slight difference in the output, but as I don't know
the formula used by the fixed function CSC of the other pipes, I don't
think it's worth the effort to try to match the output exactly. It
might not even be possible due to difference in internal precision etc.
One slight caveat here is that the color correction registers are single
bufferred, so we should really be updating them during vblank, but we
still don't have a mechanism for that, so just toss in another FIXME.
v2: Rebase
v3: s/bri/brightness/ s/con/contrast/ (Shashank)
v4: Clarify the constants and math (Shashank)
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: "Tang, Jun" <jun.tang@intel.com>
Reported-by: "Tang, Jun" <jun.tang@intel.com>
Cc: stable@vger.kernel.org
Fixes: 7f1f3851feb0 ("drm/i915: sprite support for ValleyView v4")
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180214192327.3250-5-ville.syrjala@linux.intel.com
2018-02-14 21:23:23 +02:00
|
|
|
chv_update_csc(plane_state);
|
2017-03-09 17:44:32 +02:00
|
|
|
|
2015-03-19 21:18:57 +02:00
|
|
|
if (key->flags) {
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPKEYMINVAL(pipe, plane_id),
|
|
|
|
key->min_value);
|
|
|
|
intel_de_write_fw(dev_priv, SPKEYMSK(pipe, plane_id),
|
|
|
|
key->channel_mask);
|
|
|
|
intel_de_write_fw(dev_priv, SPKEYMAXVAL(pipe, plane_id),
|
|
|
|
key->max_value);
|
2015-03-19 21:18:57 +02:00
|
|
|
}
|
2014-01-17 20:09:03 +02:00
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPLINOFF(pipe, plane_id), linear_offset);
|
|
|
|
intel_de_write_fw(dev_priv, SPTILEOFF(pipe, plane_id), (y << 16) | x);
|
2013-04-02 11:22:20 -07:00
|
|
|
|
2018-11-14 23:07:17 +02:00
|
|
|
/*
|
|
|
|
* The control register self-arms if the plane was previously
|
|
|
|
* disabled. Try to make the plane enable atomic by writing
|
|
|
|
* the control register just before the surface register.
|
|
|
|
*/
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPCNTR(pipe, plane_id), sprctl);
|
|
|
|
intel_de_write_fw(dev_priv, SPSURF(pipe, plane_id),
|
|
|
|
intel_plane_ggtt_offset(plane_state) + sprsurf_offset);
|
2017-03-09 17:44:33 +02:00
|
|
|
|
2018-11-14 23:07:18 +02:00
|
|
|
vlv_update_clrc(plane_state);
|
2019-07-03 23:08:21 +03:00
|
|
|
vlv_update_gamma(plane_state);
|
2018-11-14 23:07:18 +02:00
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
|
2013-04-02 11:22:20 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2018-11-14 23:07:20 +02:00
|
|
|
vlv_disable_plane(struct intel_plane *plane,
|
|
|
|
const struct intel_crtc_state *crtc_state)
|
2013-04-02 11:22:20 -07:00
|
|
|
{
|
2017-03-27 21:55:33 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum pipe pipe = plane->pipe;
|
|
|
|
enum plane_id plane_id = plane->id;
|
2017-03-09 17:44:33 +02:00
|
|
|
unsigned long irqflags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
|
2013-04-02 11:22:20 -07:00
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPCNTR(pipe, plane_id), 0);
|
|
|
|
intel_de_write_fw(dev_priv, SPSURF(pipe, plane_id), 0);
|
2017-03-09 17:44:33 +02:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
|
2013-04-02 11:22:20 -07:00
|
|
|
}
|
|
|
|
|
2017-11-17 21:19:08 +02:00
|
|
|
static bool
|
2018-01-30 22:38:03 +02:00
|
|
|
vlv_plane_get_hw_state(struct intel_plane *plane,
|
|
|
|
enum pipe *pipe)
|
2017-11-17 21:19:08 +02:00
|
|
|
{
|
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum intel_display_power_domain power_domain;
|
|
|
|
enum plane_id plane_id = plane->id;
|
2019-01-14 14:21:24 +00:00
|
|
|
intel_wakeref_t wakeref;
|
2017-11-17 21:19:08 +02:00
|
|
|
bool ret;
|
|
|
|
|
2018-01-30 22:38:03 +02:00
|
|
|
power_domain = POWER_DOMAIN_PIPE(plane->pipe);
|
2019-01-14 14:21:24 +00:00
|
|
|
wakeref = intel_display_power_get_if_enabled(dev_priv, power_domain);
|
|
|
|
if (!wakeref)
|
2017-11-17 21:19:08 +02:00
|
|
|
return false;
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
ret = intel_de_read(dev_priv, SPCNTR(plane->pipe, plane_id)) & SP_ENABLE;
|
2018-01-30 22:38:03 +02:00
|
|
|
|
|
|
|
*pipe = plane->pipe;
|
2017-11-17 21:19:08 +02:00
|
|
|
|
2019-01-14 14:21:24 +00:00
|
|
|
intel_display_power_put(dev_priv, power_domain, wakeref);
|
2017-11-17 21:19:08 +02:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-10-15 22:30:26 +03:00
|
|
|
static void ivb_plane_ratio(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state,
|
|
|
|
unsigned int *num, unsigned int *den)
|
|
|
|
{
|
|
|
|
u8 active_planes = crtc_state->active_planes & ~BIT(PLANE_CURSOR);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-15 22:30:26 +03:00
|
|
|
unsigned int cpp = fb->format->cpp[0];
|
|
|
|
|
|
|
|
if (hweight8(active_planes) == 2) {
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 10;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
case 4:
|
|
|
|
*num = 17;
|
|
|
|
*den = 16;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 9;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void ivb_plane_ratio_scaling(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state,
|
|
|
|
unsigned int *num, unsigned int *den)
|
|
|
|
{
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-15 22:30:26 +03:00
|
|
|
unsigned int cpp = fb->format->cpp[0];
|
|
|
|
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 12;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
case 4:
|
|
|
|
*num = 19;
|
|
|
|
*den = 16;
|
|
|
|
break;
|
|
|
|
case 2:
|
|
|
|
*num = 33;
|
|
|
|
*den = 32;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
int ivb_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
|
|
|
unsigned int pixel_rate;
|
|
|
|
unsigned int num, den;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Note that crtc_state->pixel_rate accounts for both
|
|
|
|
* horizontal and vertical panel fitter downscaling factors.
|
|
|
|
* Pre-HSW bspec tells us to only consider the horizontal
|
|
|
|
* downscaling factor here. We ignore that and just consider
|
|
|
|
* both for simplicity.
|
|
|
|
*/
|
|
|
|
pixel_rate = crtc_state->pixel_rate;
|
|
|
|
|
|
|
|
ivb_plane_ratio(crtc_state, plane_state, &num, &den);
|
|
|
|
|
|
|
|
return DIV_ROUND_UP(pixel_rate * num, den);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ivb_sprite_min_cdclk(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
|
|
|
unsigned int src_w, dst_w, pixel_rate;
|
|
|
|
unsigned int num, den;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Note that crtc_state->pixel_rate accounts for both
|
|
|
|
* horizontal and vertical panel fitter downscaling factors.
|
|
|
|
* Pre-HSW bspec tells us to only consider the horizontal
|
|
|
|
* downscaling factor here. We ignore that and just consider
|
|
|
|
* both for simplicity.
|
|
|
|
*/
|
|
|
|
pixel_rate = crtc_state->pixel_rate;
|
|
|
|
|
2019-10-31 12:26:08 +01:00
|
|
|
src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
|
|
|
|
dst_w = drm_rect_width(&plane_state->uapi.dst);
|
2019-10-15 22:30:26 +03:00
|
|
|
|
|
|
|
if (src_w != dst_w)
|
|
|
|
ivb_plane_ratio_scaling(crtc_state, plane_state, &num, &den);
|
|
|
|
else
|
|
|
|
ivb_plane_ratio(crtc_state, plane_state, &num, &den);
|
|
|
|
|
|
|
|
/* Horizontal downscaling limits the maximum pixel rate */
|
|
|
|
dst_w = min(src_w, dst_w);
|
|
|
|
|
|
|
|
return DIV_ROUND_UP_ULL(mul_u32_u32(pixel_rate, num * src_w),
|
|
|
|
den * dst_w);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void hsw_plane_ratio(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state,
|
|
|
|
unsigned int *num, unsigned int *den)
|
|
|
|
{
|
|
|
|
u8 active_planes = crtc_state->active_planes & ~BIT(PLANE_CURSOR);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-15 22:30:26 +03:00
|
|
|
unsigned int cpp = fb->format->cpp[0];
|
|
|
|
|
|
|
|
if (hweight8(active_planes) == 2) {
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 10;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
switch (cpp) {
|
|
|
|
case 8:
|
|
|
|
*num = 9;
|
|
|
|
*den = 8;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
*num = 1;
|
|
|
|
*den = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
int hsw_plane_min_cdclk(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
|
|
|
unsigned int pixel_rate = crtc_state->pixel_rate;
|
|
|
|
unsigned int num, den;
|
|
|
|
|
|
|
|
hsw_plane_ratio(crtc_state, plane_state, &num, &den);
|
|
|
|
|
|
|
|
return DIV_ROUND_UP(pixel_rate * num, den);
|
|
|
|
}
|
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
static u32 ivb_sprite_ctl_crtc(const struct intel_crtc_state *crtc_state)
|
|
|
|
{
|
|
|
|
u32 sprctl = 0;
|
|
|
|
|
2019-02-07 22:39:13 +02:00
|
|
|
if (crtc_state->gamma_enable)
|
|
|
|
sprctl |= SPRITE_GAMMA_ENABLE;
|
2019-02-05 18:08:36 +02:00
|
|
|
|
2019-02-07 22:21:42 +02:00
|
|
|
if (crtc_state->csc_enable)
|
2019-02-05 18:08:36 +02:00
|
|
|
sprctl |= SPRITE_PIPE_CSC_ENABLE;
|
|
|
|
|
|
|
|
return sprctl;
|
|
|
|
}
|
|
|
|
|
2019-10-15 22:30:31 +03:00
|
|
|
static bool ivb_need_sprite_gamma(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
|
|
|
struct drm_i915_private *dev_priv =
|
2019-10-31 12:26:08 +01:00
|
|
|
to_i915(plane_state->uapi.plane->dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-15 22:30:31 +03:00
|
|
|
|
|
|
|
return fb->format->cpp[0] == 8 &&
|
|
|
|
(IS_IVYBRIDGE(dev_priv) || IS_HASWELL(dev_priv));
|
|
|
|
}
|
|
|
|
|
2017-03-17 23:17:59 +02:00
|
|
|
static u32 ivb_sprite_ctl(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
2011-12-13 13:19:38 -08:00
|
|
|
{
|
2017-03-17 23:17:59 +02:00
|
|
|
struct drm_i915_private *dev_priv =
|
2019-10-31 12:26:08 +01:00
|
|
|
to_i915(plane_state->uapi.plane->dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
|
|
|
unsigned int rotation = plane_state->hw.rotation;
|
2016-01-07 11:54:06 +01:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2017-03-17 23:17:59 +02:00
|
|
|
u32 sprctl;
|
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
sprctl = SPRITE_ENABLE;
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2017-03-17 23:17:59 +02:00
|
|
|
if (IS_IVYBRIDGE(dev_priv))
|
|
|
|
sprctl |= SPRITE_TRICKLE_FEED_DISABLE;
|
|
|
|
|
2016-12-14 23:32:55 +02:00
|
|
|
switch (fb->format->format) {
|
2011-12-13 13:19:38 -08:00
|
|
|
case DRM_FORMAT_XBGR8888:
|
2012-08-23 12:08:57 +05:30
|
|
|
sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
|
2011-12-13 13:19:38 -08:00
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
2012-08-23 12:08:57 +05:30
|
|
|
sprctl |= SPRITE_FORMAT_RGBX888;
|
2011-12-13 13:19:38 -08:00
|
|
|
break;
|
2019-10-31 18:56:46 +02:00
|
|
|
case DRM_FORMAT_XBGR2101010:
|
|
|
|
sprctl |= SPRITE_FORMAT_RGBX101010 | SPRITE_RGB_ORDER_RGBX;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB2101010:
|
|
|
|
sprctl |= SPRITE_FORMAT_RGBX101010;
|
|
|
|
break;
|
2019-10-15 22:30:31 +03:00
|
|
|
case DRM_FORMAT_XBGR16161616F:
|
|
|
|
sprctl |= SPRITE_FORMAT_RGBX161616 | SPRITE_RGB_ORDER_RGBX;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB16161616F:
|
|
|
|
sprctl |= SPRITE_FORMAT_RGBX161616;
|
|
|
|
break;
|
2011-12-13 13:19:38 -08:00
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
|
|
|
|
break;
|
|
|
|
default:
|
2017-03-17 23:17:59 +02:00
|
|
|
MISSING_CASE(fb->format->format);
|
|
|
|
return 0;
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|
|
|
|
|
2019-10-15 22:30:31 +03:00
|
|
|
if (!ivb_need_sprite_gamma(plane_state))
|
|
|
|
sprctl |= SPRITE_INT_GAMMA_DISABLE;
|
2019-07-03 23:08:20 +03:00
|
|
|
|
2019-10-31 12:26:07 +01:00
|
|
|
if (plane_state->hw.color_encoding == DRM_COLOR_YCBCR_BT709)
|
2018-02-14 21:23:25 +02:00
|
|
|
sprctl |= SPRITE_YUV_TO_RGB_CSC_FORMAT_BT709;
|
|
|
|
|
2019-10-31 12:26:07 +01:00
|
|
|
if (plane_state->hw.color_range == DRM_COLOR_YCBCR_FULL_RANGE)
|
2018-02-14 21:23:27 +02:00
|
|
|
sprctl |= SPRITE_YUV_RANGE_CORRECTION_DISABLE;
|
|
|
|
|
2016-11-16 13:33:16 +02:00
|
|
|
if (fb->modifier == I915_FORMAT_MOD_X_TILED)
|
2011-12-13 13:19:38 -08:00
|
|
|
sprctl |= SPRITE_TILED;
|
|
|
|
|
2017-05-19 16:50:17 -04:00
|
|
|
if (rotation & DRM_MODE_ROTATE_180)
|
2016-11-14 18:53:59 +02:00
|
|
|
sprctl |= SPRITE_ROTATE_180;
|
|
|
|
|
2017-03-09 17:44:32 +02:00
|
|
|
if (key->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
sprctl |= SPRITE_DEST_KEY;
|
|
|
|
else if (key->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
sprctl |= SPRITE_SOURCE_KEY;
|
|
|
|
|
2017-03-17 23:17:59 +02:00
|
|
|
return sprctl;
|
|
|
|
}
|
|
|
|
|
2019-10-15 22:30:31 +03:00
|
|
|
static void ivb_sprite_linear_gamma(const struct intel_plane_state *plane_state,
|
|
|
|
u16 gamma[18])
|
2019-07-03 23:08:21 +03:00
|
|
|
{
|
2019-10-15 22:30:31 +03:00
|
|
|
int scale, i;
|
2019-07-03 23:08:21 +03:00
|
|
|
|
2019-10-15 22:30:31 +03:00
|
|
|
/*
|
|
|
|
* WaFP16GammaEnabling:ivb,hsw
|
|
|
|
* "Workaround : When using the 64-bit format, the sprite output
|
|
|
|
* on each color channel has one quarter amplitude. It can be
|
|
|
|
* brought up to full amplitude by using sprite internal gamma
|
|
|
|
* correction, pipe gamma correction, or pipe color space
|
|
|
|
* conversion to multiply the sprite output by four."
|
|
|
|
*/
|
|
|
|
scale = 4;
|
|
|
|
|
|
|
|
for (i = 0; i < 16; i++)
|
|
|
|
gamma[i] = min((scale * i << 10) / 16, (1 << 10) - 1);
|
|
|
|
|
|
|
|
gamma[i] = min((scale * i << 10) / 16, 1 << 10);
|
|
|
|
i++;
|
2019-07-03 23:08:21 +03:00
|
|
|
|
|
|
|
gamma[i] = 3 << 10;
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void ivb_update_gamma(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2019-07-03 23:08:21 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum pipe pipe = plane->pipe;
|
|
|
|
u16 gamma[18];
|
|
|
|
int i;
|
|
|
|
|
2019-10-15 22:30:31 +03:00
|
|
|
if (!ivb_need_sprite_gamma(plane_state))
|
|
|
|
return;
|
|
|
|
|
|
|
|
ivb_sprite_linear_gamma(plane_state, gamma);
|
2019-07-03 23:08:21 +03:00
|
|
|
|
|
|
|
/* FIXME these register are single buffered :( */
|
|
|
|
for (i = 0; i < 16; i++)
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRGAMC(pipe, i),
|
|
|
|
gamma[i] << 20 | gamma[i] << 10 | gamma[i]);
|
|
|
|
|
|
|
|
intel_de_write_fw(dev_priv, SPRGAMC16(pipe, 0), gamma[i]);
|
|
|
|
intel_de_write_fw(dev_priv, SPRGAMC16(pipe, 1), gamma[i]);
|
|
|
|
intel_de_write_fw(dev_priv, SPRGAMC16(pipe, 2), gamma[i]);
|
2019-07-03 23:08:21 +03:00
|
|
|
i++;
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRGAMC17(pipe, 0), gamma[i]);
|
|
|
|
intel_de_write_fw(dev_priv, SPRGAMC17(pipe, 1), gamma[i]);
|
|
|
|
intel_de_write_fw(dev_priv, SPRGAMC17(pipe, 2), gamma[i]);
|
2019-07-03 23:08:21 +03:00
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
2017-03-17 23:17:59 +02:00
|
|
|
static void
|
2017-03-27 21:55:33 +03:00
|
|
|
ivb_update_plane(struct intel_plane *plane,
|
2017-03-17 23:17:59 +02:00
|
|
|
const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2017-03-27 21:55:33 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum pipe pipe = plane->pipe;
|
2018-09-07 18:24:04 +03:00
|
|
|
u32 sprsurf_offset = plane_state->color_plane[0].offset;
|
2017-03-23 21:27:12 +02:00
|
|
|
u32 linear_offset;
|
2017-03-17 23:17:59 +02:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2019-10-31 12:26:08 +01:00
|
|
|
int crtc_x = plane_state->uapi.dst.x1;
|
|
|
|
int crtc_y = plane_state->uapi.dst.y1;
|
|
|
|
u32 crtc_w = drm_rect_width(&plane_state->uapi.dst);
|
|
|
|
u32 crtc_h = drm_rect_height(&plane_state->uapi.dst);
|
2019-01-16 11:15:28 +02:00
|
|
|
u32 x = plane_state->color_plane[0].x;
|
|
|
|
u32 y = plane_state->color_plane[0].y;
|
2019-10-31 12:26:08 +01:00
|
|
|
u32 src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
|
|
|
|
u32 src_h = drm_rect_height(&plane_state->uapi.src) >> 16;
|
2019-02-05 18:08:36 +02:00
|
|
|
u32 sprctl, sprscale = 0;
|
2017-03-17 23:17:59 +02:00
|
|
|
unsigned long irqflags;
|
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
sprctl = plane_state->ctl | ivb_sprite_ctl_crtc(crtc_state);
|
|
|
|
|
2011-12-13 13:19:38 -08:00
|
|
|
/* Sizes are 0 based */
|
|
|
|
src_w--;
|
|
|
|
src_h--;
|
|
|
|
crtc_w--;
|
|
|
|
crtc_h--;
|
|
|
|
|
2013-12-05 15:51:39 +02:00
|
|
|
if (crtc_w != src_w || crtc_h != src_h)
|
2011-12-13 13:19:38 -08:00
|
|
|
sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;
|
|
|
|
|
2016-01-20 18:02:50 +02:00
|
|
|
linear_offset = intel_fb_xy_to_linear(x, y, plane_state, 0);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 13:16:41 +03:00
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRSTRIDE(pipe),
|
|
|
|
plane_state->color_plane[0].stride);
|
|
|
|
intel_de_write_fw(dev_priv, SPRPOS(pipe), (crtc_y << 16) | crtc_x);
|
|
|
|
intel_de_write_fw(dev_priv, SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
|
2018-11-14 23:07:17 +02:00
|
|
|
if (IS_IVYBRIDGE(dev_priv))
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRSCALE(pipe), sprscale);
|
2018-11-14 23:07:17 +02:00
|
|
|
|
2015-03-19 21:18:57 +02:00
|
|
|
if (key->flags) {
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRKEYVAL(pipe), key->min_value);
|
|
|
|
intel_de_write_fw(dev_priv, SPRKEYMSK(pipe),
|
|
|
|
key->channel_mask);
|
|
|
|
intel_de_write_fw(dev_priv, SPRKEYMAX(pipe), key->max_value);
|
2015-03-19 21:18:57 +02:00
|
|
|
}
|
|
|
|
|
2012-10-26 18:20:12 +01:00
|
|
|
/* HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET
|
|
|
|
* register */
|
2018-11-08 17:09:55 +02:00
|
|
|
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) {
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPROFFSET(pipe), (y << 16) | x);
|
2018-11-08 17:09:55 +02:00
|
|
|
} else {
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRLINOFF(pipe), linear_offset);
|
|
|
|
intel_de_write_fw(dev_priv, SPRTILEOFF(pipe), (y << 16) | x);
|
2018-11-08 17:09:55 +02:00
|
|
|
}
|
2012-10-26 18:20:11 +01:00
|
|
|
|
2018-11-14 23:07:17 +02:00
|
|
|
/*
|
|
|
|
* The control register self-arms if the plane was previously
|
|
|
|
* disabled. Try to make the plane enable atomic by writing
|
|
|
|
* the control register just before the surface register.
|
|
|
|
*/
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRCTL(pipe), sprctl);
|
|
|
|
intel_de_write_fw(dev_priv, SPRSURF(pipe),
|
|
|
|
intel_plane_ggtt_offset(plane_state) + sprsurf_offset);
|
2017-03-09 17:44:33 +02:00
|
|
|
|
2019-07-03 23:08:21 +03:00
|
|
|
ivb_update_gamma(plane_state);
|
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2018-11-14 23:07:20 +02:00
|
|
|
ivb_disable_plane(struct intel_plane *plane,
|
|
|
|
const struct intel_crtc_state *crtc_state)
|
2011-12-13 13:19:38 -08:00
|
|
|
{
|
2017-03-27 21:55:33 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum pipe pipe = plane->pipe;
|
2017-03-09 17:44:33 +02:00
|
|
|
unsigned long irqflags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
|
2011-12-13 13:19:38 -08:00
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRCTL(pipe), 0);
|
2018-11-14 23:07:17 +02:00
|
|
|
/* Disable the scaler */
|
2018-09-07 18:24:08 +03:00
|
|
|
if (IS_IVYBRIDGE(dev_priv))
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, SPRSCALE(pipe), 0);
|
|
|
|
intel_de_write_fw(dev_priv, SPRSURF(pipe), 0);
|
2017-03-09 17:44:33 +02:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|
|
|
|
|
2017-11-17 21:19:08 +02:00
|
|
|
static bool
|
2018-01-30 22:38:03 +02:00
|
|
|
ivb_plane_get_hw_state(struct intel_plane *plane,
|
|
|
|
enum pipe *pipe)
|
2017-11-17 21:19:08 +02:00
|
|
|
{
|
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum intel_display_power_domain power_domain;
|
2019-01-14 14:21:24 +00:00
|
|
|
intel_wakeref_t wakeref;
|
2017-11-17 21:19:08 +02:00
|
|
|
bool ret;
|
|
|
|
|
2018-01-30 22:38:03 +02:00
|
|
|
power_domain = POWER_DOMAIN_PIPE(plane->pipe);
|
2019-01-14 14:21:24 +00:00
|
|
|
wakeref = intel_display_power_get_if_enabled(dev_priv, power_domain);
|
|
|
|
if (!wakeref)
|
2017-11-17 21:19:08 +02:00
|
|
|
return false;
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
ret = intel_de_read(dev_priv, SPRCTL(plane->pipe)) & SPRITE_ENABLE;
|
2018-01-30 22:38:03 +02:00
|
|
|
|
|
|
|
*pipe = plane->pipe;
|
2017-11-17 21:19:08 +02:00
|
|
|
|
2019-01-14 14:21:24 +00:00
|
|
|
intel_display_power_put(dev_priv, power_domain, wakeref);
|
2017-11-17 21:19:08 +02:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2019-10-15 22:30:26 +03:00
|
|
|
static int g4x_sprite_min_cdclk(const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-15 22:30:26 +03:00
|
|
|
unsigned int hscale, pixel_rate;
|
|
|
|
unsigned int limit, decimate;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Note that crtc_state->pixel_rate accounts for both
|
|
|
|
* horizontal and vertical panel fitter downscaling factors.
|
|
|
|
* Pre-HSW bspec tells us to only consider the horizontal
|
|
|
|
* downscaling factor here. We ignore that and just consider
|
|
|
|
* both for simplicity.
|
|
|
|
*/
|
|
|
|
pixel_rate = crtc_state->pixel_rate;
|
|
|
|
|
|
|
|
/* Horizontal downscaling limits the maximum pixel rate */
|
2019-10-31 12:26:08 +01:00
|
|
|
hscale = drm_rect_calc_hscale(&plane_state->uapi.src,
|
|
|
|
&plane_state->uapi.dst,
|
2019-10-15 22:30:26 +03:00
|
|
|
0, INT_MAX);
|
2020-02-06 22:12:03 +02:00
|
|
|
hscale = max(hscale, 0x10000u);
|
2019-10-15 22:30:26 +03:00
|
|
|
|
|
|
|
/* Decimation steps at 2x,4x,8x,16x */
|
|
|
|
decimate = ilog2(hscale >> 16);
|
|
|
|
hscale >>= decimate;
|
|
|
|
|
|
|
|
/* Starting limit is 90% of cdclk */
|
|
|
|
limit = 9;
|
|
|
|
|
|
|
|
/* -10% per decimation step */
|
|
|
|
limit -= decimate;
|
|
|
|
|
|
|
|
/* -10% for RGB */
|
2020-02-06 22:12:04 +02:00
|
|
|
if (!fb->format->is_yuv)
|
|
|
|
limit--;
|
2019-10-15 22:30:26 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We should also do -10% if sprite scaling is enabled
|
|
|
|
* on the other pipe, but we can't really check for that,
|
|
|
|
* so we ignore it.
|
|
|
|
*/
|
|
|
|
|
|
|
|
return DIV_ROUND_UP_ULL(mul_u32_u32(pixel_rate, 10 * hscale),
|
|
|
|
limit << 16);
|
|
|
|
}
|
|
|
|
|
2018-09-07 18:24:02 +03:00
|
|
|
static unsigned int
|
|
|
|
g4x_sprite_max_stride(struct intel_plane *plane,
|
|
|
|
u32 pixel_format, u64 modifier,
|
|
|
|
unsigned int rotation)
|
|
|
|
{
|
2021-01-11 18:37:02 +02:00
|
|
|
const struct drm_format_info *info = drm_format_info(pixel_format);
|
|
|
|
int cpp = info->cpp[0];
|
|
|
|
|
|
|
|
/* Limit to 4k pixels to guarantee TILEOFF.x doesn't get too big. */
|
|
|
|
if (modifier == I915_FORMAT_MOD_X_TILED)
|
|
|
|
return min(4096 * cpp, 16 * 1024);
|
|
|
|
else
|
|
|
|
return 16 * 1024;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int
|
|
|
|
hsw_sprite_max_stride(struct intel_plane *plane,
|
|
|
|
u32 pixel_format, u64 modifier,
|
|
|
|
unsigned int rotation)
|
|
|
|
{
|
|
|
|
const struct drm_format_info *info = drm_format_info(pixel_format);
|
|
|
|
int cpp = info->cpp[0];
|
|
|
|
|
|
|
|
/* Limit to 8k pixels to guarantee OFFSET.x doesn't get too big. */
|
|
|
|
return min(8192 * cpp, 16 * 1024);
|
2018-09-07 18:24:02 +03:00
|
|
|
}
|
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
static u32 g4x_sprite_ctl_crtc(const struct intel_crtc_state *crtc_state)
|
|
|
|
{
|
2019-02-07 22:39:13 +02:00
|
|
|
u32 dvscntr = 0;
|
|
|
|
|
|
|
|
if (crtc_state->gamma_enable)
|
|
|
|
dvscntr |= DVS_GAMMA_ENABLE;
|
|
|
|
|
2019-02-07 22:21:42 +02:00
|
|
|
if (crtc_state->csc_enable)
|
|
|
|
dvscntr |= DVS_PIPE_CSC_ENABLE;
|
|
|
|
|
2019-02-07 22:39:13 +02:00
|
|
|
return dvscntr;
|
2019-02-05 18:08:36 +02:00
|
|
|
}
|
|
|
|
|
2017-04-21 21:14:32 +03:00
|
|
|
static u32 g4x_sprite_ctl(const struct intel_crtc_state *crtc_state,
|
2017-03-17 23:18:00 +02:00
|
|
|
const struct intel_plane_state *plane_state)
|
2011-12-13 13:19:38 -08:00
|
|
|
{
|
2017-03-17 23:18:00 +02:00
|
|
|
struct drm_i915_private *dev_priv =
|
2019-10-31 12:26:08 +01:00
|
|
|
to_i915(plane_state->uapi.plane->dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
|
|
|
unsigned int rotation = plane_state->hw.rotation;
|
2016-01-07 11:54:06 +01:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2017-03-17 23:18:00 +02:00
|
|
|
u32 dvscntr;
|
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
dvscntr = DVS_ENABLE;
|
2011-12-13 13:19:38 -08:00
|
|
|
|
drm/i915: replace IS_GEN<N> with IS_GEN(..., N)
Define IS_GEN() similarly to our IS_GEN_RANGE(). but use gen instead of
gen_mask to do the comparison. Now callers can pass then gen as a parameter,
so we don't require one macro for each gen.
The following spatch was used to convert the users of these macros:
@@
expression e;
@@
(
- IS_GEN2(e)
+ IS_GEN(e, 2)
|
- IS_GEN3(e)
+ IS_GEN(e, 3)
|
- IS_GEN4(e)
+ IS_GEN(e, 4)
|
- IS_GEN5(e)
+ IS_GEN(e, 5)
|
- IS_GEN6(e)
+ IS_GEN(e, 6)
|
- IS_GEN7(e)
+ IS_GEN(e, 7)
|
- IS_GEN8(e)
+ IS_GEN(e, 8)
|
- IS_GEN9(e)
+ IS_GEN(e, 9)
|
- IS_GEN10(e)
+ IS_GEN(e, 10)
|
- IS_GEN11(e)
+ IS_GEN(e, 11)
)
v2: use IS_GEN rather than GT_GEN and compare to info.gen rather than
using the bitmask
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181212181044.15886-2-lucas.demarchi@intel.com
2018-12-12 10:10:43 -08:00
|
|
|
if (IS_GEN(dev_priv, 6))
|
2017-03-17 23:18:00 +02:00
|
|
|
dvscntr |= DVS_TRICKLE_FEED_DISABLE;
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2016-12-14 23:32:55 +02:00
|
|
|
switch (fb->format->format) {
|
2011-12-13 13:19:38 -08:00
|
|
|
case DRM_FORMAT_XBGR8888:
|
2012-02-27 12:40:10 -08:00
|
|
|
dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
|
2011-12-13 13:19:38 -08:00
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
2012-02-27 12:40:10 -08:00
|
|
|
dvscntr |= DVS_FORMAT_RGBX888;
|
2011-12-13 13:19:38 -08:00
|
|
|
break;
|
2019-10-31 18:56:46 +02:00
|
|
|
case DRM_FORMAT_XBGR2101010:
|
|
|
|
dvscntr |= DVS_FORMAT_RGBX101010 | DVS_RGB_ORDER_XBGR;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB2101010:
|
|
|
|
dvscntr |= DVS_FORMAT_RGBX101010;
|
|
|
|
break;
|
2019-10-15 22:30:32 +03:00
|
|
|
case DRM_FORMAT_XBGR16161616F:
|
|
|
|
dvscntr |= DVS_FORMAT_RGBX161616 | DVS_RGB_ORDER_XBGR;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_XRGB16161616F:
|
|
|
|
dvscntr |= DVS_FORMAT_RGBX161616;
|
|
|
|
break;
|
2011-12-13 13:19:38 -08:00
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
|
|
|
|
break;
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
|
|
|
|
break;
|
|
|
|
default:
|
2017-03-17 23:18:00 +02:00
|
|
|
MISSING_CASE(fb->format->format);
|
|
|
|
return 0;
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|
|
|
|
|
2019-10-31 12:26:07 +01:00
|
|
|
if (plane_state->hw.color_encoding == DRM_COLOR_YCBCR_BT709)
|
2018-02-14 21:23:25 +02:00
|
|
|
dvscntr |= DVS_YUV_FORMAT_BT709;
|
|
|
|
|
2019-10-31 12:26:07 +01:00
|
|
|
if (plane_state->hw.color_range == DRM_COLOR_YCBCR_FULL_RANGE)
|
2018-02-14 21:23:27 +02:00
|
|
|
dvscntr |= DVS_YUV_RANGE_CORRECTION_DISABLE;
|
|
|
|
|
2016-11-16 13:33:16 +02:00
|
|
|
if (fb->modifier == I915_FORMAT_MOD_X_TILED)
|
2011-12-13 13:19:38 -08:00
|
|
|
dvscntr |= DVS_TILED;
|
|
|
|
|
2017-05-19 16:50:17 -04:00
|
|
|
if (rotation & DRM_MODE_ROTATE_180)
|
2016-11-14 18:53:59 +02:00
|
|
|
dvscntr |= DVS_ROTATE_180;
|
|
|
|
|
2017-03-09 17:44:32 +02:00
|
|
|
if (key->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
dvscntr |= DVS_DEST_KEY;
|
|
|
|
else if (key->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
dvscntr |= DVS_SOURCE_KEY;
|
|
|
|
|
2017-03-17 23:18:00 +02:00
|
|
|
return dvscntr;
|
|
|
|
}
|
|
|
|
|
2019-07-03 23:08:21 +03:00
|
|
|
static void g4x_update_gamma(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2019-07-03 23:08:21 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-07-03 23:08:21 +03:00
|
|
|
enum pipe pipe = plane->pipe;
|
|
|
|
u16 gamma[8];
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Seems RGB data bypasses the gamma always */
|
|
|
|
if (!fb->format->is_yuv)
|
|
|
|
return;
|
|
|
|
|
|
|
|
i9xx_plane_linear_gamma(gamma);
|
|
|
|
|
|
|
|
/* FIXME these register are single buffered :( */
|
|
|
|
/* The two end points are implicit (0.0 and 1.0) */
|
|
|
|
for (i = 1; i < 8 - 1; i++)
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSGAMC_G4X(pipe, i - 1),
|
|
|
|
gamma[i] << 16 | gamma[i] << 8 | gamma[i]);
|
2019-07-03 23:08:21 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static void ilk_sprite_linear_gamma(u16 gamma[17])
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < 17; i++)
|
|
|
|
gamma[i] = (i << 10) / 16;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void ilk_update_gamma(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2019-07-03 23:08:21 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-07-03 23:08:21 +03:00
|
|
|
enum pipe pipe = plane->pipe;
|
|
|
|
u16 gamma[17];
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Seems RGB data bypasses the gamma always */
|
|
|
|
if (!fb->format->is_yuv)
|
|
|
|
return;
|
|
|
|
|
|
|
|
ilk_sprite_linear_gamma(gamma);
|
|
|
|
|
|
|
|
/* FIXME these register are single buffered :( */
|
|
|
|
for (i = 0; i < 16; i++)
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSGAMC_ILK(pipe, i),
|
|
|
|
gamma[i] << 20 | gamma[i] << 10 | gamma[i]);
|
|
|
|
|
|
|
|
intel_de_write_fw(dev_priv, DVSGAMCMAX_ILK(pipe, 0), gamma[i]);
|
|
|
|
intel_de_write_fw(dev_priv, DVSGAMCMAX_ILK(pipe, 1), gamma[i]);
|
|
|
|
intel_de_write_fw(dev_priv, DVSGAMCMAX_ILK(pipe, 2), gamma[i]);
|
2019-07-03 23:08:21 +03:00
|
|
|
i++;
|
|
|
|
}
|
|
|
|
|
2017-03-17 23:18:00 +02:00
|
|
|
static void
|
2017-03-27 21:55:33 +03:00
|
|
|
g4x_update_plane(struct intel_plane *plane,
|
2017-03-17 23:18:00 +02:00
|
|
|
const struct intel_crtc_state *crtc_state,
|
|
|
|
const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2017-03-27 21:55:33 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum pipe pipe = plane->pipe;
|
2018-09-07 18:24:04 +03:00
|
|
|
u32 dvssurf_offset = plane_state->color_plane[0].offset;
|
2017-03-23 21:27:12 +02:00
|
|
|
u32 linear_offset;
|
2017-03-17 23:18:00 +02:00
|
|
|
const struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2019-10-31 12:26:08 +01:00
|
|
|
int crtc_x = plane_state->uapi.dst.x1;
|
|
|
|
int crtc_y = plane_state->uapi.dst.y1;
|
|
|
|
u32 crtc_w = drm_rect_width(&plane_state->uapi.dst);
|
|
|
|
u32 crtc_h = drm_rect_height(&plane_state->uapi.dst);
|
2019-01-16 11:15:28 +02:00
|
|
|
u32 x = plane_state->color_plane[0].x;
|
|
|
|
u32 y = plane_state->color_plane[0].y;
|
2019-10-31 12:26:08 +01:00
|
|
|
u32 src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
|
|
|
|
u32 src_h = drm_rect_height(&plane_state->uapi.src) >> 16;
|
2019-02-05 18:08:36 +02:00
|
|
|
u32 dvscntr, dvsscale = 0;
|
2017-03-17 23:18:00 +02:00
|
|
|
unsigned long irqflags;
|
|
|
|
|
2019-02-05 18:08:36 +02:00
|
|
|
dvscntr = plane_state->ctl | g4x_sprite_ctl_crtc(crtc_state);
|
|
|
|
|
2011-12-13 13:19:38 -08:00
|
|
|
/* Sizes are 0 based */
|
|
|
|
src_w--;
|
|
|
|
src_h--;
|
|
|
|
crtc_w--;
|
|
|
|
crtc_h--;
|
|
|
|
|
2013-12-05 15:51:31 +02:00
|
|
|
if (crtc_w != src_w || crtc_h != src_h)
|
2011-12-13 13:19:38 -08:00
|
|
|
dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;
|
|
|
|
|
2016-01-20 18:02:50 +02:00
|
|
|
linear_offset = intel_fb_xy_to_linear(x, y, plane_state, 0);
|
drm/i915: Rewrite fb rotation GTT handling
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling easier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,height,stride in tile units,
and the page offset into the object where the plane starts. Each plane
is handled exactly the same way, no special casing for NV12 or other
formats. We then store the computed rotation_info under
intel_framebuffer so that we don't have to recompute it again.
To handle fb->offsets[] we treat them as a linear offsets and convert
them to x/y offsets from the start of the relevant GTT mapping (either
normal or rotated). We store the x/y offsets under intel_framebuffer,
and for some extra convenience we also store the rotated pitch (ie.
tile aligned plane height). So for each plane we have the normal
x/y offsets, rotated x/y offsets, and the rotated pitch. The normal
pitch is available already in fb->pitches[].
While we're gathering up all that extra information, we can also easily
compute the storage requirements for the framebuffer, so that we can
check that the object is big enough to hold it.
When it comes time to deal with the plane source coordinates, we first
rotate the clipped src coordinates to match the relevant GTT view
orientation, then add to them the fb x/y offsets. Next we compute
the aligned surface page offset, and as a result we're left with some
residual x/y offsets. Finally, if required by the hardware, we convert
the remaining x/y offsets into a linear offset.
For gen2/3 we simply skip computing the final page offset, and just
convert the src+fb x/y offsets directly into a linear offset since
that's what the hardware wants.
After this all platforms, incluing SKL+, compute these things in exactly
the same way (excluding alignemnt differences).
v2: Use BIT(DRM_ROTATE_270) instead of ROTATE_270 when rotating
plane src coordinates
Drop some spurious changes that got left behind during
development
v3: Split out more changes to prep patches (Daniel)
s/intel_fb->plane[].foo.bar/intel_fb->foo[].bar/ for brevity
Rename intel_surf_gtt_offset to intel_fb_gtt_offset
Kill the pointless 'plane' parameter from intel_fb_gtt_offset()
v4: Fix alignment vs. alignment-1 when calling
_intel_compute_tile_offset() from intel_fill_fb_info()
Pass the pitch in tiles in
stad of pixels to intel_adjust_tile_offset() from intel_fill_fb_info()
Pass the full width/height of the rotated area to
drm_rect_rotate() for clarity
Use u32 for more offsets
v5: Preserve the upper_32_bits()/lower_32_bits() handling for the
fb ggtt offset (Sivakumar)
v6: Rebase due to drm_plane_state src/dst rects
Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470821001-25272-2-git-send-email-ville.syrjala@linux.intel.com
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2015-09-15 13:16:41 +03:00
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSSTRIDE(pipe),
|
|
|
|
plane_state->color_plane[0].stride);
|
|
|
|
intel_de_write_fw(dev_priv, DVSPOS(pipe), (crtc_y << 16) | crtc_x);
|
|
|
|
intel_de_write_fw(dev_priv, DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
|
|
|
|
intel_de_write_fw(dev_priv, DVSSCALE(pipe), dvsscale);
|
2018-11-14 23:07:17 +02:00
|
|
|
|
2015-03-19 21:18:57 +02:00
|
|
|
if (key->flags) {
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSKEYVAL(pipe), key->min_value);
|
|
|
|
intel_de_write_fw(dev_priv, DVSKEYMSK(pipe),
|
|
|
|
key->channel_mask);
|
|
|
|
intel_de_write_fw(dev_priv, DVSKEYMAX(pipe), key->max_value);
|
2015-03-19 21:18:57 +02:00
|
|
|
}
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSLINOFF(pipe), linear_offset);
|
|
|
|
intel_de_write_fw(dev_priv, DVSTILEOFF(pipe), (y << 16) | x);
|
2017-03-09 17:44:33 +02:00
|
|
|
|
2018-11-14 23:07:17 +02:00
|
|
|
/*
|
|
|
|
* The control register self-arms if the plane was previously
|
|
|
|
* disabled. Try to make the plane enable atomic by writing
|
|
|
|
* the control register just before the surface register.
|
|
|
|
*/
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSCNTR(pipe), dvscntr);
|
|
|
|
intel_de_write_fw(dev_priv, DVSSURF(pipe),
|
|
|
|
intel_plane_ggtt_offset(plane_state) + dvssurf_offset);
|
2017-03-09 17:44:33 +02:00
|
|
|
|
2019-07-03 23:08:21 +03:00
|
|
|
if (IS_G4X(dev_priv))
|
|
|
|
g4x_update_gamma(plane_state);
|
|
|
|
else
|
|
|
|
ilk_update_gamma(plane_state);
|
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2018-11-14 23:07:20 +02:00
|
|
|
g4x_disable_plane(struct intel_plane *plane,
|
|
|
|
const struct intel_crtc_state *crtc_state)
|
2011-12-13 13:19:38 -08:00
|
|
|
{
|
2017-03-27 21:55:33 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum pipe pipe = plane->pipe;
|
2017-03-09 17:44:33 +02:00
|
|
|
unsigned long irqflags;
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSCNTR(pipe), 0);
|
2011-12-13 13:19:38 -08:00
|
|
|
/* Disable the scaler */
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
intel_de_write_fw(dev_priv, DVSSCALE(pipe), 0);
|
|
|
|
intel_de_write_fw(dev_priv, DVSSURF(pipe), 0);
|
2015-03-19 17:57:13 +02:00
|
|
|
|
2017-03-09 17:44:33 +02:00
|
|
|
spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags);
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|
|
|
|
|
2017-11-17 21:19:08 +02:00
|
|
|
static bool
|
2018-01-30 22:38:03 +02:00
|
|
|
g4x_plane_get_hw_state(struct intel_plane *plane,
|
|
|
|
enum pipe *pipe)
|
2017-11-17 21:19:08 +02:00
|
|
|
{
|
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
|
|
|
enum intel_display_power_domain power_domain;
|
2019-01-14 14:21:24 +00:00
|
|
|
intel_wakeref_t wakeref;
|
2017-11-17 21:19:08 +02:00
|
|
|
bool ret;
|
|
|
|
|
2018-01-30 22:38:03 +02:00
|
|
|
power_domain = POWER_DOMAIN_PIPE(plane->pipe);
|
2019-01-14 14:21:24 +00:00
|
|
|
wakeref = intel_display_power_get_if_enabled(dev_priv, power_domain);
|
|
|
|
if (!wakeref)
|
2017-11-17 21:19:08 +02:00
|
|
|
return false;
|
|
|
|
|
drm/i915/sprite: use intel_de_*() functions for register access
The implicit "dev_priv" local variable use has been a long-standing pain
point in the register access macros I915_READ(), I915_WRITE(),
POSTING_READ(), I915_READ_FW(), and I915_WRITE_FW().
Replace them with the corresponding new display engine register
accessors intel_de_read(), intel_de_write(), intel_de_posting_read(),
intel_de_read_fw(), and intel_de_write_fw().
No functional changes.
Generated using the following semantic patch:
@@
expression REG, OFFSET;
@@
- I915_READ(REG)
+ intel_de_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- POSTING_READ(REG)
+ intel_de_posting_read(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE(REG, OFFSET)
+ intel_de_write(dev_priv, REG, OFFSET)
@@
expression REG;
@@
- I915_READ_FW(REG)
+ intel_de_read_fw(dev_priv, REG)
@@
expression REG, OFFSET;
@@
- I915_WRITE_FW(REG, OFFSET)
+ intel_de_write_fw(dev_priv, REG, OFFSET)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/722f73a4529808ef7dad51c03c0a3775d8c5b052.1579871655.git.jani.nikula@intel.com
2020-01-24 15:25:49 +02:00
|
|
|
ret = intel_de_read(dev_priv, DVSCNTR(plane->pipe)) & DVS_ENABLE;
|
2018-01-30 22:38:03 +02:00
|
|
|
|
|
|
|
*pipe = plane->pipe;
|
2017-11-17 21:19:08 +02:00
|
|
|
|
2019-01-14 14:21:24 +00:00
|
|
|
intel_display_power_put(dev_priv, power_domain, wakeref);
|
2017-11-17 21:19:08 +02:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2021-02-05 16:48:38 +02:00
|
|
|
static bool g4x_fb_scalable(const struct drm_framebuffer *fb)
|
2018-10-05 15:58:11 +03:00
|
|
|
{
|
|
|
|
if (!fb)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
switch (fb->format->format) {
|
|
|
|
case DRM_FORMAT_C8:
|
2019-10-15 22:30:29 +03:00
|
|
|
case DRM_FORMAT_XRGB16161616F:
|
|
|
|
case DRM_FORMAT_ARGB16161616F:
|
|
|
|
case DRM_FORMAT_XBGR16161616F:
|
|
|
|
case DRM_FORMAT_ABGR16161616F:
|
2021-02-05 16:48:38 +02:00
|
|
|
return false;
|
2018-10-05 15:58:11 +03:00
|
|
|
default:
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-12-13 13:19:38 -08:00
|
|
|
static int
|
2018-09-07 18:24:09 +03:00
|
|
|
g4x_sprite_check_scaling(struct intel_crtc_state *crtc_state,
|
|
|
|
struct intel_plane_state *plane_state)
|
2011-12-13 13:19:38 -08:00
|
|
|
{
|
2019-10-31 12:26:07 +01:00
|
|
|
const struct drm_framebuffer *fb = plane_state->hw.fb;
|
2019-10-31 12:26:08 +01:00
|
|
|
const struct drm_rect *src = &plane_state->uapi.src;
|
|
|
|
const struct drm_rect *dst = &plane_state->uapi.dst;
|
2019-07-19 02:41:00 +00:00
|
|
|
int src_x, src_w, src_h, crtc_w, crtc_h;
|
2018-09-07 18:24:09 +03:00
|
|
|
const struct drm_display_mode *adjusted_mode =
|
2019-10-31 12:26:02 +01:00
|
|
|
&crtc_state->hw.adjusted_mode;
|
2019-09-30 21:30:45 +03:00
|
|
|
unsigned int stride = plane_state->color_plane[0].stride;
|
2018-09-07 18:24:09 +03:00
|
|
|
unsigned int cpp = fb->format->cpp[0];
|
|
|
|
unsigned int width_bytes;
|
|
|
|
int min_width, min_height;
|
|
|
|
|
|
|
|
crtc_w = drm_rect_width(dst);
|
|
|
|
crtc_h = drm_rect_height(dst);
|
|
|
|
|
|
|
|
src_x = src->x1 >> 16;
|
|
|
|
src_w = drm_rect_width(src) >> 16;
|
|
|
|
src_h = drm_rect_height(src) >> 16;
|
|
|
|
|
|
|
|
if (src_w == crtc_w && src_h == crtc_h)
|
2015-06-15 12:33:44 +02:00
|
|
|
return 0;
|
2018-09-07 18:24:09 +03:00
|
|
|
|
|
|
|
min_width = 3;
|
|
|
|
|
|
|
|
if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) {
|
|
|
|
if (src_h & 1) {
|
|
|
|
DRM_DEBUG_KMS("Source height must be even with interlaced modes\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
min_height = 6;
|
|
|
|
} else {
|
|
|
|
min_height = 3;
|
2014-12-04 10:27:42 -08:00
|
|
|
}
|
2013-03-26 09:25:43 -07:00
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
width_bytes = ((src_x * cpp) & 63) + src_w * cpp;
|
|
|
|
|
|
|
|
if (src_w < min_width || src_h < min_height ||
|
|
|
|
src_w > 2048 || src_h > 2048) {
|
|
|
|
DRM_DEBUG_KMS("Source dimensions (%dx%d) exceed hardware limits (%dx%d - %dx%d)\n",
|
|
|
|
src_w, src_h, min_width, min_height, 2048, 2048);
|
2011-12-13 13:19:38 -08:00
|
|
|
return -EINVAL;
|
2013-04-24 18:52:38 +03:00
|
|
|
}
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
if (width_bytes > 4096) {
|
|
|
|
DRM_DEBUG_KMS("Fetch width (%d) exceeds hardware max with scaling (%u)\n",
|
|
|
|
width_bytes, 4096);
|
2011-12-13 13:19:38 -08:00
|
|
|
return -EINVAL;
|
2013-04-24 18:52:38 +03:00
|
|
|
}
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2019-09-30 21:30:45 +03:00
|
|
|
if (stride > 4096) {
|
2018-09-07 18:24:09 +03:00
|
|
|
DRM_DEBUG_KMS("Stride (%u) exceeds hardware max with scaling (%u)\n",
|
2019-09-30 21:30:45 +03:00
|
|
|
stride, 4096);
|
2018-09-07 18:24:09 +03:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
g4x_sprite_check(struct intel_crtc_state *crtc_state,
|
|
|
|
struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2018-09-07 18:24:09 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2018-10-05 15:58:11 +03:00
|
|
|
int min_scale = DRM_PLANE_HELPER_NO_SCALING;
|
|
|
|
int max_scale = DRM_PLANE_HELPER_NO_SCALING;
|
2018-09-07 18:24:09 +03:00
|
|
|
int ret;
|
|
|
|
|
2021-02-05 16:48:38 +02:00
|
|
|
if (g4x_fb_scalable(plane_state->hw.fb)) {
|
2018-10-05 15:58:11 +03:00
|
|
|
if (INTEL_GEN(dev_priv) < 7) {
|
|
|
|
min_scale = 1;
|
|
|
|
max_scale = 16 << 16;
|
|
|
|
} else if (IS_IVYBRIDGE(dev_priv)) {
|
|
|
|
min_scale = 1;
|
|
|
|
max_scale = 2 << 16;
|
|
|
|
}
|
2015-05-18 16:18:44 -07:00
|
|
|
}
|
|
|
|
|
2020-11-17 11:47:13 -08:00
|
|
|
ret = intel_atomic_plane_check_clipping(plane_state, crtc_state,
|
|
|
|
min_scale, max_scale, true);
|
2018-05-03 13:22:15 +02:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
2012-10-22 18:19:27 +01:00
|
|
|
|
2019-05-09 15:21:56 +03:00
|
|
|
ret = i9xx_check_plane_surface(plane_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2019-10-31 12:26:08 +01:00
|
|
|
if (!plane_state->uapi.visible)
|
2018-09-07 18:24:09 +03:00
|
|
|
return 0;
|
2013-04-24 18:52:38 +03:00
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
ret = intel_plane_check_src_coordinates(plane_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2013-04-24 18:52:38 +03:00
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
ret = g4x_sprite_check_scaling(crtc_state, plane_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2013-04-24 18:52:38 +03:00
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
if (INTEL_GEN(dev_priv) >= 7)
|
|
|
|
plane_state->ctl = ivb_sprite_ctl(crtc_state, plane_state);
|
|
|
|
else
|
|
|
|
plane_state->ctl = g4x_sprite_ctl(crtc_state, plane_state);
|
2017-03-23 21:27:12 +02:00
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
return 0;
|
|
|
|
}
|
2017-03-23 21:27:12 +02:00
|
|
|
|
2018-09-07 18:24:12 +03:00
|
|
|
int chv_plane_check_rotation(const struct intel_plane_state *plane_state)
|
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2018-09-07 18:24:12 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2019-10-31 12:26:07 +01:00
|
|
|
unsigned int rotation = plane_state->hw.rotation;
|
2018-09-07 18:24:12 +03:00
|
|
|
|
|
|
|
/* CHV ignores the mirror bit when the rotate bit is set :( */
|
|
|
|
if (IS_CHERRYVIEW(dev_priv) &&
|
|
|
|
rotation & DRM_MODE_ROTATE_180 &&
|
|
|
|
rotation & DRM_MODE_REFLECT_X) {
|
drm/i915/sprite: automatic conversion to drm_device based logging macros
Conversion of most instances of the printk based logging macros to the
struct drm_device based logging macros in i915/display/intel_sprite.c
This was done automatically by the following coccinelle script that
matches based on the existence of a struct drm_i915_private device:
@@
identifier fn, T;
@@
fn(...) {
...
struct drm_i915_private *T = ...;
<+...
(
-DRM_INFO(
+drm_info(&T->drm,
...)
|
-DRM_ERROR(
+drm_err(&T->drm,
...)
|
-DRM_WARN(
+drm_warn(&T->drm,
...)
|
-DRM_DEBUG(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_KMS(
+drm_dbg_kms(&T->drm,
...)
|
-DRM_DEBUG_DRIVER(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_ATOMIC(
+drm_dbg_atomic(&T->drm,
...)
)
...+>
}
@@
identifier fn, T;
@@
fn(...,struct drm_i915_private *T,...) {
<+...
(
-DRM_INFO(
+drm_info(&T->drm,
...)
|
-DRM_ERROR(
+drm_err(&T->drm,
...)
|
-DRM_WARN(
+drm_warn(&T->drm,
...)
|
-DRM_DEBUG(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_DRIVER(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_KMS(
+drm_dbg_kms(&T->drm,
...)
|
-DRM_DEBUG_ATOMIC(
+drm_dbg_atomic(&T->drm,
...)
)
...+>
}
Checkpatch warnings were fixed manually.
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200130083229.12889-8-wambui.karugax@gmail.com
2020-01-30 11:32:24 +03:00
|
|
|
drm_dbg_kms(&dev_priv->drm,
|
|
|
|
"Cannot rotate and reflect at the same time\n");
|
2018-09-07 18:24:12 +03:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
static int
|
|
|
|
vlv_sprite_check(struct intel_crtc_state *crtc_state,
|
|
|
|
struct intel_plane_state *plane_state)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2018-09-07 18:24:12 +03:00
|
|
|
ret = chv_plane_check_rotation(plane_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2020-11-17 11:47:13 -08:00
|
|
|
ret = intel_atomic_plane_check_clipping(plane_state, crtc_state,
|
|
|
|
DRM_PLANE_HELPER_NO_SCALING,
|
|
|
|
DRM_PLANE_HELPER_NO_SCALING,
|
|
|
|
true);
|
2018-09-07 18:24:09 +03:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2019-05-09 15:21:56 +03:00
|
|
|
ret = i9xx_check_plane_surface(plane_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2019-10-31 12:26:08 +01:00
|
|
|
if (!plane_state->uapi.visible)
|
2018-09-07 18:24:09 +03:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
ret = intel_plane_check_src_coordinates(plane_state);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
plane_state->ctl = vlv_sprite_ctl(crtc_state, plane_state);
|
2017-03-23 21:27:12 +02:00
|
|
|
|
2018-09-07 18:24:09 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-02-05 16:48:36 +02:00
|
|
|
static bool has_dst_key_in_primary_plane(struct drm_i915_private *dev_priv)
|
2020-02-24 14:36:51 -08:00
|
|
|
{
|
2021-02-05 16:48:36 +02:00
|
|
|
return INTEL_GEN(dev_priv) >= 9;
|
2020-02-24 14:36:51 -08:00
|
|
|
}
|
|
|
|
|
2021-02-05 16:48:36 +02:00
|
|
|
static void intel_plane_set_ckey(struct intel_plane_state *plane_state,
|
|
|
|
const struct drm_intel_sprite_colorkey *set)
|
2018-09-07 18:24:10 +03:00
|
|
|
{
|
2019-10-31 12:26:08 +01:00
|
|
|
struct intel_plane *plane = to_intel_plane(plane_state->uapi.plane);
|
2018-08-27 15:37:53 +03:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(plane->base.dev);
|
2021-02-05 16:48:36 +02:00
|
|
|
struct drm_intel_sprite_colorkey *key = &plane_state->ckey;
|
2018-09-07 18:24:10 +03:00
|
|
|
|
2021-02-05 16:48:36 +02:00
|
|
|
*key = *set;
|
2018-05-29 21:28:00 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We want src key enabled on the
|
|
|
|
* sprite and not on the primary.
|
|
|
|
*/
|
|
|
|
if (plane->id == PLANE_PRIMARY &&
|
|
|
|
set->flags & I915_SET_COLORKEY_SOURCE)
|
|
|
|
key->flags = 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* On SKL+ we want dst key enabled on
|
|
|
|
* the primary and not on the sprite.
|
|
|
|
*/
|
|
|
|
if (INTEL_GEN(dev_priv) >= 9 && plane->id != PLANE_PRIMARY &&
|
|
|
|
set->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
key->flags = 0;
|
|
|
|
}
|
|
|
|
|
2018-02-07 18:48:41 +02:00
|
|
|
int intel_sprite_set_colorkey_ioctl(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file_priv)
|
2012-01-03 08:05:39 -08:00
|
|
|
{
|
2016-10-14 10:13:44 +01:00
|
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
2012-01-03 08:05:39 -08:00
|
|
|
struct drm_intel_sprite_colorkey *set = data;
|
|
|
|
struct drm_plane *plane;
|
2015-06-15 12:33:54 +02:00
|
|
|
struct drm_plane_state *plane_state;
|
|
|
|
struct drm_atomic_state *state;
|
|
|
|
struct drm_modeset_acquire_ctx ctx;
|
2012-01-03 08:05:39 -08:00
|
|
|
int ret = 0;
|
|
|
|
|
2018-02-02 22:42:31 +02:00
|
|
|
/* ignore the pointless "none" flag */
|
|
|
|
set->flags &= ~I915_SET_COLORKEY_NONE;
|
|
|
|
|
2018-02-06 22:43:33 +02:00
|
|
|
if (set->flags & ~(I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2012-01-03 08:05:39 -08:00
|
|
|
/* Make sure we don't try to enable both src & dest simultaneously */
|
|
|
|
if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2016-10-14 10:13:44 +01:00
|
|
|
if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
|
2015-03-19 21:18:57 +02:00
|
|
|
set->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2017-03-14 23:25:07 -07:00
|
|
|
plane = drm_plane_find(dev, file_priv, set->plane_id);
|
2015-06-15 12:33:54 +02:00
|
|
|
if (!plane || plane->type != DRM_PLANE_TYPE_OVERLAY)
|
|
|
|
return -ENOENT;
|
2012-01-03 08:05:39 -08:00
|
|
|
|
2018-05-29 21:28:00 +03:00
|
|
|
/*
|
|
|
|
* SKL+ only plane 2 can do destination keying against plane 1.
|
|
|
|
* Also multiple planes can't do destination keying on the same
|
|
|
|
* pipe simultaneously.
|
|
|
|
*/
|
|
|
|
if (INTEL_GEN(dev_priv) >= 9 &&
|
|
|
|
to_intel_plane(plane)->id >= PLANE_SPRITE1 &&
|
|
|
|
set->flags & I915_SET_COLORKEY_DESTINATION)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2015-06-15 12:33:54 +02:00
|
|
|
drm_modeset_acquire_init(&ctx, 0);
|
2015-04-27 13:48:39 -07:00
|
|
|
|
2015-06-15 12:33:54 +02:00
|
|
|
state = drm_atomic_state_alloc(plane->dev);
|
|
|
|
if (!state) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto out;
|
2015-04-27 13:48:39 -07:00
|
|
|
}
|
2015-06-15 12:33:54 +02:00
|
|
|
state->acquire_ctx = &ctx;
|
|
|
|
|
|
|
|
while (1) {
|
|
|
|
plane_state = drm_atomic_get_plane_state(state, plane);
|
|
|
|
ret = PTR_ERR_OR_ZERO(plane_state);
|
2018-05-29 21:28:00 +03:00
|
|
|
if (!ret)
|
|
|
|
intel_plane_set_ckey(to_intel_plane_state(plane_state), set);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* On some platforms we have to configure
|
|
|
|
* the dst colorkey on the primary plane.
|
|
|
|
*/
|
|
|
|
if (!ret && has_dst_key_in_primary_plane(dev_priv)) {
|
|
|
|
struct intel_crtc *crtc =
|
|
|
|
intel_get_crtc_for_pipe(dev_priv,
|
|
|
|
to_intel_plane(plane)->pipe);
|
|
|
|
|
|
|
|
plane_state = drm_atomic_get_plane_state(state,
|
|
|
|
crtc->base.primary);
|
|
|
|
ret = PTR_ERR_OR_ZERO(plane_state);
|
|
|
|
if (!ret)
|
|
|
|
intel_plane_set_ckey(to_intel_plane_state(plane_state), set);
|
2015-06-15 12:33:54 +02:00
|
|
|
}
|
2015-04-27 13:48:39 -07:00
|
|
|
|
2018-05-29 21:28:00 +03:00
|
|
|
if (!ret)
|
|
|
|
ret = drm_atomic_commit(state);
|
|
|
|
|
2015-06-15 12:33:54 +02:00
|
|
|
if (ret != -EDEADLK)
|
|
|
|
break;
|
2012-01-03 08:05:39 -08:00
|
|
|
|
2015-06-15 12:33:54 +02:00
|
|
|
drm_atomic_state_clear(state);
|
|
|
|
drm_modeset_backoff(&ctx);
|
|
|
|
}
|
2012-01-03 08:05:39 -08:00
|
|
|
|
2016-10-14 13:18:18 +01:00
|
|
|
drm_atomic_state_put(state);
|
2015-06-15 12:33:54 +02:00
|
|
|
out:
|
|
|
|
drm_modeset_drop_locks(&ctx);
|
|
|
|
drm_modeset_acquire_fini(&ctx);
|
|
|
|
return ret;
|
2013-03-26 09:25:43 -07:00
|
|
|
}
|
|
|
|
|
2019-01-16 11:15:28 +02:00
|
|
|
static const u32 g4x_plane_formats[] = {
|
2012-04-10 11:41:49 +01:00
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2019-01-16 11:15:28 +02:00
|
|
|
static const u64 i9xx_plane_format_modifiers[] = {
|
2017-08-01 09:58:16 -07:00
|
|
|
I915_FORMAT_MOD_X_TILED,
|
|
|
|
DRM_FORMAT_MOD_LINEAR,
|
|
|
|
DRM_FORMAT_MOD_INVALID
|
|
|
|
};
|
|
|
|
|
2019-01-16 11:15:28 +02:00
|
|
|
static const u32 snb_plane_formats[] = {
|
2011-12-13 13:19:38 -08:00
|
|
|
DRM_FORMAT_XRGB8888,
|
2019-10-15 22:30:32 +03:00
|
|
|
DRM_FORMAT_XBGR8888,
|
2019-10-31 18:56:46 +02:00
|
|
|
DRM_FORMAT_XRGB2101010,
|
|
|
|
DRM_FORMAT_XBGR2101010,
|
2019-10-15 22:30:32 +03:00
|
|
|
DRM_FORMAT_XRGB16161616F,
|
|
|
|
DRM_FORMAT_XBGR16161616F,
|
2011-12-13 13:19:38 -08:00
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2019-01-16 11:15:28 +02:00
|
|
|
static const u32 vlv_plane_formats[] = {
|
2019-10-31 18:56:49 +02:00
|
|
|
DRM_FORMAT_C8,
|
2013-04-02 11:22:20 -07:00
|
|
|
DRM_FORMAT_RGB565,
|
|
|
|
DRM_FORMAT_XRGB8888,
|
2019-10-31 18:56:51 +02:00
|
|
|
DRM_FORMAT_XBGR8888,
|
|
|
|
DRM_FORMAT_ARGB8888,
|
|
|
|
DRM_FORMAT_ABGR8888,
|
2013-04-02 11:22:20 -07:00
|
|
|
DRM_FORMAT_XBGR2101010,
|
|
|
|
DRM_FORMAT_ABGR2101010,
|
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2019-10-31 18:56:48 +02:00
|
|
|
static const u32 chv_pipe_b_sprite_formats[] = {
|
2019-10-31 18:56:49 +02:00
|
|
|
DRM_FORMAT_C8,
|
2019-10-31 18:56:48 +02:00
|
|
|
DRM_FORMAT_RGB565,
|
|
|
|
DRM_FORMAT_XRGB8888,
|
|
|
|
DRM_FORMAT_XBGR8888,
|
|
|
|
DRM_FORMAT_ARGB8888,
|
|
|
|
DRM_FORMAT_ABGR8888,
|
|
|
|
DRM_FORMAT_XRGB2101010,
|
|
|
|
DRM_FORMAT_XBGR2101010,
|
|
|
|
DRM_FORMAT_ARGB2101010,
|
|
|
|
DRM_FORMAT_ABGR2101010,
|
|
|
|
DRM_FORMAT_YUYV,
|
|
|
|
DRM_FORMAT_YVYU,
|
|
|
|
DRM_FORMAT_UYVY,
|
|
|
|
DRM_FORMAT_VYUY,
|
|
|
|
};
|
|
|
|
|
2018-05-18 19:21:59 +03:00
|
|
|
static bool g4x_sprite_format_mod_supported(struct drm_plane *_plane,
|
|
|
|
u32 format, u64 modifier)
|
2017-08-01 09:58:16 -07:00
|
|
|
{
|
2018-05-18 19:21:59 +03:00
|
|
|
switch (modifier) {
|
|
|
|
case DRM_FORMAT_MOD_LINEAR:
|
|
|
|
case I915_FORMAT_MOD_X_TILED:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-08-01 09:58:16 -07:00
|
|
|
switch (format) {
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
case DRM_FORMAT_VYUY:
|
|
|
|
if (modifier == DRM_FORMAT_MOD_LINEAR ||
|
|
|
|
modifier == I915_FORMAT_MOD_X_TILED)
|
|
|
|
return true;
|
2020-08-23 17:36:59 -05:00
|
|
|
fallthrough;
|
2017-08-01 09:58:16 -07:00
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-18 19:21:59 +03:00
|
|
|
static bool snb_sprite_format_mod_supported(struct drm_plane *_plane,
|
|
|
|
u32 format, u64 modifier)
|
2017-08-01 09:58:16 -07:00
|
|
|
{
|
2018-05-18 19:21:59 +03:00
|
|
|
switch (modifier) {
|
|
|
|
case DRM_FORMAT_MOD_LINEAR:
|
|
|
|
case I915_FORMAT_MOD_X_TILED:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-08-01 09:58:16 -07:00
|
|
|
switch (format) {
|
2017-12-22 21:22:27 +02:00
|
|
|
case DRM_FORMAT_XRGB8888:
|
|
|
|
case DRM_FORMAT_XBGR8888:
|
2019-10-31 18:56:46 +02:00
|
|
|
case DRM_FORMAT_XRGB2101010:
|
|
|
|
case DRM_FORMAT_XBGR2101010:
|
2019-10-15 22:30:31 +03:00
|
|
|
case DRM_FORMAT_XRGB16161616F:
|
|
|
|
case DRM_FORMAT_XBGR16161616F:
|
2017-08-01 09:58:16 -07:00
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
case DRM_FORMAT_VYUY:
|
2017-12-22 21:22:27 +02:00
|
|
|
if (modifier == DRM_FORMAT_MOD_LINEAR ||
|
|
|
|
modifier == I915_FORMAT_MOD_X_TILED)
|
|
|
|
return true;
|
2020-08-23 17:36:59 -05:00
|
|
|
fallthrough;
|
2017-12-22 21:22:27 +02:00
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-18 19:21:59 +03:00
|
|
|
static bool vlv_sprite_format_mod_supported(struct drm_plane *_plane,
|
|
|
|
u32 format, u64 modifier)
|
2017-12-22 21:22:27 +02:00
|
|
|
{
|
2018-05-18 19:21:59 +03:00
|
|
|
switch (modifier) {
|
|
|
|
case DRM_FORMAT_MOD_LINEAR:
|
|
|
|
case I915_FORMAT_MOD_X_TILED:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-12-22 21:22:27 +02:00
|
|
|
switch (format) {
|
2019-10-31 18:56:49 +02:00
|
|
|
case DRM_FORMAT_C8:
|
2017-08-01 09:58:16 -07:00
|
|
|
case DRM_FORMAT_RGB565:
|
2017-12-22 21:22:27 +02:00
|
|
|
case DRM_FORMAT_ABGR8888:
|
2017-08-01 09:58:16 -07:00
|
|
|
case DRM_FORMAT_ARGB8888:
|
2017-12-22 21:22:27 +02:00
|
|
|
case DRM_FORMAT_XBGR8888:
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
2017-08-01 09:58:16 -07:00
|
|
|
case DRM_FORMAT_XBGR2101010:
|
|
|
|
case DRM_FORMAT_ABGR2101010:
|
2019-10-31 18:56:48 +02:00
|
|
|
case DRM_FORMAT_XRGB2101010:
|
|
|
|
case DRM_FORMAT_ARGB2101010:
|
2017-12-22 21:22:27 +02:00
|
|
|
case DRM_FORMAT_YUYV:
|
|
|
|
case DRM_FORMAT_YVYU:
|
|
|
|
case DRM_FORMAT_UYVY:
|
|
|
|
case DRM_FORMAT_VYUY:
|
2017-08-01 09:58:16 -07:00
|
|
|
if (modifier == DRM_FORMAT_MOD_LINEAR ||
|
|
|
|
modifier == I915_FORMAT_MOD_X_TILED)
|
|
|
|
return true;
|
2020-08-23 17:36:59 -05:00
|
|
|
fallthrough;
|
2017-08-01 09:58:16 -07:00
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-05-18 19:21:59 +03:00
|
|
|
static const struct drm_plane_funcs g4x_sprite_funcs = {
|
|
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
|
|
|
.destroy = intel_plane_destroy,
|
|
|
|
.atomic_duplicate_state = intel_plane_duplicate_state,
|
|
|
|
.atomic_destroy_state = intel_plane_destroy_state,
|
|
|
|
.format_mod_supported = g4x_sprite_format_mod_supported,
|
|
|
|
};
|
2017-08-01 09:58:16 -07:00
|
|
|
|
2018-05-18 19:21:59 +03:00
|
|
|
static const struct drm_plane_funcs snb_sprite_funcs = {
|
|
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
|
|
|
.destroy = intel_plane_destroy,
|
|
|
|
.atomic_duplicate_state = intel_plane_duplicate_state,
|
|
|
|
.atomic_destroy_state = intel_plane_destroy_state,
|
|
|
|
.format_mod_supported = snb_sprite_format_mod_supported,
|
|
|
|
};
|
2017-08-01 09:58:16 -07:00
|
|
|
|
2018-05-18 19:21:59 +03:00
|
|
|
static const struct drm_plane_funcs vlv_sprite_funcs = {
|
|
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
|
|
|
.destroy = intel_plane_destroy,
|
|
|
|
.atomic_duplicate_state = intel_plane_duplicate_state,
|
|
|
|
.atomic_destroy_state = intel_plane_destroy_state,
|
|
|
|
.format_mod_supported = vlv_sprite_format_mod_supported,
|
|
|
|
};
|
2017-08-01 09:58:16 -07:00
|
|
|
|
2016-10-25 18:58:02 +03:00
|
|
|
struct intel_plane *
|
2016-10-31 22:37:00 +02:00
|
|
|
intel_sprite_plane_create(struct drm_i915_private *dev_priv,
|
2018-10-05 15:58:16 +03:00
|
|
|
enum pipe pipe, int sprite)
|
2011-12-13 13:19:38 -08:00
|
|
|
{
|
2018-10-05 15:58:16 +03:00
|
|
|
struct intel_plane *plane;
|
2018-05-18 19:21:59 +03:00
|
|
|
const struct drm_plane_funcs *plane_funcs;
|
2016-09-26 19:30:56 +03:00
|
|
|
unsigned int supported_rotations;
|
2018-10-05 15:58:16 +03:00
|
|
|
const u64 *modifiers;
|
|
|
|
const u32 *formats;
|
|
|
|
int num_formats;
|
2019-04-13 11:13:27 +00:00
|
|
|
int ret, zpos;
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
plane = intel_plane_alloc();
|
|
|
|
if (IS_ERR(plane))
|
|
|
|
return plane;
|
2014-12-23 10:41:52 -08:00
|
|
|
|
2018-10-05 15:58:15 +03:00
|
|
|
if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
|
2018-10-05 15:58:16 +03:00
|
|
|
plane->update_plane = vlv_update_plane;
|
|
|
|
plane->disable_plane = vlv_disable_plane;
|
|
|
|
plane->get_hw_state = vlv_plane_get_hw_state;
|
|
|
|
plane->check_plane = vlv_sprite_check;
|
2021-01-11 18:37:02 +02:00
|
|
|
plane->max_stride = i965_plane_max_stride;
|
2019-10-15 22:30:26 +03:00
|
|
|
plane->min_cdclk = vlv_plane_min_cdclk;
|
2018-10-05 15:58:16 +03:00
|
|
|
|
2019-10-31 18:56:48 +02:00
|
|
|
if (IS_CHERRYVIEW(dev_priv) && pipe == PIPE_B) {
|
|
|
|
formats = chv_pipe_b_sprite_formats;
|
|
|
|
num_formats = ARRAY_SIZE(chv_pipe_b_sprite_formats);
|
|
|
|
} else {
|
|
|
|
formats = vlv_plane_formats;
|
|
|
|
num_formats = ARRAY_SIZE(vlv_plane_formats);
|
|
|
|
}
|
2017-08-01 09:58:16 -07:00
|
|
|
modifiers = i9xx_plane_format_modifiers;
|
2018-05-18 19:21:59 +03:00
|
|
|
|
|
|
|
plane_funcs = &vlv_sprite_funcs;
|
2016-10-25 18:58:03 +03:00
|
|
|
} else if (INTEL_GEN(dev_priv) >= 7) {
|
2018-10-05 15:58:16 +03:00
|
|
|
plane->update_plane = ivb_update_plane;
|
|
|
|
plane->disable_plane = ivb_disable_plane;
|
|
|
|
plane->get_hw_state = ivb_plane_get_hw_state;
|
|
|
|
plane->check_plane = g4x_sprite_check;
|
|
|
|
|
2021-01-11 18:37:02 +02:00
|
|
|
if (IS_BROADWELL(dev_priv) || IS_HASWELL(dev_priv)) {
|
|
|
|
plane->max_stride = hsw_sprite_max_stride;
|
2019-10-15 22:30:26 +03:00
|
|
|
plane->min_cdclk = hsw_plane_min_cdclk;
|
2021-01-11 18:37:02 +02:00
|
|
|
} else {
|
|
|
|
plane->max_stride = g4x_sprite_max_stride;
|
2019-10-15 22:30:26 +03:00
|
|
|
plane->min_cdclk = ivb_sprite_min_cdclk;
|
2021-01-11 18:37:02 +02:00
|
|
|
}
|
2019-10-15 22:30:26 +03:00
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
formats = snb_plane_formats;
|
|
|
|
num_formats = ARRAY_SIZE(snb_plane_formats);
|
2017-08-01 09:58:16 -07:00
|
|
|
modifiers = i9xx_plane_format_modifiers;
|
2018-05-18 19:21:59 +03:00
|
|
|
|
|
|
|
plane_funcs = &snb_sprite_funcs;
|
2016-10-25 18:58:03 +03:00
|
|
|
} else {
|
2018-10-05 15:58:16 +03:00
|
|
|
plane->update_plane = g4x_update_plane;
|
|
|
|
plane->disable_plane = g4x_disable_plane;
|
|
|
|
plane->get_hw_state = g4x_plane_get_hw_state;
|
|
|
|
plane->check_plane = g4x_sprite_check;
|
2021-01-11 18:37:02 +02:00
|
|
|
plane->max_stride = g4x_sprite_max_stride;
|
2019-10-15 22:30:26 +03:00
|
|
|
plane->min_cdclk = g4x_sprite_min_cdclk;
|
2013-04-02 11:22:20 -07:00
|
|
|
|
2017-08-01 09:58:16 -07:00
|
|
|
modifiers = i9xx_plane_format_modifiers;
|
drm/i915: replace IS_GEN<N> with IS_GEN(..., N)
Define IS_GEN() similarly to our IS_GEN_RANGE(). but use gen instead of
gen_mask to do the comparison. Now callers can pass then gen as a parameter,
so we don't require one macro for each gen.
The following spatch was used to convert the users of these macros:
@@
expression e;
@@
(
- IS_GEN2(e)
+ IS_GEN(e, 2)
|
- IS_GEN3(e)
+ IS_GEN(e, 3)
|
- IS_GEN4(e)
+ IS_GEN(e, 4)
|
- IS_GEN5(e)
+ IS_GEN(e, 5)
|
- IS_GEN6(e)
+ IS_GEN(e, 6)
|
- IS_GEN7(e)
+ IS_GEN(e, 7)
|
- IS_GEN8(e)
+ IS_GEN(e, 8)
|
- IS_GEN9(e)
+ IS_GEN(e, 9)
|
- IS_GEN10(e)
+ IS_GEN(e, 10)
|
- IS_GEN11(e)
+ IS_GEN(e, 11)
)
v2: use IS_GEN rather than GT_GEN and compare to info.gen rather than
using the bitmask
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181212181044.15886-2-lucas.demarchi@intel.com
2018-12-12 10:10:43 -08:00
|
|
|
if (IS_GEN(dev_priv, 6)) {
|
2018-10-05 15:58:16 +03:00
|
|
|
formats = snb_plane_formats;
|
|
|
|
num_formats = ARRAY_SIZE(snb_plane_formats);
|
2018-05-18 19:21:59 +03:00
|
|
|
|
|
|
|
plane_funcs = &snb_sprite_funcs;
|
2016-10-25 18:58:03 +03:00
|
|
|
} else {
|
2018-10-05 15:58:16 +03:00
|
|
|
formats = g4x_plane_formats;
|
|
|
|
num_formats = ARRAY_SIZE(g4x_plane_formats);
|
2018-05-18 19:21:59 +03:00
|
|
|
|
|
|
|
plane_funcs = &g4x_sprite_funcs;
|
2013-04-02 11:22:20 -07:00
|
|
|
}
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|
|
|
|
|
2018-10-05 15:58:15 +03:00
|
|
|
if (IS_CHERRYVIEW(dev_priv) && pipe == PIPE_B) {
|
2016-11-14 18:54:00 +02:00
|
|
|
supported_rotations =
|
2017-05-19 16:50:17 -04:00
|
|
|
DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_180 |
|
|
|
|
DRM_MODE_REFLECT_X;
|
2016-09-26 19:30:56 +03:00
|
|
|
} else {
|
|
|
|
supported_rotations =
|
2017-05-19 16:50:17 -04:00
|
|
|
DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_180;
|
2016-09-26 19:30:56 +03:00
|
|
|
}
|
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
plane->pipe = pipe;
|
|
|
|
plane->id = PLANE_SPRITE0 + sprite;
|
|
|
|
plane->frontbuffer_bit = INTEL_FRONTBUFFER(pipe, plane->id);
|
2016-03-21 14:43:22 +00:00
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
ret = drm_universal_plane_init(&dev_priv->drm, &plane->base,
|
2020-02-26 22:05:17 +05:30
|
|
|
0, plane_funcs,
|
2018-10-05 15:58:16 +03:00
|
|
|
formats, num_formats, modifiers,
|
2018-10-05 15:58:15 +03:00
|
|
|
DRM_PLANE_TYPE_OVERLAY,
|
2018-10-05 15:58:16 +03:00
|
|
|
"sprite %c", sprite_name(pipe, sprite));
|
2016-03-21 14:43:22 +00:00
|
|
|
if (ret)
|
|
|
|
goto fail;
|
2014-08-05 11:26:55 +05:30
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
drm_plane_create_rotation_property(&plane->base,
|
2017-05-19 16:50:17 -04:00
|
|
|
DRM_MODE_ROTATE_0,
|
2016-09-26 19:30:56 +03:00
|
|
|
supported_rotations);
|
2011-12-13 13:19:38 -08:00
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
drm_plane_create_color_properties(&plane->base,
|
2018-02-14 21:23:25 +02:00
|
|
|
BIT(DRM_COLOR_YCBCR_BT601) |
|
|
|
|
BIT(DRM_COLOR_YCBCR_BT709),
|
2018-02-14 21:23:27 +02:00
|
|
|
BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) |
|
|
|
|
BIT(DRM_COLOR_YCBCR_FULL_RANGE),
|
2018-02-14 21:23:26 +02:00
|
|
|
DRM_COLOR_YCBCR_BT709,
|
2018-02-14 21:23:25 +02:00
|
|
|
DRM_COLOR_YCBCR_LIMITED_RANGE);
|
|
|
|
|
2019-04-13 11:13:27 +00:00
|
|
|
zpos = sprite + 1;
|
|
|
|
drm_plane_create_zpos_immutable_property(&plane->base, zpos);
|
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
drm_plane_helper_add(&plane->base, &intel_plane_helper_funcs);
|
2014-12-23 10:41:52 -08:00
|
|
|
|
2018-10-05 15:58:16 +03:00
|
|
|
return plane;
|
2016-03-21 14:43:22 +00:00
|
|
|
|
|
|
|
fail:
|
2018-10-05 15:58:16 +03:00
|
|
|
intel_plane_free(plane);
|
2016-03-21 14:43:22 +00:00
|
|
|
|
2016-10-25 18:58:02 +03:00
|
|
|
return ERR_PTR(ret);
|
2011-12-13 13:19:38 -08:00
|
|
|
}
|