2020-01-16 13:32:39 -08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
|
|
* Memory Bandwidth Monitoring (MBM) test
|
|
|
|
*
|
|
|
|
* Copyright (C) 2018 Intel Corporation
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
|
|
|
|
* Fenghua Yu <fenghua.yu@intel.com>
|
|
|
|
*/
|
|
|
|
#include "resctrl.h"
|
|
|
|
|
|
|
|
#define RESULT_FILE_NAME "result_mbm"
|
2023-10-02 12:48:13 +03:00
|
|
|
#define MAX_DIFF_PERCENT 8
|
2020-01-16 13:32:39 -08:00
|
|
|
#define NUM_OF_RUNS 5
|
|
|
|
|
2021-03-17 02:22:42 +00:00
|
|
|
static int
|
2023-07-17 16:14:57 +03:00
|
|
|
show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, size_t span)
|
2020-01-16 13:32:39 -08:00
|
|
|
{
|
|
|
|
unsigned long sum_bw_imc = 0, sum_bw_resc = 0;
|
2024-05-08 13:41:01 -07:00
|
|
|
long avg_bw_imc = 0, avg_bw_resc = 0;
|
2021-03-17 02:22:48 +00:00
|
|
|
int runs, ret, avg_diff_per;
|
|
|
|
float avg_diff = 0;
|
2020-01-16 13:32:39 -08:00
|
|
|
|
2024-10-24 14:18:51 -07:00
|
|
|
for (runs = 0; runs < NUM_OF_RUNS; runs++) {
|
2020-01-16 13:32:39 -08:00
|
|
|
sum_bw_imc += bw_imc[runs];
|
|
|
|
sum_bw_resc += bw_resc[runs];
|
|
|
|
}
|
|
|
|
|
2024-10-24 14:18:51 -07:00
|
|
|
avg_bw_imc = sum_bw_imc / NUM_OF_RUNS;
|
|
|
|
avg_bw_resc = sum_bw_resc / NUM_OF_RUNS;
|
2021-03-17 02:22:48 +00:00
|
|
|
avg_diff = (float)labs(avg_bw_resc - avg_bw_imc) / avg_bw_imc;
|
|
|
|
avg_diff_per = (int)(avg_diff * 100);
|
2020-01-16 13:32:39 -08:00
|
|
|
|
2021-03-17 02:22:48 +00:00
|
|
|
ret = avg_diff_per > MAX_DIFF_PERCENT;
|
2021-04-07 19:57:28 +00:00
|
|
|
ksft_print_msg("%s Check MBM diff within %d%%\n",
|
2021-03-17 02:22:48 +00:00
|
|
|
ret ? "Fail:" : "Pass:", MAX_DIFF_PERCENT);
|
|
|
|
ksft_print_msg("avg_diff_per: %d%%\n", avg_diff_per);
|
2024-10-24 14:18:39 -07:00
|
|
|
if (span)
|
|
|
|
ksft_print_msg("Span (MB): %zu\n", span / MB);
|
2021-03-17 02:22:42 +00:00
|
|
|
ksft_print_msg("avg_bw_imc: %lu\n", avg_bw_imc);
|
|
|
|
ksft_print_msg("avg_bw_resc: %lu\n", avg_bw_resc);
|
|
|
|
|
|
|
|
return ret;
|
2020-01-16 13:32:39 -08:00
|
|
|
}
|
|
|
|
|
2023-07-17 16:14:57 +03:00
|
|
|
static int check_results(size_t span)
|
2020-01-16 13:32:39 -08:00
|
|
|
{
|
|
|
|
unsigned long bw_imc[NUM_OF_RUNS], bw_resc[NUM_OF_RUNS];
|
|
|
|
char temp[1024], *token_array[8];
|
|
|
|
char output[] = RESULT_FILE_NAME;
|
2021-03-17 02:22:42 +00:00
|
|
|
int runs, ret;
|
2020-01-16 13:32:39 -08:00
|
|
|
FILE *fp;
|
|
|
|
|
2021-03-17 02:22:42 +00:00
|
|
|
ksft_print_msg("Checking for pass/fail\n");
|
2020-01-16 13:32:39 -08:00
|
|
|
|
|
|
|
fp = fopen(output, "r");
|
|
|
|
if (!fp) {
|
2023-12-15 17:04:47 +02:00
|
|
|
ksft_perror(output);
|
2020-01-16 13:32:39 -08:00
|
|
|
|
2023-12-15 17:04:48 +02:00
|
|
|
return -1;
|
2020-01-16 13:32:39 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
runs = 0;
|
|
|
|
while (fgets(temp, sizeof(temp), fp)) {
|
|
|
|
char *token = strtok(temp, ":\t");
|
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
while (token) {
|
|
|
|
token_array[i++] = token;
|
|
|
|
token = strtok(NULL, ":\t");
|
|
|
|
}
|
|
|
|
|
|
|
|
bw_resc[runs] = strtoul(token_array[5], NULL, 0);
|
|
|
|
bw_imc[runs] = strtoul(token_array[3], NULL, 0);
|
|
|
|
runs++;
|
|
|
|
}
|
|
|
|
|
2021-03-17 02:22:42 +00:00
|
|
|
ret = show_bw_info(bw_imc, bw_resc, span);
|
2020-01-16 13:32:39 -08:00
|
|
|
|
|
|
|
fclose(fp);
|
|
|
|
|
2021-03-17 02:22:42 +00:00
|
|
|
return ret;
|
2020-01-16 13:32:39 -08:00
|
|
|
}
|
|
|
|
|
2024-06-10 18:14:51 +03:00
|
|
|
static int mbm_init(const struct resctrl_val_param *param, int domain_id)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2024-10-24 14:18:46 -07:00
|
|
|
ret = initialize_read_mem_bw_imc();
|
2024-06-10 18:14:51 +03:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
initialize_mem_bw_resctrl(param, domain_id);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-12-15 17:05:12 +02:00
|
|
|
static int mbm_setup(const struct resctrl_test *test,
|
|
|
|
const struct user_params *uparams,
|
|
|
|
struct resctrl_val_param *p)
|
2020-01-16 13:32:39 -08:00
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
|
2023-04-13 16:22:54 +09:00
|
|
|
/* Run NUM_OF_RUNS times */
|
|
|
|
if (p->num_of_runs >= NUM_OF_RUNS)
|
2023-04-14 09:43:58 -07:00
|
|
|
return END_OF_TESTS;
|
2023-04-13 16:22:54 +09:00
|
|
|
|
2020-01-16 13:32:39 -08:00
|
|
|
/* Set up shemata with 100% allocation on the first run. */
|
2024-02-16 09:35:28 +01:00
|
|
|
if (p->num_of_runs == 0 && resctrl_resource_exists("MB"))
|
2023-12-15 17:05:12 +02:00
|
|
|
ret = write_schemata(p->ctrlgrp, "100", uparams->cpu, test->resource);
|
2020-01-16 13:32:39 -08:00
|
|
|
|
2023-04-13 16:22:54 +09:00
|
|
|
p->num_of_runs++;
|
|
|
|
|
2020-01-16 13:32:39 -08:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2024-06-10 18:14:50 +03:00
|
|
|
static int mbm_measure(const struct user_params *uparams,
|
|
|
|
struct resctrl_val_param *param, pid_t bm_pid)
|
|
|
|
{
|
2024-10-24 14:18:46 -07:00
|
|
|
return measure_read_mem_bw(uparams, param, bm_pid);
|
2024-06-10 18:14:50 +03:00
|
|
|
}
|
|
|
|
|
2024-02-27 08:21:43 +01:00
|
|
|
static void mbm_test_cleanup(void)
|
2020-01-16 13:32:39 -08:00
|
|
|
{
|
|
|
|
remove(RESULT_FILE_NAME);
|
|
|
|
}
|
|
|
|
|
2023-12-15 17:05:11 +02:00
|
|
|
static int mbm_run_test(const struct resctrl_test *test, const struct user_params *uparams)
|
2020-01-16 13:32:39 -08:00
|
|
|
{
|
|
|
|
struct resctrl_val_param param = {
|
|
|
|
.ctrlgrp = "c1",
|
|
|
|
.filename = RESULT_FILE_NAME,
|
2024-06-10 18:14:51 +03:00
|
|
|
.init = mbm_init,
|
2024-06-10 18:14:50 +03:00
|
|
|
.setup = mbm_setup,
|
|
|
|
.measure = mbm_measure,
|
2020-01-16 13:32:39 -08:00
|
|
|
};
|
selftests/resctrl: Make benchmark parameter passing robust
The benchmark used during the CMT, MBM, and MBA tests can be provided by
the user via (-b) parameter, if not provided the default "fill_buf"
benchmark is used. The user is additionally able to override
any of the "fill_buf" default parameters when running the tests with
"-b fill_buf <fill_buf parameters>".
The "fill_buf" parameters are managed as an array of strings. Using an
array of strings is complex because it requires transformations to/from
strings at every producer and consumer. This is made worse for the
individual tests where the default benchmark parameters values may not
be appropriate and additional data wrangling is required. For example,
the CMT test duplicates the entire array of strings in order to replace
one of the parameters.
More issues appear when combining the usage of an array of strings with
the use case of user overriding default parameters by specifying
"-b fill_buf <parameters>". This use case is fragile with opportunities
to trigger a SIGSEGV because of opportunities for NULL pointers to exist
in the array of strings. For example, by running below (thus by specifying
"fill_buf" should be used but all parameters are NULL):
$ sudo resctrl_tests -t mbm -b fill_buf
Replace the "array of strings" parameters used for "fill_buf" with
new struct fill_buf_param that contains the "fill_buf" parameters that
can be used directly without transformations to/from strings. Two
instances of struct fill_buf_param may exist at any point in time:
* If the user provides new parameters to "fill_buf", the
user parameter structure (struct user_params) will point to a
fully initialized and immutable struct fill_buf_param
containing the user provided parameters.
* If "fill_buf" is the benchmark that should be used by a test,
then the test parameter structure (struct resctrl_val_param)
will point to a fully initialized struct fill_buf_param. The
latter may contain (a) the user provided parameters verbatim,
(b) user provided parameters adjusted to be appropriate for
the test, or (c) the default parameters for "fill_buf" that
is appropriate for the test if the user did not provide
"fill_buf" parameters nor an alternate benchmark.
The existing behavior of CMT test is to use test defined value for the
buffer size even if the user provides another value via command line.
This behavior is maintained since the test requires that the buffer size
matches the size of the cache allocated, and the amount of cache
allocated can instead be changed by the user with the "-n" command line
parameter.
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
2024-10-24 14:18:47 -07:00
|
|
|
struct fill_buf_param fill_buf = {};
|
2020-01-16 13:32:39 -08:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
remove(RESULT_FILE_NAME);
|
|
|
|
|
selftests/resctrl: Make benchmark parameter passing robust
The benchmark used during the CMT, MBM, and MBA tests can be provided by
the user via (-b) parameter, if not provided the default "fill_buf"
benchmark is used. The user is additionally able to override
any of the "fill_buf" default parameters when running the tests with
"-b fill_buf <fill_buf parameters>".
The "fill_buf" parameters are managed as an array of strings. Using an
array of strings is complex because it requires transformations to/from
strings at every producer and consumer. This is made worse for the
individual tests where the default benchmark parameters values may not
be appropriate and additional data wrangling is required. For example,
the CMT test duplicates the entire array of strings in order to replace
one of the parameters.
More issues appear when combining the usage of an array of strings with
the use case of user overriding default parameters by specifying
"-b fill_buf <parameters>". This use case is fragile with opportunities
to trigger a SIGSEGV because of opportunities for NULL pointers to exist
in the array of strings. For example, by running below (thus by specifying
"fill_buf" should be used but all parameters are NULL):
$ sudo resctrl_tests -t mbm -b fill_buf
Replace the "array of strings" parameters used for "fill_buf" with
new struct fill_buf_param that contains the "fill_buf" parameters that
can be used directly without transformations to/from strings. Two
instances of struct fill_buf_param may exist at any point in time:
* If the user provides new parameters to "fill_buf", the
user parameter structure (struct user_params) will point to a
fully initialized and immutable struct fill_buf_param
containing the user provided parameters.
* If "fill_buf" is the benchmark that should be used by a test,
then the test parameter structure (struct resctrl_val_param)
will point to a fully initialized struct fill_buf_param. The
latter may contain (a) the user provided parameters verbatim,
(b) user provided parameters adjusted to be appropriate for
the test, or (c) the default parameters for "fill_buf" that
is appropriate for the test if the user did not provide
"fill_buf" parameters nor an alternate benchmark.
The existing behavior of CMT test is to use test defined value for the
buffer size even if the user provides another value via command line.
This behavior is maintained since the test requires that the buffer size
matches the size of the cache allocated, and the amount of cache
allocated can instead be changed by the user with the "-n" command line
parameter.
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
2024-10-24 14:18:47 -07:00
|
|
|
if (uparams->fill_buf) {
|
|
|
|
fill_buf.buf_size = uparams->fill_buf->buf_size;
|
|
|
|
fill_buf.memflush = uparams->fill_buf->memflush;
|
|
|
|
param.fill_buf = &fill_buf;
|
|
|
|
} else if (!uparams->benchmark_cmd[0]) {
|
2024-10-24 14:18:49 -07:00
|
|
|
ssize_t buf_size;
|
|
|
|
|
|
|
|
buf_size = get_fill_buf_size(uparams->cpu, "L3");
|
|
|
|
if (buf_size < 0)
|
|
|
|
return buf_size;
|
|
|
|
fill_buf.buf_size = buf_size;
|
selftests/resctrl: Make benchmark parameter passing robust
The benchmark used during the CMT, MBM, and MBA tests can be provided by
the user via (-b) parameter, if not provided the default "fill_buf"
benchmark is used. The user is additionally able to override
any of the "fill_buf" default parameters when running the tests with
"-b fill_buf <fill_buf parameters>".
The "fill_buf" parameters are managed as an array of strings. Using an
array of strings is complex because it requires transformations to/from
strings at every producer and consumer. This is made worse for the
individual tests where the default benchmark parameters values may not
be appropriate and additional data wrangling is required. For example,
the CMT test duplicates the entire array of strings in order to replace
one of the parameters.
More issues appear when combining the usage of an array of strings with
the use case of user overriding default parameters by specifying
"-b fill_buf <parameters>". This use case is fragile with opportunities
to trigger a SIGSEGV because of opportunities for NULL pointers to exist
in the array of strings. For example, by running below (thus by specifying
"fill_buf" should be used but all parameters are NULL):
$ sudo resctrl_tests -t mbm -b fill_buf
Replace the "array of strings" parameters used for "fill_buf" with
new struct fill_buf_param that contains the "fill_buf" parameters that
can be used directly without transformations to/from strings. Two
instances of struct fill_buf_param may exist at any point in time:
* If the user provides new parameters to "fill_buf", the
user parameter structure (struct user_params) will point to a
fully initialized and immutable struct fill_buf_param
containing the user provided parameters.
* If "fill_buf" is the benchmark that should be used by a test,
then the test parameter structure (struct resctrl_val_param)
will point to a fully initialized struct fill_buf_param. The
latter may contain (a) the user provided parameters verbatim,
(b) user provided parameters adjusted to be appropriate for
the test, or (c) the default parameters for "fill_buf" that
is appropriate for the test if the user did not provide
"fill_buf" parameters nor an alternate benchmark.
The existing behavior of CMT test is to use test defined value for the
buffer size even if the user provides another value via command line.
This behavior is maintained since the test requires that the buffer size
matches the size of the cache allocated, and the amount of cache
allocated can instead be changed by the user with the "-n" command line
parameter.
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
2024-10-24 14:18:47 -07:00
|
|
|
fill_buf.memflush = true;
|
|
|
|
param.fill_buf = &fill_buf;
|
2024-10-24 14:18:39 -07:00
|
|
|
}
|
|
|
|
|
selftests/resctrl: Make benchmark parameter passing robust
The benchmark used during the CMT, MBM, and MBA tests can be provided by
the user via (-b) parameter, if not provided the default "fill_buf"
benchmark is used. The user is additionally able to override
any of the "fill_buf" default parameters when running the tests with
"-b fill_buf <fill_buf parameters>".
The "fill_buf" parameters are managed as an array of strings. Using an
array of strings is complex because it requires transformations to/from
strings at every producer and consumer. This is made worse for the
individual tests where the default benchmark parameters values may not
be appropriate and additional data wrangling is required. For example,
the CMT test duplicates the entire array of strings in order to replace
one of the parameters.
More issues appear when combining the usage of an array of strings with
the use case of user overriding default parameters by specifying
"-b fill_buf <parameters>". This use case is fragile with opportunities
to trigger a SIGSEGV because of opportunities for NULL pointers to exist
in the array of strings. For example, by running below (thus by specifying
"fill_buf" should be used but all parameters are NULL):
$ sudo resctrl_tests -t mbm -b fill_buf
Replace the "array of strings" parameters used for "fill_buf" with
new struct fill_buf_param that contains the "fill_buf" parameters that
can be used directly without transformations to/from strings. Two
instances of struct fill_buf_param may exist at any point in time:
* If the user provides new parameters to "fill_buf", the
user parameter structure (struct user_params) will point to a
fully initialized and immutable struct fill_buf_param
containing the user provided parameters.
* If "fill_buf" is the benchmark that should be used by a test,
then the test parameter structure (struct resctrl_val_param)
will point to a fully initialized struct fill_buf_param. The
latter may contain (a) the user provided parameters verbatim,
(b) user provided parameters adjusted to be appropriate for
the test, or (c) the default parameters for "fill_buf" that
is appropriate for the test if the user did not provide
"fill_buf" parameters nor an alternate benchmark.
The existing behavior of CMT test is to use test defined value for the
buffer size even if the user provides another value via command line.
This behavior is maintained since the test requires that the buffer size
matches the size of the cache allocated, and the amount of cache
allocated can instead be changed by the user with the "-n" command line
parameter.
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
2024-10-24 14:18:47 -07:00
|
|
|
ret = resctrl_val(test, uparams, ¶m);
|
2020-01-16 13:32:39 -08:00
|
|
|
if (ret)
|
2024-02-27 08:21:43 +01:00
|
|
|
return ret;
|
2020-01-16 13:32:39 -08:00
|
|
|
|
selftests/resctrl: Make benchmark parameter passing robust
The benchmark used during the CMT, MBM, and MBA tests can be provided by
the user via (-b) parameter, if not provided the default "fill_buf"
benchmark is used. The user is additionally able to override
any of the "fill_buf" default parameters when running the tests with
"-b fill_buf <fill_buf parameters>".
The "fill_buf" parameters are managed as an array of strings. Using an
array of strings is complex because it requires transformations to/from
strings at every producer and consumer. This is made worse for the
individual tests where the default benchmark parameters values may not
be appropriate and additional data wrangling is required. For example,
the CMT test duplicates the entire array of strings in order to replace
one of the parameters.
More issues appear when combining the usage of an array of strings with
the use case of user overriding default parameters by specifying
"-b fill_buf <parameters>". This use case is fragile with opportunities
to trigger a SIGSEGV because of opportunities for NULL pointers to exist
in the array of strings. For example, by running below (thus by specifying
"fill_buf" should be used but all parameters are NULL):
$ sudo resctrl_tests -t mbm -b fill_buf
Replace the "array of strings" parameters used for "fill_buf" with
new struct fill_buf_param that contains the "fill_buf" parameters that
can be used directly without transformations to/from strings. Two
instances of struct fill_buf_param may exist at any point in time:
* If the user provides new parameters to "fill_buf", the
user parameter structure (struct user_params) will point to a
fully initialized and immutable struct fill_buf_param
containing the user provided parameters.
* If "fill_buf" is the benchmark that should be used by a test,
then the test parameter structure (struct resctrl_val_param)
will point to a fully initialized struct fill_buf_param. The
latter may contain (a) the user provided parameters verbatim,
(b) user provided parameters adjusted to be appropriate for
the test, or (c) the default parameters for "fill_buf" that
is appropriate for the test if the user did not provide
"fill_buf" parameters nor an alternate benchmark.
The existing behavior of CMT test is to use test defined value for the
buffer size even if the user provides another value via command line.
This behavior is maintained since the test requires that the buffer size
matches the size of the cache allocated, and the amount of cache
allocated can instead be changed by the user with the "-n" command line
parameter.
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
2024-10-24 14:18:47 -07:00
|
|
|
ret = check_results(param.fill_buf ? param.fill_buf->buf_size : 0);
|
2024-12-16 16:18:54 +01:00
|
|
|
if (ret && (get_vendor() == ARCH_INTEL) && !snc_kernel_support())
|
|
|
|
ksft_print_msg("Kernel doesn't support Sub-NUMA Clustering but it is enabled on the system.\n");
|
2020-01-16 13:32:39 -08:00
|
|
|
|
2023-04-13 16:22:59 +09:00
|
|
|
return ret;
|
2020-01-16 13:32:39 -08:00
|
|
|
}
|
2023-12-15 17:05:11 +02:00
|
|
|
|
|
|
|
static bool mbm_feature_check(const struct resctrl_test *test)
|
|
|
|
{
|
2024-02-16 09:35:28 +01:00
|
|
|
return resctrl_mon_feature_exists("L3_MON", "mbm_total_bytes") &&
|
|
|
|
resctrl_mon_feature_exists("L3_MON", "mbm_local_bytes");
|
2023-12-15 17:05:11 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
struct resctrl_test mbm_test = {
|
|
|
|
.name = "MBM",
|
|
|
|
.resource = "MB",
|
|
|
|
.vendor_specific = ARCH_INTEL,
|
|
|
|
.feature_check = mbm_feature_check,
|
|
|
|
.run_test = mbm_run_test,
|
2024-02-27 08:21:41 +01:00
|
|
|
.cleanup = mbm_test_cleanup,
|
2023-12-15 17:05:11 +02:00
|
|
|
};
|