2019-05-20 09:19:02 +02:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2011-11-02 13:39:38 -07:00
|
|
|
/*
|
|
|
|
* pps-gpio.c -- PPS client driver using GPIO
|
|
|
|
*
|
|
|
|
* Copyright (C) 2010 Ricardo Martins <rasm@fe.up.pt>
|
|
|
|
* Copyright (C) 2011 James Nuss <jamesnuss@nanometrics.ca>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define PPS_GPIO_NAME "pps-gpio"
|
|
|
|
#define pr_fmt(fmt) PPS_GPIO_NAME ": " fmt
|
|
|
|
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/interrupt.h>
|
2021-03-18 15:03:19 +02:00
|
|
|
#include <linux/mod_devicetable.h>
|
2011-11-02 13:39:38 -07:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/pps_kernel.h>
|
2019-05-14 15:45:40 -07:00
|
|
|
#include <linux/gpio/consumer.h>
|
2011-11-02 13:39:38 -07:00
|
|
|
#include <linux/list.h>
|
2021-03-18 15:03:19 +02:00
|
|
|
#include <linux/property.h>
|
2019-05-14 15:45:46 -07:00
|
|
|
#include <linux/timer.h>
|
|
|
|
#include <linux/jiffies.h>
|
2011-11-02 13:39:38 -07:00
|
|
|
|
|
|
|
/* Info for each registered platform device */
|
|
|
|
struct pps_gpio_device_data {
|
|
|
|
int irq; /* IRQ used as PPS source */
|
|
|
|
struct pps_device *pps; /* PPS source device */
|
|
|
|
struct pps_source_info info; /* PPS source information */
|
2019-05-14 15:45:40 -07:00
|
|
|
struct gpio_desc *gpio_pin; /* GPIO port descriptors */
|
2019-05-14 15:45:46 -07:00
|
|
|
struct gpio_desc *echo_pin;
|
|
|
|
struct timer_list echo_timer; /* timer to reset echo active state */
|
2013-07-03 15:09:12 -07:00
|
|
|
bool assert_falling_edge;
|
|
|
|
bool capture_clear;
|
2019-05-14 15:45:46 -07:00
|
|
|
unsigned int echo_active_ms; /* PPS echo active duration */
|
|
|
|
unsigned long echo_timeout; /* timer timeout value in jiffies */
|
2011-11-02 13:39:38 -07:00
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Report the PPS event
|
|
|
|
*/
|
|
|
|
|
|
|
|
static irqreturn_t pps_gpio_irq_handler(int irq, void *data)
|
|
|
|
{
|
|
|
|
const struct pps_gpio_device_data *info;
|
|
|
|
struct pps_event_time ts;
|
|
|
|
int rising_edge;
|
|
|
|
|
|
|
|
/* Get the time stamp first */
|
|
|
|
pps_get_ts(&ts);
|
|
|
|
|
|
|
|
info = data;
|
|
|
|
|
2025-01-08 16:30:12 +01:00
|
|
|
/* Small trick to bypass the check on edge's direction when capture_clear is unset */
|
|
|
|
rising_edge = info->capture_clear ?
|
|
|
|
gpiod_get_value(info->gpio_pin) : !info->assert_falling_edge;
|
2013-07-03 15:09:12 -07:00
|
|
|
if ((rising_edge && !info->assert_falling_edge) ||
|
|
|
|
(!rising_edge && info->assert_falling_edge))
|
2019-05-14 15:45:46 -07:00
|
|
|
pps_event(info->pps, &ts, PPS_CAPTUREASSERT, data);
|
2013-07-03 15:09:12 -07:00
|
|
|
else if (info->capture_clear &&
|
|
|
|
((rising_edge && info->assert_falling_edge) ||
|
2019-05-14 15:45:40 -07:00
|
|
|
(!rising_edge && !info->assert_falling_edge)))
|
2019-05-14 15:45:46 -07:00
|
|
|
pps_event(info->pps, &ts, PPS_CAPTURECLEAR, data);
|
2025-01-08 16:30:12 +01:00
|
|
|
else
|
|
|
|
dev_warn_ratelimited(&info->pps->dev, "IRQ did not trigger any PPS event\n");
|
2011-11-02 13:39:38 -07:00
|
|
|
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
2019-05-14 15:45:46 -07:00
|
|
|
/* This function will only be called when an ECHO GPIO is defined */
|
|
|
|
static void pps_gpio_echo(struct pps_device *pps, int event, void *data)
|
|
|
|
{
|
|
|
|
/* add_timer() needs to write into info->echo_timer */
|
|
|
|
struct pps_gpio_device_data *info = data;
|
|
|
|
|
|
|
|
switch (event) {
|
|
|
|
case PPS_CAPTUREASSERT:
|
|
|
|
if (pps->params.mode & PPS_ECHOASSERT)
|
|
|
|
gpiod_set_value(info->echo_pin, 1);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case PPS_CAPTURECLEAR:
|
|
|
|
if (pps->params.mode & PPS_ECHOCLEAR)
|
|
|
|
gpiod_set_value(info->echo_pin, 1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* fire the timer */
|
|
|
|
if (info->pps->params.mode & (PPS_ECHOASSERT | PPS_ECHOCLEAR)) {
|
|
|
|
info->echo_timer.expires = jiffies + info->echo_timeout;
|
|
|
|
add_timer(&info->echo_timer);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Timer callback to reset the echo pin to the inactive state */
|
|
|
|
static void pps_gpio_echo_timer_callback(struct timer_list *t)
|
|
|
|
{
|
|
|
|
const struct pps_gpio_device_data *info;
|
|
|
|
|
2025-05-09 07:51:14 +02:00
|
|
|
info = timer_container_of(info, t, echo_timer);
|
2019-05-14 15:45:46 -07:00
|
|
|
|
|
|
|
gpiod_set_value(info->echo_pin, 0);
|
|
|
|
}
|
|
|
|
|
2021-03-18 15:03:20 +02:00
|
|
|
static int pps_gpio_setup(struct device *dev)
|
2019-05-14 15:45:40 -07:00
|
|
|
{
|
2021-03-18 15:03:20 +02:00
|
|
|
struct pps_gpio_device_data *data = dev_get_drvdata(dev);
|
2019-05-14 15:45:46 -07:00
|
|
|
int ret;
|
|
|
|
u32 value;
|
2019-05-14 15:45:40 -07:00
|
|
|
|
2021-03-18 15:03:20 +02:00
|
|
|
data->gpio_pin = devm_gpiod_get(dev, NULL, GPIOD_IN);
|
2021-03-18 15:03:16 +02:00
|
|
|
if (IS_ERR(data->gpio_pin))
|
2021-03-18 15:03:20 +02:00
|
|
|
return dev_err_probe(dev, PTR_ERR(data->gpio_pin),
|
2021-03-18 15:03:16 +02:00
|
|
|
"failed to request PPS GPIO\n");
|
2019-05-14 15:45:40 -07:00
|
|
|
|
2021-03-18 15:03:21 +02:00
|
|
|
data->assert_falling_edge =
|
|
|
|
device_property_read_bool(dev, "assert-falling-edge");
|
|
|
|
|
2021-03-18 15:03:20 +02:00
|
|
|
data->echo_pin = devm_gpiod_get_optional(dev, "echo", GPIOD_OUT_LOW);
|
2021-03-18 15:03:16 +02:00
|
|
|
if (IS_ERR(data->echo_pin))
|
2021-03-18 15:03:20 +02:00
|
|
|
return dev_err_probe(dev, PTR_ERR(data->echo_pin),
|
2021-03-18 15:03:16 +02:00
|
|
|
"failed to request ECHO GPIO\n");
|
2019-05-14 15:45:46 -07:00
|
|
|
|
2021-03-18 15:03:21 +02:00
|
|
|
if (!data->echo_pin)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
ret = device_property_read_u32(dev, "echo-active-ms", &value);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(dev, "failed to get echo-active-ms from FW\n");
|
|
|
|
return ret;
|
2019-05-14 15:45:46 -07:00
|
|
|
}
|
|
|
|
|
2021-03-18 15:03:21 +02:00
|
|
|
/* sanity check on echo_active_ms */
|
|
|
|
if (!value || value > 999) {
|
|
|
|
dev_err(dev, "echo-active-ms: %u - bad value from FW\n", value);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
data->echo_active_ms = value;
|
|
|
|
|
2019-05-14 15:45:40 -07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-11-02 13:39:38 -07:00
|
|
|
static unsigned long
|
2013-07-03 15:09:12 -07:00
|
|
|
get_irqf_trigger_flags(const struct pps_gpio_device_data *data)
|
2011-11-02 13:39:38 -07:00
|
|
|
{
|
2013-07-03 15:09:12 -07:00
|
|
|
unsigned long flags = data->assert_falling_edge ?
|
2011-11-02 13:39:38 -07:00
|
|
|
IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING;
|
|
|
|
|
2013-07-03 15:09:12 -07:00
|
|
|
if (data->capture_clear) {
|
2011-11-02 13:39:38 -07:00
|
|
|
flags |= ((flags & IRQF_TRIGGER_RISING) ?
|
|
|
|
IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING);
|
|
|
|
}
|
|
|
|
|
|
|
|
return flags;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int pps_gpio_probe(struct platform_device *pdev)
|
|
|
|
{
|
|
|
|
struct pps_gpio_device_data *data;
|
2021-03-18 15:03:20 +02:00
|
|
|
struct device *dev = &pdev->dev;
|
2011-11-02 13:39:38 -07:00
|
|
|
int ret;
|
|
|
|
int pps_default_params;
|
2013-07-03 15:09:12 -07:00
|
|
|
|
|
|
|
/* allocate space for device info */
|
2021-03-18 15:03:20 +02:00
|
|
|
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
|
2013-07-03 15:09:12 -07:00
|
|
|
if (!data)
|
|
|
|
return -ENOMEM;
|
2021-03-18 15:03:20 +02:00
|
|
|
|
|
|
|
dev_set_drvdata(dev, data);
|
2011-11-02 13:39:38 -07:00
|
|
|
|
2019-05-14 15:45:40 -07:00
|
|
|
/* GPIO setup */
|
2021-03-18 15:03:20 +02:00
|
|
|
ret = pps_gpio_setup(dev);
|
2021-03-18 15:03:18 +02:00
|
|
|
if (ret)
|
2022-01-12 14:52:14 -06:00
|
|
|
return ret;
|
2011-11-02 13:39:38 -07:00
|
|
|
|
|
|
|
/* IRQ setup */
|
2019-05-14 15:45:40 -07:00
|
|
|
ret = gpiod_to_irq(data->gpio_pin);
|
2013-07-03 15:09:12 -07:00
|
|
|
if (ret < 0) {
|
2021-03-18 15:03:20 +02:00
|
|
|
dev_err(dev, "failed to map GPIO to IRQ: %d\n", ret);
|
2013-07-03 15:09:10 -07:00
|
|
|
return -EINVAL;
|
2011-11-02 13:39:38 -07:00
|
|
|
}
|
2013-07-03 15:09:12 -07:00
|
|
|
data->irq = ret;
|
2011-11-02 13:39:38 -07:00
|
|
|
|
|
|
|
/* initialize PPS specific parts of the bookkeeping data structure. */
|
|
|
|
data->info.mode = PPS_CAPTUREASSERT | PPS_OFFSETASSERT |
|
|
|
|
PPS_ECHOASSERT | PPS_CANWAIT | PPS_TSFMT_TSPEC;
|
2013-07-03 15:09:12 -07:00
|
|
|
if (data->capture_clear)
|
2011-11-02 13:39:38 -07:00
|
|
|
data->info.mode |= PPS_CAPTURECLEAR | PPS_OFFSETCLEAR |
|
|
|
|
PPS_ECHOCLEAR;
|
|
|
|
data->info.owner = THIS_MODULE;
|
|
|
|
snprintf(data->info.name, PPS_MAX_NAME_LEN - 1, "%s.%d",
|
|
|
|
pdev->name, pdev->id);
|
2019-05-14 15:45:46 -07:00
|
|
|
if (data->echo_pin) {
|
|
|
|
data->info.echo = pps_gpio_echo;
|
|
|
|
data->echo_timeout = msecs_to_jiffies(data->echo_active_ms);
|
|
|
|
timer_setup(&data->echo_timer, pps_gpio_echo_timer_callback, 0);
|
|
|
|
}
|
2011-11-02 13:39:38 -07:00
|
|
|
|
|
|
|
/* register PPS source */
|
|
|
|
pps_default_params = PPS_CAPTUREASSERT | PPS_OFFSETASSERT;
|
2013-07-03 15:09:12 -07:00
|
|
|
if (data->capture_clear)
|
2011-11-02 13:39:38 -07:00
|
|
|
pps_default_params |= PPS_CAPTURECLEAR | PPS_OFFSETCLEAR;
|
|
|
|
data->pps = pps_register_source(&data->info, pps_default_params);
|
2018-11-26 18:24:22 +08:00
|
|
|
if (IS_ERR(data->pps)) {
|
2021-03-18 15:03:20 +02:00
|
|
|
dev_err(dev, "failed to register IRQ %d as PPS source\n",
|
2013-07-03 15:09:12 -07:00
|
|
|
data->irq);
|
2018-11-26 18:24:22 +08:00
|
|
|
return PTR_ERR(data->pps);
|
2011-11-02 13:39:38 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* register IRQ interrupt handler */
|
2025-05-27 05:33:55 +00:00
|
|
|
ret = request_irq(data->irq, pps_gpio_irq_handler,
|
|
|
|
get_irqf_trigger_flags(data), data->info.name, data);
|
2011-11-02 13:39:38 -07:00
|
|
|
if (ret) {
|
|
|
|
pps_unregister_source(data->pps);
|
2021-03-18 15:03:20 +02:00
|
|
|
dev_err(dev, "failed to acquire IRQ %d\n", data->irq);
|
2013-07-03 15:09:10 -07:00
|
|
|
return -EINVAL;
|
2011-11-02 13:39:38 -07:00
|
|
|
}
|
|
|
|
|
pps: Fix a use-after-free
On a board running ntpd and gpsd, I'm seeing a consistent use-after-free
in sys_exit() from gpsd when rebooting:
pps pps1: removed
------------[ cut here ]------------
kobject: '(null)' (00000000db4bec24): is not initialized, yet kobject_put() is being called.
WARNING: CPU: 2 PID: 440 at lib/kobject.c:734 kobject_put+0x120/0x150
CPU: 2 UID: 299 PID: 440 Comm: gpsd Not tainted 6.11.0-rc6-00308-gb31c44928842 #1
Hardware name: Raspberry Pi 4 Model B Rev 1.1 (DT)
pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : kobject_put+0x120/0x150
lr : kobject_put+0x120/0x150
sp : ffffffc0803d3ae0
x29: ffffffc0803d3ae0 x28: ffffff8042dc9738 x27: 0000000000000001
x26: 0000000000000000 x25: ffffff8042dc9040 x24: ffffff8042dc9440
x23: ffffff80402a4620 x22: ffffff8042ef4bd0 x21: ffffff80405cb600
x20: 000000000008001b x19: ffffff8040b3b6e0 x18: 0000000000000000
x17: 0000000000000000 x16: 0000000000000000 x15: 696e6920746f6e20
x14: 7369203a29343263 x13: 205d303434542020 x12: 0000000000000000
x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000
x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000
x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000
x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000
Call trace:
kobject_put+0x120/0x150
cdev_put+0x20/0x3c
__fput+0x2c4/0x2d8
____fput+0x1c/0x38
task_work_run+0x70/0xfc
do_exit+0x2a0/0x924
do_group_exit+0x34/0x90
get_signal+0x7fc/0x8c0
do_signal+0x128/0x13b4
do_notify_resume+0xdc/0x160
el0_svc+0xd4/0xf8
el0t_64_sync_handler+0x140/0x14c
el0t_64_sync+0x190/0x194
---[ end trace 0000000000000000 ]---
...followed by more symptoms of corruption, with similar stacks:
refcount_t: underflow; use-after-free.
kernel BUG at lib/list_debug.c:62!
Kernel panic - not syncing: Oops - BUG: Fatal exception
This happens because pps_device_destruct() frees the pps_device with the
embedded cdev immediately after calling cdev_del(), but, as the comment
above cdev_del() notes, fops for previously opened cdevs are still
callable even after cdev_del() returns. I think this bug has always
been there: I can't explain why it suddenly started happening every time
I reboot this particular board.
In commit d953e0e837e6 ("pps: Fix a use-after free bug when
unregistering a source."), George Spelvin suggested removing the
embedded cdev. That seems like the simplest way to fix this, so I've
implemented his suggestion, using __register_chrdev() with pps_idr
becoming the source of truth for which minor corresponds to which
device.
But now that pps_idr defines userspace visibility instead of cdev_add(),
we need to be sure the pps->dev refcount can't reach zero while
userspace can still find it again. So, the idr_remove() call moves to
pps_unregister_cdev(), and pps_idr now holds a reference to pps->dev.
pps_core: source serial1 got cdev (251:1)
<...>
pps pps1: removed
pps_core: unregistering pps1
pps_core: deallocating pps1
Fixes: d953e0e837e6 ("pps: Fix a use-after free bug when unregistering a source.")
Cc: stable@vger.kernel.org
Signed-off-by: Calvin Owens <calvin@wbinvd.org>
Reviewed-by: Michal Schmidt <mschmidt@redhat.com>
Link: https://lore.kernel.org/r/a17975fd5ae99385791929e563f72564edbcf28f.1731383727.git.calvin@wbinvd.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-11-11 20:13:29 -08:00
|
|
|
dev_dbg(&data->pps->dev, "Registered IRQ %d as PPS source\n",
|
|
|
|
data->irq);
|
2011-11-02 13:39:38 -07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2024-03-08 09:51:15 +01:00
|
|
|
static void pps_gpio_remove(struct platform_device *pdev)
|
2011-11-02 13:39:38 -07:00
|
|
|
{
|
|
|
|
struct pps_gpio_device_data *data = platform_get_drvdata(pdev);
|
|
|
|
|
2025-05-27 05:33:55 +00:00
|
|
|
free_irq(data->irq, data);
|
2011-11-02 13:39:38 -07:00
|
|
|
pps_unregister_source(data->pps);
|
2025-04-05 10:17:26 +02:00
|
|
|
timer_delete_sync(&data->echo_timer);
|
2021-03-18 15:03:17 +02:00
|
|
|
/* reset echo pin in any case */
|
|
|
|
gpiod_set_value(data->echo_pin, 0);
|
2013-07-03 15:09:12 -07:00
|
|
|
dev_info(&pdev->dev, "removed IRQ %d as PPS source\n", data->irq);
|
2011-11-02 13:39:38 -07:00
|
|
|
}
|
|
|
|
|
2013-07-03 15:09:12 -07:00
|
|
|
static const struct of_device_id pps_gpio_dt_ids[] = {
|
|
|
|
{ .compatible = "pps-gpio", },
|
|
|
|
{ /* sentinel */ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, pps_gpio_dt_ids);
|
|
|
|
|
2011-11-02 13:39:38 -07:00
|
|
|
static struct platform_driver pps_gpio_driver = {
|
|
|
|
.probe = pps_gpio_probe,
|
2024-12-01 15:12:43 -08:00
|
|
|
.remove = pps_gpio_remove,
|
2011-11-02 13:39:38 -07:00
|
|
|
.driver = {
|
|
|
|
.name = PPS_GPIO_NAME,
|
2013-11-12 15:11:33 -08:00
|
|
|
.of_match_table = pps_gpio_dt_ids,
|
2011-11-02 13:39:38 -07:00
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2013-07-03 15:09:10 -07:00
|
|
|
module_platform_driver(pps_gpio_driver);
|
2011-11-02 13:39:38 -07:00
|
|
|
MODULE_AUTHOR("Ricardo Martins <rasm@fe.up.pt>");
|
|
|
|
MODULE_AUTHOR("James Nuss <jamesnuss@nanometrics.ca>");
|
|
|
|
MODULE_DESCRIPTION("Use GPIO pin as PPS source");
|
|
|
|
MODULE_LICENSE("GPL");
|
2019-05-14 15:45:46 -07:00
|
|
|
MODULE_VERSION("1.2.0");
|