2018-04-22 17:33:20 -04:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
2013-06-04 11:22:30 -03:00
|
|
|
/*
|
|
|
|
* vsp1_uds.c -- R-Car VSP1 Up and Down Scaler
|
|
|
|
*
|
2014-02-06 14:42:31 -03:00
|
|
|
* Copyright (C) 2013-2014 Renesas Electronics Corporation
|
2013-06-04 11:22:30 -03:00
|
|
|
*
|
|
|
|
* Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/gfp.h>
|
|
|
|
|
|
|
|
#include <media/v4l2-subdev.h>
|
|
|
|
|
|
|
|
#include "vsp1.h"
|
2015-11-22 20:29:25 -02:00
|
|
|
#include "vsp1_dl.h"
|
2025-04-30 02:29:00 +03:00
|
|
|
#include "vsp1_entity.h"
|
2016-09-11 23:26:35 -03:00
|
|
|
#include "vsp1_pipe.h"
|
2013-06-04 11:22:30 -03:00
|
|
|
#include "vsp1_uds.h"
|
|
|
|
|
|
|
|
#define UDS_MIN_SIZE 4U
|
|
|
|
#define UDS_MAX_SIZE 8190U
|
|
|
|
|
|
|
|
#define UDS_MIN_FACTOR 0x0100
|
|
|
|
#define UDS_MAX_FACTOR 0xffff
|
|
|
|
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* Device Access
|
|
|
|
*/
|
|
|
|
|
2018-05-18 16:42:02 -04:00
|
|
|
static inline void vsp1_uds_write(struct vsp1_uds *uds,
|
|
|
|
struct vsp1_dl_body *dlb, u32 reg, u32 data)
|
2013-06-04 11:22:30 -03:00
|
|
|
{
|
2018-05-18 16:42:02 -04:00
|
|
|
vsp1_dl_body_write(dlb, reg + uds->entity.index * VI6_UDS_OFFSET, data);
|
2013-06-04 11:22:30 -03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* Scaling Computation
|
|
|
|
*/
|
|
|
|
|
2018-05-18 16:42:02 -04:00
|
|
|
void vsp1_uds_set_alpha(struct vsp1_entity *entity, struct vsp1_dl_body *dlb,
|
2015-11-22 20:29:25 -02:00
|
|
|
unsigned int alpha)
|
2014-05-30 21:45:48 -03:00
|
|
|
{
|
2016-06-19 23:19:43 -03:00
|
|
|
struct vsp1_uds *uds = to_uds(&entity->subdev);
|
|
|
|
|
2018-05-18 16:42:02 -04:00
|
|
|
vsp1_uds_write(uds, dlb, VI6_UDS_ALPVAL,
|
2015-11-22 20:29:25 -02:00
|
|
|
alpha << VI6_UDS_ALPVAL_VAL0_SHIFT);
|
2014-05-30 21:45:48 -03:00
|
|
|
}
|
|
|
|
|
2013-06-04 11:22:30 -03:00
|
|
|
/*
|
|
|
|
* uds_output_size - Return the output size for an input size and scaling ratio
|
|
|
|
* @input: input size in pixels
|
|
|
|
* @ratio: scaling ratio in U4.12 fixed-point format
|
|
|
|
*/
|
|
|
|
static unsigned int uds_output_size(unsigned int input, unsigned int ratio)
|
|
|
|
{
|
|
|
|
if (ratio > 4096) {
|
|
|
|
/* Down-scaling */
|
|
|
|
unsigned int mp;
|
|
|
|
|
|
|
|
mp = ratio / 4096;
|
|
|
|
mp = mp < 4 ? 1 : (mp < 8 ? 2 : 4);
|
|
|
|
|
|
|
|
return (input - 1) / mp * mp * 4096 / ratio + 1;
|
|
|
|
} else {
|
|
|
|
/* Up-scaling */
|
|
|
|
return (input - 1) * 4096 / ratio + 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* uds_output_limits - Return the min and max output sizes for an input size
|
|
|
|
* @input: input size in pixels
|
|
|
|
* @minimum: minimum output size (returned)
|
|
|
|
* @maximum: maximum output size (returned)
|
|
|
|
*/
|
|
|
|
static void uds_output_limits(unsigned int input,
|
|
|
|
unsigned int *minimum, unsigned int *maximum)
|
|
|
|
{
|
|
|
|
*minimum = max(uds_output_size(input, UDS_MAX_FACTOR), UDS_MIN_SIZE);
|
|
|
|
*maximum = min(uds_output_size(input, UDS_MIN_FACTOR), UDS_MAX_SIZE);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* uds_passband_width - Return the passband filter width for a scaling ratio
|
|
|
|
* @ratio: scaling ratio in U4.12 fixed-point format
|
|
|
|
*/
|
|
|
|
static unsigned int uds_passband_width(unsigned int ratio)
|
|
|
|
{
|
|
|
|
if (ratio >= 4096) {
|
|
|
|
/* Down-scaling */
|
|
|
|
unsigned int mp;
|
|
|
|
|
|
|
|
mp = ratio / 4096;
|
|
|
|
mp = mp < 4 ? 1 : (mp < 8 ? 2 : 4);
|
|
|
|
|
|
|
|
return 64 * 4096 * mp / ratio;
|
|
|
|
} else {
|
|
|
|
/* Up-scaling */
|
|
|
|
return 64;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int uds_compute_ratio(unsigned int input, unsigned int output)
|
|
|
|
{
|
|
|
|
/* TODO: This is an approximation that will need to be refined. */
|
|
|
|
return (input - 1) * 4096 / (output - 1);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* V4L2 Subdevice Pad Operations
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int uds_enum_mbus_code(struct v4l2_subdev *subdev,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 17:55:58 +03:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2013-06-04 11:22:30 -03:00
|
|
|
struct v4l2_subdev_mbus_code_enum *code)
|
|
|
|
{
|
|
|
|
static const unsigned int codes[] = {
|
2014-11-10 14:28:31 -03:00
|
|
|
MEDIA_BUS_FMT_ARGB8888_1X32,
|
|
|
|
MEDIA_BUS_FMT_AYUV8_1X32,
|
2013-06-04 11:22:30 -03:00
|
|
|
};
|
|
|
|
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 17:55:58 +03:00
|
|
|
return vsp1_subdev_enum_mbus_code(subdev, sd_state, code, codes,
|
2016-02-24 20:25:42 -03:00
|
|
|
ARRAY_SIZE(codes));
|
2013-06-04 11:22:30 -03:00
|
|
|
}
|
|
|
|
|
|
|
|
static int uds_enum_frame_size(struct v4l2_subdev *subdev,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 17:55:58 +03:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2013-06-04 11:22:30 -03:00
|
|
|
struct v4l2_subdev_frame_size_enum *fse)
|
|
|
|
{
|
2015-03-04 01:47:58 -08:00
|
|
|
struct vsp1_uds *uds = to_uds(subdev);
|
2023-11-26 03:37:15 +02:00
|
|
|
struct v4l2_subdev_state *state;
|
2013-06-04 11:22:30 -03:00
|
|
|
struct v4l2_mbus_framefmt *format;
|
2016-06-26 08:09:31 -03:00
|
|
|
int ret = 0;
|
2013-06-04 11:22:30 -03:00
|
|
|
|
2023-11-26 03:37:15 +02:00
|
|
|
state = vsp1_entity_get_state(&uds->entity, sd_state, fse->which);
|
|
|
|
if (!state)
|
2015-11-15 19:14:22 -02:00
|
|
|
return -EINVAL;
|
|
|
|
|
2023-11-12 04:14:05 +02:00
|
|
|
format = v4l2_subdev_state_get_format(state, UDS_PAD_SINK);
|
2013-06-04 11:22:30 -03:00
|
|
|
|
2016-06-26 08:09:31 -03:00
|
|
|
mutex_lock(&uds->entity.lock);
|
|
|
|
|
|
|
|
if (fse->index || fse->code != format->code) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto done;
|
|
|
|
}
|
2013-06-04 11:22:30 -03:00
|
|
|
|
|
|
|
if (fse->pad == UDS_PAD_SINK) {
|
|
|
|
fse->min_width = UDS_MIN_SIZE;
|
|
|
|
fse->max_width = UDS_MAX_SIZE;
|
|
|
|
fse->min_height = UDS_MIN_SIZE;
|
|
|
|
fse->max_height = UDS_MAX_SIZE;
|
|
|
|
} else {
|
|
|
|
uds_output_limits(format->width, &fse->min_width,
|
|
|
|
&fse->max_width);
|
|
|
|
uds_output_limits(format->height, &fse->min_height,
|
|
|
|
&fse->max_height);
|
|
|
|
}
|
|
|
|
|
2016-06-26 08:09:31 -03:00
|
|
|
done:
|
|
|
|
mutex_unlock(&uds->entity.lock);
|
|
|
|
return ret;
|
2013-06-04 11:22:30 -03:00
|
|
|
}
|
|
|
|
|
2015-11-01 15:18:32 -02:00
|
|
|
static void uds_try_format(struct vsp1_uds *uds,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 17:55:58 +03:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2015-11-15 19:14:22 -02:00
|
|
|
unsigned int pad, struct v4l2_mbus_framefmt *fmt)
|
2013-06-04 11:22:30 -03:00
|
|
|
{
|
|
|
|
struct v4l2_mbus_framefmt *format;
|
|
|
|
unsigned int minimum;
|
|
|
|
unsigned int maximum;
|
|
|
|
|
|
|
|
switch (pad) {
|
|
|
|
case UDS_PAD_SINK:
|
|
|
|
/* Default to YUV if the requested format is not supported. */
|
2014-11-10 14:28:31 -03:00
|
|
|
if (fmt->code != MEDIA_BUS_FMT_ARGB8888_1X32 &&
|
|
|
|
fmt->code != MEDIA_BUS_FMT_AYUV8_1X32)
|
|
|
|
fmt->code = MEDIA_BUS_FMT_AYUV8_1X32;
|
2013-06-04 11:22:30 -03:00
|
|
|
|
2025-04-30 02:29:00 +03:00
|
|
|
vsp1_entity_adjust_color_space(fmt);
|
|
|
|
|
2013-06-04 11:22:30 -03:00
|
|
|
fmt->width = clamp(fmt->width, UDS_MIN_SIZE, UDS_MAX_SIZE);
|
|
|
|
fmt->height = clamp(fmt->height, UDS_MIN_SIZE, UDS_MAX_SIZE);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case UDS_PAD_SOURCE:
|
|
|
|
/* The UDS scales but can't perform format conversion. */
|
2023-11-12 04:14:05 +02:00
|
|
|
format = v4l2_subdev_state_get_format(sd_state, UDS_PAD_SINK);
|
2013-06-04 11:22:30 -03:00
|
|
|
fmt->code = format->code;
|
|
|
|
|
2025-04-30 02:29:00 +03:00
|
|
|
fmt->colorspace = format->colorspace;
|
|
|
|
fmt->xfer_func = format->xfer_func;
|
|
|
|
fmt->ycbcr_enc = format->ycbcr_enc;
|
|
|
|
fmt->quantization = format->quantization;
|
|
|
|
|
2013-06-04 11:22:30 -03:00
|
|
|
uds_output_limits(format->width, &minimum, &maximum);
|
|
|
|
fmt->width = clamp(fmt->width, minimum, maximum);
|
|
|
|
uds_output_limits(format->height, &minimum, &maximum);
|
|
|
|
fmt->height = clamp(fmt->height, minimum, maximum);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
fmt->field = V4L2_FIELD_NONE;
|
|
|
|
}
|
|
|
|
|
2015-11-01 15:18:32 -02:00
|
|
|
static int uds_set_format(struct v4l2_subdev *subdev,
|
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 17:55:58 +03:00
|
|
|
struct v4l2_subdev_state *sd_state,
|
2013-06-04 11:22:30 -03:00
|
|
|
struct v4l2_subdev_format *fmt)
|
|
|
|
{
|
|
|
|
struct vsp1_uds *uds = to_uds(subdev);
|
2023-11-26 03:37:15 +02:00
|
|
|
struct v4l2_subdev_state *state;
|
2013-06-04 11:22:30 -03:00
|
|
|
struct v4l2_mbus_framefmt *format;
|
2016-06-26 08:09:31 -03:00
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
mutex_lock(&uds->entity.lock);
|
2013-06-04 11:22:30 -03:00
|
|
|
|
2023-11-26 03:37:15 +02:00
|
|
|
state = vsp1_entity_get_state(&uds->entity, sd_state, fmt->which);
|
|
|
|
if (!state) {
|
2016-06-26 08:09:31 -03:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto done;
|
|
|
|
}
|
2015-11-15 19:14:22 -02:00
|
|
|
|
2023-11-26 03:37:15 +02:00
|
|
|
uds_try_format(uds, state, fmt->pad, &fmt->format);
|
2013-06-04 11:22:30 -03:00
|
|
|
|
2023-11-12 04:14:05 +02:00
|
|
|
format = v4l2_subdev_state_get_format(state, fmt->pad);
|
2013-06-04 11:22:30 -03:00
|
|
|
*format = fmt->format;
|
|
|
|
|
|
|
|
if (fmt->pad == UDS_PAD_SINK) {
|
|
|
|
/* Propagate the format to the source pad. */
|
2023-11-12 04:14:05 +02:00
|
|
|
format = v4l2_subdev_state_get_format(state, UDS_PAD_SOURCE);
|
2013-06-04 11:22:30 -03:00
|
|
|
*format = fmt->format;
|
|
|
|
|
2023-11-26 03:37:15 +02:00
|
|
|
uds_try_format(uds, state, UDS_PAD_SOURCE, format);
|
2013-06-04 11:22:30 -03:00
|
|
|
}
|
|
|
|
|
2016-06-26 08:09:31 -03:00
|
|
|
done:
|
|
|
|
mutex_unlock(&uds->entity.lock);
|
|
|
|
return ret;
|
2013-06-04 11:22:30 -03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* V4L2 Subdevice Operations
|
|
|
|
*/
|
|
|
|
|
2016-06-17 21:11:26 -03:00
|
|
|
static const struct v4l2_subdev_pad_ops uds_pad_ops = {
|
2013-06-04 11:22:30 -03:00
|
|
|
.enum_mbus_code = uds_enum_mbus_code,
|
|
|
|
.enum_frame_size = uds_enum_frame_size,
|
2016-02-24 21:10:13 -03:00
|
|
|
.get_fmt = vsp1_subdev_get_pad_format,
|
2013-06-04 11:22:30 -03:00
|
|
|
.set_fmt = uds_set_format,
|
|
|
|
};
|
|
|
|
|
2016-06-17 21:11:26 -03:00
|
|
|
static const struct v4l2_subdev_ops uds_ops = {
|
2013-06-04 11:22:30 -03:00
|
|
|
.pad = &uds_pad_ops,
|
|
|
|
};
|
|
|
|
|
2015-11-17 13:10:26 -02:00
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* VSP1 Entity Operations
|
|
|
|
*/
|
|
|
|
|
2018-05-18 16:42:01 -04:00
|
|
|
static void uds_configure_stream(struct vsp1_entity *entity,
|
2023-11-12 04:14:05 +02:00
|
|
|
struct v4l2_subdev_state *state,
|
2018-05-18 16:42:01 -04:00
|
|
|
struct vsp1_pipeline *pipe,
|
2019-03-11 20:13:43 +02:00
|
|
|
struct vsp1_dl_list *dl,
|
2018-05-18 16:42:02 -04:00
|
|
|
struct vsp1_dl_body *dlb)
|
2015-11-17 13:10:26 -02:00
|
|
|
{
|
|
|
|
struct vsp1_uds *uds = to_uds(&entity->subdev);
|
|
|
|
const struct v4l2_mbus_framefmt *output;
|
|
|
|
const struct v4l2_mbus_framefmt *input;
|
|
|
|
unsigned int hscale;
|
|
|
|
unsigned int vscale;
|
|
|
|
bool multitap;
|
|
|
|
|
2023-11-12 04:14:05 +02:00
|
|
|
input = v4l2_subdev_state_get_format(state, UDS_PAD_SINK);
|
|
|
|
output = v4l2_subdev_state_get_format(state, UDS_PAD_SOURCE);
|
2017-08-04 12:32:42 -04:00
|
|
|
|
2015-11-17 13:10:26 -02:00
|
|
|
hscale = uds_compute_ratio(input->width, output->width);
|
|
|
|
vscale = uds_compute_ratio(input->height, output->height);
|
|
|
|
|
|
|
|
dev_dbg(uds->entity.vsp1->dev, "hscale %u vscale %u\n", hscale, vscale);
|
|
|
|
|
2017-02-26 10:29:50 -03:00
|
|
|
/*
|
|
|
|
* Multi-tap scaling can't be enabled along with alpha scaling when
|
2015-11-17 13:10:26 -02:00
|
|
|
* scaling down with a factor lower than or equal to 1/2 in either
|
|
|
|
* direction.
|
|
|
|
*/
|
|
|
|
if (uds->scale_alpha && (hscale >= 8192 || vscale >= 8192))
|
|
|
|
multitap = false;
|
|
|
|
else
|
|
|
|
multitap = true;
|
|
|
|
|
2018-05-18 16:42:02 -04:00
|
|
|
vsp1_uds_write(uds, dlb, VI6_UDS_CTRL,
|
2015-11-17 13:10:26 -02:00
|
|
|
(uds->scale_alpha ? VI6_UDS_CTRL_AON : 0) |
|
|
|
|
(multitap ? VI6_UDS_CTRL_BC : 0));
|
|
|
|
|
2018-05-18 16:42:02 -04:00
|
|
|
vsp1_uds_write(uds, dlb, VI6_UDS_PASS_BWIDTH,
|
2015-11-17 13:10:26 -02:00
|
|
|
(uds_passband_width(hscale)
|
|
|
|
<< VI6_UDS_PASS_BWIDTH_H_SHIFT) |
|
|
|
|
(uds_passband_width(vscale)
|
|
|
|
<< VI6_UDS_PASS_BWIDTH_V_SHIFT));
|
|
|
|
|
2016-09-11 23:26:35 -03:00
|
|
|
/* Set the scaling ratios. */
|
2018-05-18 16:42:02 -04:00
|
|
|
vsp1_uds_write(uds, dlb, VI6_UDS_SCALE,
|
2015-11-17 13:10:26 -02:00
|
|
|
(hscale << VI6_UDS_SCALE_HFRAC_SHIFT) |
|
|
|
|
(vscale << VI6_UDS_SCALE_VFRAC_SHIFT));
|
|
|
|
}
|
|
|
|
|
2018-05-18 16:42:01 -04:00
|
|
|
static void uds_configure_partition(struct vsp1_entity *entity,
|
|
|
|
struct vsp1_pipeline *pipe,
|
2023-11-15 00:34:56 +02:00
|
|
|
const struct vsp1_partition *partition,
|
2018-05-18 16:42:02 -04:00
|
|
|
struct vsp1_dl_list *dl,
|
|
|
|
struct vsp1_dl_body *dlb)
|
2018-05-18 16:42:01 -04:00
|
|
|
{
|
|
|
|
struct vsp1_uds *uds = to_uds(&entity->subdev);
|
|
|
|
|
2018-08-31 10:40:44 -04:00
|
|
|
/* Input size clipping. */
|
2018-05-18 16:42:02 -04:00
|
|
|
vsp1_uds_write(uds, dlb, VI6_UDS_HSZCLIP, VI6_UDS_HSZCLIP_HCEN |
|
2018-05-18 16:42:01 -04:00
|
|
|
(0 << VI6_UDS_HSZCLIP_HCL_OFST_SHIFT) |
|
|
|
|
(partition->uds_sink.width
|
|
|
|
<< VI6_UDS_HSZCLIP_HCL_SIZE_SHIFT));
|
|
|
|
|
2018-08-31 10:40:44 -04:00
|
|
|
/* Output size clipping. */
|
2018-05-18 16:42:02 -04:00
|
|
|
vsp1_uds_write(uds, dlb, VI6_UDS_CLIP_SIZE,
|
2018-05-18 16:42:01 -04:00
|
|
|
(partition->uds_source.width
|
|
|
|
<< VI6_UDS_CLIP_SIZE_HSIZE_SHIFT) |
|
2023-11-14 00:53:07 +02:00
|
|
|
(partition->uds_source.height
|
2018-05-18 16:42:01 -04:00
|
|
|
<< VI6_UDS_CLIP_SIZE_VSIZE_SHIFT));
|
|
|
|
}
|
|
|
|
|
2016-07-12 10:06:34 -03:00
|
|
|
static unsigned int uds_max_width(struct vsp1_entity *entity,
|
2023-11-12 04:14:05 +02:00
|
|
|
struct v4l2_subdev_state *state,
|
2016-07-12 10:06:34 -03:00
|
|
|
struct vsp1_pipeline *pipe)
|
|
|
|
{
|
|
|
|
const struct v4l2_mbus_framefmt *output;
|
|
|
|
const struct v4l2_mbus_framefmt *input;
|
|
|
|
unsigned int hscale;
|
|
|
|
|
2023-11-12 04:14:05 +02:00
|
|
|
input = v4l2_subdev_state_get_format(state, UDS_PAD_SINK);
|
|
|
|
output = v4l2_subdev_state_get_format(state, UDS_PAD_SOURCE);
|
2016-07-12 10:06:34 -03:00
|
|
|
hscale = output->width / input->width;
|
|
|
|
|
2018-09-14 10:26:52 -04:00
|
|
|
/*
|
|
|
|
* The maximum width of the UDS is 304 pixels. These are input pixels
|
|
|
|
* in the event of up-scaling, and output pixels in the event of
|
|
|
|
* downscaling.
|
|
|
|
*
|
|
|
|
* To support overlapping partition windows we clamp at units of 256 and
|
|
|
|
* the remaining pixels are reserved.
|
|
|
|
*/
|
2016-07-12 10:06:34 -03:00
|
|
|
if (hscale <= 2)
|
|
|
|
return 256;
|
|
|
|
else if (hscale <= 4)
|
|
|
|
return 512;
|
|
|
|
else if (hscale <= 8)
|
|
|
|
return 1024;
|
|
|
|
else
|
|
|
|
return 2048;
|
|
|
|
}
|
|
|
|
|
2017-08-04 12:32:44 -04:00
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* Partition Algorithm Support
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void uds_partition(struct vsp1_entity *entity,
|
2023-11-12 04:14:05 +02:00
|
|
|
struct v4l2_subdev_state *state,
|
2017-08-04 12:32:44 -04:00
|
|
|
struct vsp1_pipeline *pipe,
|
|
|
|
struct vsp1_partition *partition,
|
|
|
|
unsigned int partition_idx,
|
2023-11-14 00:53:07 +02:00
|
|
|
struct v4l2_rect *window)
|
2017-08-04 12:32:44 -04:00
|
|
|
{
|
|
|
|
const struct v4l2_mbus_framefmt *output;
|
|
|
|
const struct v4l2_mbus_framefmt *input;
|
|
|
|
|
2023-11-12 04:14:05 +02:00
|
|
|
input = v4l2_subdev_state_get_format(state, UDS_PAD_SINK);
|
|
|
|
output = v4l2_subdev_state_get_format(state, UDS_PAD_SOURCE);
|
2017-08-04 12:32:44 -04:00
|
|
|
|
|
|
|
partition->uds_sink.width = window->width * input->width
|
|
|
|
/ output->width;
|
|
|
|
partition->uds_sink.left = window->left * input->width
|
|
|
|
/ output->width;
|
2023-11-14 00:53:07 +02:00
|
|
|
partition->uds_sink.height = input->height;
|
|
|
|
partition->uds_sink.top = 0;
|
|
|
|
|
|
|
|
partition->uds_source = *window;
|
2017-08-04 12:32:44 -04:00
|
|
|
|
|
|
|
*window = partition->uds_sink;
|
|
|
|
}
|
|
|
|
|
2015-11-17 13:10:26 -02:00
|
|
|
static const struct vsp1_entity_operations uds_entity_ops = {
|
2018-05-18 16:42:01 -04:00
|
|
|
.configure_stream = uds_configure_stream,
|
|
|
|
.configure_partition = uds_configure_partition,
|
2016-07-12 10:06:34 -03:00
|
|
|
.max_width = uds_max_width,
|
2017-08-04 12:32:44 -04:00
|
|
|
.partition = uds_partition,
|
2015-11-17 13:10:26 -02:00
|
|
|
};
|
|
|
|
|
2013-06-04 11:22:30 -03:00
|
|
|
/* -----------------------------------------------------------------------------
|
|
|
|
* Initialization and Cleanup
|
|
|
|
*/
|
|
|
|
|
|
|
|
struct vsp1_uds *vsp1_uds_create(struct vsp1_device *vsp1, unsigned int index)
|
|
|
|
{
|
|
|
|
struct vsp1_uds *uds;
|
2015-11-15 19:42:01 -02:00
|
|
|
char name[6];
|
2013-06-04 11:22:30 -03:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
uds = devm_kzalloc(vsp1->dev, sizeof(*uds), GFP_KERNEL);
|
|
|
|
if (uds == NULL)
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
|
2015-11-17 13:10:26 -02:00
|
|
|
uds->entity.ops = &uds_entity_ops;
|
2013-06-04 11:22:30 -03:00
|
|
|
uds->entity.type = VSP1_ENTITY_UDS;
|
|
|
|
uds->entity.index = index;
|
|
|
|
|
2015-11-15 19:42:01 -02:00
|
|
|
sprintf(name, "uds.%u", index);
|
2016-02-15 22:10:26 -02:00
|
|
|
ret = vsp1_entity_init(vsp1, &uds->entity, name, 2, &uds_ops,
|
|
|
|
MEDIA_ENT_F_PROC_VIDEO_SCALER);
|
2013-06-04 11:22:30 -03:00
|
|
|
if (ret < 0)
|
|
|
|
return ERR_PTR(ret);
|
|
|
|
|
|
|
|
return uds;
|
|
|
|
}
|