2023-06-02 16:41:47 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
/*
|
|
|
|
* Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/coresight.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/of.h>
|
|
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/pm_runtime.h>
|
|
|
|
|
|
|
|
#include "coresight-priv.h"
|
2024-11-21 14:28:29 +08:00
|
|
|
#include "coresight-trace-id.h"
|
2023-06-02 16:41:47 +08:00
|
|
|
|
|
|
|
struct dummy_drvdata {
|
|
|
|
struct device *dev;
|
|
|
|
struct coresight_device *csdev;
|
2024-11-21 14:28:29 +08:00
|
|
|
u8 traceid;
|
2023-06-02 16:41:47 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
DEFINE_CORESIGHT_DEVLIST(source_devs, "dummy_source");
|
|
|
|
DEFINE_CORESIGHT_DEVLIST(sink_devs, "dummy_sink");
|
|
|
|
|
|
|
|
static int dummy_source_enable(struct coresight_device *csdev,
|
2024-07-22 11:11:56 +01:00
|
|
|
struct perf_event *event, enum cs_mode mode,
|
2025-03-03 11:29:27 +08:00
|
|
|
__maybe_unused struct coresight_path *path)
|
2023-06-02 16:41:47 +08:00
|
|
|
{
|
2024-08-12 12:28:44 +08:00
|
|
|
if (!coresight_take_mode(csdev, mode))
|
|
|
|
return -EBUSY;
|
|
|
|
|
2023-06-02 16:41:47 +08:00
|
|
|
dev_dbg(csdev->dev.parent, "Dummy source enabled\n");
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dummy_source_disable(struct coresight_device *csdev,
|
|
|
|
struct perf_event *event)
|
|
|
|
{
|
2024-08-12 12:28:44 +08:00
|
|
|
coresight_set_mode(csdev, CS_MODE_DISABLED);
|
2023-06-02 16:41:47 +08:00
|
|
|
dev_dbg(csdev->dev.parent, "Dummy source disabled\n");
|
|
|
|
}
|
|
|
|
|
2025-03-03 11:29:23 +08:00
|
|
|
static int dummy_source_trace_id(struct coresight_device *csdev, __maybe_unused enum cs_mode mode,
|
|
|
|
__maybe_unused struct coresight_device *sink)
|
|
|
|
{
|
|
|
|
struct dummy_drvdata *drvdata;
|
|
|
|
|
|
|
|
drvdata = dev_get_drvdata(csdev->dev.parent);
|
|
|
|
|
|
|
|
return drvdata->traceid;
|
|
|
|
}
|
|
|
|
|
coresight: dummy: Update type of mode parameter in dummy_{sink,source}_enable()
Clang's kernel Control Flow Integrity (kCFI) is a compiler-based
security mitigation that ensures the target of an indirect function call
matches the expected type of the call and trapping if they do not match
exactly. The warning -Wincompatible-function-pointer-types-strict aims
to catch these issues at compile time, which reveals:
drivers/hwtracing/coresight/coresight-dummy.c:53:12: error: incompatible function pointer types initializing 'int (*)(struct coresight_device *, struct perf_event *, enum cs_mode)' with an expression of type 'int (struct coresight_device *, struct perf_event *, u32)' (aka 'int (struct coresight_device *, struct perf_event *, unsigned int)') [-Werror,-Wincompatible-function-pointer-types-strict]
53 | .enable = dummy_source_enable,
| ^~~~~~~~~~~~~~~~~~~
drivers/hwtracing/coresight/coresight-dummy.c:62:12: error: incompatible function pointer types initializing 'int (*)(struct coresight_device *, enum cs_mode, void *)' with an expression of type 'int (struct coresight_device *, u32, void *)' (aka 'int (struct coresight_device *, unsigned int, void *)') [-Werror,-Wincompatible-function-pointer-types-strict]
62 | .enable = dummy_sink_enable,
| ^~~~~~~~~~~~~~~~~
2 errors generated.
Commit 9fa3682869d4 ("coresight: Use enum type for cs_mode wherever
possible") updated the type of the mode parameter in the prototype but
this driver was not introduced until commit 9d3ba0b6c056 ("Coresight:
Add coresight dummy driver") and 'int' is ABI compatible with 'enum
cs_mode', so there is no warning from regular
-Wincompatible-function-pointer-types.
Adjust the type of the mode parameter in the callback implementations in
the coresight dummy driver to match the prototype, clearing up the
warning and avoiding kCFI failures at runtime.
Fixes: 9d3ba0b6c056 ("Coresight: Add coresight dummy driver")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230616-coresight-dummy-fix-kcfi-warnings-v1-1-c55c64f8f0f5@kernel.org
2023-06-16 09:41:30 -07:00
|
|
|
static int dummy_sink_enable(struct coresight_device *csdev, enum cs_mode mode,
|
2023-06-02 16:41:47 +08:00
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
dev_dbg(csdev->dev.parent, "Dummy sink enabled\n");
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dummy_sink_disable(struct coresight_device *csdev)
|
|
|
|
{
|
|
|
|
dev_dbg(csdev->dev.parent, "Dummy sink disabled\n");
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct coresight_ops_source dummy_source_ops = {
|
|
|
|
.enable = dummy_source_enable,
|
|
|
|
.disable = dummy_source_disable,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct coresight_ops dummy_source_cs_ops = {
|
2025-03-03 11:29:23 +08:00
|
|
|
.trace_id = dummy_source_trace_id,
|
|
|
|
.source_ops = &dummy_source_ops,
|
2023-06-02 16:41:47 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
static const struct coresight_ops_sink dummy_sink_ops = {
|
|
|
|
.enable = dummy_sink_enable,
|
|
|
|
.disable = dummy_sink_disable,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct coresight_ops dummy_sink_cs_ops = {
|
|
|
|
.sink_ops = &dummy_sink_ops,
|
|
|
|
};
|
|
|
|
|
2024-11-21 14:28:29 +08:00
|
|
|
/* User can get the trace id of dummy source from this node. */
|
|
|
|
static ssize_t traceid_show(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
unsigned long val;
|
|
|
|
struct dummy_drvdata *drvdata = dev_get_drvdata(dev->parent);
|
|
|
|
|
|
|
|
val = drvdata->traceid;
|
|
|
|
return sysfs_emit(buf, "%#lx\n", val);
|
|
|
|
}
|
|
|
|
static DEVICE_ATTR_RO(traceid);
|
|
|
|
|
|
|
|
static struct attribute *coresight_dummy_attrs[] = {
|
|
|
|
&dev_attr_traceid.attr,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct attribute_group coresight_dummy_group = {
|
|
|
|
.attrs = coresight_dummy_attrs,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct attribute_group *coresight_dummy_groups[] = {
|
|
|
|
&coresight_dummy_group,
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
2023-06-02 16:41:47 +08:00
|
|
|
static int dummy_probe(struct platform_device *pdev)
|
|
|
|
{
|
|
|
|
struct device *dev = &pdev->dev;
|
|
|
|
struct device_node *node = dev->of_node;
|
|
|
|
struct coresight_platform_data *pdata;
|
|
|
|
struct dummy_drvdata *drvdata;
|
|
|
|
struct coresight_desc desc = { 0 };
|
2024-11-21 14:28:29 +08:00
|
|
|
int ret = 0, trace_id = 0;
|
|
|
|
|
|
|
|
drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
|
|
|
|
if (!drvdata)
|
|
|
|
return -ENOMEM;
|
2023-06-02 16:41:47 +08:00
|
|
|
|
|
|
|
if (of_device_is_compatible(node, "arm,coresight-dummy-source")) {
|
|
|
|
|
|
|
|
desc.name = coresight_alloc_device_name(&source_devs, dev);
|
|
|
|
if (!desc.name)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
desc.type = CORESIGHT_DEV_TYPE_SOURCE;
|
|
|
|
desc.subtype.source_subtype =
|
|
|
|
CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS;
|
|
|
|
desc.ops = &dummy_source_cs_ops;
|
2024-11-21 14:28:29 +08:00
|
|
|
desc.groups = coresight_dummy_groups;
|
|
|
|
|
|
|
|
ret = coresight_get_static_trace_id(dev, &trace_id);
|
|
|
|
if (!ret) {
|
|
|
|
/* Get the static id if id is set in device tree. */
|
|
|
|
ret = coresight_trace_id_get_static_system_id(trace_id);
|
|
|
|
if (ret < 0) {
|
|
|
|
dev_err(dev, "Fail to get static id.\n");
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/* Get next available id if id is not set in device tree. */
|
|
|
|
trace_id = coresight_trace_id_get_system_id();
|
|
|
|
if (trace_id < 0) {
|
|
|
|
ret = trace_id;
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
drvdata->traceid = (u8)trace_id;
|
|
|
|
|
2023-06-02 16:41:47 +08:00
|
|
|
} else if (of_device_is_compatible(node, "arm,coresight-dummy-sink")) {
|
|
|
|
desc.name = coresight_alloc_device_name(&sink_devs, dev);
|
|
|
|
if (!desc.name)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
desc.type = CORESIGHT_DEV_TYPE_SINK;
|
|
|
|
desc.subtype.sink_subtype = CORESIGHT_DEV_SUBTYPE_SINK_DUMMY;
|
|
|
|
desc.ops = &dummy_sink_cs_ops;
|
|
|
|
} else {
|
|
|
|
dev_err(dev, "Device type not set\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
pdata = coresight_get_platform_data(dev);
|
2024-11-21 14:28:29 +08:00
|
|
|
if (IS_ERR(pdata)) {
|
|
|
|
ret = PTR_ERR(pdata);
|
|
|
|
goto free_id;
|
|
|
|
}
|
2023-06-02 16:41:47 +08:00
|
|
|
pdev->dev.platform_data = pdata;
|
|
|
|
|
|
|
|
drvdata->dev = &pdev->dev;
|
|
|
|
platform_set_drvdata(pdev, drvdata);
|
|
|
|
|
|
|
|
desc.pdata = pdev->dev.platform_data;
|
|
|
|
desc.dev = &pdev->dev;
|
|
|
|
drvdata->csdev = coresight_register(&desc);
|
2024-11-21 14:28:29 +08:00
|
|
|
if (IS_ERR(drvdata->csdev)) {
|
|
|
|
ret = PTR_ERR(drvdata->csdev);
|
|
|
|
goto free_id;
|
|
|
|
}
|
2023-06-02 16:41:47 +08:00
|
|
|
|
|
|
|
pm_runtime_enable(dev);
|
|
|
|
dev_dbg(dev, "Dummy device initialized\n");
|
|
|
|
|
2024-11-21 14:28:29 +08:00
|
|
|
ret = 0;
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
free_id:
|
|
|
|
if (IS_VALID_CS_TRACE_ID(drvdata->traceid))
|
|
|
|
coresight_trace_id_put_system_id(drvdata->traceid);
|
|
|
|
|
|
|
|
out:
|
|
|
|
return ret;
|
2023-06-02 16:41:47 +08:00
|
|
|
}
|
|
|
|
|
2023-11-16 18:33:02 +01:00
|
|
|
static void dummy_remove(struct platform_device *pdev)
|
2023-06-02 16:41:47 +08:00
|
|
|
{
|
|
|
|
struct dummy_drvdata *drvdata = platform_get_drvdata(pdev);
|
|
|
|
struct device *dev = &pdev->dev;
|
|
|
|
|
2024-11-21 14:28:29 +08:00
|
|
|
if (IS_VALID_CS_TRACE_ID(drvdata->traceid))
|
|
|
|
coresight_trace_id_put_system_id(drvdata->traceid);
|
2023-06-02 16:41:47 +08:00
|
|
|
pm_runtime_disable(dev);
|
|
|
|
coresight_unregister(drvdata->csdev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct of_device_id dummy_match[] = {
|
|
|
|
{.compatible = "arm,coresight-dummy-source"},
|
|
|
|
{.compatible = "arm,coresight-dummy-sink"},
|
|
|
|
{},
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct platform_driver dummy_driver = {
|
|
|
|
.probe = dummy_probe,
|
2024-12-01 15:12:43 -08:00
|
|
|
.remove = dummy_remove,
|
2023-06-02 16:41:47 +08:00
|
|
|
.driver = {
|
|
|
|
.name = "coresight-dummy",
|
|
|
|
.of_match_table = dummy_match,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2023-08-04 17:27:09 +08:00
|
|
|
module_platform_driver(dummy_driver);
|
2023-06-02 16:41:47 +08:00
|
|
|
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
MODULE_DESCRIPTION("CoreSight dummy driver");
|