2019-06-04 10:11:33 +02:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2012-08-15 13:59:49 +01:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2012 Russell King
|
|
|
|
*/
|
2019-08-04 11:41:31 +02:00
|
|
|
|
2019-01-17 22:03:34 +01:00
|
|
|
#include <drm/drm_modeset_helper.h>
|
2019-08-04 11:41:31 +02:00
|
|
|
#include <drm/drm_fourcc.h>
|
2018-03-30 15:11:33 +01:00
|
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
2019-08-04 11:41:31 +02:00
|
|
|
|
2012-08-15 13:59:49 +01:00
|
|
|
#include "armada_drm.h"
|
|
|
|
#include "armada_fb.h"
|
|
|
|
#include "armada_gem.h"
|
|
|
|
#include "armada_hw.h"
|
|
|
|
|
|
|
|
static const struct drm_framebuffer_funcs armada_fb_funcs = {
|
2018-03-30 15:11:33 +01:00
|
|
|
.destroy = drm_gem_fb_destroy,
|
|
|
|
.create_handle = drm_gem_fb_create_handle,
|
2012-08-15 13:59:49 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
struct armada_framebuffer *armada_framebuffer_create(struct drm_device *dev,
|
2025-07-01 12:07:13 +03:00
|
|
|
const struct drm_format_info *info,
|
|
|
|
const struct drm_mode_fb_cmd2 *mode,
|
|
|
|
struct armada_gem_object *obj)
|
2012-08-15 13:59:49 +01:00
|
|
|
{
|
|
|
|
struct armada_framebuffer *dfb;
|
|
|
|
uint8_t format, config;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
switch (mode->pixel_format) {
|
|
|
|
#define FMT(drm, fmt, mod) \
|
|
|
|
case DRM_FORMAT_##drm: \
|
|
|
|
format = CFG_##fmt; \
|
|
|
|
config = mod; \
|
|
|
|
break
|
|
|
|
FMT(RGB565, 565, CFG_SWAPRB);
|
|
|
|
FMT(BGR565, 565, 0);
|
|
|
|
FMT(ARGB1555, 1555, CFG_SWAPRB);
|
|
|
|
FMT(ABGR1555, 1555, 0);
|
|
|
|
FMT(RGB888, 888PACK, CFG_SWAPRB);
|
|
|
|
FMT(BGR888, 888PACK, 0);
|
|
|
|
FMT(XRGB8888, X888, CFG_SWAPRB);
|
|
|
|
FMT(XBGR8888, X888, 0);
|
|
|
|
FMT(ARGB8888, 8888, CFG_SWAPRB);
|
|
|
|
FMT(ABGR8888, 8888, 0);
|
|
|
|
FMT(YUYV, 422PACK, CFG_YUV2RGB | CFG_SWAPYU | CFG_SWAPUV);
|
|
|
|
FMT(UYVY, 422PACK, CFG_YUV2RGB);
|
|
|
|
FMT(VYUY, 422PACK, CFG_YUV2RGB | CFG_SWAPUV);
|
|
|
|
FMT(YVYU, 422PACK, CFG_YUV2RGB | CFG_SWAPYU);
|
|
|
|
FMT(YUV422, 422, CFG_YUV2RGB);
|
|
|
|
FMT(YVU422, 422, CFG_YUV2RGB | CFG_SWAPUV);
|
|
|
|
FMT(YUV420, 420, CFG_YUV2RGB);
|
|
|
|
FMT(YVU420, 420, CFG_YUV2RGB | CFG_SWAPUV);
|
|
|
|
FMT(C8, PSEUDO8, 0);
|
|
|
|
#undef FMT
|
|
|
|
default:
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
}
|
|
|
|
|
|
|
|
dfb = kzalloc(sizeof(*dfb), GFP_KERNEL);
|
|
|
|
if (!dfb) {
|
|
|
|
DRM_ERROR("failed to allocate Armada fb object\n");
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
}
|
|
|
|
|
|
|
|
dfb->fmt = format;
|
|
|
|
dfb->mod = config;
|
2018-03-30 15:11:33 +01:00
|
|
|
dfb->fb.obj[0] = &obj->obj;
|
2012-08-15 13:59:49 +01:00
|
|
|
|
2025-07-01 12:07:13 +03:00
|
|
|
drm_helper_mode_fill_fb_struct(dev, &dfb->fb, info, mode);
|
2012-08-15 13:59:49 +01:00
|
|
|
|
|
|
|
ret = drm_framebuffer_init(dev, &dfb->fb, &armada_fb_funcs);
|
|
|
|
if (ret) {
|
|
|
|
kfree(dfb);
|
|
|
|
return ERR_PTR(ret);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Take a reference on our object as we're successful - the
|
|
|
|
* caller already holds a reference, which keeps us safe for
|
|
|
|
* the above call, but the caller will drop their reference
|
|
|
|
* to it. Hence we need to take our own reference.
|
|
|
|
*/
|
2017-09-20 12:54:48 -06:00
|
|
|
drm_gem_object_get(&obj->obj);
|
2012-08-15 13:59:49 +01:00
|
|
|
|
|
|
|
return dfb;
|
|
|
|
}
|
|
|
|
|
2018-07-30 11:52:34 +01:00
|
|
|
struct drm_framebuffer *armada_fb_create(struct drm_device *dev,
|
drm: Pass the format info to .fb_create()
Pass along the format information from the top to .fb_create()
so that we can avoid redundant (and somewhat expensive) lookups
in the drivers.
Done with cocci (with some manual fixups):
@@
identifier func =~ ".*create.*";
identifier dev, file, mode_cmd;
@@
struct drm_framebuffer *func(
struct drm_device *dev,
struct drm_file *file,
+ const struct drm_format_info *info,
const struct drm_mode_fb_cmd2 *mode_cmd)
{
...
(
- const struct drm_format_info *info = drm_get_format_info(...);
|
- const struct drm_format_info *info;
...
- info = drm_get_format_info(...);
)
<...
- if (!info)
- return ...;
...>
}
@@
identifier func =~ ".*create.*";
identifier dev, file, mode_cmd;
@@
struct drm_framebuffer *func(
struct drm_device *dev,
struct drm_file *file,
+ const struct drm_format_info *info,
const struct drm_mode_fb_cmd2 *mode_cmd)
{
...
}
@find@
identifier fb_create_func =~ ".*create.*";
identifier dev, file, mode_cmd;
@@
struct drm_framebuffer *fb_create_func(
struct drm_device *dev,
struct drm_file *file,
+ const struct drm_format_info *info,
const struct drm_mode_fb_cmd2 *mode_cmd);
@@
identifier find.fb_create_func;
expression dev, file, mode_cmd;
@@
fb_create_func(dev, file
+ ,info
,mode_cmd)
@@
expression dev, file, mode_cmd;
@@
drm_gem_fb_create(dev, file
+ ,info
,mode_cmd)
@@
expression dev, file, mode_cmd;
@@
drm_gem_fb_create_with_dirty(dev, file
+ ,info
,mode_cmd)
@@
expression dev, file_priv, mode_cmd;
identifier info, fb;
@@
info = drm_get_format_info(...);
...
fb = dev->mode_config.funcs->fb_create(dev, file_priv
+ ,info
,mode_cmd);
@@
identifier dev, file_priv, mode_cmd;
@@
struct drm_mode_config_funcs {
...
struct drm_framebuffer *(*fb_create)(struct drm_device *dev,
struct drm_file *file_priv,
+ const struct drm_format_info *info,
const struct drm_mode_fb_cmd2 *mode_cmd);
...
};
v2: Fix kernel docs (Laurent)
Fix commit msg (Geert)
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Dmitry Baryshkov <lumag@kernel.org>
Cc: Sean Paul <sean@poorly.run>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>
Cc: Andy Yan <andy.yan@rock-chips.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: "Maíra Canal" <mcanal@igalia.com>
Cc: Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Gurchetan Singh <gurchetansingh@chromium.org>
Cc: Chia-I Wu <olvaffe@gmail.com>
Cc: Zack Rusin <zack.rusin@broadcom.com>
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
Cc: virtualization@lists.linux.dev
Cc: spice-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250701090722.13645-5-ville.syrjala@linux.intel.com
2025-07-01 12:07:07 +03:00
|
|
|
struct drm_file *dfile, const struct drm_format_info *info,
|
|
|
|
const struct drm_mode_fb_cmd2 *mode)
|
2012-08-15 13:59:49 +01:00
|
|
|
{
|
|
|
|
struct armada_gem_object *obj;
|
|
|
|
struct armada_framebuffer *dfb;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
DRM_DEBUG_DRIVER("w%u h%u pf%08x f%u p%u,%u,%u\n",
|
|
|
|
mode->width, mode->height, mode->pixel_format,
|
|
|
|
mode->flags, mode->pitches[0], mode->pitches[1],
|
|
|
|
mode->pitches[2]);
|
|
|
|
|
|
|
|
/* We can only handle a single plane at the moment */
|
2019-05-16 12:31:47 +02:00
|
|
|
if (info->num_planes > 1 &&
|
2012-08-15 13:59:49 +01:00
|
|
|
(mode->handles[0] != mode->handles[1] ||
|
|
|
|
mode->handles[0] != mode->handles[2])) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2016-05-09 11:04:54 +01:00
|
|
|
obj = armada_gem_object_lookup(dfile, mode->handles[0]);
|
2012-08-15 13:59:49 +01:00
|
|
|
if (!obj) {
|
|
|
|
ret = -ENOENT;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (obj->obj.import_attach && !obj->sgt) {
|
|
|
|
ret = armada_gem_map_import(obj);
|
|
|
|
if (ret)
|
|
|
|
goto err_unref;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Framebuffer objects must have a valid device address for scanout */
|
2017-05-22 10:46:22 +02:00
|
|
|
if (!obj->mapped) {
|
2012-08-15 13:59:49 +01:00
|
|
|
ret = -EINVAL;
|
|
|
|
goto err_unref;
|
|
|
|
}
|
|
|
|
|
2025-07-01 12:07:13 +03:00
|
|
|
dfb = armada_framebuffer_create(dev, info, mode, obj);
|
2012-08-15 13:59:49 +01:00
|
|
|
if (IS_ERR(dfb)) {
|
|
|
|
ret = PTR_ERR(dfb);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2020-05-15 10:50:56 +01:00
|
|
|
drm_gem_object_put(&obj->obj);
|
2012-08-15 13:59:49 +01:00
|
|
|
|
|
|
|
return &dfb->fb;
|
|
|
|
|
|
|
|
err_unref:
|
2020-05-15 10:50:56 +01:00
|
|
|
drm_gem_object_put(&obj->obj);
|
2012-08-15 13:59:49 +01:00
|
|
|
err:
|
|
|
|
DRM_ERROR("failed to initialize framebuffer: %d\n", ret);
|
|
|
|
return ERR_PTR(ret);
|
|
|
|
}
|