License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 15:07:57 +01:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2011-10-18 16:52:41 +10:00
|
|
|
#ifndef M68K_MCF_PGALLOC_H
|
|
|
|
|
#define M68K_MCF_PGALLOC_H
|
|
|
|
|
|
|
|
|
|
#include <asm/tlb.h>
|
|
|
|
|
#include <asm/tlbflush.h>
|
|
|
|
|
|
2023-08-07 16:05:04 -07:00
|
|
|
static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte)
|
2011-10-18 16:52:41 +10:00
|
|
|
{
|
2025-04-08 10:52:14 +01:00
|
|
|
pagetable_dtor_free(virt_to_ptdesc(pte));
|
2011-10-18 16:52:41 +10:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
extern const char bad_pmd_string[];
|
|
|
|
|
|
2023-08-07 16:05:04 -07:00
|
|
|
static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm)
|
2011-10-18 16:52:41 +10:00
|
|
|
{
|
2023-08-07 16:05:04 -07:00
|
|
|
struct ptdesc *ptdesc = pagetable_alloc((GFP_DMA | __GFP_ZERO) &
|
|
|
|
|
~__GFP_HIGHMEM, 0);
|
2011-10-18 16:52:41 +10:00
|
|
|
|
2023-08-07 16:05:04 -07:00
|
|
|
if (!ptdesc)
|
2011-10-18 16:52:41 +10:00
|
|
|
return NULL;
|
2025-04-08 10:52:14 +01:00
|
|
|
if (!pagetable_pte_ctor(mm, ptdesc)) {
|
|
|
|
|
pagetable_free(ptdesc);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
2011-10-18 16:52:41 +10:00
|
|
|
|
2023-08-07 16:05:04 -07:00
|
|
|
return ptdesc_address(ptdesc);
|
2011-10-18 16:52:41 +10:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address)
|
|
|
|
|
{
|
|
|
|
|
return (pmd_t *) pgd;
|
|
|
|
|
}
|
|
|
|
|
|
2020-01-31 13:45:41 +01:00
|
|
|
#define pmd_populate(mm, pmd, pte) (pmd_val(*pmd) = (unsigned long)(pte))
|
2011-10-18 16:52:41 +10:00
|
|
|
|
2020-01-31 13:45:41 +01:00
|
|
|
#define pmd_populate_kernel pmd_populate
|
2011-10-18 16:52:41 +10:00
|
|
|
|
2020-01-31 13:45:41 +01:00
|
|
|
static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pgtable,
|
2011-10-18 16:52:41 +10:00
|
|
|
unsigned long address)
|
|
|
|
|
{
|
2023-08-07 16:05:04 -07:00
|
|
|
struct ptdesc *ptdesc = virt_to_ptdesc(pgtable);
|
2020-01-31 13:45:41 +01:00
|
|
|
|
2025-01-08 14:57:23 +08:00
|
|
|
pagetable_dtor(ptdesc);
|
2023-08-07 16:05:04 -07:00
|
|
|
pagetable_free(ptdesc);
|
2011-10-18 16:52:41 +10:00
|
|
|
}
|
|
|
|
|
|
2020-01-31 13:45:41 +01:00
|
|
|
static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
|
2011-10-18 16:52:41 +10:00
|
|
|
{
|
2023-08-07 16:05:04 -07:00
|
|
|
struct ptdesc *ptdesc = pagetable_alloc(GFP_DMA | __GFP_ZERO, 0);
|
2011-10-18 16:52:41 +10:00
|
|
|
pte_t *pte;
|
|
|
|
|
|
2023-08-07 16:05:04 -07:00
|
|
|
if (!ptdesc)
|
2011-10-18 16:52:41 +10:00
|
|
|
return NULL;
|
mm: pass mm down to pagetable_{pte,pmd}_ctor
Patch series "Always call constructor for kernel page tables", v2.
There has been much confusion around exactly when page table
constructors/destructors (pagetable_*_[cd]tor) are supposed to be called.
They were initially introduced for user PTEs only (to support split page
table locks), then at the PMD level for the same purpose. Accounting was
added later on, starting at the PTE level and then moving to higher levels
(PMD, PUD). Finally, with my earlier series "Account page tables at all
levels" [1], the ctor/dtor is run for all levels, all the way to PGD.
I thought this was the end of the story, and it hopefully is for user
pgtables, but I was wrong for what concerns kernel pgtables. The current
situation there makes very little sense:
* At the PTE level, the ctor/dtor is not called (at least in the generic
implementation). Specific helpers are used for kernel pgtables at this
level (pte_{alloc,free}_kernel()) and those have never called the
ctor/dtor, most likely because they were initially irrelevant in the
kernel case.
* At all other levels, the ctor/dtor is normally called. This is
potentially wasteful at the PMD level (more on that later).
This series aims to ensure that the ctor/dtor is always called for kernel
pgtables, as it already is for user pgtables. Besides consistency, the
main motivation is to guarantee that ctor/dtor hooks are systematically
called; this makes it possible to insert hooks to protect page tables [2],
for instance. There is however an extra challenge: split locks are not
used for kernel pgtables, and it would therefore be wasteful to initialise
them (ptlock_init()).
It is worth clarifying exactly when split locks are used. They clearly
are for user pgtables, but as illustrated in commit 61444cde9170 ("ARM:
8591/1: mm: use fully constructed struct pages for EFI pgd allocations"),
they also are for special page tables like efi_mm. The one case where
split locks are definitely unused is pgtables owned by init_mm; this is
consistent with the behaviour of apply_to_pte_range().
The approach chosen in this series is therefore to pass the mm associated
to the pgtables being constructed to pagetable_{pte,pmd}_ctor() (patch 1),
and skip ptlock_init() if mm == &init_mm (patch 3 and 7). This makes it
possible to call the PTE ctor/dtor from pte_{alloc,free}_kernel() without
unintended consequences (patch 3). As a result the accounting functions
are now called at all levels for kernel pgtables, and split locks are
never initialised.
In configurations where ptlocks are dynamically allocated (32-bit,
PREEMPT_RT, etc.) and ARCH_ENABLE_SPLIT_PMD_PTLOCK is selected, this
series results in the removal of a kmem_cache allocation for every kernel
PMD. Additionally, for certain architectures that do not use
<asm-generic/pgalloc.h> such as s390, the same optimisation occurs at the
PTE level.
===
Things get more complicated when it comes to special pgtable allocators
(patch 8-12). All architectures need such allocators to create initial
kernel pgtables; we are not concerned with those as the ctor cannot be
called so early in the boot sequence. However, those allocators may also
be used later in the boot sequence or during normal operations. There are
two main use-cases:
1. Mapping EFI memory: efi_mm (arm, arm64, riscv)
2. arch_add_memory(): init_mm
The ctor is already explicitly run (at the PTE/PMD level) in the first
case, as required for pgtables that are not associated with init_mm.
However the same allocators may also be used for the second use-case (or
others), and this is where it gets messy. Patch 1 calls the ctor with
NULL as mm in those situations, as the actual mm isn't available.
Practically this means that ptlocks will be unconditionally initialised.
This is fine on arm - create_mapping_late() is only used for the EFI
mapping. On arm64, __create_pgd_mapping() is also used by
arch_add_memory(); patch 8/9/11 ensure that ctors are called at all levels
with the appropriate mm. The situation is similar on riscv, but
propagating the mm down to the ctor would require significant refactoring.
Since they are already called unconditionally, this series leaves riscv
no worse off - patch 10 adds comments to clarify the situation.
From a cursory look at other architectures implementing arch_add_memory(),
s390 and x86 may also need a similar treatment to add constructor calls.
This is to be taken care of in a future version or as a follow-up.
===
The complications in those special pgtable allocators beg the question:
does it really make sense to treat efi_mm and init_mm differently in e.g.
apply_to_pte_range()? Maybe what we really need is a way to tell if an mm
corresponds to user memory or not, and never use split locks for non-user
mm's. Feedback and suggestions welcome!
This patch (of 12):
In preparation for calling constructors for all kernel page tables while
eliding unnecessary ptlock initialisation, let's pass down the associated
mm to the PTE/PMD level ctors. (These are the two levels where ptlocks
are used.)
In most cases the mm is already around at the point of calling the ctor so
we simply pass it down. This is however not the case for special page
table allocators:
* arch/arm/mm/mmu.c
* arch/arm64/mm/mmu.c
* arch/riscv/mm/init.c
In those cases, the page tables being allocated are either for standard
kernel memory (init_mm) or special page directories, which may not be
associated to any mm. For now let's pass NULL as mm; this will be refined
where possible in future patches.
No functional change in this patch.
Link: https://lore.kernel.org/linux-mm/20250103184415.2744423-1-kevin.brodsky@arm.com/ [1]
Link: https://lore.kernel.org/linux-hardening/20250203101839.1223008-1-kevin.brodsky@arm.com/ [2]
Link: https://lkml.kernel.org/r/20250408095222.860601-1-kevin.brodsky@arm.com
Link: https://lkml.kernel.org/r/20250408095222.860601-2-kevin.brodsky@arm.com
Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com> [s390]
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Andreas Larsson <andreas@gaisler.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>
Cc: Linus Waleij <linus.walleij@linaro.org>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yang Shi <yang@os.amperecomputing.com>
Cc: <x86@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2025-04-08 10:52:11 +01:00
|
|
|
if (!pagetable_pte_ctor(mm, ptdesc)) {
|
2023-08-07 16:05:04 -07:00
|
|
|
pagetable_free(ptdesc);
|
2013-11-14 14:31:34 -08:00
|
|
|
return NULL;
|
|
|
|
|
}
|
2011-10-18 16:52:41 +10:00
|
|
|
|
2023-08-07 16:05:04 -07:00
|
|
|
pte = ptdesc_address(ptdesc);
|
2020-01-31 13:45:41 +01:00
|
|
|
return pte;
|
2011-10-18 16:52:41 +10:00
|
|
|
}
|
|
|
|
|
|
2020-01-31 13:45:41 +01:00
|
|
|
static inline void pte_free(struct mm_struct *mm, pgtable_t pgtable)
|
2011-10-18 16:52:41 +10:00
|
|
|
{
|
2023-08-07 16:05:04 -07:00
|
|
|
struct ptdesc *ptdesc = virt_to_ptdesc(pgtable);
|
2020-01-31 13:45:41 +01:00
|
|
|
|
2025-01-08 14:57:23 +08:00
|
|
|
pagetable_dtor(ptdesc);
|
2023-08-07 16:05:04 -07:00
|
|
|
pagetable_free(ptdesc);
|
2011-10-18 16:52:41 +10:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* In our implementation, each pgd entry contains 1 pmd that is never allocated
|
|
|
|
|
* or freed. pgd_present is always 1, so this should never be called. -NL
|
|
|
|
|
*/
|
|
|
|
|
#define pmd_free(mm, pmd) BUG()
|
|
|
|
|
|
|
|
|
|
static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd)
|
|
|
|
|
{
|
2025-01-03 18:44:15 +00:00
|
|
|
pagetable_dtor_free(virt_to_ptdesc(pgd));
|
2011-10-18 16:52:41 +10:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline pgd_t *pgd_alloc(struct mm_struct *mm)
|
|
|
|
|
{
|
|
|
|
|
pgd_t *new_pgd;
|
2023-08-07 16:05:04 -07:00
|
|
|
struct ptdesc *ptdesc = pagetable_alloc((GFP_DMA | __GFP_NOWARN) &
|
|
|
|
|
~__GFP_HIGHMEM, 0);
|
2011-10-18 16:52:41 +10:00
|
|
|
|
2023-08-07 16:05:04 -07:00
|
|
|
if (!ptdesc)
|
2011-10-18 16:52:41 +10:00
|
|
|
return NULL;
|
2025-01-03 18:44:15 +00:00
|
|
|
pagetable_pgd_ctor(ptdesc);
|
2023-08-07 16:05:04 -07:00
|
|
|
new_pgd = ptdesc_address(ptdesc);
|
|
|
|
|
|
m68k: mm: Fix ColdFire pgd_alloc()
I also notice that building for m5475evb_defconfig with vanilla v5.5
triggers this scary looking warning due to a mismatch between the pgd
size and the (8k!) page size:
| In function 'pgd_alloc.isra.111',
| inlined from 'mm_alloc_pgd' at kernel/fork.c:634:12,
| inlined from 'mm_init.isra.112' at kernel/fork.c:1043:6:
| ./arch/m68k/include/asm/string.h:72:25: warning: '__builtin_memcpy' forming offset [4097, 8192] is out of the bounds [0, 4096] of object 'kernel_pg_dir' with type 'pgd_t[1024]' {aka 'struct <anonymous>[1024]'} [-Warray-bounds]
| #define memcpy(d, s, n) __builtin_memcpy(d, s, n)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| ./arch/m68k/include/asm/mcf_pgalloc.h:93:2: note: in expansion of macro 'memcpy'
| memcpy(new_pgd, swapper_pg_dir, PAGE_SIZE);
| ^~~~~~
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Tested-by: Greg Ungerer <gerg@linux-m68k.org>
Link: https://lore.kernel.org/r/20200131125403.540057688@infradead.org
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
2020-01-31 13:45:33 +01:00
|
|
|
memcpy(new_pgd, swapper_pg_dir, PTRS_PER_PGD * sizeof(pgd_t));
|
2011-10-18 16:52:41 +10:00
|
|
|
memset(new_pgd, 0, PAGE_OFFSET >> PGDIR_SHIFT);
|
|
|
|
|
return new_pgd;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#endif /* M68K_MCF_PGALLOC_H */
|