Commit graph

3929 commits

Author SHA1 Message Date
Andrei
cdeeed0e8e #1756 Email newsletter dialog 2022-12-26 14:02:52 -08:00
Andrei
765827819b Merge branch 'sictiru' of github.com:samuelclay/NewsBlur into sictiru 2022-12-26 11:32:06 -08:00
sictiru
84e4d418b3
Premium archive subcription tier (#17)
NewsBlur Premium Archive subscription
2022-12-26 11:01:35 -08:00
David Sinclair
a1777280d9 #1720 (Grid view)
- Work in progress on refactoring the feed detail cell to view-based Swift, to make it easier to maintain, and to use autolayout to rearrange the content.
2022-12-12 22:04:04 -06:00
David Sinclair
5ae9207306 Merge branch 'dejal' into catalyst 2022-12-07 19:22:39 -06:00
Samuel Clay
3ff2ab83ba iOS v12.0.5. 2022-12-01 11:03:30 -05:00
Samuel Clay
de69dce7f2 iOS v12.0.4. 2022-12-01 10:24:20 -05:00
Samuel Clay
c743da5817 iOS v12.0.2 (still needs #1747) 2022-12-01 10:19:03 -05:00
David Sinclair
bc5065f9f2 1747 (marking a feed as read takes you to the wrong feed)
- Now repeats selecting the next folder or feed until it finds a folder or feed that isn’t muted and has unread stories.
2022-12-01 10:19:03 -05:00
David Sinclair
f351037ca1 #1746 (image preview shows images even on No Image option)
- Fixed.
2022-12-01 10:19:03 -05:00
David Sinclair
d8bdb7c596 #1740 (avatar and notification icons)
- Tweaked positions of avatar and notifcations buttons again.
2022-12-01 10:19:02 -05:00
Samuel Clay
387b6230f8 Unclipping notifications icon. 2022-12-01 10:19:02 -05:00
David Sinclair
a9758a5efb #1740 (avatar and notification icons)
- Tweaked the position of the avatar icon.
2022-12-01 10:19:02 -05:00
Samuel Clay
e9f003fc18 New intelligence icons, switching to full text for feed list control. 2022-12-01 10:19:02 -05:00
David Sinclair
e9cfbb784e #1734 (support for iOS and iPadOS 16, and Xcode 14)
- Updated project to Xcode 14.
- Updated Swift code to Swift 5.7.
- Tweaked the login view to avoid the logo behind the Dynamic Island on iPhone 14 Pro.
2022-12-01 10:19:02 -05:00
David Sinclair
10ab9925f8 #1732 (new preference to load next feed on mark read)
- Added keyboard shortcuts to go to the Next and Previous Folder and Site in the feeds list.
- Added preference to go to the next feed on mark read. On by default.
- If that pref is on, it uses the keyboard methods to do that.
2022-12-01 10:19:02 -05:00
David Sinclair
6172c3e6ce #1727 (settings dialog should match theme)
- The Preferences now uses light or dark mode to match the theme.
2022-12-01 10:19:02 -05:00
David Sinclair
8a3bb97403 #1729 (single line titles take too much vertical space)
- Improved the spacing.
- The spacing is kinda a hack of guessing good heights; it will likely become much smarter with the grid view changes.
2022-12-01 10:19:02 -05:00
David Sinclair
25667a2183 #1728 (saved story icon in story titles list)
- Fixed icon in feed detail.
2022-12-01 10:19:02 -05:00
David Sinclair
8c5c858d66 #1726 (saved story folder color)
- This would have been broken forever; the code hasn’t changed in years.
- Now doesn’t show the count for collapsed folders for Saved intelligence view, since they don’t correspond with the saved view.
2022-12-01 10:19:02 -05:00
David Sinclair
f83bbc33cf #1693 (2022 Redesign)
- Changed color of folder icons in gray theme.
- Fixed world icon in Add Site.
- Tweaked the colors in the Interactions popover in gray theme.
- Removed Delete This Site from the story menu.
- Changed the alignment of the user and activity toolbar buttons.
2022-12-01 10:19:02 -05:00
David Sinclair
23895a8854 #1723 (some thumbnails not showing on app but do show on the web)
- Changed the preview image caching to try each of the story images in turn until a valid one (not missing or too small) is found.
- Only loads one image for each story initially, loading more if needed.
- Now caches based on the story hash instead of image URL.
2022-12-01 10:19:02 -05:00
David Sinclair
9d6d726f5c #1693 (2022 Redesign)
- More tweaks to the feed detail layout.
2022-12-01 10:19:02 -05:00
David Sinclair
d29448c6d5 #1693 (2022 Redesign)
- Replaced the feeds list notificaitons icon.
- The feed detail folder title icon now matches the color.
- Changed all of the settings icons to the new style.
- Changed the feed detail mark read icon.
- Changed the focus and hidden unread indicators.
- Unread indicators sized to match the web.
- Tweaked feed detail spacing.
- Increased feed detail titles to up to three lines.
- Titlecased Interactions / Your Activities.
- Removed borders and tweaked section titles in trainer.
2022-12-01 10:19:02 -05:00
Samuel Clay
5ab3d6eed4 Adjusting share buttons 2022-12-01 10:19:02 -05:00
David Sinclair
11a8d6de6b #1693 (2022 Redesign)
Feeds list:

- Updated Focus and Saved icons. (Note, can’t use color on just one component of a segmented control, so uses the same color for all.)

Feed detail list:

- Now updates the title when updating the theme.
- Increased the horizontal spacing.
- Increased the title font size by 1 point.

Story detail:

- Fixed the cutoff icon.
2022-12-01 10:19:02 -05:00
David Sinclair
17e554e442 #1693 (2022 Redesign)
Feeds list:

- Fixed dark areas next to nested folders.
- The feeds list background colors now match the web.
- Adjusted the color of the icons.
- Changing the font size or comfort layout no longer dismisses the menu or reloads.

Feed detail:

- A story with a short title in two-line mode now has a shorter cell.
- Fixed multiple rows being selected.
- Comfortable layout now has larger top and bottom margins.
- Fixed notification icon in menu.
- Fixed saved_searches appearing in move submenu.
- Adjusted the height for feeds.
- Changing the title, image, font size, or comfort layout no longer dismisses the menu or reloads.

Story:

- Lighter header color.
- Updated icons and removed borders for share/save/train buttons.
- Updated the trainer popover to use the new style.
2022-12-01 10:19:02 -05:00
David Sinclair
a19faeaf1d #1718 (nested folder bug)
- The Feeds list now shows only the folder name for nested folders, instead of parent ▸ subfolder.
- A folder that has only subfolders, without any directly contained feeds, is now displayed in the list.
- Selecting a folder will now show the feeds within all subfolders (plus any direct feeds).
- Collapsing a folder with subfolders will now collapse them too, as one might expect.

(Some interesting challenges with this one!)
2022-12-01 10:19:02 -05:00
David Sinclair
fe1e81ef90 #1697 (clean scroll stutter on iPhone)
- Heaviest activity was scaling story thumbnails on the main thread; moved to a background thread.
- No more heavy activity when scrolling shown in Instruments.
2022-12-01 10:19:02 -05:00
David Sinclair
5e0d037db5 #1714 (sometimes read stories are sent in to the backend dozens of times a second)
- I wasn’t able to reproduce this, or figure out how it could happen.
- But I added a check to prevent it, and will leave a breakpoint there, so if it does occur for me, I’ll be able to investigate further.
2022-12-01 10:19:02 -05:00
David Sinclair
a22c8e3364 #1693 (2022 Redesign)
- Laboriously updated the icons (finding the names in the web inspector, updating the code, inspecting the colors, setting those separately, dealing with scaling issues, etc etc).
- Let me know if you spot any icons that I missed, or unscaled icons (they have to be explicitly sized, otherwise appear huge).
- More space between story title and story content.
- More space when reading a folder.
- Added Compact/Comfortable to feed detail menu.
- Changing Compact/Comfortable also adjusts the feed detail list.
- Adjusted the color of the story content etc in the feed detail list.
- Removed top and bottom borders from feed title gradient in story detail.
- More space in story detail header.
- The feed detail is offset when selected.
- Updated the feeds social, search, and saved background colors.
- Unread counts no longer have a shadow, and have more space.
- Folders and feeds remain selected in the feeds list when returning from a story or refreshing.
- Folders in the feeds list no longer have a different background color.
- The folders and feeds highlight is now rounded and unbordered like on web.
2022-12-01 10:19:02 -05:00
David Sinclair
33807cceb1 #1693 (2022 Redesign)
- Story titles author now next to date, and same color as content.
- Story titles now always bold.
- Story titles are now positioned to have equal top spacing (i.e. normalized).
- Unread indicator now top-aligned.
- Added border radius and margin to highlighted feeds.
- Feed favicons are now rounded.
- Blurblogs moved below folders.
- Fixed an issue with the feed detail settings for some folder types.
- Renamed All Stories to All Site Stories, to match web.
- Removed border from story content header.
2022-12-01 10:19:02 -05:00
David Sinclair
22c2ebea85 #1704 (item from Infrequent site stories opens wrong story)
This one took a long time to reproduce and track down; it turned out that because the infrequent stories use a magical loading parameter, they are not suitable for offline caching; the offlien stories didn’t match the fetched one, thus messing up the cached next story page.
2022-12-01 10:19:02 -05:00
David Sinclair
73e7b2b8b1 #1695 (Premium Archive subscription)
- Changed font to Whitney.
2022-12-01 10:19:02 -05:00
David Sinclair
d66649761f #1695 (Premium Archive subscription)
- Removed confetti.
- Fixed iPad layout.
- Moved Manage Subscription to the bottom of the active subscription.
2022-12-01 10:19:02 -05:00
David Sinclair
ed748e61c0 #1695 (Premium Archive subscription) 2022-12-01 10:19:02 -05:00
David Sinclair
379f0588df #1695 (Premium Archive subscription) 2022-12-01 10:19:02 -05:00
David Sinclair
069d32ba8c Fixed #1700 (Add Tag context menu on already saved stories is too short) 2022-12-01 10:19:02 -05:00
David Sinclair
031ddba2c4 #1718 (nested folder bug)
- Fixed duplication of feeds from subfolders.
2022-11-30 15:08:30 -06:00
David Sinclair
9adbe4c479 #1765 (user's feed list is empty)
- Their “Main Folder” contains 80,744 feeds, which the table view can’t handle; it now limits display to the first 5,000 feeds in a folder.
2022-11-28 10:03:40 -06:00
David Sinclair
6fcadf791d #1762 (don't enlarge images beyond their native size)
- Fixed.
2022-11-25 16:14:22 -06:00
David Sinclair
7b809c57fc #1755 (split builds for development)
- Replicated NewsBlur Dev for the Catalyst branch (too complex and risky to merge, since the project has lots of other changes).
2022-11-24 20:49:57 -06:00
David Sinclair
3b1c824ab3 Merge branch 'dejal' into catalyst 2022-11-24 20:30:06 -06:00
David Sinclair
26c5de63d8 #1755 (split builds for development) 2022-11-23 21:35:56 -06:00
David Sinclair
4e6493afb0 #1751 (don't allow double-tap to open original story while on story titles)
- This reverts commit 7da4a868495013f3f1f09a5484f076d244603bba., so iPad is back to previous default.
- Also changed it to completely remove the option on iPhone.
2022-11-23 19:37:18 -06:00
David Sinclair
48c1d80284 #1747 (marking a feed as read takes you to the wrong feed)
- Another tricksy edge case: was picking the wrong feed if viewing Unread with a nested folder within a collapsed folder! Now much smarter about that.
2022-11-21 11:17:54 -06:00
David Sinclair
6a47503ef4 #1747 (marking a feed as read takes you to the wrong feed)
- Fixed crash with unread focus.
2022-11-19 18:40:46 -06:00
David Sinclair
739c61fe4a #1758 (reloading of story on rotation)
- Fixed.
- Only affected Pro Max phones.
- By the way, rotating back to landscape would show the story again.
2022-11-18 19:51:09 -06:00
David Sinclair
b5b4c5de42 #1759 (subfolders missing unread counts)
- Fixed.
2022-11-18 14:32:22 -06:00
David Sinclair
5ce58e186d #1747 (marking a feed as read takes you to the wrong feed)
- Fixed folder not opening next unread.
2022-11-18 13:37:17 -06:00